100671 2012-10-29 07:01:08 -0700 CoordinatedGraphics: Unrelease adopted images 2012-10-30 02:15:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte jturcotte kenneth noam webkit.review.bot oldest_to_newest 753385 0 jturcotte 2012-10-29 07:01:08 -0700 CoordinatedGraphics: Unrelease adopted images 753391 1 171242 jturcotte 2012-10-29 07:05:17 -0700 Created attachment 171242 Patch 753404 2 171242 kenneth 2012-10-29 07:14:36 -0700 Comment on attachment 171242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171242&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:516 > + // Check if we were going to release this image on the next flush. during next flush. check whether > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:517 > + size_t releasedPos = m_releasedDirectlyCompositedImages.find(key); Pos meaning what? position? 753433 3 171242 jturcotte 2012-10-29 07:37:36 -0700 Comment on attachment 171242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171242&action=review >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:516 >> + // Check if we were going to release this image on the next flush. > > during next flush. > check whether I don't understand what's wrong with "Check if" and "on the next". >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:517 >> + size_t releasedPos = m_releasedDirectlyCompositedImages.find(key); > > Pos meaning what? position? Yep that one is misleading, "index" would be clearer. I'll change it. 753437 4 kenneth 2012-10-29 07:40:30 -0700 Isnt it called "during a flush", you dont say on a flush, at least it sounds weird to me. 753453 5 jturcotte 2012-10-29 07:59:18 -0700 (In reply to comment #4) > Isnt it called "during a flush", you dont say on a flush, at least it sounds weird to me. Ok, according to the Internet "on" should only be used for specific days. 753456 6 noam 2012-10-29 08:02:05 -0700 (In reply to comment #5) > (In reply to comment #4) > > Isnt it called "during a flush", you dont say on a flush, at least it sounds weird to me. > > Ok, according to the Internet "on" should only be used for specific days. Usually "on" is for instantaneous reactions or events, and "during" is for operations that take time; e.g. "on the next timer event" or "during the next render phase". "if" makes a sentence into a conditional statement. In this case the statement is not conditional. </grammar nit> 753523 7 171264 jturcotte 2012-10-29 09:42:29 -0700 Created attachment 171264 Patch Reuploading since I just figured out that the ShareableBitmap should also happen only if it wasn't in the release vector. I checked and 'if' should be fine here, just less formal. 'If' have the same meaning as 'whether' as long as it's not followed by a second alternative or an infinitive. 754100 8 171264 kenneth 2012-10-30 02:09:06 -0700 Comment on attachment 171264 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171264&action=review > Source/WebKit2/ChangeLog:3 > + Coordinated Graphics: Unrelease adopted images unrelease? you really mean 'do not release'? Wouldn't it be cleared to use that wording, anyway nit. 754106 9 171264 webkit.review.bot 2012-10-30 02:15:47 -0700 Comment on attachment 171264 Patch Clearing flags on attachment: 171264 Committed r132883: <http://trac.webkit.org/changeset/132883> 754107 10 webkit.review.bot 2012-10-30 02:15:51 -0700 All reviewed patches have been landed. Closing bug. 171242 2012-10-29 07:05:17 -0700 2012-10-29 09:42:25 -0700 Patch bug-100671-20121029150343.patch text/plain 2338 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGFjMWMyOGVlZmU0ZjE0 MTcxNDU2YTkyYjdjNTVlNjIxZTgwZTkxMy4uNWM5NDNhYWYzNjdhODU5NDU4Yzg4Nzg2M2E4YTli YWYzY2NlYTYxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTI5ICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CisKKyAgICAgICAgQ29v cmRpbmF0ZWQgR3JhcGhpY3M6IFVucmVsZWFzZSBhZG9wdGVkIGltYWdlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNjcxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVsb2FkaW5nIGNvdWxkIGNhdXNl IGEgY3Jhc2ggc2luY2UgcjEzMjY0MCB3aGVyZSB0aGUgZGlyZWN0bHkgY29tcG9zaXRlZAorICAg ICAgICBpbWFnZSB3b3VsZCBiZSByZS1hZG9wdGVkIHdpdGggdGhlIHNhbWUga2V5IGJlZm9yZSBp dCB3YXMgcHJvcGVybHkgcmVsZWFzZWQKKyAgICAgICAgaW4gdGhlIFVJIHByb2Nlc3MuCisgICAg ICAgIENhbmNlbCB0aGUgcmVsZWFzZSB3aGVuIHRoaXMgaGFwcGVucyByYXRoZXIgdGhhbiBjcmVh dGluZyBhIG5ldyBpbWFnZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 TGF5ZXJUcmVlQ29vcmRpbmF0b3I6OmFkb3B0SW1hZ2VCYWNraW5nU3RvcmUpOgorCiAyMDEyLTEw LTI0ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CiAKICAg ICAgICAgV2ViSWNvbkRhdGFiYXNlOiBQcm9wZXJseSBjbGVhbiB1cCBvbiBkZXN0cnVjdGlvbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVk R3JhcGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuY3Bw CmluZGV4IGJiNTIyMTA0OTJhMDllNTU4NDQyODU5MTIwMWJhZjEyZDhhM2YxYjQuLmI3MDY5NDU4 MjIwMjg0ZTZhNTIzMTNmZjM2ODE4NzI1YTgxM2RmN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3Jk aW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRp bmF0ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGluYXRvci5jcHAKQEAgLTUxMyw5ICs1MTMsMTUg QEAgaW50NjRfdCBMYXllclRyZWVDb29yZGluYXRvcjo6YWRvcHRJbWFnZUJhY2tpbmdTdG9yZShJ bWFnZSogaW1hZ2UpCiAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd0ltYWdlKGltYWdlLCBD b2xvclNwYWNlRGV2aWNlUkdCLCBJbnRQb2ludDo6emVybygpKTsKICAgICB9CiAKLSAgICBTaGFy ZWFibGVCaXRtYXA6OkhhbmRsZSBoYW5kbGU7Ci0gICAgYml0bWFwLT5jcmVhdGVIYW5kbGUoaGFu ZGxlKTsKLSAgICBtX3dlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6OkxheWVyVHJlZUNvb3JkaW5hdG9y UHJveHk6OkNyZWF0ZURpcmVjdGx5Q29tcG9zaXRlZEltYWdlKGtleSwgaGFuZGxlKSk7CisgICAg Ly8gQ2hlY2sgaWYgd2Ugd2VyZSBnb2luZyB0byByZWxlYXNlIHRoaXMgaW1hZ2Ugb24gdGhlIG5l eHQgZmx1c2guCisgICAgc2l6ZV90IHJlbGVhc2VkUG9zID0gbV9yZWxlYXNlZERpcmVjdGx5Q29t cG9zaXRlZEltYWdlcy5maW5kKGtleSk7CisgICAgaWYgKHJlbGVhc2VkUG9zID09IG5vdEZvdW5k KSB7CisgICAgICAgIFNoYXJlYWJsZUJpdG1hcDo6SGFuZGxlIGhhbmRsZTsKKyAgICAgICAgYml0 bWFwLT5jcmVhdGVIYW5kbGUoaGFuZGxlKTsKKyAgICAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3Nh Z2VzOjpMYXllclRyZWVDb29yZGluYXRvclByb3h5OjpDcmVhdGVEaXJlY3RseUNvbXBvc2l0ZWRJ bWFnZShrZXksIGhhbmRsZSkpOworICAgIH0gZWxzZQorICAgICAgICBtX3JlbGVhc2VkRGlyZWN0 bHlDb21wb3NpdGVkSW1hZ2VzLnJlbW92ZShyZWxlYXNlZFBvcyk7CisKICAgICBtX2RpcmVjdGx5 Q29tcG9zaXRlZEltYWdlUmVmQ291bnRzLmFkZChrZXksIDEpOwogICAgIHJldHVybiBrZXk7CiB9 Cg== 171264 2012-10-29 09:42:29 -0700 2012-10-30 02:15:46 -0700 Patch bug-100671-20121029174055.patch text/plain 3028 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTA5OTA0ZDhkNjBlYmM0 OThmZjgxYzgwYzVjYjkxNWYzNzMwYzJiOS4uMTc5MWFlMThhMjI4ODU0ZTY0ZThlZDVjM2ZkOTg4 NjBhNjcyNDk0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTI5ICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CisKKyAgICAgICAgQ29v cmRpbmF0ZWQgR3JhcGhpY3M6IFVucmVsZWFzZSBhZG9wdGVkIGltYWdlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNjcxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVsb2FkaW5nIGNvdWxkIGNhdXNl IGEgY3Jhc2ggc2luY2UgcjEzMjY0MCB3aGVyZSB0aGUgZGlyZWN0bHkgY29tcG9zaXRlZAorICAg ICAgICBpbWFnZSB3b3VsZCBiZSByZS1hZG9wdGVkIHdpdGggdGhlIHNhbWUga2V5IGJlZm9yZSBp dCB3YXMgcHJvcGVybHkgcmVsZWFzZWQKKyAgICAgICAgaW4gdGhlIFVJIHByb2Nlc3MuCisgICAg ICAgIENhbmNlbCB0aGUgcmVsZWFzZSB3aGVuIHRoaXMgaGFwcGVucyByYXRoZXIgdGhhbiBjcmVh dGluZyBhIG5ldyBpbWFnZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 TGF5ZXJUcmVlQ29vcmRpbmF0b3I6OmFkb3B0SW1hZ2VCYWNraW5nU3RvcmUpOgorCiAyMDEyLTEw LTI5ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAg ICAgICAgW1dLMl1bV0tUUl0gRW5hYmxlIFNoYWRvdyBET00gYXQgcnVudGltZSBpZiBjb21waWxl ZCB3aXRoIFNIQURPV19ET00gc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3Iu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuY3BwCmluZGV4IGM2MWQ4NGJlMTNmNGRmY2MyMWZiMTBk YWNiNmEyYjNmYzllNTM2YmYuLjdlYjQ3OWJlMDgxNjIxYzc5YmU5MTE1ZjU2OTk0ZjJjZTBiMzVh MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGlu YXRvci5jcHAKQEAgLTUxMiwxNSArNTEyLDIwIEBAIGludDY0X3QgTGF5ZXJUcmVlQ29vcmRpbmF0 b3I6OmFkb3B0SW1hZ2VCYWNraW5nU3RvcmUoSW1hZ2UqIGltYWdlKQogICAgICAgICByZXR1cm4g a2V5OwogICAgIH0KIAotICAgIFJlZlB0cjxTaGFyZWFibGVCaXRtYXA+IGJpdG1hcCA9IFNoYXJl YWJsZUJpdG1hcDo6Y3JlYXRlU2hhcmVhYmxlKGltYWdlLT5zaXplKCksIChpbWFnZS0+Y3VycmVu dEZyYW1lSGFzQWxwaGEoKSA/IFNoYXJlYWJsZUJpdG1hcDo6U3VwcG9ydHNBbHBoYSA6IDApKTsK LSAgICB7Ci0gICAgICAgIE93blB0cjxXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ+IGdyYXBoaWNz Q29udGV4dCA9IGJpdG1hcC0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0KCk7Ci0gICAgICAgIGdyYXBo aWNzQ29udGV4dC0+ZHJhd0ltYWdlKGltYWdlLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBJbnRQb2lu dDo6emVybygpKTsKLSAgICB9CisgICAgLy8gQ2hlY2sgaWYgd2Ugd2VyZSBnb2luZyB0byByZWxl YXNlIHRoaXMgaW1hZ2UgZHVyaW5nIHRoZSBuZXh0IGZsdXNoLgorICAgIHNpemVfdCByZWxlYXNl ZEluZGV4ID0gbV9yZWxlYXNlZERpcmVjdGx5Q29tcG9zaXRlZEltYWdlcy5maW5kKGtleSk7Cisg ICAgaWYgKHJlbGVhc2VkSW5kZXggPT0gbm90Rm91bmQpIHsKKyAgICAgICAgUmVmUHRyPFNoYXJl YWJsZUJpdG1hcD4gYml0bWFwID0gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGVTaGFyZWFibGUoaW1h Z2UtPnNpemUoKSwgKGltYWdlLT5jdXJyZW50RnJhbWVIYXNBbHBoYSgpID8gU2hhcmVhYmxlQml0 bWFwOjpTdXBwb3J0c0FscGhhIDogMCkpOworICAgICAgICB7CisgICAgICAgICAgICBPd25QdHI8 V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0PiBncmFwaGljc0NvbnRleHQgPSBiaXRtYXAtPmNyZWF0 ZUdyYXBoaWNzQ29udGV4dCgpOworICAgICAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5kcmF3SW1h Z2UoaW1hZ2UsIENvbG9yU3BhY2VEZXZpY2VSR0IsIEludFBvaW50Ojp6ZXJvKCkpOworICAgICAg ICB9CisgICAgICAgIFNoYXJlYWJsZUJpdG1hcDo6SGFuZGxlIGhhbmRsZTsKKyAgICAgICAgYml0 bWFwLT5jcmVhdGVIYW5kbGUoaGFuZGxlKTsKKyAgICAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3Nh Z2VzOjpMYXllclRyZWVDb29yZGluYXRvclByb3h5OjpDcmVhdGVEaXJlY3RseUNvbXBvc2l0ZWRJ bWFnZShrZXksIGhhbmRsZSkpOworICAgIH0gZWxzZQorICAgICAgICBtX3JlbGVhc2VkRGlyZWN0 bHlDb21wb3NpdGVkSW1hZ2VzLnJlbW92ZShyZWxlYXNlZEluZGV4KTsKIAotICAgIFNoYXJlYWJs ZUJpdG1hcDo6SGFuZGxlIGhhbmRsZTsKLSAgICBiaXRtYXAtPmNyZWF0ZUhhbmRsZShoYW5kbGUp OwotICAgIG1fd2ViUGFnZS0+c2VuZChNZXNzYWdlczo6TGF5ZXJUcmVlQ29vcmRpbmF0b3JQcm94 eTo6Q3JlYXRlRGlyZWN0bHlDb21wb3NpdGVkSW1hZ2Uoa2V5LCBoYW5kbGUpKTsKICAgICBtX2Rp cmVjdGx5Q29tcG9zaXRlZEltYWdlUmVmQ291bnRzLmFkZChrZXksIDEpOwogICAgIHJldHVybiBr ZXk7CiB9Cg==