100662 2012-10-29 06:00:15 -0700 [EFL][WK2] Fix cursor change detection in EwkViewImpl::setCursor() 2012-10-29 07:50:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 753328 0 cdumez 2012-10-29 06:00:15 -0700 cursor change detection in EwkViewImpl::setCursor() is broken and we keep recreating the same cursor. 753331 1 171218 cdumez 2012-10-29 06:06:56 -0700 Created attachment 171218 Patch 753436 2 171218 kenneth 2012-10-29 07:39:02 -0700 Comment on attachment 171218 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171218&action=review Is it possible to test this using a unit test? > Source/WebKit2/ChangeLog:13 > + Cursor change detection in EwkViewImpl::setCursor() relies on > + addresses returned by Cursor::platformCursor(). However, the > + value returned is currently assigned to a WKEinaSharedString > + instead of a raw pointer. Therefore, the address is always > + different and we keep recreating Evas Objects for the same > + cursor. Yikes :-) 753438 3 171218 cdumez 2012-10-29 07:45:09 -0700 Comment on attachment 171218 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171218&action=review I thought about unit testing but this is not a public API, this is private implementation. >> Source/WebKit2/ChangeLog:13 >> + cursor. > > Yikes :-) Well, it is faster than comparing strings :) 753444 4 171218 webkit.review.bot 2012-10-29 07:50:42 -0700 Comment on attachment 171218 Patch Clearing flags on attachment: 171218 Committed r132803: <http://trac.webkit.org/changeset/132803> 753445 5 webkit.review.bot 2012-10-29 07:50:47 -0700 All reviewed patches have been landed. Closing bug. 171218 2012-10-29 06:06:56 -0700 2012-10-29 07:50:42 -0700 Patch 100662_cursorGroup.patch text/plain 2912 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNTY1MWFlLi40MzljZmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTItMTAtMjkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEZpeCBjdXJzb3IgY2hhbmdlIGRldGVjdGlvbiBp biBFd2tWaWV3SW1wbDo6c2V0Q3Vyc29yKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMDY2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEN1cnNvciBjaGFuZ2UgZGV0ZWN0aW9uIGluIEV3a1ZpZXdJbXBs OjpzZXRDdXJzb3IoKSByZWxpZXMgb24KKyAgICAgICAgYWRkcmVzc2VzIHJldHVybmVkIGJ5IEN1 cnNvcjo6cGxhdGZvcm1DdXJzb3IoKS4gSG93ZXZlciwgdGhlCisgICAgICAgIHZhbHVlIHJldHVy bmVkIGlzIGN1cnJlbnRseSBhc3NpZ25lZCB0byBhIFdLRWluYVNoYXJlZFN0cmluZworICAgICAg ICBpbnN0ZWFkIG9mIGEgcmF3IHBvaW50ZXIuIFRoZXJlZm9yZSwgdGhlIGFkZHJlc3MgaXMgYWx3 YXlzCisgICAgICAgIGRpZmZlcmVudCBhbmQgd2Uga2VlcCByZWNyZWF0aW5nIEV2YXMgT2JqZWN0 cyBmb3IgdGhlIHNhbWUKKyAgICAgICAgY3Vyc29yLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9lZmwvRXdrVmlld0ltcGwuY3BwOgorICAgICAgICAoRXdrVmlld0ltcGw6OkV3a1ZpZXdJbXBs KToKKyAgICAgICAgKEV3a1ZpZXdJbXBsOjpzZXRDdXJzb3IpOiBDYWxsIHNtYXJ0RGF0YSgpIGFm dGVyIHNhbWUgY3Vyc29yCisgICAgICAgIGRldGVjdGlvbiBzaW5jZSBpdCBpcyBub3QgbmVlZGVk IGlmIHRoZSBjdXJzb3IgaGFzIG5vdCBjaGFuZ2VkCisgICAgICAgIGFuZCBpdCBtYXkgYWZmZWN0 IHBlcmZvcm1hbmNlLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmg6 CisgICAgICAgIChFd2tWaWV3SW1wbCk6CisKIDIwMTItMTAtMjkgIEpvY2VseW4gVHVyY290dGUg IDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KIAogICAgICAgICBbV0syXSBFbmFibGUgZGVs ZWdhdGVkIHNjcm9sbGluZyBhcyBzb29uIGFzIHRoZSBGcmFtZVZpZXcgaXMgY3JlYXRlZCB3aGVu IHVzaW5nIGZpeGVkIGxheW91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvRXdrVmlld0ltcGwuY3BwCmluZGV4IGY1NGQ3NmYuLjc4ZDE3NTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAKQEAgLTExMSw2ICsx MTEsNyBAQCBFd2tWaWV3SW1wbDo6RXdrVmlld0ltcGwoRXZhc19PYmplY3QqIHZpZXcsIFBhc3NS ZWZQdHI8RXdrX0NvbnRleHQ+IGNvbnRleHQsIFBhcwogICAgICwgbV9ldmFzR2xTdXJmYWNlKDAp CiAjZW5kaWYKICAgICAsIG1fc2V0dGluZ3MoRXdrX1NldHRpbmdzOjpjcmVhdGUodGhpcykpCisg ICAgLCBtX2N1cnNvckdyb3VwKDApCiAgICAgLCBtX21vdXNlRXZlbnRzRW5hYmxlZChmYWxzZSkK ICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogICAgICwgbV90b3VjaEV2ZW50c0VuYWJsZWQoZmFs c2UpCkBAIC0xODcsMTMgKzE4OCwxMiBAQCBXS1BhZ2VSZWYgRXdrVmlld0ltcGw6OndrUGFnZSgp CiAKIHZvaWQgRXdrVmlld0ltcGw6OnNldEN1cnNvcihjb25zdCBDdXJzb3ImIGN1cnNvcikKIHsK LSAgICBFd2tfVmlld19TbWFydF9EYXRhKiBzZCA9IHNtYXJ0RGF0YSgpOwotCiAgICAgY29uc3Qg Y2hhciogZ3JvdXAgPSBjdXJzb3IucGxhdGZvcm1DdXJzb3IoKTsKICAgICBpZiAoIWdyb3VwIHx8 IGdyb3VwID09IG1fY3Vyc29yR3JvdXApCiAgICAgICAgIHJldHVybjsKIAogICAgIG1fY3Vyc29y R3JvdXAgPSBncm91cDsKKyAgICBFd2tfVmlld19TbWFydF9EYXRhKiBzZCA9IHNtYXJ0RGF0YSgp OwogICAgIG1fY3Vyc29yT2JqZWN0ID0gYWRvcHRSZWYoZWRqZV9vYmplY3RfYWRkKHNkLT5iYXNl LmV2YXMpKTsKIAogICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfZWNvcmVf ZXZhc19nZXQoc2QtPmJhc2UuZXZhcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvRXdrVmlld0ltcGwuaAppbmRleCBmNGU5MTc3Li5mY2FlNGY0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmgKQEAgLTI2MCw3ICsyNjAs NyBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgT3duUHRyPEV3a19TZXR0aW5ncz4gbV9zZXR0aW5n czsKICAgICBSZWZQdHI8RXZhc19PYmplY3Q+IG1fY3Vyc29yT2JqZWN0OwotICAgIFdLRWluYVNo YXJlZFN0cmluZyBtX2N1cnNvckdyb3VwOworICAgIGNvbnN0IGNoYXIqIG1fY3Vyc29yR3JvdXA7 IC8vIFRoaXMgaXMgYW4gYWRkcmVzcywgZG8gbm90IGZyZWUgaXQgb3IgdXNlIFdLRWluYVNoYXJl ZFN0cmluZy4KICAgICBXS0VpbmFTaGFyZWRTdHJpbmcgbV9mYXZpY29uVVJMOwogICAgIFdLRWlu YVNoYXJlZFN0cmluZyBtX3VybDsKICAgICBtdXRhYmxlIFdLRWluYVNoYXJlZFN0cmluZyBtX3Rp dGxlOwo=