100658 2012-10-29 05:28:33 -0700 [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build 2012-10-29 23:44:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth tony webkit.review.bot oldest_to_newest 753293 0 jochen 2012-10-29 05:28:33 -0700 [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build 753294 1 171209 jochen 2012-10-29 05:30:11 -0700 Created attachment 171209 Patch 753630 2 171209 tony 2012-10-29 11:18:15 -0700 Comment on attachment 171209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171209&action=review > Tools/ChangeLog:10 > + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: You can add extra notes about the code change here. For example, it would have been helpful if you wrote that include_dirs and dependencies is redundant here because TestRunner already has these settings. 753989 3 171373 jochen 2012-10-29 22:22:18 -0700 Created attachment 171373 Patch 754010 4 171373 webkit.review.bot 2012-10-29 23:44:02 -0700 Comment on attachment 171373 Patch Clearing flags on attachment: 171373 Committed r132872: <http://trac.webkit.org/changeset/132872> 754011 5 webkit.review.bot 2012-10-29 23:44:06 -0700 All reviewed patches have been landed. Closing bug. 171209 2012-10-29 05:30:11 -0700 2012-10-29 22:22:15 -0700 Patch bug-100658-20121029132837.patch text/plain 2480 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmY2YjNhYmY0NTY4NGFkMzZkNWIxOGI5ZjEwMGRmYzQy OWYxNDRlMC4uMjQ5ODliZDk3ZTI4Y2IzZGIwODM4NTQ0ZmJjYTNmNjRlNWEzZTQwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTEwLTI5ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gVGVzdFJ1bm5lciBuZWVkcyB0byBjb21waWxlIENocm9taXVt Q3VycmVudFRpbWUgYW5kIENocm9taXVtVGhyZWFkaW5nIGluIGNvbXBvbmVudHMgYnVpbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDY1OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlZm9yZSwgdGhp cyB3YXMgY29tcGlsZWQgaW50byBEdW1wUmVuZGVyVHJlZS4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXA6CisKIDIwMTItMTAt MjkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzI3ODIuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAppbmRl eCBiZGZmMjk5NGY3ZDZjZGE1Zjc4YWUwZTJhYmVhYWE1YzVhZDgyZjZlLi41NmFlYWI3MzJjOWY0 ZjZlMDFmNDZkODAwZThkNmVjM2Q3NTkxOWNmIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKQEAgLTEx Niw2ICsxMTYsMTIgQEAKICAgICAgICAgICAgICAgICAgICAgICAgICc8KHNvdXJjZV9kaXIpL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvZ3RrJywKICAgICAgICAgICAgICAgICAgICAgXSwKICAgICAg ICAgICAgICAgICB9XSwKKyAgICAgICAgICAgICAgICBbJ2luc2lkZV9jaHJvbWl1bV9idWlsZD09 MSBhbmQgY29tcG9uZW50PT0ic2hhcmVkX2xpYnJhcnkiJywgeworICAgICAgICAgICAgICAgICAg ICAnc291cmNlcyc6IFsKKyAgICAgICAgICAgICAgICAgICAgICAgICc8KHNvdXJjZV9kaXIpL1dl YktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1DdXJyZW50VGltZS5jcHAnLAorICAgICAgICAgICAg ICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWl1bVRo cmVhZGluZy5jcHAnLAorICAgICAgICAgICAgICAgICAgICBdLAorICAgICAgICAgICAgICAgIH1d LAogICAgICAgICAgICAgXSwKICAgICAgICAgfSwKICAgICAgICAgewpAQCAtMzQ4LDE4ICszNTQs NiBAQAogICAgICAgICAgICAgICAgICAgICAgICAgWydleGNsdWRlJywgJ0FuZHJvaWRcXC5jcHAk J10sCiAgICAgICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAgICAgfV0sCi0gICAgICAg ICAgICAgICAgWydpbnNpZGVfY2hyb21pdW1fYnVpbGQ9PTEgYW5kIGNvbXBvbmVudD09InNoYXJl ZF9saWJyYXJ5IicsIHsKLSAgICAgICAgICAgICAgICAgICAgJ3NvdXJjZXMnOiBbCi0gICAgICAg ICAgICAgICAgICAgICAgICAnPChzb3VyY2VfZGlyKS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9t aXVtQ3VycmVudFRpbWUuY3BwJywKLSAgICAgICAgICAgICAgICAgICAgICAgICc8KHNvdXJjZV9k aXIpL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1UaHJlYWRpbmcuY3BwJywKLSAgICAgICAg ICAgICAgICAgICAgXSwKLSAgICAgICAgICAgICAgICAgICAgJ2luY2x1ZGVfZGlycyc6IFsKLSAg ICAgICAgICAgICAgICAgICAgICAgICc8KHNvdXJjZV9kaXIpL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMnLAotICAgICAgICAgICAgICAgICAgICBdLAotICAgICAgICAgICAgICAgICAgICAnZGVwZW5k ZW5jaWVzJzogWwotICAgICAgICAgICAgICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV1RGL1dU Ri5neXAvV1RGLmd5cDp3dGYnLAotICAgICAgICAgICAgICAgICAgICBdLAotICAgICAgICAgICAg ICAgIH1dLAogICAgICAgICAgICAgICAgIFsnaW5zaWRlX2Nocm9taXVtX2J1aWxkPT0wJywgewog ICAgICAgICAgICAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAgICAgICAgICAg ICAgICAgJzwoY2hyb21pdW1fc3JjX2Rpcikvd2Via2l0L3N1cHBvcnQvc2V0dXBfdGhpcmRfcGFy dHkuZ3lwOnRoaXJkX3BhcnR5X2hlYWRlcnMnLAo= 171373 2012-10-29 22:22:18 -0700 2012-10-29 23:44:02 -0700 Patch bug-100658-20121030062044.patch text/plain 2575 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDlmYmVlODc2NmQzODJiY2I1MDM2NDBiZWY5ODQ5YTdi MTFhYThjYi4uYjZmY2YwODIwNmYwODYwNjhiYzE2NjhiNDAzNDVkZGI0YWQ5NzA4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEwLTI5ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gVGVzdFJ1bm5lciBuZWVkcyB0byBjb21waWxlIENocm9taXVt Q3VycmVudFRpbWUgYW5kIENocm9taXVtVGhyZWFkaW5nIGluIGNvbXBvbmVudHMgYnVpbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDY1OAorCisg ICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCisKKyAgICAgICAgQmVmb3JlLCB0aGlzIHdh cyBjb21waWxlZCBpbnRvIER1bXBSZW5kZXJUcmVlLiBJIGFsc28gZHJvcHBlZCB0aGUKKyAgICAg ICAgaW5jbHVkZV9kaXJzIGFuZCBkZXBlbmRlbmNpZXMgYmxvY2sgYXMgVGVzdFJ1bm5lciBhbHJl YWR5IGhhcyB0aGVtLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUu Z3lwL0R1bXBSZW5kZXJUcmVlLmd5cDoKKwogMjAxMi0xMC0yOSAgVGFrYXNoaSBTYWthbW90byAg PHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkaW5nIG15c2VsZiBh cyBhIGNvbW1pdHRlci4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5k ZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1w UmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCmluZGV4IGJkZmYyOTk0ZjdkNmNkYTVm NzhhZTBlMmFiZWFhYTVjNWFkODJmNmUuLjU2YWVhYjczMmM5ZjRmNmUwMWY0NmQ4MDBlOGQ2ZWMz ZDc1OTE5Y2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVl Lmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJl bmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cApAQCAtMTE2LDYgKzExNiwxMiBAQAogICAg ICAgICAgICAgICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9ndGsnLAogICAgICAgICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgIH1dLAorICAg ICAgICAgICAgICAgIFsnaW5zaWRlX2Nocm9taXVtX2J1aWxkPT0xIGFuZCBjb21wb25lbnQ9PSJz aGFyZWRfbGlicmFyeSInLCB7CisgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzJzogWworICAg ICAgICAgICAgICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV2ViS2l0L2Nocm9taXVtL3NyYy9D aHJvbWl1bUN1cnJlbnRUaW1lLmNwcCcsCisgICAgICAgICAgICAgICAgICAgICAgICAnPChzb3Vy Y2VfZGlyKS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVtVGhyZWFkaW5nLmNwcCcsCisgICAg ICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAgICBdLAog ICAgICAgICB9LAogICAgICAgICB7CkBAIC0zNDgsMTggKzM1NCw2IEBACiAgICAgICAgICAgICAg ICAgICAgICAgICBbJ2V4Y2x1ZGUnLCAnQW5kcm9pZFxcLmNwcCQnXSwKICAgICAgICAgICAgICAg ICAgICAgXSwKICAgICAgICAgICAgICAgICB9XSwKLSAgICAgICAgICAgICAgICBbJ2luc2lkZV9j aHJvbWl1bV9idWlsZD09MSBhbmQgY29tcG9uZW50PT0ic2hhcmVkX2xpYnJhcnkiJywgewotICAg ICAgICAgICAgICAgICAgICAnc291cmNlcyc6IFsKLSAgICAgICAgICAgICAgICAgICAgICAgICc8 KHNvdXJjZV9kaXIpL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1DdXJyZW50VGltZS5jcHAn LAotICAgICAgICAgICAgICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV2ViS2l0L2Nocm9taXVt L3NyYy9DaHJvbWl1bVRocmVhZGluZy5jcHAnLAotICAgICAgICAgICAgICAgICAgICBdLAotICAg ICAgICAgICAgICAgICAgICAnaW5jbHVkZV9kaXJzJzogWwotICAgICAgICAgICAgICAgICAgICAg ICAgJzwoc291cmNlX2RpcikvV2ViS2l0L2Nocm9taXVtL3B1YmxpYycsCi0gICAgICAgICAgICAg ICAgICAgIF0sCi0gICAgICAgICAgICAgICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCi0gICAgICAg ICAgICAgICAgICAgICAgICAnPChzb3VyY2VfZGlyKS9XVEYvV1RGLmd5cC9XVEYuZ3lwOnd0Zics Ci0gICAgICAgICAgICAgICAgICAgIF0sCi0gICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAg ICAgICAgWydpbnNpZGVfY2hyb21pdW1fYnVpbGQ9PTAnLCB7CiAgICAgICAgICAgICAgICAgICAg ICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9z cmNfZGlyKS93ZWJraXQvc3VwcG9ydC9zZXR1cF90aGlyZF9wYXJ0eS5neXA6dGhpcmRfcGFydHlf aGVhZGVycycsCg==