100649 2012-10-29 03:19:56 -0700 [BlackBerry] Fix a build error 2012-10-29 14:42:50 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 robin.webkit robin.webkit charles.wei haraken mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 753214 0 robin.webkit 2012-10-29 03:19:56 -0700 r127876 changed the signature of WebCore::EventHandler::hitTestResultAtPoint(), but this commit was later reverted. We need to update a call site in the BlackBerry port to make it build. 753256 1 171199 robin.webkit 2012-10-29 04:18:58 -0700 Created attachment 171199 patch 753314 2 171199 haraken 2012-10-29 05:51:39 -0700 Comment on attachment 171199 patch rs=me. This could even be an unreviewed fix. 753333 3 171199 webkit.review.bot 2012-10-29 06:08:06 -0700 Comment on attachment 171199 patch Clearing flags on attachment: 171199 Committed r132792: <http://trac.webkit.org/changeset/132792> 753334 4 webkit.review.bot 2012-10-29 06:08:14 -0700 All reviewed patches have been landed. Closing bug. 753770 5 171199 tonikitoo 2012-10-29 14:32:27 -0700 Comment on attachment 171199 patch From a very quick look, this revision changed the method signature to be the contrary of what you did: http://trac.webkit.org/changeset/127876/trunk/Source/WebCore/page/EventHandler.h It does not take a bool as a second parameter, but a HitTestRequestType. Did I miss something? 753775 6 tonikitoo 2012-10-29 14:42:50 -0700 (In reply to comment #5) > (From update of attachment 171199 [details]) > From a very quick look, this revision changed the method signature to be the contrary of what you did: http://trac.webkit.org/changeset/127876/trunk/Source/WebCore/page/EventHandler.h > > > It does not take a bool as a second parameter, but a HitTestRequestType. Did I miss something? Ignore, me. I missed " but this commit was later reverted." 171199 2012-10-29 04:18:58 -0700 2012-10-29 14:32:27 -0700 patch bug-100649-20121029191723.patch text/plain 1837 robin.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlNDJlNmQzMDk2NGRmNWFmNmNlNGRhNDYwYjRiNDQ2NjAyNTM2OGE3Li5lNzFhYjMwNjRm YjY5YWM3ZWJlNmIwZGU2YmIxYTlmMjJlNjNlYzEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMC0yOSAgUm9iaW4gQ2FvICA8cm9iaW4uY2Fv QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRml4IGEgYnVpbGQg ZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIx Mjc4NzYgY2hhbmdlZCB0aGUgc2lnbmF0dXJlIG9mIFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGl0 VGVzdFJlc3VsdEF0UG9pbnQoKQorICAgICAgICBhbmQgdGhpcyBjb21taXQgd2FzIGxhdGVyIHJl dmVydGVkLiBXZSBuZWVkIHRvIHVwZGF0ZSBhIGNhbGwgc2l0ZSBpbiB0aGUKKyAgICAgICAgQmxh Y2tCZXJyeSBwb3J0IHRvIG1ha2UgaXQgYnVpbGQuCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpoaXRUZXN0 UmVzdWx0KToKKwogMjAxMi0xMC0yNiAgSmFja3kgSmlhbmcgIDx6aGFqaWFuZ0ByaW0uY29tPgog CiAgICAgICAgIFtCbGFja0JlcnJ5XVtGdWxsU2NyZWVuXSBlbnRlcmluZy9sZWF2aW5nIGZ1bGxz Y3JlZW4gcmVzdWx0cyBpbiB0ZW1wb3JhcnkgZ2xpdGNoZXMgb24gdGhlIHNjcmVlbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggOWM3MDU2YzlhNjc0NDcwMjg1 OGU3NmZmZmUzY2IyMjAxODFiOTVmNy4uMDczZTM4MDUwYmVhNTUxNjZkYjFjNDQ5YmQ1ZDhjNzcw Y2JhZWM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC02 MzY0LDcgKzYzNjQsNyBAQCBjb25zdCBIaXRUZXN0UmVzdWx0JiBXZWJQYWdlUHJpdmF0ZTo6aGl0 VGVzdFJlc3VsdChjb25zdCBJbnRQb2ludCYgY29udGVudFBvcykKIHsKICAgICBpZiAobV9jYWNo ZWRIaXRUZXN0Q29udGVudFBvcyAhPSBjb250ZW50UG9zKSB7CiAgICAgICAgIG1fY2FjaGVkSGl0 VGVzdENvbnRlbnRQb3MgPSBjb250ZW50UG9zOwotICAgICAgICBtX2NhY2hlZEhpdFRlc3RSZXN1 bHQgPSBtX21haW5GcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhpdFRlc3RSZXN1bHRBdFBvaW50KG1f Y2FjaGVkSGl0VGVzdENvbnRlbnRQb3MsIEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRl c3RSZXF1ZXN0OjpBY3RpdmUgfCBIaXRUZXN0UmVxdWVzdDo6QWxsb3dTaGFkb3dDb250ZW50KTsK KyAgICAgICAgbV9jYWNoZWRIaXRUZXN0UmVzdWx0ID0gbV9tYWluRnJhbWUtPmV2ZW50SGFuZGxl cigpLT5oaXRUZXN0UmVzdWx0QXRQb2ludChtX2NhY2hlZEhpdFRlc3RDb250ZW50UG9zLCB0cnVl IC8qYWxsb3dTaGFkb3dDb250ZW50Ki8pOwogICAgIH0KIAogICAgIHJldHVybiBtX2NhY2hlZEhp dFRlc3RSZXN1bHQ7Cg==