100628 2012-10-28 22:40:42 -0700 Remove an un-necessary connection to X-Server 2012-11-01 04:22:24 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 kalyan.kondapally webkit-unassigned webkit.review.bot oldest_to_newest 753070 0 kalyan.kondapally 2012-10-28 22:40:42 -0700 In GraphicsSurfacePrivate constructor we make a connection to Xserver for gaining access to the screens in the display.Immediately(in constructor itself) we ask the display from offscreenwindow. Removing the former connection as we use the Display returned by offscreenwindow. 753071 1 171159 kalyan.kondapally 2012-10-28 22:42:26 -0700 Created attachment 171159 proposed-patch Patch 753079 2 kalyan.kondapally 2012-10-28 23:03:47 -0700 After the following changeset we always use the Display returned by offscreenwindow: https://bugs.webkit.org/show_bug.cgi?id=100523 754136 3 171159 kenneth 2012-10-30 02:57:04 -0700 Comment on attachment 171159 proposed-patch View in context: https://bugs.webkit.org/attachment.cgi?id=171159&action=review > Source/WebCore/ChangeLog:8 > + for gaining access to the screens in the display.Immediately(in constructor itself) > + we ask the display from offscreenwindow. Space before Immediately and before the (. Maybe it should be on a new line Try to make the changelogs easy readable > Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:133 > , m_hasAlpha(false) > { > GLXContext shareContextObject = 0; > - m_display = XOpenDisplay(0); > + m_display = m_offScreenWindow.display(); sorry is m_offScreenWindow initialized here? it is not in the initializer list 754164 4 kalyan.kondapally 2012-10-30 03:41:23 -0700 (In reply to comment #3) > (From update of attachment 171159 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171159&action=review > > > Source/WebCore/ChangeLog:8 > > + for gaining access to the screens in the display.Immediately(in constructor itself) > > + we ask the display from offscreenwindow. > > Space before Immediately and before the (. Maybe it should be on a new line > > Try to make the changelogs easy readable > > > Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:133 > > , m_hasAlpha(false) > > { > > GLXContext shareContextObject = 0; > > - m_display = XOpenDisplay(0); > > + m_display = m_offScreenWindow.display(); > > sorry is m_offScreenWindow initialized here? it is not in the initializer list m_offScreenWindow is a member variable of GraphicsSurfacePrivate. It is created here and increments refcount (static member variable) in its constructor. It would create a window and open connection to display on calls to getXWindow () and display () respectively. 754630 5 171513 kalyan.kondapally 2012-10-30 13:39:56 -0700 Created attachment 171513 patch2 Review changes 756080 6 171513 webkit.review.bot 2012-11-01 04:22:21 -0700 Comment on attachment 171513 patch2 Clearing flags on attachment: 171513 Committed r133147: <http://trac.webkit.org/changeset/133147> 756081 7 webkit.review.bot 2012-11-01 04:22:24 -0700 All reviewed patches have been landed. Closing bug. 171159 2012-10-28 22:42:26 -0700 2012-10-30 13:40:21 -0700 proposed-patch xconnectionremoval.patch text/plain 1809 kalyan.kondapally ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYTkyMjdjLi44ZDE0OWU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMjkgIEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50 ZWwuY29tPgorCisgICAgICAgIFtRdF1bRUZMXVtXSzJdIFJlbW92ZSBhbiB1bi1uZWNlc3Nhcnkg Y29ubmVjdGlvbiB0byBYLVNlcnZlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMDYyOAorCisgICAgICAgIEluIEdyYXBoaWNzU3VyZmFjZVByaXZh dGUgY29uc3RydWN0b3Igd2UgbWFrZSBhIGNvbm5lY3Rpb24gdG8gWHNlcnZlcgorICAgICAgICBm b3IgZ2FpbmluZyBhY2Nlc3MgdG8gdGhlIHNjcmVlbnMgaW4gdGhlIGRpc3BsYXkuSW1tZWRpYXRl bHkoaW4gY29uc3RydWN0b3IgaXRzZWxmKQorICAgICAgICB3ZSBhc2sgdGhlIGRpc3BsYXkgZnJv bSBvZmZzY3JlZW53aW5kb3cuCisgICAgICAgIFJlbW92aW5nIHRoZSBmb3JtZXIgY29ubmVjdGlv biBhcyB3ZSB1c2UgdGhlIERpc3BsYXkgcmV0dXJuZWQgYnkgb2Zmc2NyZWVud2luZG93LgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcDoKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NTdXJmYWNlUHJpdmF0ZTo6R3JhcGhp Y3NTdXJmYWNlUHJpdmF0ZSk6CisKIDIwMTItMTAtMjcgIERhdmlkIEJhcnRvbiAgPGRiYXJ0b25A bWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogbV9uZXh0IGluIExh eW91dFN0YXRlLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL3F0L0dyYXBoaWNzU3VyZmFjZUdMWC5jcHAKaW5kZXgg YmUwMGZhNi4uMjkxMzNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9xdC9HcmFwaGljc1N1cmZhY2VHTFguY3Bw CkBAIC0xMzAsNyArMTMwLDcgQEAgc3RydWN0IEdyYXBoaWNzU3VyZmFjZVByaXZhdGUgewogICAg ICAgICAsIG1faGFzQWxwaGEoZmFsc2UpCiAgICAgewogICAgICAgICBHTFhDb250ZXh0IHNoYXJl Q29udGV4dE9iamVjdCA9IDA7Ci0gICAgICAgIG1fZGlzcGxheSA9IFhPcGVuRGlzcGxheSgwKTsK KyAgICAgICAgbV9kaXNwbGF5ID0gbV9vZmZTY3JlZW5XaW5kb3cuZGlzcGxheSgpOwogCiAjaWYg UExBVEZPUk0oUVQpCiAgICAgICAgIGlmIChzaGFyZUNvbnRleHQpIHsKQEAgLTE1NCw3ICsxNTQs NiBAQCBzdHJ1Y3QgR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZSB7CiAgICAgICAgIH0KICNlbmRpZgog Ci0gICAgICAgIG1fZGlzcGxheSA9IG1fb2ZmU2NyZWVuV2luZG93LmRpc3BsYXkoKTsKICAgICAg ICAgaW50IGF0dHJpYnV0ZXNbXSA9IHsKICAgICAgICAgICAgIEdMWF9MRVZFTCwgMCwKICAgICAg ICAgICAgIEdMWF9EUkFXQUJMRV9UWVBFLCBHTFhfV0lORE9XX0JJVCwK 171513 2012-10-30 13:39:56 -0700 2012-11-01 04:22:21 -0700 patch2 xserver.patch text/plain 1845 kalyan.kondapally ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNGFjNDE0Li45N2Q5YjgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMzAgIEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50 ZWwuY29tPgorCisgICAgICAgIFtFRkxdW1F0XVtBQ10gUmVtb3ZlIGFuIHVubmVjZXNzYXJ5IGNv bm5lY3Rpb24gdG8gWC1TZXJ2ZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDA2MjguCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2l0aCBDaGFuZ3NldDogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMDUyMworICAgICAgICBHcmFwaGljc1N1cmZhY2VQcml2YXRlIHNob3Vs ZCBhbHdheXMgdXNlIHRoZSBEaXNwbGF5IHJldHVybmVkIGJ5IG9mZnNjcmVlbndpbmRvdy4KKyAg ICAgICAgSG93ZXZlciwgaW4gR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZSBjb25zdHJ1Y3RvciB3ZSBj YWxsIFhPcGVuRGlzcGxheSBiZWZvcmUgYXNraW5nCisgICAgICAgIGRpc3BsYXkgZnJvbSBvZmZz Y3JlZW53aW5kb3cuCisgICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyB1bm5lY2Vzc2FyeSBjYWxs IHRvIFhPcGVuRGlzcGxheSBtYWRlIGluIEdyYXBoaWNzU3VyZmFjZVByaXZhdGUuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9xdC9HcmFwaGljc1N1cmZhY2VHTFguY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NTdXJmYWNlUHJpdmF0ZTo6R3JhcGhpY3NTdXJm YWNlUHJpdmF0ZSk6CisKIDIwMTItMTAtMzAgIMOBZMOhbSBLYWxsYWkgIDxrYWRhbUBpbmYudS1z emVnZWQuaHU+CgogICAgICAgICBbUXRdW01hY10gVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9xdC9HcmFw aGljc1N1cmZhY2VHTFguY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3Vy ZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcAppbmRleCBiZTAwZmE2Li4yOTEzM2I3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9xdC9H cmFwaGljc1N1cmZhY2VHTFguY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3N1cmZhY2VzL3F0L0dyYXBoaWNzU3VyZmFjZUdMWC5jcHAKQEAgLTEzMCw3ICsxMzAsNyBA QCBzdHJ1Y3QgR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZSB7CiAgICAgICAgICwgbV9oYXNBbHBoYShm YWxzZSkKICAgICB7CiAgICAgICAgIEdMWENvbnRleHQgc2hhcmVDb250ZXh0T2JqZWN0ID0gMDsK LSAgICAgICAgbV9kaXNwbGF5ID0gWE9wZW5EaXNwbGF5KDApOworICAgICAgICBtX2Rpc3BsYXkg PSBtX29mZlNjcmVlbldpbmRvdy5kaXNwbGF5KCk7CgogI2lmIFBMQVRGT1JNKFFUKQogICAgICAg ICBpZiAoc2hhcmVDb250ZXh0KSB7CkBAIC0xNTQsNyArMTU0LDYgQEAgc3RydWN0IEdyYXBoaWNz U3VyZmFjZVByaXZhdGUgewogICAgICAgICB9CiAjZW5kaWYKCi0gICAgICAgIG1fZGlzcGxheSA9 IG1fb2ZmU2NyZWVuV2luZG93LmRpc3BsYXkoKTsKICAgICAgICAgaW50IGF0dHJpYnV0ZXNbXSA9 IHsKICAgICAgICAgICAgIEdMWF9MRVZFTCwgMCwKICAgICAgICAgICAgIEdMWF9EUkFXQUJMRV9U WVBFLCBHTFhfV0lORE9XX0JJVCwK