100616 2012-10-28 14:22:39 -0700 [GTK] LDFLAGS are being incorrectly used at compile time (rather than linking) 2013-01-25 09:05:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jeremyhu mrobinson mrobinson webkit.review.bot oldest_to_newest 752990 0 jeremyhu 2012-10-28 14:22:39 -0700 I noticed that some LDFLAGS (-L and -l) were being used as CXXFLAGS. See below from a build of webkitgtk-1.10.1 on darwin/x11 ... some X11 LDFLAGS are landing on the compile line. libtool: compile: /usr/bin/clang++ -DHAVE_CONFIG_H -I. -DBUILDING_WEBKIT -DPACKAGE_LOCALE_DIR=\"/opt/local/share/locale\" -DDATA_DIR=\"/opt/local/share\" -I./Source/WebCore/bindings -I./Source/WebCore/bindings/gobject -I./Source/WebKit/gtk -I./Source/WebKit/gtk/WebCoreSupport -I./Source/WebKit/gtk/webkit -I./DerivedSources/webkit -ISource/WebKit/gtk/webkit -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DENABLE_GLIB_SUPPORT=1 -DBUILDING_CAIRO__=1 -DBUILDING_GTK__=1 -DBUILDING_SOUP__=1 -DWTF_CHANGES -DXP_UNIX -DMOZ_X11 -DWTF_USE_ICU_UNICODE=1 -DWTF_USE_GSTREAMER=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_3D_RENDERING=1 -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1 -DWTF_USE_GLX=1 -DWTF_USE_OPENGL=1 -DGTK_API_VERSION_2=1 -DNDEBUG -I./Source/ThirdParty/ANGLE/src -I./Source/ThirdParty/ANGLE/include -I./Source/ThirdParty/ANGLE/include/GLSLANG -I./Source/WebCore -I./Source/WebCore/Modules/filesystem -I./Source/WebCore/Modules/gamepad -I./Source/WebCore/Modules/geolocation -I./Source/WebCore/Modules/indexeddb -I./Source/WebCore/Modules/mediasource -I./Source/WebCore/Modules/mediastream -I./Source/WebCore/Modules/notifications -I./Source/WebCore/Modules/protocolhandler -I./Source/WebCore/Modules/quota -I./Source/WebCore/Modules/webaudio -I./Source/WebCore/Modules/webdatabase -I./Source/WebCore/Modules/websockets -I./Source/WebCore/accessibility -I./Source/WebCore/bindings -I./Source/WebCore/bindings/generic -I./Source/WebCore/bindings/js -I./Source/WebCore/bridge -I./Source/WebCore/bridge/c -I./Source/WebCore/bridge/jni/jsc -I./Source/WebCore/bridge/jsc -I./Source/WebCore/css -I./Source/WebCore/dom -I./Source/WebCore/dom/default -I./Source/WebCore/editing -I./Source/WebCore/fileapi -I./Source/WebCore/history -I./Source/WebCore/html -I./Source/WebCore/html/canvas -I./Source/WebCore/html/parser -I./Source/WebCore/html/shadow -I./Source/WebCore/html/track -I./Source/WebCore/inspector -I./Source/WebCore/loader -I./Source/WebCore/loader/appcache -I./Source/WebCore/loader/archive -I./Source/WebCore/loader/cache -I./Source/WebCore/loader/icon -I./Source/WebCore/mathml -I./Source/WebCore/page -I./Source/WebCore/page/animation -I./Source/WebCore/page/scrolling -I./Source/WebCore/platform -I./Source/WebCore/platform/animation -I./Source/WebCore/platform/audio -I./Source/WebCore/platform/graphics -I./Source/WebCore/platform/graphics/filters -I./Source/WebCore/platform/graphics/filters/arm -I./Source/WebCore/platform/graphics/gpu -I./Source/WebCore/platform/graphics/opengl -I./Source/WebCore/platform/graphics/opentype -I./Source/WebCore/platform/graphics/transforms -I./Source/WebCore/platform/image-decoders -I./Source/WebCore/platform/image-decoders/bmp -I./Source/WebCore/platform/image-decoders/gif -I./Source/WebCore/platform/image-decoders/ico -I./Source/WebCore/platform/image-decoders/jpeg -I./Source/WebCore/platform/image-decoders/webp -I./Source/WebCore/platform/image-decoders/png -I./Source/WebCore/platform/leveldb -I./Source/WebCore/platform/linux -I./Source/WebCore/platform/mediastream -I./Source/WebCore/platform/mediastream/gstreamer -I./Source/WebCore/platform/mock -I./Source/WebCore/platform/network -I./Source/WebCore/platform/sql -I./Source/WebCore/platform/text -I./Source/WebCore/platform/text/transcoder -I./Source/WebCore/platform/win -I./Source/WebCore/plugins -I./Source/WebCore/plugins/win -I./Source/WebCore/rendering -I./Source/WebCore/rendering/mathml -I./Source/WebCore/rendering/style -I./Source/WebCore/rendering/svg -I./Source/WebCore/storage -I./Source/WebCore/svg -I./Source/WebCore/svg/animation -I./Source/WebCore/svg/graphics -I./Source/WebCore/svg/graphics/filters -I./Source/WebCore/svg/properties -I./Source/WebCore/testing -I./Source/WebCore/testing/js -I./Source/WebCore/websockets -I./Source/WebCore/workers -I./Source/WebCore/xml -I./Source/WebCore/xml/parser -I./WebCore/bindings/js -I./DerivedSources/WebCore -I./DerivedSources -I./DerivedSources/JavaScriptCore -DDATA_DIR=\"/opt/local/share\" -DENABLE_SMOOTH_SCROLLING=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_METER_ELEMENT=1 -DENABLE_PROGRESS_ELEMENT=1 -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_GAMEPAD=0 -DENABLE_SQL_DATABASE=1 -DENABLE_DATALIST_ELEMENT=1 -DENABLE_DIRECTORY_UPLOAD=0 -DENABLE_MUTATION_OBSERVERS=1 -DENABLE_TOUCH_ICON_LOADING=0 -DENABLE_INPUT_TYPE_COLOR=0 -DENABLE_INPUT_SPEECH=0 -DENABLE_SCRIPTED_SPEECH=0 -DENABLE_ICONDATABASE=1 -DENABLE_VIDEO=1 -DENABLE_MEDIA_SOURCE=0 -DENABLE_MEDIA_STATISTICS=1 -DENABLE_FULLSCREEN_API=1 -DENABLE_VIDEO_TRACK=1 -DENABLE_MEDIA_STREAM=0 -DENABLE_XSLT=1 -DENABLE_WORKERS=1 -DENABLE_SHADOW_DOM=1 -DENABLE_SHARED_WORKERS=1 -DENABLE_FILTERS=1 -DENABLE_CSS_BOX_DECORATION_BREAK=1 -DENABLE_CSS_REGIONS=1 -DENABLE_CSS_EXCLUSIONS=1 -DENABLE_GEOLOCATION=1 -DENABLE_MATHML=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_BLOB=1 -DENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1 -DENABLE_REQUEST_ANIMATION_FRAME=1 -DENABLE_WEBGL=1 -I./Source/WebCore/platform/graphics/texmap -DENABLE_MHTML=1 -I./Source/WebCore/loader/archive/mhtml -DENABLE_MICRODATA=1 -DENABLE_WEB_TIMING=1 -DENABLE_IFRAME_SEAMLESS=1 -DENABLE_LINK_PREFETCH=1 -DENABLE_SPELLCHECK=1 -DWEBKITGTK_API_VERSION_STRING=\"1.0\" -DWTF_USE_SOUP=1 -I./Source/WebCore/accessibility/gtk -I./Source/WebCore/loader/gtk -I./Source/WebCore/page/gtk -I./Source/WebCore/platform/cairo -I./Source/WebCore/platform/audio/gstreamer -I./Source/WebCore/platform/geoclue -I./Source/WebCore/platform/graphics/cairo -I./Source/WebCore/platform/graphics/glx -I./Source/WebCore/platform/graphics/gstreamer -I./Source/WebCore/platform/graphics/gtk -I./Source/WebCore/platform/gtk -I./Source/WebCore/platform/network/soup -I./Source/WebCore/platform/text/gtk -DWTF_USE_PANGO=1 -I./Source/WebCore/platform/graphics/pango -DENABLE_JIT=0 -I./Source -I./Source/JavaScriptCore -I./Source/JavaScriptCore/API -I./Source/JavaScriptCore/assembler -I./Source/JavaScriptCore/bytecode -I./Source/JavaScriptCore/bytecompiler -I./Source/JavaScriptCore/dfg -I./Source/JavaScriptCore/disassembler -I./Source/JavaScriptCore/heap -I./Source/JavaScriptCore/debugger -I./Source/JavaScriptCore/ForwardingHeaders -I./Source/JavaScriptCore/interpreter -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/llint -I./Source/JavaScriptCore/parser -I./Source/JavaScriptCore/profiler -I./Source/JavaScriptCore/runtime -I./Source/JavaScriptCore/tools -I./Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I./Source/WTF -DENABLE_SPELLCHECK=1 -fno-strict-aliasing -D_REENTRANT -I/opt/local/include/enchant -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -D_REENTRANT -I/opt/local/include/gail-1.0 -I/opt/local/include/atk-1.0 -I/opt/local/include/gtk-2.0 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/lib/gtk-2.0/include -I/opt/local/include/cairo -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/pango-1.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/pixman-1 -I/opt/local/include/freetype2 -I/opt/local/include/libpng15 -I/opt/local/include -I/opt/local/include/dbus-1.0 -I/opt/local/include/libxml2 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -D_REENTRANT -I/opt/local/include/gstreamer-0.10 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -D_REENTRANT -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/pango-1.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/pixman-1 -I/opt/local/include/freetype2 -I/opt/local/include/libpng15 -D_REENTRANT -I/opt/local/include/libsoup-2.4 -I/opt/local/include/libxml2 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/libxml2 -I/opt/local/include -I/opt/local/include/libxml2 -I/opt/local/include -I/opt/local/include -L/opt/local/lib -lXcomposite -L/opt/local/lib -lXdamage -lXfixes -I/opt/local/include -I/opt/local/include -fvisibility-inlines-hidden -fno-rtti -pipe -O2 -std=c++11 -Wno-error=c++11-narrowing -arch x86_64 -O2 -MT DerivedSources/webkit/libwebkitgtk_1_0_la-WebKitDOMConsole.lo -MD -MP -MF DerivedSources/webkit/.deps/libwebkitgtk_1_0_la-WebKitDOMConsole.Tpo -c DerivedSources/webkit/WebKitDOMConsole.cpp -fno-common -DPIC -o DerivedSources/webkit/.libs/libwebkitgtk_1_0_la-WebKitDOMConsole.o clang: warning: -lXcomposite: 'linker' input unused clang: warning: -lXdamage: 'linker' input unused clang: warning: -lXfixes: 'linker' input unused clang: warning: argument unused during compilation: '-L/opt/local/lib' clang: warning: argument unused during compilation: '-L/opt/local/lib' 810782 1 mrobinson 2013-01-18 10:24:34 -0800 Do you mind testing if this is still an issue with recent unstable releases? 810830 2 jeremyhu 2013-01-18 10:50:53 -0800 It was as of maybe a month or two ago, but I'll check again with 1.11.4 810972 3 jeremyhu 2013-01-18 13:21:26 -0800 1.11.4 fails to build with: :info:build Source/JavaScriptCore/bytecode/CallLinkStatus.cpp: In member function 'JSC::Intrinsic JSC::CallLinkStatus::intrinsicFor(JSC::CodeSpecializationKind) const': :info:build Source/JavaScriptCore/bytecode/CallLinkStatus.cpp:80: error: 'class JSC::ExecutableBase' has no member named 'intrinsicFor' which is blocking me from testing at the moment... 810992 4 jeremyhu 2013-01-18 13:43:12 -0800 yes, this issue still exists in 1.11.4 816630 5 mrobinson 2013-01-25 08:44:27 -0800 Thanks for reporting. This should be fixed shortly. 816631 6 184761 mrobinson 2013-01-25 08:44:33 -0800 Created attachment 184761 Patch 816638 7 184761 webkit.review.bot 2013-01-25 09:05:27 -0800 Comment on attachment 184761 Patch Clearing flags on attachment: 184761 Committed r140835: <http://trac.webkit.org/changeset/140835> 816639 8 webkit.review.bot 2013-01-25 09:05:31 -0800 All reviewed patches have been landed. Closing bug. 184761 2013-01-25 08:44:33 -0800 2013-01-25 09:05:26 -0800 Patch bug-100616-20130125084124.patch text/plain 1632 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNzczMjkyMmY3 NmZkZmRiMTFhY2UxYzQ3ODExZDkzZDQzNDkwNzVmNi4uNmU4YTljMGYwNDk4NDU2ZjFlMzU5NGEw MzcxMTk3OWFhNjUwYTYxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEz LTAxLTI1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBMREZMQUdTIGFyZSBiZWluZyBpbmNvcnJlY3RseSB1c2VkIGF0IGNvbXBpbGUgdGlt ZSAocmF0aGVyIHRoYW4gbGlua2luZykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMDYxNgorCisgICAgICAgIFVucmV2aWV3ZWQsIHNpbmNlIHRoaXMg aXMganVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiB1c2UgUEFD S0FHRV9DRkxBR1MgaW5zdGVhZCBvZiBQQUNLQUdFX0xJQlMgd2hlbiBhcHBlbmRpbmcgcGtnLWNv bmZpZworICAgICAgICB2YXJpYWJsZXMgdG8gYnVpbGQgdGFyZ2V0IF9DRkxBR1MuCisKIDIwMTMt MDEtMjMgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS10gQXZvaWQgcmVzZXQgdGl0bGUgZm9yIG5hdmlnYXRpb24gd2l0aGluIHRoZSBwYWdl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9X ZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtCmluZGV4IGExYmZlNzk4YWM1YWE3YmQ3MTBkOWMyMDE2 NDM1ZjNkMWE3MzAwMzUuLmU4NDkxMjNiMGJkZjA4ZjA1ZWQ2YzMzNTQ5YTViNjg3OTg1YzlkMjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJj ZS9XZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtCkBAIC03MCw4ICs3MCw4IEBAIGxpYndlYmtpdGd0 a19AV0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQF9AV0VCS0lUR1RLX0FQSV9NSU5PUl9WRVJT SU9OQF9sYV9DUFBGCiAJJChMSUJYU0xUX0NGTEFHUykgXAogCSQoU1FMSVRFM19DRkxBR1MpIFwK IAkkKFVOSUNPREVfQ0ZMQUdTKSBcCi0JJChYQ09NUE9TSVRFX0xJQlMpIFwKLQkkKFhEQU1BR0Vf TElCUykgXAorCSQoWENPTVBPU0lURV9DRkxBR1MpIFwKKwkkKFhEQU1BR0VfQ0ZMQUdTKSBcCiAJ JChYVF9DRkxBR1MpIFwKIAkkKFpMSUJfQ0ZMQUdTKQogCkBAIC00NDEsOCArNDQxLDggQEAgd2Vi a2l0X3Rlc3RzX2NmbGFncyA9IFwKIAkkKEdMSUJfQ0ZMQUdTKSBcCiAJJChHVEtfQ0ZMQUdTKSBc CiAJJChMSUJTT1VQX0NGTEFHUykgXAotCSQoWFJFTkRFUl9MSUJTKSBcCi0JJChYVF9MSUJTKQor CSQoWFJFTkRFUl9DRkxBR1MpIFwKKwkkKFhUX0NGTEFHUykKIAogd2Via2l0X3Rlc3RzX2xkYWRk ID0gXAogCWxpYmphdmFzY3JpcHRjb3JlZ3RrLUBXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJT05A LkBXRUJLSVRHVEtfQVBJX01JTk9SX1ZFUlNJT05ALmxhIFwK