100610 2012-10-28 09:59:34 -0700 [WK2] Fix the incorrect use of preprocessor macro in WKPage.h 2012-10-28 22:14:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bw80.lee bw80.lee webkit.review.bot oldest_to_newest 752958 0 bw80.lee 2012-10-28 09:59:34 -0700 There is a preprocessor macro to check webkit feature 'ENABLE_INSPECTOR' in WKPage.h header file. This should be removed from the header file, and be moved to the source file. 752962 1 171134 bw80.lee 2012-10-28 10:24:25 -0700 Created attachment 171134 Patch 753059 2 171134 webkit.review.bot 2012-10-28 22:14:08 -0700 Comment on attachment 171134 Patch Clearing flags on attachment: 171134 Committed r132761: <http://trac.webkit.org/changeset/132761> 753060 3 webkit.review.bot 2012-10-28 22:14:11 -0700 All reviewed patches have been landed. Closing bug. 171134 2012-10-28 10:24:25 -0700 2012-10-28 22:14:08 -0700 Patch bug-100610-20121029022252.patch text/plain 2222 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODdiMDY2MDViMzBhNTJi YTg0YWFkODYyNmM1OWZmMzRlYjJkZTcwMS4uMzcwNGQ1NTdiN2RlMGI5MTRjOGE0MDQyMjFhNDY0 ZDVmYzBjZjBkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTI4ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBGaXggdGhl IGluY29ycmVjdCB1c2Ugb2YgcHJlcHJvY2Vzc29yIHN0YXRlbWVudCBpbiBBUEkgaGVhZGVyLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNjEwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRo ZSBwcmVwcm9jZXNzb3Igc3RhdGVtZW50IHRvIGNoZWNrICdFTkFCTEVfSU5TUEVDVE9SJyBmZWF0 dXJlCisgICAgICAgIGZyb20gdGhlIFdLUGFnZS5oLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9DL1dLUGFnZS5jcHA6CisgICAgICAgIChXS1BhZ2VHZXRJbnNwZWN0b3IpOgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaDoKKwogMjAxMi0xMC0yOCAgWWFlbCBBaGFyb24gIDx5 YWVsLmFoYXJvbkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXVtBQ10gVmlld3BvcnQg c2l6ZSBkb2VzIG5vdCBjaGFuZ2Ugd2hlbiB0aGUgd2luZG93IHNpemUgY2hhbmdlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRleCA1MmUxY2ViZjg4YmViOWM0 ZTJlMDMyODM1ZmMyOTI5OWM3NDdjMzlhLi5iZGJjYjU1NGQyZjc5OTM0ZjM2OGYyMzUxYjVlYTAw MzcwOTk2YmU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQ YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcApA QCAtMTgyLDEyICsxODIsMTQgQEAgdWludDY0X3QgV0tQYWdlR2V0UmVuZGVyVHJlZVNpemUoV0tQ YWdlUmVmIHBhZ2UpCiAgICAgcmV0dXJuIHRvSW1wbChwYWdlKS0+cmVuZGVyVHJlZVNpemUoKTsK IH0KIAotI2lmIGRlZmluZWQoRU5BQkxFX0lOU1BFQ1RPUikgJiYgRU5BQkxFX0lOU1BFQ1RPUgog V0tJbnNwZWN0b3JSZWYgV0tQYWdlR2V0SW5zcGVjdG9yKFdLUGFnZVJlZiBwYWdlUmVmKQogewor I2lmIGRlZmluZWQoRU5BQkxFX0lOU1BFQ1RPUikgJiYgRU5BQkxFX0lOU1BFQ1RPUgogICAgIHJl dHVybiB0b0FQSSh0b0ltcGwocGFnZVJlZiktPmluc3BlY3RvcigpKTsKLX0KKyNlbHNlCisgICAg cmV0dXJuIDA7CiAjZW5kaWYKK30KIAogZG91YmxlIFdLUGFnZUdldEVzdGltYXRlZFByb2dyZXNz KFdLUGFnZVJlZiBwYWdlUmVmKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLUGFnZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFn ZS5oCmluZGV4IDlkZmQ1MmUzYzBiNjIzNzhjNTI5NTc4ZmE3ZmY5ZmNhYjUzMzI5MGQuLmRhZGVi YmM5MTk4Yzc3MTE5NmJlYWU1ZWE3NzljMDZjODc3OTkzM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0MvV0tQYWdlLmgKQEAgLTM4Nyw5ICszODcsNyBAQCBXS19FWFBPUlQgdWludDY0 X3QgV0tQYWdlR2V0UmVuZGVyVHJlZVNpemUoV0tQYWdlUmVmIHBhZ2UpOwogCiBXS19FWFBPUlQg dm9pZCBXS1BhZ2VTZXRNZW1vcnlDYWNoZUNsaWVudENhbGxzRW5hYmxlZChXS1BhZ2VSZWYgcGFn ZSwgYm9vbCBtZW1vcnlDYWNoZUNsaWVudENhbGxzRW5hYmxlZCk7CiAKLSNpZiBkZWZpbmVkKEVO QUJMRV9JTlNQRUNUT1IpICYmIEVOQUJMRV9JTlNQRUNUT1IKIFdLX0VYUE9SVCBXS0luc3BlY3Rv clJlZiBXS1BhZ2VHZXRJbnNwZWN0b3IoV0tQYWdlUmVmIHBhZ2UpOwotI2VuZGlmCiAKIFdLX0VY UE9SVCBXS1N0cmluZ1JlZiBXS1BhZ2VDb3B5VXNlckFnZW50KFdLUGFnZVJlZiBwYWdlKTsKIAo=