100604 2012-10-27 22:54:15 -0700 [Chromium] Find-in-page reports matches in hidden iframes 2012-10-27 23:27:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric fishd leandrogracia webkit.review.bot oldest_to_newest 752902 0 abarth 2012-10-27 22:54:15 -0700 [Chromium] Find-in-page reports matches in hidden iframes 752904 1 171124 abarth 2012-10-27 22:55:39 -0700 Created attachment 171124 Patch 752905 2 abarth 2012-10-27 22:56:40 -0700 This patch fixes <http://code.google.com/p/chromium/issues/detail?id=156919>, which is a P1 release blocker for M23. 752906 3 171124 eric 2012-10-27 23:04:12 -0700 Comment on attachment 171124 Patch OK. LGTM. 752907 4 171124 webkit.review.bot 2012-10-27 23:11:04 -0700 Comment on attachment 171124 Patch Rejecting attachment 171124 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14615683 752912 5 171124 abarth 2012-10-27 23:27:56 -0700 Comment on attachment 171124 Patch Clearing flags on attachment: 171124 Committed r132746: <http://trac.webkit.org/changeset/132746> 752913 6 abarth 2012-10-27 23:27:59 -0700 All reviewed patches have been landed. Closing bug. 171124 2012-10-27 22:55:39 -0700 2012-10-27 23:27:56 -0700 Patch bug-100604-20121027225408.patch text/plain 4739 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDI1ODczMjc0MDYyNWU4MWI4OGZjMTM1Njg1ZTY1ZTYxMzBjMjMxNmUuLjFlYmQ4ZjNhODE3ZjJh OWQ4N2Q2YjViNDIwMjI4MzM2YWNlN2NlNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMTAtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIEZpbmQtaW4tcGFnZSByZXBvcnRzIG1hdGNoZXMgaW4g aGlkZGVuIGlmcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMDYwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgaXMgYWN0dWFsbHkgYSByZWdyZXNzaW9uIGNhdXNlZCBieQorICAgICAgICBo dHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMjg3ODQuIFRoaXMgcGF0Y2ggYWRkcyBi YWNrIHNvbWUgY29kZQorICAgICAgICByZW1vdmVkIGluIFdlYkZyYW1lSW1wbDo6c2hvdWxkU2Nv cGVNYXRjaGVzIGluIHIxMjg3ODQuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhbHNvIGludHJvZHVj ZXMgYSB0ZXN0IHNvIHRoYXQgd2UgZG9uJ3QgbWFrZSB0aGlzIG1pc3Rha2UKKyAgICAgICAgYWdh aW4uCisKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViRnJhbWVJbXBsOjpzaG91bGRTY29wZU1hdGNoZXMpOgorICAgICAgICAqIHRlc3RzL1dlYkZy YW1lVGVzdC5jcHA6CisgICAgICAgICogdGVzdHMvZGF0YS9maW5kX2luX2hpZGRlbl9mcmFtZS5o dG1sOiBBZGRlZC4KKwogMjAxMi0xMC0yNiAgRG9taW5pYyBNYXp6b25pICA8ZG1henpvbmlAZ29v Z2xlLmNvbT4KIAogICAgICAgICBBWDogTm90aWZpY2F0aW9uIHNob3VsZCBiZSBzZW50IHdoZW4g YWNjZXNzaWJpbGl0eUlzSWdub3JlZCBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCA4YTg5YWE1YTFmYjBjY2E1ODBlYjkyYWJlZGU1ZDQ4 ZDM1MzUzNTYwLi45ZTZlYWM0NGQ0ZDllNDcwNTZlM2RmMzY0MDE4YzliOTEyYTg3YWI1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTI0NTMsNyAr MjQ1Myw3IEBAIGJvb2wgV2ViRnJhbWVJbXBsOjpzaG91bGRTY29wZU1hdGNoZXMoY29uc3QgU3Ry aW5nJiBzZWFyY2hUZXh0KQogICAgIC8vIERvbid0IHNjb3BlIGlmIHdlIGNhbid0IGZpbmQgYSBm cmFtZSBvciBhIHZpZXcuCiAgICAgLy8gVGhlIHVzZXIgbWF5IGhhdmUgY2xvc2VkIHRoZSB0YWIv YXBwbGljYXRpb24sIHNvIGFib3J0LgogICAgIC8vIEFsc28gaWdub3JlIGRldGFjaGVkIGZyYW1l cywgYXMgbWFueSBmaW5kIG9wZXJhdGlvbnMgcmVwb3J0IHRvIHRoZSBtYWluIGZyYW1lLgotICAg IGlmICghZnJhbWUoKSB8fCAhZnJhbWUoKS0+dmlldygpIHx8ICFmcmFtZSgpLT5wYWdlKCkpCisg ICAgaWYgKCFmcmFtZSgpIHx8ICFmcmFtZSgpLT52aWV3KCkgfHwgIWZyYW1lKCktPnBhZ2UoKSB8 fCAhaGFzVmlzaWJsZUNvbnRlbnQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgQVNT RVJUKGZyYW1lKCktPmRvY3VtZW50KCkgJiYgZnJhbWUoKS0+dmlldygpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAppbmRleCBkNGJjNDgxOWVjZjhm ZmJlOWM5YzIyOWE4N2MwMjhmNmMzMGExMTE4Li5mZmVkM2MyMDM4MTQ0ZTExMjc3Mzg4Y2MyNTVj MjI1MGNlNGQ5ZDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dl YkZyYW1lVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFt ZVRlc3QuY3BwCkBAIC0xMDQ1LDE5ICsxMDQ1LDIzIEBAIGNsYXNzIEZpbmRVcGRhdGVXZWJGcmFt ZUNsaWVudCA6IHB1YmxpYyBXZWJGcmFtZUNsaWVudCB7CiBwdWJsaWM6CiAgICAgRmluZFVwZGF0 ZVdlYkZyYW1lQ2xpZW50KCkKICAgICAgICAgOiBtX2ZpbmRSZXN1bHRzQXJlUmVhZHkoZmFsc2Up CisgICAgICAgICwgbV9jb3VudCgtMSkKICAgICB7CiAgICAgfQogCi0gICAgdmlydHVhbCB2b2lk IHJlcG9ydEZpbmRJblBhZ2VNYXRjaENvdW50KGludCwgaW50LCBib29sIGZpbmFsVXBkYXRlKSBP VkVSUklERQorICAgIHZpcnR1YWwgdm9pZCByZXBvcnRGaW5kSW5QYWdlTWF0Y2hDb3VudChpbnQs IGludCBjb3VudCwgYm9vbCBmaW5hbFVwZGF0ZSkgT1ZFUlJJREUKICAgICB7CisgICAgICAgIG1f Y291bnQgPSBjb3VudDsKICAgICAgICAgaWYgKGZpbmFsVXBkYXRlKQogICAgICAgICAgICAgbV9m aW5kUmVzdWx0c0FyZVJlYWR5ID0gdHJ1ZTsKICAgICB9CiAKICAgICBib29sIGZpbmRSZXN1bHRz QXJlUmVhZHkoKSBjb25zdCB7IHJldHVybiBtX2ZpbmRSZXN1bHRzQXJlUmVhZHk7IH0KKyAgICBp bnQgY291bnQoKSBjb25zdCB7IHJldHVybiBtX2NvdW50OyB9CiAKIHByaXZhdGU6CiAgICAgYm9v bCBtX2ZpbmRSZXN1bHRzQXJlUmVhZHk7CisgICAgaW50IG1fY291bnQ7CiB9OwogCiBURVNUX0Yo V2ViRnJhbWVUZXN0LCBGaW5kSW5QYWdlTWF0Y2hSZWN0cykKQEAgLTExNzIsNiArMTE3NiwzNyBA QCBURVNUX0YoV2ViRnJhbWVUZXN0LCBGaW5kSW5QYWdlTWF0Y2hSZWN0cykKICAgICB3ZWJWaWV3 LT5jbG9zZSgpOwogfQogCitURVNUX0YoV2ViRnJhbWVUZXN0LCBGaW5kSW5QYWdlU2tpcHNIaWRk ZW5GcmFtZXMpCit7CisgICAgcmVnaXN0ZXJNb2NrZWRIdHRwVVJMTG9hZCgiZmluZF9pbl9oaWRk ZW5fZnJhbWUuaHRtbCIpOworCisgICAgRmluZFVwZGF0ZVdlYkZyYW1lQ2xpZW50IGNsaWVudDsK KyAgICBXZWJWaWV3KiB3ZWJWaWV3ID0gRnJhbWVUZXN0SGVscGVyczo6Y3JlYXRlV2ViVmlld0Fu ZExvYWQobV9iYXNlVVJMICsgImZpbmRfaW5faGlkZGVuX2ZyYW1lLmh0bWwiLCB0cnVlLCAmY2xp ZW50KTsKKyAgICB3ZWJWaWV3LT5yZXNpemUoV2ViU2l6ZSg2NDAsIDQ4MCkpOworICAgIHdlYlZp ZXctPmxheW91dCgpOworICAgIHdlYmtpdF9zdXBwb3J0OjpSdW5BbGxQZW5kaW5nTWVzc2FnZXMo KTsKKworICAgIHN0YXRpYyBjb25zdCBjaGFyKiBrRmluZFN0cmluZyA9ICJoZWxsbyI7CisgICAg c3RhdGljIGNvbnN0IGludCBrRmluZElkZW50aWZpZXIgPSAxMjM0NTsKKyAgICBzdGF0aWMgY29u c3QgaW50IGtOdW1SZXN1bHRzID0gMTsKKworICAgIFdlYkZpbmRPcHRpb25zIG9wdGlvbnM7Cisg ICAgV2ViU3RyaW5nIHNlYXJjaFRleHQgPSBXZWJTdHJpbmc6OmZyb21VVEY4KGtGaW5kU3RyaW5n KTsKKyAgICBXZWJGcmFtZUltcGwqIG1haW5GcmFtZSA9IHN0YXRpY19jYXN0PFdlYkZyYW1lSW1w bCo+KHdlYlZpZXctPm1haW5GcmFtZSgpKTsKKyAgICBFWFBFQ1RfVFJVRShtYWluRnJhbWUtPmZp bmQoa0ZpbmRJZGVudGlmaWVyLCBzZWFyY2hUZXh0LCBvcHRpb25zLCBmYWxzZSwgMCkpOworCisg ICAgbWFpbkZyYW1lLT5yZXNldE1hdGNoQ291bnQoKTsKKworICAgIGZvciAoV2ViRnJhbWUqIGZy YW1lID0gbWFpbkZyYW1lOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJhdmVyc2VOZXh0KGZhbHNl KSkKKyAgICAgICAgZnJhbWUtPnNjb3BlU3RyaW5nTWF0Y2hlcyhrRmluZElkZW50aWZpZXIsIHNl YXJjaFRleHQsIG9wdGlvbnMsIHRydWUpOworCisgICAgd2Via2l0X3N1cHBvcnQ6OlJ1bkFsbFBl bmRpbmdNZXNzYWdlcygpOworICAgIEVYUEVDVF9UUlVFKGNsaWVudC5maW5kUmVzdWx0c0FyZVJl YWR5KCkpOworICAgIEVYUEVDVF9FUShrTnVtUmVzdWx0cywgY2xpZW50LmNvdW50KCkpOworCisg ICAgd2ViVmlldy0+Y2xvc2UoKTsKK30KKwogVEVTVF9GKFdlYkZyYW1lVGVzdCwgRmluZE9uRGV0 YWNoZWRGcmFtZSkKIHsKICAgICByZWdpc3Rlck1vY2tlZEh0dHBVUkxMb2FkKCJmaW5kX2luX3Bh Z2UuaHRtbCIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9kYXRh L2ZpbmRfaW5faGlkZGVuX2ZyYW1lLmh0bWwgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3Rz L2RhdGEvZmluZF9pbl9oaWRkZW5fZnJhbWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNjFmN2FmYWRhMDc4 MGU2ODRlNjYwYWVlNzdkOWNkMjAzOGY0YTczCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9kYXRhL2ZpbmRfaW5faGlkZGVuX2ZyYW1lLmh0bWwKQEAgLTAs MCArMSBAQAorPGRpdj5oZWxsbzwvZGl2PjxpZnJhbWUgc3R5bGU9ImRpc3BsYXk6aW5saW5lO3dp ZHRoOjA7aGVpZ2h0OjA7Ym9yZGVyOm5vbmUiIHNyYz0iZGF0YTp0ZXh0L2h0bWwsaGVsbG8iPjwv aWZyYW1lPgo=