<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100598</bug_id>
          
          <creation_ts>2012-10-27 16:45:47 -0700</creation_ts>
          <short_desc>[EFL][AC] Fix bugs preventing us from running layout tests with AC turned on</short_desc>
          <delta_ts>2012-10-29 07:30:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yael">yael</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>d-r</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>752853</commentid>
    <comment_count>0</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2012-10-27 16:45:47 -0700</bug_when>
    <thetext>Right now, all the tests crash when AC is turned on.
If there are many issues, this bug should become a meta bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753034</commentid>
    <comment_count>1</comment_count>
      <attachid>171148</attachid>
    <who name="Yael">yael</who>
    <bug_when>2012-10-28 20:33:44 -0700</bug_when>
    <thetext>Created attachment 171148
Patch

Make sure to use opengl_x11 engine when AC is turned on and X11 is in use.
We cannot create a gl context otherwise.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753082</commentid>
    <comment_count>2</comment_count>
      <attachid>171148</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-10-28 23:10:39 -0700</bug_when>
    <thetext>Comment on attachment 171148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171148&amp;action=review

&gt; Tools/EWebLauncher/main.c:813
&gt;      app-&gt;ee = ecore_evas_new(userArgs-&gt;engine, 0, 0, userArgs-&gt;geometry.w, userArgs-&gt;geometry.h, NULL);

shouldn&apos;t that be indented now?

&gt; Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:39
&gt;  static Ecore_Evas* initEcoreEvas()
&gt;  {
&gt; +#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X
&gt; +    const char* engine = &quot;opengl_x11&quot;;
&gt; +    Ecore_Evas* ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0);
&gt; +#else
&gt;      Ecore_Evas* ecoreEvas = ecore_evas_new(0, 0, 0, 800, 600, 0);
&gt; +#endif
&gt;      if (!ecoreEvas)

I would prefer

const char* engine = 0;

#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X
engine = &quot;opengl_x11&quot;;
#endif

Ecore_Evas* ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0);

&gt; Tools/DumpRenderTree/efl/DumpRenderTree.cpp:427
&gt; +#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X
&gt; +    const char* engine = &quot;opelgl_x11&quot;;
&gt; +    Ecore_Evas* ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0);
&gt; +#else
&gt;      Ecore_Evas* ecoreEvas = ecore_evas_new(0, 0, 0, 800, 600, 0);
&gt; +#endif

so much copied code, can&apos;t we concentrate it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753303</commentid>
    <comment_count>3</comment_count>
      <attachid>171211</attachid>
    <who name="Yael">yael</who>
    <bug_when>2012-10-29 05:42:38 -0700</bug_when>
    <thetext>Created attachment 171211
Patch for landing.

Take comment 2 into account.
I don&apos;t see how to share code between DumpRenderTree and WebKitTestRunner, so did not combine the code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753311</commentid>
    <comment_count>4</comment_count>
      <attachid>171211</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-29 05:49:14 -0700</bug_when>
    <thetext>Comment on attachment 171211
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=171211&amp;action=review

&gt; Tools/EWebLauncher/main.c:810
&gt; +#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X

I feel this is more readable:
#if defined(WTF_USE_ACCELERATED_COMPOSITING) &amp;&amp; defined(HAVE_ECORE_X)

It looks odd to mix #ifdef and defined. It also decreases readability to use &quot;defined&quot; without parenthesis.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753327</commentid>
    <comment_count>5</comment_count>
      <attachid>171211</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-29 05:58:43 -0700</bug_when>
    <thetext>Comment on attachment 171211
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=171211&amp;action=review

&gt; Tools/DumpRenderTree/efl/DumpRenderTree.cpp:422
&gt; +const char* engine = 0;

Nit : wrong indentation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753338</commentid>
    <comment_count>6</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2012-10-29 06:13:56 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 171211 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=171211&amp;action=review
&gt; 
&gt; &gt; Tools/DumpRenderTree/efl/DumpRenderTree.cpp:422
&gt; &gt; +const char* engine = 0;
&gt; 
&gt; Nit : wrong indentation.

Oops :) 
The stylebot should have caught it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753340</commentid>
    <comment_count>7</comment_count>
      <attachid>171219</attachid>
    <who name="Yael">yael</who>
    <bug_when>2012-10-29 06:16:07 -0700</bug_when>
    <thetext>Created attachment 171219
Patch for landing.

Address comment #4 and comment #5 .</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753345</commentid>
    <comment_count>8</comment_count>
      <attachid>171219</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-29 06:20:43 -0700</bug_when>
    <thetext>Comment on attachment 171219
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=171219&amp;action=review

&gt; Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:33
&gt; +const char* engine = 0;

ditto ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753353</commentid>
    <comment_count>9</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2012-10-29 06:27:25 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (From update of attachment 171219 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=171219&amp;action=review
&gt; 
&gt; &gt; Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:33
&gt; &gt; +const char* engine = 0;
&gt; 
&gt; ditto ?

Fixed but didn&apos;t save :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753356</commentid>
    <comment_count>10</comment_count>
      <attachid>171227</attachid>
    <who name="Yael">yael</who>
    <bug_when>2012-10-29 06:29:22 -0700</bug_when>
    <thetext>Created attachment 171227
One more time .</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753371</commentid>
    <comment_count>11</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-10-29 06:47:58 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 171211 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=171211&amp;action=review
&gt; 
&gt; &gt; Tools/EWebLauncher/main.c:810
&gt; &gt; +#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X
&gt; 
&gt; I feel this is more readable:
&gt; #if defined(WTF_USE_ACCELERATED_COMPOSITING) &amp;&amp; defined(HAVE_ECORE_X)

While we&apos;re at it, and I don&apos;t mean to halt the cq+, but shouldn&apos;t the first part be 
#if USE(ACCELERATED_COMPOSITING)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753388</commentid>
    <comment_count>12</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-29 07:03:21 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 171211 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=171211&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Tools/EWebLauncher/main.c:810
&gt; &gt; &gt; +#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X
&gt; &gt; 
&gt; &gt; I feel this is more readable:
&gt; &gt; #if defined(WTF_USE_ACCELERATED_COMPOSITING) &amp;&amp; defined(HAVE_ECORE_X)
&gt; 
&gt; While we&apos;re at it, and I don&apos;t mean to halt the cq+, but shouldn&apos;t the first part be 
&gt; #if USE(ACCELERATED_COMPOSITING)?

As far as I know, we have to use USE(XXX) macro in WebKit inside because this macro is defined in Platform.h file.  So, it seems to me that Tools can&apos;t use this.  However, if Tools can use this, I think it is better to use USE() macro. To my quick search, Tools can use it. Yael, could you check this ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753395</commentid>
    <comment_count>13</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2012-10-29 07:07:12 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 171211 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=171211&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Tools/EWebLauncher/main.c:810
&gt; &gt; &gt; +#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X
&gt; &gt; 
&gt; &gt; I feel this is more readable:
&gt; &gt; #if defined(WTF_USE_ACCELERATED_COMPOSITING) &amp;&amp; defined(HAVE_ECORE_X)
&gt; 
&gt; While we&apos;re at it, and I don&apos;t mean to halt the cq+, but shouldn&apos;t the first part be 
&gt; #if USE(ACCELERATED_COMPOSITING)?

AFAIK USE() macro is defined only internally to webkit.
EWebLauncher is not part of webkit itself and so the USE() macro is not defined.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753412</commentid>
    <comment_count>14</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-10-29 07:22:05 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #11)
&gt; &gt; (In reply to comment #4)
&gt; &gt; &gt; (From update of attachment 171211 [details] [details] [details])
&gt; &gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=171211&amp;action=review
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Tools/EWebLauncher/main.c:810
&gt; &gt; &gt; &gt; +#ifdef WTF_USE_ACCELERATED_COMPOSITING &amp;&amp; defined HAVE_ECORE_X
&gt; &gt; &gt; 
&gt; &gt; &gt; I feel this is more readable:
&gt; &gt; &gt; #if defined(WTF_USE_ACCELERATED_COMPOSITING) &amp;&amp; defined(HAVE_ECORE_X)
&gt; &gt; 
&gt; &gt; While we&apos;re at it, and I don&apos;t mean to halt the cq+, but shouldn&apos;t the first part be 
&gt; &gt; #if USE(ACCELERATED_COMPOSITING)?
&gt; 
&gt; AFAIK USE() macro is defined only internally to webkit.
&gt; EWebLauncher is not part of webkit itself and so the USE() macro is not defined.

Alright, thanks for checking. Sorry for the noise then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753418</commentid>
    <comment_count>15</comment_count>
      <attachid>171227</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-29 07:25:36 -0700</bug_when>
    <thetext>Comment on attachment 171227
One more time .

To my quick search, USE() is being used in Tools as well. However, I prefer to use USE() in WebKit inside only. cq+ again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753423</commentid>
    <comment_count>16</comment_count>
      <attachid>171227</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-29 07:30:09 -0700</bug_when>
    <thetext>Comment on attachment 171227
One more time .

Clearing flags on attachment: 171227

Committed r132799: &lt;http://trac.webkit.org/changeset/132799&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753424</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-29 07:30:14 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171148</attachid>
            <date>2012-10-28 20:33:44 -0700</date>
            <delta_ts>2012-10-29 05:42:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>100598.patch</filename>
            <type>text/plain</type>
            <size>3596</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv
TWluaUJyb3dzZXIvZWZsL21haW4uYwkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvTWluaUJy
b3dzZXIvZWZsL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtNzc5LDYgKzc3OSwxMiBAQAogCiAg
ICAgaWYgKGV2YXNfZW5naW5lX25hbWUpCiAgICAgICAgIGVsbV9jb25maWdfcHJlZmVycmVkX2Vu
Z2luZV9zZXQoZXZhc19lbmdpbmVfbmFtZSk7CisjaWZkZWYgV1RGX1VTRV9BQ0NFTEVSQVRFRF9D
T01QT1NJVElORyAmJiBkZWZpbmVkIEhBVkVfRUNPUkVfWAorICAgIGVsc2UgeworICAgICAgICBl
dmFzX2VuZ2luZV9uYW1lID0gIm9wZW5nbF94MTEiOworICAgICAgICBlbG1fY29uZmlnX3ByZWZl
cnJlZF9lbmdpbmVfc2V0KGV2YXNfZW5naW5lX25hbWUpOworICAgIH0KKyNlbmRpZgogCiAgICAg
aWYgKGFyZ3MgPCBhcmdjKSB7CiAgICAgICAgIGNoYXIgKnVybCA9IHVybF9mcm9tX3VzZXJfaW5w
dXQoYXJndlthcmdzXSk7CkluZGV4OiBUb29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFRvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMJKHJldmlzaW9uIDEzMjc1MSkKKysrIFRv
b2xzL0VXZWJMYXVuY2hlci9tYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTgwNyw3ICs4MDcsMTYg
QEAKICAgICAgICAgcmV0dXJuIE5VTEw7CiAgICAgfQogCisjaWZkZWYgV1RGX1VTRV9BQ0NFTEVS
QVRFRF9DT01QT1NJVElORyAmJiBkZWZpbmVkIEhBVkVfRUNPUkVfWAorICAgIGlmICh1c2VyQXJn
cy0+ZW5naW5lKQorI2VuZGlmCiAgICAgYXBwLT5lZSA9IGVjb3JlX2V2YXNfbmV3KHVzZXJBcmdz
LT5lbmdpbmUsIDAsIDAsIHVzZXJBcmdzLT5nZW9tZXRyeS53LCB1c2VyQXJncy0+Z2VvbWV0cnku
aCwgTlVMTCk7CisjaWZkZWYgV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORyAmJiBkZWZp
bmVkIEhBVkVfRUNPUkVfWAorICAgIGVsc2UgeworICAgICAgICBjb25zdCBjaGFyKiBlbmdpbmUg
PSAib3BlbmdsX3gxMSI7CisgICAgICAgIGFwcC0+ZWUgPSBlY29yZV9ldmFzX25ldyhlbmdpbmUs
IDAsIDAsIHVzZXJBcmdzLT5nZW9tZXRyeS53LCB1c2VyQXJncy0+Z2VvbWV0cnkuaCwgTlVMTCk7
CisgICAgfQorI2VuZGlmCiAgICAgaWYgKCFhcHAtPmVlKSB7CiAgICAgICAgIHF1aXQoRUlOQV9G
QUxTRSwgIkVSUk9SOiBjb3VsZCBub3QgY29uc3RydWN0IGV2YXMtZWNvcmVcbiIpOwogICAgICAg
ICByZXR1cm4gTlVMTDsKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3Jt
V2ViVmlld0VmbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwv
UGxhdGZvcm1XZWJWaWV3RWZsLmNwcAkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvV2ViS2l0
VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt
MzAsNyArMzAsMTIgQEAKIAogc3RhdGljIEVjb3JlX0V2YXMqIGluaXRFY29yZUV2YXMoKQogewor
I2lmZGVmIFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkcgJiYgZGVmaW5lZCBIQVZFX0VD
T1JFX1gKKyAgICBjb25zdCBjaGFyKiBlbmdpbmUgPSAib3BlbmdsX3gxMSI7CisgICAgRWNvcmVf
RXZhcyogZWNvcmVFdmFzID0gZWNvcmVfZXZhc19uZXcoZW5naW5lLCAwLCAwLCA4MDAsIDYwMCwg
MCk7CisjZWxzZQogICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KDAs
IDAsIDAsIDgwMCwgNjAwLCAwKTsKKyNlbmRpZgogICAgIGlmICghZWNvcmVFdmFzKQogICAgICAg
ICByZXR1cm4gMDsKIApJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJU
cmVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRl
clRyZWUuY3BwCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9lZmwv
RHVtcFJlbmRlclRyZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTksNyArNDE5LDEyIEBACiAK
IHN0YXRpYyBFY29yZV9FdmFzKiBpbml0RWNvcmVFdmFzKCkKIHsKKyNpZmRlZiBXVEZfVVNFX0FD
Q0VMRVJBVEVEX0NPTVBPU0lUSU5HICYmIGRlZmluZWQgSEFWRV9FQ09SRV9YCisgICAgY29uc3Qg
Y2hhciogZW5naW5lID0gIm9wZWxnbF94MTEiOworICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9
IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwgODAwLCA2MDAsIDApOworI2Vsc2UKICAgICBF
Y29yZV9FdmFzKiBlY29yZUV2YXMgPSBlY29yZV9ldmFzX25ldygwLCAwLCAwLCA4MDAsIDYwMCwg
MCk7CisjZW5kaWYKICAgICBpZiAoIWVjb3JlRXZhcykgewogICAgICAgICBzaHV0ZG93bkVmbCgp
OwogICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMC0yOCAgWWFl
bCBBaGFyb24gIDx5YWVsLmFoYXJvbkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bQUNdIEZp
eCBidWdzIHByZXZlbnRpbmcgdXMgZnJvbSBydW5uaW5nIGxheW91dCB0ZXN0cyB3aXRoIEFDIHR1
cm5lZCBvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTAwNTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
TWFrZSBzdXJlIHRvIHVzZSBvcGVuZ2xfeDExIGVuZ2luZSB3aGVuIEFDIGlzIHR1cm5lZCBvbiBh
bmQgWDExIGlzIGluIHVzZS4KKyAgICAgICAgV2UgY2Fubm90IGNyZWF0ZSBhIGdsIGNvbnRleHQg
b3RoZXJ3aXNlLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAg
KGVsbV9tYWluKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZp
ZXdFZmwuY3BwOgorICAgICAgICAoV1RSOjppbml0RWNvcmVFdmFzKToKKyAgICAgICAgKiBEdW1w
UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoaW5pdEVjb3JlRXZh
cyk6CisgICAgICAgICogRVdlYkxhdW5jaGVyL2VmbC9tYWluLmM6CisgICAgICAgICh3aW5kb3dD
cmVhdGUpOgorCiAyMDEyLTEwLTI3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK
ICAgICAgICAgUkVBTF9QTEFURk9STV9OQU1FIGJ1aWxkIHNldHRpbmcgaXMgbm8gbG9uZ2VyIG5l
ZWRlZAo=
</data>
<flag name="review"
          id="184955"
          type_id="1"
          status="+"
          setter="kenneth"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171211</attachid>
            <date>2012-10-29 05:42:38 -0700</date>
            <delta_ts>2012-10-29 06:16:07 -0700</delta_ts>
            <desc>Patch for landing.</desc>
            <filename>100598.patch</filename>
            <type>text/plain</type>
            <size>3729</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRVdl
YkxhdW5jaGVyL21haW4uYwkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvRVdlYkxhdW5jaGVy
L21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtODA3LDcgKzgwNywxNiBAQAogICAgICAgICByZXR1
cm4gTlVMTDsKICAgICB9CiAKLSAgICBhcHAtPmVlID0gZWNvcmVfZXZhc19uZXcodXNlckFyZ3Mt
PmVuZ2luZSwgMCwgMCwgdXNlckFyZ3MtPmdlb21ldHJ5LncsIHVzZXJBcmdzLT5nZW9tZXRyeS5o
LCBOVUxMKTsKKyNpZmRlZiBXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HICYmIGRlZmlu
ZWQgSEFWRV9FQ09SRV9YCisgICAgaWYgKHVzZXJBcmdzLT5lbmdpbmUpCisjZW5kaWYKKyAgICAg
ICAgYXBwLT5lZSA9IGVjb3JlX2V2YXNfbmV3KHVzZXJBcmdzLT5lbmdpbmUsIDAsIDAsIHVzZXJB
cmdzLT5nZW9tZXRyeS53LCB1c2VyQXJncy0+Z2VvbWV0cnkuaCwgTlVMTCk7CisjaWZkZWYgV1RG
X1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORyAmJiBkZWZpbmVkIEhBVkVfRUNPUkVfWAorICAg
IGVsc2UgeworICAgICAgICBjb25zdCBjaGFyKiBlbmdpbmUgPSAib3BlbmdsX3gxMSI7CisgICAg
ICAgIGFwcC0+ZWUgPSBlY29yZV9ldmFzX25ldyhlbmdpbmUsIDAsIDAsIHVzZXJBcmdzLT5nZW9t
ZXRyeS53LCB1c2VyQXJncy0+Z2VvbWV0cnkuaCwgTlVMTCk7CisgICAgfQorI2VuZGlmCiAgICAg
aWYgKCFhcHAtPmVlKSB7CiAgICAgICAgIHF1aXQoRUlOQV9GQUxTRSwgIkVSUk9SOiBjb3VsZCBu
b3QgY29uc3RydWN0IGV2YXMtZWNvcmVcbiIpOwogICAgICAgICByZXR1cm4gTlVMTDsKSW5kZXg6
IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3JtV2ViVmlld0VmbC5jcHAKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNw
cAkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZv
cm1XZWJWaWV3RWZsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsMTEgQEAKIAogc3Rh
dGljIEVjb3JlX0V2YXMqIGluaXRFY29yZUV2YXMoKQogewotICAgIEVjb3JlX0V2YXMqIGVjb3Jl
RXZhcyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIDgwMCwgNjAwLCAwKTsKK2NvbnN0IGNoYXIq
IGVuZ2luZSA9IDA7CisjaWZkZWYgV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORyAmJiBk
ZWZpbmVkIEhBVkVfRUNPUkVfWAorICAgIGVuZ2luZSA9ICJvcGVuZ2xfeDExIjsKKyNlbmRpZgor
ICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwg
ODAwLCA2MDAsIDApOwogICAgIGlmICghZWNvcmVFdmFzKQogICAgICAgICByZXR1cm4gMDsKIApJ
bmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwCShyZXZp
c2lvbiAxMzI3NTEpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTksNyArNDE5LDExIEBACiAKIHN0YXRpYyBFY29yZV9F
dmFzKiBpbml0RWNvcmVFdmFzKCkKIHsKLSAgICBFY29yZV9FdmFzKiBlY29yZUV2YXMgPSBlY29y
ZV9ldmFzX25ldygwLCAwLCAwLCA4MDAsIDYwMCwgMCk7Citjb25zdCBjaGFyKiBlbmdpbmUgPSAw
OworI2lmZGVmIFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkcgJiYgZGVmaW5lZCBIQVZF
X0VDT1JFX1gKKyAgICBlbmdpbmUgPSAib3BlbmdsX3gxMSI7CisjZW5kaWYKKyAgICBFY29yZV9F
dmFzKiBlY29yZUV2YXMgPSBlY29yZV9ldmFzX25ldyhlbmdpbmUsIDAsIDAsIDgwMCwgNjAwLCAw
KTsKICAgICBpZiAoIWVjb3JlRXZhcykgewogICAgICAgICBzaHV0ZG93bkVmbCgpOwogICAgICAg
ICBleGl0KEVYSVRfRkFJTFVSRSk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9DaGFuZ2VMb2cJ
KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMC0yOCAgWWFlbCBBaGFyb24g
IDx5YWVsLmFoYXJvbkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bQUNdIEZpeCBidWdzIHBy
ZXZlbnRpbmcgdXMgZnJvbSBydW5uaW5nIGxheW91dCB0ZXN0cyB3aXRoIEFDIHR1cm5lZCBvbgor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNTk4CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAg
ICAgTWFrZSBzdXJlIHRvIHVzZSBvcGVuZ2xfeDExIGVuZ2luZSB3aGVuIEFDIGlzIHR1cm5lZCBv
biBhbmQgWDExIGlzIGluIHVzZS4KKyAgICAgICAgV2UgY2Fubm90IGNyZWF0ZSBhIGdsIGNvbnRl
eHQgb3RoZXJ3aXNlLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAg
ICAgKGVsbV9tYWluKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdl
YlZpZXdFZmwuY3BwOgorICAgICAgICAoV1RSOjppbml0RWNvcmVFdmFzKToKKyAgICAgICAgKiBE
dW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoaW5pdEVjb3Jl
RXZhcyk6CisgICAgICAgICogRVdlYkxhdW5jaGVyL2VmbC9tYWluLmM6CisgICAgICAgICh3aW5k
b3dDcmVhdGUpOgorCiAyMDEyLTEwLTI3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+
CiAKICAgICAgICAgUkVBTF9QTEFURk9STV9OQU1FIGJ1aWxkIHNldHRpbmcgaXMgbm8gbG9uZ2Vy
IG5lZWRlZApJbmRleDogVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29s
cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCSh3b3JraW5nIGNvcHkpCkBAIC03NzksNiArNzc5LDEy
IEBACiAKICAgICBpZiAoZXZhc19lbmdpbmVfbmFtZSkKICAgICAgICAgZWxtX2NvbmZpZ19wcmVm
ZXJyZWRfZW5naW5lX3NldChldmFzX2VuZ2luZV9uYW1lKTsKKyNpZmRlZiBXVEZfVVNFX0FDQ0VM
RVJBVEVEX0NPTVBPU0lUSU5HICYmIGRlZmluZWQgSEFWRV9FQ09SRV9YCisgICAgZWxzZSB7Cisg
ICAgICAgIGV2YXNfZW5naW5lX25hbWUgPSAib3BlbmdsX3gxMSI7CisgICAgICAgIGVsbV9jb25m
aWdfcHJlZmVycmVkX2VuZ2luZV9zZXQoZXZhc19lbmdpbmVfbmFtZSk7CisgICAgfQorI2VuZGlm
CiAKICAgICBpZiAoYXJncyA8IGFyZ2MpIHsKICAgICAgICAgY2hhciAqdXJsID0gdXJsX2Zyb21f
dXNlcl9pbnB1dChhcmd2W2FyZ3NdKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171219</attachid>
            <date>2012-10-29 06:16:07 -0700</date>
            <delta_ts>2012-10-29 06:29:22 -0700</delta_ts>
            <desc>Patch for landing.</desc>
            <filename>100598.patch</filename>
            <type>text/plain</type>
            <size>3768</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRVdl
YkxhdW5jaGVyL21haW4uYwkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvRVdlYkxhdW5jaGVy
L21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtODA3LDcgKzgwNywxNiBAQAogICAgICAgICByZXR1
cm4gTlVMTDsKICAgICB9CiAKLSAgICBhcHAtPmVlID0gZWNvcmVfZXZhc19uZXcodXNlckFyZ3Mt
PmVuZ2luZSwgMCwgMCwgdXNlckFyZ3MtPmdlb21ldHJ5LncsIHVzZXJBcmdzLT5nZW9tZXRyeS5o
LCBOVUxMKTsKKyNpZiBkZWZpbmVkKFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpICYm
IGRlZmluZWQoSEFWRV9FQ09SRV9YKQorICAgIGlmICh1c2VyQXJncy0+ZW5naW5lKQorI2VuZGlm
CisgICAgICAgIGFwcC0+ZWUgPSBlY29yZV9ldmFzX25ldyh1c2VyQXJncy0+ZW5naW5lLCAwLCAw
LCB1c2VyQXJncy0+Z2VvbWV0cnkudywgdXNlckFyZ3MtPmdlb21ldHJ5LmgsIE5VTEwpOworI2lm
IGRlZmluZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORykgJiYgZGVmaW5lZChIQVZF
X0VDT1JFX1gpCisgICAgZWxzZSB7CisgICAgICAgIGNvbnN0IGNoYXIqIGVuZ2luZSA9ICJvcGVu
Z2xfeDExIjsKKyAgICAgICAgYXBwLT5lZSA9IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwg
dXNlckFyZ3MtPmdlb21ldHJ5LncsIHVzZXJBcmdzLT5nZW9tZXRyeS5oLCBOVUxMKTsKKyAgICB9
CisjZW5kaWYKICAgICBpZiAoIWFwcC0+ZWUpIHsKICAgICAgICAgcXVpdChFSU5BX0ZBTFNFLCAi
RVJST1I6IGNvdWxkIG5vdCBjb25zdHJ1Y3QgZXZhcy1lY29yZVxuIik7CiAgICAgICAgIHJldHVy
biBOVUxMOwpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5n
ZUxvZwkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp
CkBAIC0xLDMgKzEsMjIgQEAKKzIwMTItMTAtMjggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25A
aW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0FDXSBGaXggYnVncyBwcmV2ZW50aW5nIHVzIGZy
b20gcnVubmluZyBsYXlvdXQgdGVzdHMgd2l0aCBBQyB0dXJuZWQgb24KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDU5OAorCisgICAgICAgIFJldmll
d2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAgICAgIE1ha2Ugc3VyZSB0
byB1c2Ugb3BlbmdsX3gxMSBlbmdpbmUgd2hlbiBBQyBpcyB0dXJuZWQgb24gYW5kIFgxMSBpcyBp
biB1c2UuCisgICAgICAgIFdlIGNhbm5vdCBjcmVhdGUgYSBnbCBjb250ZXh0IG90aGVyd2lzZS4K
KworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAgIChlbG1fbWFpbik6
CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcDoK
KyAgICAgICAgKFdUUjo6aW5pdEVjb3JlRXZhcyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUv
ZWZsL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKGluaXRFY29yZUV2YXMpOgorICAgICAg
ICAqIEVXZWJMYXVuY2hlci9lZmwvbWFpbi5jOgorICAgICAgICAod2luZG93Q3JlYXRlKToKKwog
MjAxMi0xMC0yNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJF
QUxfUExBVEZPUk1fTkFNRSBidWlsZCBzZXR0aW5nIGlzIG5vIGxvbmdlciBuZWVkZWQKSW5kZXg6
IFRvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWluaUJy
b3dzZXIvZWZsL21haW4uYwkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvTWluaUJyb3dzZXIv
ZWZsL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtNzc5LDYgKzc3OSwxMiBAQAogCiAgICAgaWYg
KGV2YXNfZW5naW5lX25hbWUpCiAgICAgICAgIGVsbV9jb25maWdfcHJlZmVycmVkX2VuZ2luZV9z
ZXQoZXZhc19lbmdpbmVfbmFtZSk7CisjaWYgZGVmaW5lZChXVEZfVVNFX0FDQ0VMRVJBVEVEX0NP
TVBPU0lUSU5HKSAmJiBkZWZpbmVkKEhBVkVfRUNPUkVfWCkKKyAgICBlbHNlIHsKKyAgICAgICAg
ZXZhc19lbmdpbmVfbmFtZSA9ICJvcGVuZ2xfeDExIjsKKyAgICAgICAgZWxtX2NvbmZpZ19wcmVm
ZXJyZWRfZW5naW5lX3NldChldmFzX2VuZ2luZV9uYW1lKTsKKyAgICB9CisjZW5kaWYKIAogICAg
IGlmIChhcmdzIDwgYXJnYykgewogICAgICAgICBjaGFyICp1cmwgPSB1cmxfZnJvbV91c2VyX2lu
cHV0KGFyZ3ZbYXJnc10pOwpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZv
cm1XZWJWaWV3RWZsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL2Vm
bC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9XZWJL
aXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC0zMCw3ICszMCwxMSBAQAogCiBzdGF0aWMgRWNvcmVfRXZhcyogaW5pdEVjb3JlRXZhcygpCiB7
Ci0gICAgRWNvcmVfRXZhcyogZWNvcmVFdmFzID0gZWNvcmVfZXZhc19uZXcoMCwgMCwgMCwgODAw
LCA2MDAsIDApOworY29uc3QgY2hhciogZW5naW5lID0gMDsKKyNpZiBkZWZpbmVkKFdURl9VU0Vf
QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpICYmIGRlZmluZWQoSEFWRV9FQ09SRV9YKQorICAgIGVu
Z2luZSA9ICJvcGVuZ2xfeDExIjsKKyNlbmRpZgorICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9
IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwgODAwLCA2MDAsIDApOwogICAgIGlmICghZWNv
cmVFdmFzKQogICAgICAgICByZXR1cm4gMDsKIApJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUv
ZWZsL0R1bXBSZW5kZXJUcmVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl
ZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9EdW1w
UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTks
NyArNDE5LDExIEBACiAKIHN0YXRpYyBFY29yZV9FdmFzKiBpbml0RWNvcmVFdmFzKCkKIHsKLSAg
ICBFY29yZV9FdmFzKiBlY29yZUV2YXMgPSBlY29yZV9ldmFzX25ldygwLCAwLCAwLCA4MDAsIDYw
MCwgMCk7CisgICAgY29uc3QgY2hhciogZW5naW5lID0gMDsKKyNpZiBkZWZpbmVkKFdURl9VU0Vf
QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpICYmIGRlZmluZWQoSEFWRV9FQ09SRV9YKQorICAgIGVu
Z2luZSA9ICJvcGVuZ2xfeDExIjsKKyNlbmRpZgorICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9
IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwgODAwLCA2MDAsIDApOwogICAgIGlmICghZWNv
cmVFdmFzKSB7CiAgICAgICAgIHNodXRkb3duRWZsKCk7CiAgICAgICAgIGV4aXQoRVhJVF9GQUlM
VVJFKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171227</attachid>
            <date>2012-10-29 06:29:22 -0700</date>
            <delta_ts>2012-10-29 07:30:09 -0700</delta_ts>
            <desc>One more time .</desc>
            <filename>100598.patch</filename>
            <type>text/plain</type>
            <size>3772</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3JtV2ViVmlld0VmbC5jcHAK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3
RWZsLmNwcAkocmV2aXNpb24gMTMyNzUxKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwv
UGxhdGZvcm1XZWJWaWV3RWZsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsMTEgQEAK
IAogc3RhdGljIEVjb3JlX0V2YXMqIGluaXRFY29yZUV2YXMoKQogewotICAgIEVjb3JlX0V2YXMq
IGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIDgwMCwgNjAwLCAwKTsKKyAgICBj
b25zdCBjaGFyKiBlbmdpbmUgPSAwOworI2lmIGRlZmluZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9D
T01QT1NJVElORykgJiYgZGVmaW5lZChIQVZFX0VDT1JFX1gpCisgICAgZW5naW5lID0gIm9wZW5n
bF94MTEiOworI2VuZGlmCisgICAgRWNvcmVfRXZhcyogZWNvcmVFdmFzID0gZWNvcmVfZXZhc19u
ZXcoZW5naW5lLCAwLCAwLCA4MDAsIDYwMCwgMCk7CiAgICAgaWYgKCFlY29yZUV2YXMpCiAgICAg
ICAgIHJldHVybiAwOwogCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRl
clRyZWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVu
ZGVyVHJlZS5jcHAJKHJldmlzaW9uIDEzMjc1MSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Vm
bC9EdW1wUmVuZGVyVHJlZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxOSw3ICs0MTksMTEgQEAK
IAogc3RhdGljIEVjb3JlX0V2YXMqIGluaXRFY29yZUV2YXMoKQogewotICAgIEVjb3JlX0V2YXMq
IGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIDgwMCwgNjAwLCAwKTsKKyAgICBj
b25zdCBjaGFyKiBlbmdpbmUgPSAwOworI2lmIGRlZmluZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9D
T01QT1NJVElORykgJiYgZGVmaW5lZChIQVZFX0VDT1JFX1gpCisgICAgZW5naW5lID0gIm9wZW5n
bF94MTEiOworI2VuZGlmCisgICAgRWNvcmVfRXZhcyogZWNvcmVFdmFzID0gZWNvcmVfZXZhc19u
ZXcoZW5naW5lLCAwLCAwLCA4MDAsIDYwMCwgMCk7CiAgICAgaWYgKCFlY29yZUV2YXMpIHsKICAg
ICAgICAgc2h1dGRvd25FZmwoKTsKICAgICAgICAgZXhpdChFWElUX0ZBSUxVUkUpOwpJbmRleDog
VG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9FV2ViTGF1bmNo
ZXIvbWFpbi5jCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9FV2ViTGF1bmNoZXIvbWFpbi5j
CSh3b3JraW5nIGNvcHkpCkBAIC04MDcsNyArODA3LDE2IEBACiAgICAgICAgIHJldHVybiBOVUxM
OwogICAgIH0KIAotICAgIGFwcC0+ZWUgPSBlY29yZV9ldmFzX25ldyh1c2VyQXJncy0+ZW5naW5l
LCAwLCAwLCB1c2VyQXJncy0+Z2VvbWV0cnkudywgdXNlckFyZ3MtPmdlb21ldHJ5LmgsIE5VTEwp
OworI2lmIGRlZmluZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORykgJiYgZGVmaW5l
ZChIQVZFX0VDT1JFX1gpCisgICAgaWYgKHVzZXJBcmdzLT5lbmdpbmUpCisjZW5kaWYKKyAgICAg
ICAgYXBwLT5lZSA9IGVjb3JlX2V2YXNfbmV3KHVzZXJBcmdzLT5lbmdpbmUsIDAsIDAsIHVzZXJB
cmdzLT5nZW9tZXRyeS53LCB1c2VyQXJncy0+Z2VvbWV0cnkuaCwgTlVMTCk7CisjaWYgZGVmaW5l
ZChXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKSAmJiBkZWZpbmVkKEhBVkVfRUNPUkVf
WCkKKyAgICBlbHNlIHsKKyAgICAgICAgY29uc3QgY2hhciogZW5naW5lID0gIm9wZW5nbF94MTEi
OworICAgICAgICBhcHAtPmVlID0gZWNvcmVfZXZhc19uZXcoZW5naW5lLCAwLCAwLCB1c2VyQXJn
cy0+Z2VvbWV0cnkudywgdXNlckFyZ3MtPmdlb21ldHJ5LmgsIE5VTEwpOworICAgIH0KKyNlbmRp
ZgogICAgIGlmICghYXBwLT5lZSkgewogICAgICAgICBxdWl0KEVJTkFfRkFMU0UsICJFUlJPUjog
Y291bGQgbm90IGNvbnN0cnVjdCBldmFzLWVjb3JlXG4iKTsKICAgICAgICAgcmV0dXJuIE5VTEw7
CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShy
ZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs
MyArMSwyMiBAQAorMjAxMi0xMC0yOCAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBpbnRlbC5j
b20+CisKKyAgICAgICAgW0VGTF1bQUNdIEZpeCBidWdzIHByZXZlbnRpbmcgdXMgZnJvbSBydW5u
aW5nIGxheW91dCB0ZXN0cyB3aXRoIEFDIHR1cm5lZCBvbgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgTWFrZSBzdXJlIHRvIHVzZSBv
cGVuZ2xfeDExIGVuZ2luZSB3aGVuIEFDIGlzIHR1cm5lZCBvbiBhbmQgWDExIGlzIGluIHVzZS4K
KyAgICAgICAgV2UgY2Fubm90IGNyZWF0ZSBhIGdsIGNvbnRleHQgb3RoZXJ3aXNlLgorCisgICAg
ICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKGVsbV9tYWluKToKKyAgICAg
ICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwOgorICAgICAg
ICAoV1RSOjppbml0RWNvcmVFdmFzKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVt
cFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoaW5pdEVjb3JlRXZhcyk6CisgICAgICAgICogRVdl
YkxhdW5jaGVyL2VmbC9tYWluLmM6CisgICAgICAgICh3aW5kb3dDcmVhdGUpOgorCiAyMDEyLTEw
LTI3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVBTF9QTEFU
Rk9STV9OQU1FIGJ1aWxkIHNldHRpbmcgaXMgbm8gbG9uZ2VyIG5lZWRlZApJbmRleDogVG9vbHMv
TWluaUJyb3dzZXIvZWZsL21haW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9l
ZmwvbWFpbi5jCShyZXZpc2lvbiAxMzI3NTEpCisrKyBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFp
bi5jCSh3b3JraW5nIGNvcHkpCkBAIC03NzksNiArNzc5LDEyIEBACiAKICAgICBpZiAoZXZhc19l
bmdpbmVfbmFtZSkKICAgICAgICAgZWxtX2NvbmZpZ19wcmVmZXJyZWRfZW5naW5lX3NldChldmFz
X2VuZ2luZV9uYW1lKTsKKyNpZiBkZWZpbmVkKFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJ
TkcpICYmIGRlZmluZWQoSEFWRV9FQ09SRV9YKQorICAgIGVsc2UgeworICAgICAgICBldmFzX2Vu
Z2luZV9uYW1lID0gIm9wZW5nbF94MTEiOworICAgICAgICBlbG1fY29uZmlnX3ByZWZlcnJlZF9l
bmdpbmVfc2V0KGV2YXNfZW5naW5lX25hbWUpOworICAgIH0KKyNlbmRpZgogCiAgICAgaWYgKGFy
Z3MgPCBhcmdjKSB7CiAgICAgICAgIGNoYXIgKnVybCA9IHVybF9mcm9tX3VzZXJfaW5wdXQoYXJn
dlthcmdzXSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>