100589 2012-10-27 05:06:44 -0700 ASSERT problem on MIPS 2012-11-08 14:21:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 kilvadyb webkit-unassigned fu gergely oliver palfia webkit.review.bot oldest_to_newest 752750 0 kilvadyb 2012-10-27 05:06:44 -0700 There is an ASSERT(!value); line at Source/JavaScriptCore/jit/JITOpcodes.cpp:1627 which works on most of the platforms but fails on MIPS as value == regT0 and regT0 is not the first register (int(regT0) != 0) on MIPS. 752753 1 171088 kilvadyb 2012-10-27 05:22:39 -0700 Created attachment 171088 ASSERT fix. As value variable is const (const RegisterID value = regT0;) after quick look I would remove the ASSERT line but anyway I created a patch to make it work on MIPS in debug mode. Feel free to throw it out :) 762061 2 173095 kilvadyb 2012-11-08 12:32:01 -0800 Created attachment 173095 ASSERT fix. 762068 3 173095 oliver 2012-11-08 12:35:46 -0800 Comment on attachment 173095 ASSERT fix. View in context: https://bugs.webkit.org/attachment.cgi?id=173095&action=review > Source/JavaScriptCore/jit/JITOpcodes.cpp:1631 > ASSERT(!value); Can't this just be ASSERT(value == regT0) ? 762082 4 173099 kilvadyb 2012-11-08 12:48:14 -0800 Created attachment 173099 ASSERT fix. Simple fix :) 762086 5 kilvadyb 2012-11-08 12:53:00 -0800 (In reply to comment #3) > (From update of attachment 173095 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173095&action=review > > > Source/JavaScriptCore/jit/JITOpcodes.cpp:1631 > > ASSERT(!value); > > Can't this just be ASSERT(value == regT0) ? Yes, works, new patch added. Is this ASSERT useful for a const variable? Assembly code could hurt it? 762122 6 173099 oliver 2012-11-08 13:32:39 -0800 Comment on attachment 173099 ASSERT fix. The assertion is intended to prevent anyone from trying to use a different register for value, as the profiling logic in the baseline jit always assumes regT0 contains the value and t1 the tag (if appropriate) 762166 7 173099 webkit.review.bot 2012-11-08 14:21:01 -0800 Comment on attachment 173099 ASSERT fix. Clearing flags on attachment: 173099 Committed r133950: <http://trac.webkit.org/changeset/133950> 762167 8 webkit.review.bot 2012-11-08 14:21:04 -0800 All reviewed patches have been landed. Closing bug. 171088 2012-10-27 05:22:39 -0700 2012-11-08 12:32:01 -0800 ASSERT fix. assert.diff text/plain 1326 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNiMjE3ZmIuLjhmYzBjOTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTI3ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgTUlQUzogQVNTRVJUIGZpeC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDU4OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFTU0VSVCBm aXggZm9yIE1JUFMgYXJjaC4KKworICAgICAgICAqIGppdC9KSVRPcGNvZGVzLmNwcDoKKyAgICAg ICAgKEpTQzo6SklUOjplbWl0X3Jlc29sdmVfb3BlcmF0aW9ucyk6CisKIDIwMTItMTAtMjUgIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBGb3J3YXJkIE9TUiBjYWxj dWxhdGlvbiBpcyB3cm9uZyBpbiB0aGUgcHJlc2VuY2Ugb2YgbXVsdGlwbGUgU2V0TG9jYWxzLCBv ciBhIG1peCBvZiBTZXRMb2NhbHMgYW5kIFBoYW50b21zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRPcGNvZGVzLmNwcAppbmRleCAwN2M4YWNlLi5kZTgzODhiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUT3Bjb2Rlcy5jcHAKQEAgLTE2MjQsNyArMTYyNCwxMSBAQCB2b2lkIEpJ VDo6ZW1pdF9yZXNvbHZlX29wZXJhdGlvbnMoUmVzb2x2ZU9wZXJhdGlvbnMqIHJlc29sdmVPcGVy YXRpb25zLCBjb25zdCBpbgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgUmVzb2x2 ZU9wZXJhdGlvbjo6UmV0dXJuU2NvcGVBc0Jhc2U6CiAgICAgICAgICAgICBlbWl0U3RvcmVDZWxs KCpiYXNlVlIsIHNjb3BlKTsKKyNpZiBDUFUoTUlQUykKKyAgICAgICAgICAgIEFTU0VSVCh2YWx1 ZSA9PSBNSVBTUmVnaXN0ZXJzOjpyMik7CisjZWxzZQogICAgICAgICAgICAgQVNTRVJUKCF2YWx1 ZSk7CisjZW5kaWYKICAgICAgICAgICAgIG1vdmUoc2NvcGUsIHZhbHVlKTsKICNpZiBVU0UoSlNW QUxVRTMyXzY0KQogICAgICAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6Q2VsbFRh ZyksIHZhbHVlVGFnKTsK 173095 2012-11-08 12:32:01 -0800 2012-11-08 12:48:14 -0800 ASSERT fix. assert.diff text/plain 1315 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQ4ZDY2NDcuLmIxMzRkN2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTA4ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgQVNTRVJUIHByb2JsZW0gb24g TUlQUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVNT RVJUIGZpeCBmb3IgTUlQUyBhcmNoLgorCisgICAgICAgICogaml0L0pJVE9wY29kZXMuY3BwOgor ICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfcmVzb2x2ZV9vcGVyYXRpb25zKToKKwogMjAxMi0xMS0w OCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBPcGFxdWVK U0NsYXNzQ29udGV4dERhdGEoKSBzaG91bGQgdXNlIFN0cmluZ0ltcGw6Omlzb2xhdGVkQ29weSgp IHRvIG1ha2Ugc3RyaW5nIGNvcGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRPcGNvZGVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rl cy5jcHAKaW5kZXggMjQ5ZGNiYS4uZTMyM2YzOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVE9wY29kZXMuY3BwCkBAIC0xNjI1LDcgKzE2MjUsMTEgQEAgdm9pZCBKSVQ6OmVtaXRfcmVz b2x2ZV9vcGVyYXRpb25zKFJlc29sdmVPcGVyYXRpb25zKiByZXNvbHZlT3BlcmF0aW9ucywgY29u c3QgaW4KICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFJlc29sdmVPcGVyYXRpb246 OlJldHVyblNjb3BlQXNCYXNlOgogICAgICAgICAgICAgZW1pdFN0b3JlQ2VsbCgqYmFzZVZSLCBz Y29wZSk7CisjaWYgQ1BVKE1JUFMpCisgICAgICAgICAgICBBU1NFUlQodmFsdWUgPT0gTUlQU1Jl Z2lzdGVyczo6cjIpOworI2Vsc2UKICAgICAgICAgICAgIEFTU0VSVCghdmFsdWUpOworI2VuZGlm CiAgICAgICAgICAgICBtb3ZlKHNjb3BlLCB2YWx1ZSk7CiAjaWYgVVNFKEpTVkFMVUUzMl82NCkK ICAgICAgICAgICAgIG1vdmUoVHJ1c3RlZEltbTMyKEpTVmFsdWU6OkNlbGxUYWcpLCB2YWx1ZVRh Zyk7Cg== 173099 2012-11-08 12:48:14 -0800 2012-11-08 14:21:00 -0800 ASSERT fix. assert.diff text/plain 1272 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQ4ZDY2NDcuLmIxMzRkN2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTA4ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgQVNTRVJUIHByb2JsZW0gb24g TUlQUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVNT RVJUIGZpeCBmb3IgTUlQUyBhcmNoLgorCisgICAgICAgICogaml0L0pJVE9wY29kZXMuY3BwOgor ICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfcmVzb2x2ZV9vcGVyYXRpb25zKToKKwogMjAxMi0xMS0w OCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBPcGFxdWVK U0NsYXNzQ29udGV4dERhdGEoKSBzaG91bGQgdXNlIFN0cmluZ0ltcGw6Omlzb2xhdGVkQ29weSgp IHRvIG1ha2Ugc3RyaW5nIGNvcGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRPcGNvZGVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rl cy5jcHAKaW5kZXggMjQ5ZGNiYS4uNGZiOWQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVE9wY29kZXMuY3BwCkBAIC0xNjI1LDcgKzE2MjUsNyBAQCB2b2lkIEpJVDo6ZW1pdF9yZXNv bHZlX29wZXJhdGlvbnMoUmVzb2x2ZU9wZXJhdGlvbnMqIHJlc29sdmVPcGVyYXRpb25zLCBjb25z dCBpbgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgUmVzb2x2ZU9wZXJhdGlvbjo6 UmV0dXJuU2NvcGVBc0Jhc2U6CiAgICAgICAgICAgICBlbWl0U3RvcmVDZWxsKCpiYXNlVlIsIHNj b3BlKTsKLSAgICAgICAgICAgIEFTU0VSVCghdmFsdWUpOworICAgICAgICAgICAgQVNTRVJUKHZh bHVlID09IHJlZ1QwKTsKICAgICAgICAgICAgIG1vdmUoc2NvcGUsIHZhbHVlKTsKICNpZiBVU0Uo SlNWQUxVRTMyXzY0KQogICAgICAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6Q2Vs bFRhZyksIHZhbHVlVGFnKTsK