100585 2012-10-26 19:08:48 -0700 [BlackBerry] Browser prematurely sends wrong credentials 2012-11-01 06:47:44 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 charles.wei charles.wei joenotcharles mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 752653 0 charles.wei 2012-10-26 19:08:48 -0700 Internal tracking Number: 232027 Patch for bug 96362 (https://bugs.webkit.org/show_bug.cgi?id=96362) tried to address the problem that when the browser restarts, the user will be prompted for authentication again which has already been authenticated in the last browser session. The patch did it the wrong way: for each request to the server, even a new request that never been sent to the server and thus never been challenged by the server yet, it tries to get the credential from the persistent credential store and sends the credential to the server. This is not only error-prone, but also downgrades the performance. 1. It tries to get the credential from the persistent credential storage using only the URL, which is wrong. One URL might have multiple credentials, one for each realm. it's very possible that it will get the wrong credential just using URL. 2. It queries the persistent credential storage prematurely for each request, even though 99% requests won't be challenged at all. This is time consuming and downgrades the performance., The right solution to the problem described by bug 96362 has been resolved with bug : 100448 (https://bugs.webkit.org/show_bug.cgi?id=100448), which only queries persistent credential storage using the right information (URL, realm, etc.)only when challenged. Patch for 96362 should be reverted, but since so much has been changed since that patch, and a sheriffbot automated auto-revert failed. I come up with this bug and patch for manually revert. 752657 1 171071 charles.wei 2012-10-26 19:13:38 -0700 Created attachment 171071 Patch 752660 2 171071 charles.wei 2012-10-26 19:32:32 -0700 Comment on attachment 171071 Patch This patch is already internally reviewed by Joe Mason. Need an upstream reviewer to approve it. 752677 3 171071 charles.wei 2012-10-26 21:34:33 -0700 Comment on attachment 171071 Patch commit. 752693 4 171071 webkit.review.bot 2012-10-26 23:01:00 -0700 Comment on attachment 171071 Patch Clearing flags on attachment: 171071 Committed r132722: <http://trac.webkit.org/changeset/132722> 752694 5 webkit.review.bot 2012-10-26 23:01:04 -0700 All reviewed patches have been landed. Closing bug. 755846 6 charles.wei 2012-10-31 21:09:31 -0700 Except the patch above, which only prevents the browser from sending the credentials from persistent credential storage, we should also prevent the browser from sending the in-memory credentials before been challenged. Because sending credentials before been challenged is not only a security concern, but also error-prone because the server might support multiple schemes, we should always use the scheme that has highest security instead of the BASIC; Also it's very possible it's redundant to send the credentials, because most of the servers will remember the client by cookies, the client can just send the request with the right cookies, and the server won't challenge the client at all. 755847 7 171765 charles.wei 2012-10-31 21:11:25 -0700 Created attachment 171765 Patch 755855 8 171765 joenotcharles 2012-10-31 21:31:53 -0700 Comment on attachment 171765 Patch lgtm 756166 9 171765 charles.wei 2012-11-01 06:42:21 -0700 Comment on attachment 171765 Patch commit. 756172 10 171765 webkit.review.bot 2012-11-01 06:47:40 -0700 Comment on attachment 171765 Patch Clearing flags on attachment: 171765 Committed r133156: <http://trac.webkit.org/changeset/133156> 756173 11 webkit.review.bot 2012-11-01 06:47:44 -0700 All reviewed patches have been landed. Closing bug. 171071 2012-10-26 19:13:38 -0700 2012-10-31 21:11:18 -0700 Patch bug-100585-20121027101207.patch text/plain 5844 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JkMzc4YTYwYjIyZjE0 Yzg3NDE0OTkwY2JhMzRlNDNjZDYxM2U4Zi4uNzgyNDNmYTc1ZDE1Y2U0NjQ2MmIzZjEzN2IwZGM2 OTNmMDcyZjBkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTI2ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gQnJvd3NlciBwcmVtYXR1cmVseSBzZW5kcyB3cm9uZyBjcmVkZW50aWFscworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNTg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFudWFsbHkgcmV2 ZXJ0IHRoZSBwYXRjaCBmb3IgYnVnIDk2MzYyLCB3aGljaCBjYXVzZXMgcmVncmVzc2lvbnMgYW5k IHRoZSByaWdodCBwYXRjaCBoYXMgYmVlbgorICAgICAgICBzdWJtaXR0ZWQgd2l0aCBwYXRjaCBm b3IgYnVnIDEwMDQ0OC4gU2luY2UgdGhlIGF1dG8tcmV2ZXJ0IGZhaWxzLCB3ZSB1c2UgdGhpcyBw YXRjaCB0byBtYW51YWxseQorICAgICAgICByZXZlcnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiBUaGUgdGVzdCBpcyBjb3ZlcnRlZCBieSBwYXRjaCBmb3IgMTAwNDQ4LgorCisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L0NyZWRlbnRpYWxCYWNraW5nU3RvcmUuY3BwOgor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9DcmVkZW50aWFsQmFja2luZ1N0 b3JlLmg6CisgICAgICAgIChDcmVkZW50aWFsQmFja2luZ1N0b3JlKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TmV0d29ya01hbmFnZXI6OnN0YXJ0Sm9iKToKKwogMjAxMi0xMC0yNiAgRGFuaWVsIENo ZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KIAogICAgICAgICBkcmFnb3ZlcidzIGRlZmF1bHQg YWN0aW9uIHNob3VsZCBwcmV2ZW50IGRyb3AgZm9yIGZpbGUgZHJhZ3MKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9DcmVkZW50aWFsQmFja2lu Z1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9D cmVkZW50aWFsQmFja2luZ1N0b3JlLmNwcAppbmRleCBiMDhhODQxMTAzYjI5MDFjZDRmZGMwNWE1 NmU4ZmUzY2ViZTI2MWUxLi4wZDNlYzY5ZTkxNzMwNTY4YmQwOGM2MTExYTRmOWZmYTc0MmRjYTZk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkv Q3JlZGVudGlhbEJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9ibGFja2JlcnJ5L0NyZWRlbnRpYWxCYWNraW5nU3RvcmUuY3BwCkBAIC0yNTMsMzIg KzI1Myw2IEBAIGJvb2wgQ3JlZGVudGlhbEJhY2tpbmdTdG9yZTo6aGFzTG9naW4oY29uc3QgS1VS TCYgdXJsLCBjb25zdCBQcm90ZWN0aW9uU3BhY2UmIHByCiAgICAgcmV0dXJuIGZhbHNlOwogfQog Ci1Qcm90ZWN0aW9uU3BhY2UgQ3JlZGVudGlhbEJhY2tpbmdTdG9yZTo6Z2V0UHJvdGVjdGlvblNw YWNlKGNvbnN0IEtVUkwmIHVybCkKLXsKLSAgICBBU1NFUlQobV9kYXRhYmFzZS5pc09wZW4oKSk7 Ci0gICAgQVNTRVJUKG1fZGF0YWJhc2UudGFibGVFeGlzdHMoImxvZ2lucyIpKTsKLQotICAgIGlm ICghbV9nZXRMb2dpbkJ5VVJMU3RhdGVtZW50KQotICAgICAgICByZXR1cm4gUHJvdGVjdGlvblNw YWNlKCk7Ci0KLSAgICBtX2dldExvZ2luQnlVUkxTdGF0ZW1lbnQtPmJpbmRUZXh0KDEsIHVybC5z dHJpbmcoKSk7Ci0KLSAgICBpbnQgcmVzdWx0ID0gbV9nZXRMb2dpbkJ5VVJMU3RhdGVtZW50LT5z dGVwKCk7Ci0gICAgU3RyaW5nIHVzZXJuYW1lID0gbV9nZXRMb2dpbkJ5VVJMU3RhdGVtZW50LT5n ZXRDb2x1bW5UZXh0KDApOwotICAgIFN0cmluZyBwYXNzd29yZCA9IGNlcnRNZ3JXcmFwcGVyKCkt PmlzUmVhZHkoKSA/ICIiIDogbV9nZXRMb2dpbkJ5VVJMU3RhdGVtZW50LT5nZXRDb2x1bW5CbG9i QXNTdHJpbmcoMSk7Ci0gICAgU3RyaW5nIGhvc3QgPSBtX2dldExvZ2luQnlVUkxTdGF0ZW1lbnQt PmdldENvbHVtblRleHQoMik7Ci0gICAgaW50IHBvcnQgPSBtX2dldExvZ2luQnlVUkxTdGF0ZW1l bnQtPmdldENvbHVtbkludCgzKTsKLSAgICBpbnQgc2VydmljZVR5cGUgPSBtX2dldExvZ2luQnlV UkxTdGF0ZW1lbnQtPmdldENvbHVtbkludCg0KTsKLSAgICBTdHJpbmcgcmVhbG0gPSBtX2dldExv Z2luQnlVUkxTdGF0ZW1lbnQtPmdldENvbHVtblRleHQoNSk7Ci0gICAgaW50IGF1dGhlbnRpY2F0 aW9uU2NoZW1lID0gbV9nZXRMb2dpbkJ5VVJMU3RhdGVtZW50LT5nZXRDb2x1bW5JbnQoNik7Ci0g ICAgbV9nZXRMb2dpbkJ5VVJMU3RhdGVtZW50LT5yZXNldCgpOwotICAgIEhBTkRMRV9TUUxfRVhF Q19GQUlMVVJFKHJlc3VsdCAhPSBTUUxSZXN1bHRSb3csIFByb3RlY3Rpb25TcGFjZSgpLAotICAg ICAgICAiRmFpbGVkIHRvIGV4ZWN1dGUgc2VsZWN0IGxvZ2luIGluZm8gZnJvbSB0YWJsZSBsb2dp bnMgaW4gZ2V0TG9naW5CeVVSTCAtICVpIiwgcmVzdWx0KTsKLQotICAgIHJldHVybiBQcm90ZWN0 aW9uU3BhY2UgKGhvc3QsIHBvcnQsIHN0YXRpY19jYXN0PFByb3RlY3Rpb25TcGFjZVNlcnZlclR5 cGU+KHNlcnZpY2VUeXBlKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWFsbSwgc3Rh dGljX2Nhc3Q8UHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWU+KGF1dGhlbnRpY2F0 aW9uU2NoZW1lKSk7Ci19Ci0KIENyZWRlbnRpYWwgQ3JlZGVudGlhbEJhY2tpbmdTdG9yZTo6Z2V0 TG9naW4oY29uc3QgUHJvdGVjdGlvblNwYWNlJiBwcm90ZWN0aW9uU3BhY2UpCiB7CiAgICAgQVNT RVJUKG1fZGF0YWJhc2UuaXNPcGVuKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L0NyZWRlbnRpYWxCYWNraW5nU3RvcmUuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9DcmVkZW50aWFsQmFja2luZ1N0 b3JlLmgKaW5kZXggY2M1MzkyNDgwNjlhNDVlOTg4NDYwYTgwYzliYjU5MmU3Yzk5OTJkYS4uNDcx YTA2OTcxNzI3MDY5YWIwY2ZhZDY4YzJhOWNjY2ZkYTA0ODA5ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L0NyZWRlbnRpYWxCYWNraW5nU3Rv cmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvQ3Jl ZGVudGlhbEJhY2tpbmdTdG9yZS5oCkBAIC00NCw3ICs0NCw2IEBAIHB1YmxpYzoKICAgICBib29s IGFkZExvZ2luKGNvbnN0IEtVUkwmLCBjb25zdCBQcm90ZWN0aW9uU3BhY2UmLCBjb25zdCBDcmVk ZW50aWFsJik7CiAgICAgYm9vbCB1cGRhdGVMb2dpbihjb25zdCBLVVJMJiwgY29uc3QgUHJvdGVj dGlvblNwYWNlJiwgY29uc3QgQ3JlZGVudGlhbCYpOwogICAgIGJvb2wgaGFzTG9naW4oY29uc3Qg S1VSTCYsIGNvbnN0IFByb3RlY3Rpb25TcGFjZSYpOwotICAgIFByb3RlY3Rpb25TcGFjZSBnZXRQ cm90ZWN0aW9uU3BhY2UoY29uc3QgS1VSTCYpOwogICAgIENyZWRlbnRpYWwgZ2V0TG9naW4oY29u c3QgUHJvdGVjdGlvblNwYWNlJik7CiAgICAgQ3JlZGVudGlhbCBnZXRMb2dpbihjb25zdCBLVVJM Jik7CiAgICAgYm9vbCByZW1vdmVMb2dpbihjb25zdCBLVVJMJiwgY29uc3QgUHJvdGVjdGlvblNw YWNlJik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya01hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2VyLmNwcAppbmRleCAxZjFlYzk5MTk4NTY4OTExM2U3 YzVkMzM5YzYzYjczMjY1ZDlkYTgwLi42MGEyMDIzZWQyNDI1NDM4YjQ2ZjZjNjQwNDZiY2JkZDc2 YjI4MGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya01hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5jcHAKQEAgLTIwLDE3ICsyMCwxMSBAQAog I2luY2x1ZGUgIk5ldHdvcmtNYW5hZ2VyLmgiCiAKICNpbmNsdWRlICJDaHJvbWUuaCIKLSNpZiBF TkFCTEUoQkxBQ0tCRVJSWV9DUkVERU5USUFMX1BFUlNJU1QpCi0jaW5jbHVkZSAiQ3JlZGVudGlh bEJhY2tpbmdTdG9yZS5oIgotI2VuZGlmCiAjaW5jbHVkZSAiQ3JlZGVudGlhbFN0b3JhZ2UuaCIK ICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJy eS5oIgogI2luY2x1ZGUgIk5ldHdvcmtKb2IuaCIKICNpbmNsdWRlICJQYWdlLmgiCi0jaWYgRU5B QkxFKEJMQUNLQkVSUllfQ1JFREVOVElBTF9QRVJTSVNUKQotI2luY2x1ZGUgIlJlc291cmNlSGFu ZGxlQ2xpZW50LmgiCi0jZW5kaWYKICNpbmNsdWRlICJSZXNvdXJjZUhhbmRsZUludGVybmFsLmgi CiAjaW5jbHVkZSAiUmVzb3VyY2VSZXF1ZXN0LmgiCiAjaW5jbHVkZSAiU2VjdXJpdHlPcmlnaW4u aCIKQEAgLTEyNCwxNCArMTE4LDYgQEAgYm9vbCBOZXR3b3JrTWFuYWdlcjo6c3RhcnRKb2IoaW50 IHBsYXllcklkLCBjb25zdCBTdHJpbmcmIHBhZ2VHcm91cE5hbWUsIFBhc3NSZWYKICAgICAgICAg Ly8gRm9yIFVSTHMgdGhhdCBtYXRjaCB0aGUgcGF0aHMgb2YgdGhvc2UgcHJldmlvdXNseSBjaGFs bGVuZ2VkIGZvciBIVFRQIEJhc2ljIGF1dGhlbnRpY2F0aW9uLAogICAgICAgICAvLyB0cnkgYW5k IHJldXNlIHRoZSBjcmVkZW50aWFsIHByZWVtcHRpdmVseSwgYXMgYWxsb3dlZCBieSBSRkMgMjYx Ny4KICAgICAgICAgQ3JlZGVudGlhbCBjcmVkZW50aWFsID0gQ3JlZGVudGlhbFN0b3JhZ2U6Omdl dCh1cmwpOwotI2lmIEVOQUJMRShCTEFDS0JFUlJZX0NSRURFTlRJQUxfUEVSU0lTVCkKLSAgICAg ICAgLy8gRklYTUU6IG5lZWRzIHRvIHJlZmFjdG9yIHRoZSBjcmVkZW50aWFsQmFja2luZ1N0b3Jl IHRvIGdldCBjcmVkZW50aWFsIGFuZCBwcm90ZWN0aW9uIHNwYWNlIGF0IG9uZSB0aW1lLgotICAg ICAgICBpZiAoY3JlZGVudGlhbC5pc0VtcHR5KCkgJiYgZ3VhcmRKb2ItPmNsaWVudCgpLT5zaG91 bGRVc2VDcmVkZW50aWFsU3RvcmFnZShndWFyZEpvYi5nZXQoKSkpIHsKLSAgICAgICAgICAgIGNy ZWRlbnRpYWwgPSBjcmVkZW50aWFsQmFja2luZ1N0b3JlKCkuZ2V0TG9naW4odXJsKTsKLSAgICAg ICAgICAgIGlmICghY3JlZGVudGlhbC5pc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgQ3JlZGVu dGlhbFN0b3JhZ2U6OnNldChjcmVkZW50aWFsLCBjcmVkZW50aWFsQmFja2luZ1N0b3JlKCkuZ2V0 UHJvdGVjdGlvblNwYWNlKHVybCksIHVybCk7Ci0gICAgICAgIH0KLSNlbmRpZgogICAgICAgICBp ZiAoIWNyZWRlbnRpYWwuaXNFbXB0eSgpKQogICAgICAgICAgICAgcGxhdGZvcm1SZXF1ZXN0LnNl dENyZWRlbnRpYWxzKGNyZWRlbnRpYWwudXNlcigpLnV0ZjgoKS5kYXRhKCksIGNyZWRlbnRpYWwu cGFzc3dvcmQoKS51dGY4KCkuZGF0YSgpLCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TmV0d29ya1Jl cXVlc3Q6OkF1dGhIVFRQQmFzaWMpOwogICAgIH0K 171765 2012-10-31 21:11:25 -0700 2012-11-01 06:47:40 -0700 Patch bug-100585-20121101120945.patch text/plain 1986 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJiNzUxNTM4ODQ1ZTA4 ODcxNmEyNzBiMzE0Y2QyMTA0N2E5MTM5ZC4uOGJhZWNhN2U0NjQ5NzIyYTg1NDczOGYwMjVmODMw NDBjZDg3MWUzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTMxICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gQnJvd3NlciBwcmVtYXR1cmVseSBzZW5kcyB3cm9uZyBjcmVkZW50aWFscworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNTg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qgc2VuZCBj cmVkZW50aWFscyB0byB0aGUgc2VydmVyIGJlZm9yZSBiZWVuIGNoYWxsZW5nZWQuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TmV0d29ya01hbmFnZXI6OnN0YXJ0Sm9iKToKKwogMjAxMi0xMC0zMSAg Q2hyaXMgRXZhbnMgIDxjZXZhbnNAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZW5kZXJBcmVuYSBo YXMgYSBtZW1vcnkgbGVhayBhbmQgcG9vciBlZmZpY2llbmN5CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2Vy LmNwcAppbmRleCA2MGEyMDIzZWQyNDI1NDM4YjQ2ZjZjNjQwNDZiY2JkZDc2YjI4MGIwLi4xOGJj MWU3NTE3MzVjZGJhODI2ZTUzNzU2MTBkNGY2NGM0NjY3ZmIyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFu YWdlci5jcHAKQEAgLTExNCwxMiArMTE0LDYgQEAgYm9vbCBOZXR3b3JrTWFuYWdlcjo6c3RhcnRK b2IoaW50IHBsYXllcklkLCBjb25zdCBTdHJpbmcmIHBhZ2VHcm91cE5hbWUsIFBhc3NSZWYKIAog ICAgICAgICBpZiAoYXV0aFR5cGUgIT0gQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdvcmtSZXF1 ZXN0OjpBdXRoTm9uZSkKICAgICAgICAgICAgIHBsYXRmb3JtUmVxdWVzdC5zZXRDcmVkZW50aWFs cyh1c2VybmFtZS51dGY4KCkuZGF0YSgpLCBwYXNzd29yZC51dGY4KCkuZGF0YSgpLCBhdXRoVHlw ZSk7Ci0gICAgfSBlbHNlIGlmICh1cmwucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKSB7Ci0gICAg ICAgIC8vIEZvciBVUkxzIHRoYXQgbWF0Y2ggdGhlIHBhdGhzIG9mIHRob3NlIHByZXZpb3VzbHkg Y2hhbGxlbmdlZCBmb3IgSFRUUCBCYXNpYyBhdXRoZW50aWNhdGlvbiwKLSAgICAgICAgLy8gdHJ5 IGFuZCByZXVzZSB0aGUgY3JlZGVudGlhbCBwcmVlbXB0aXZlbHksIGFzIGFsbG93ZWQgYnkgUkZD IDI2MTcuCi0gICAgICAgIENyZWRlbnRpYWwgY3JlZGVudGlhbCA9IENyZWRlbnRpYWxTdG9yYWdl OjpnZXQodXJsKTsKLSAgICAgICAgaWYgKCFjcmVkZW50aWFsLmlzRW1wdHkoKSkKLSAgICAgICAg ICAgIHBsYXRmb3JtUmVxdWVzdC5zZXRDcmVkZW50aWFscyhjcmVkZW50aWFsLnVzZXIoKS51dGY4 KCkuZGF0YSgpLCBjcmVkZW50aWFsLnBhc3N3b3JkKCkudXRmOCgpLmRhdGEoKSwgQmxhY2tCZXJy eTo6UGxhdGZvcm06Ok5ldHdvcmtSZXF1ZXN0OjpBdXRoSFRUUEJhc2ljKTsKICAgICB9CiAKICAg ICBpZiAoIXJlcXVlc3Qub3ZlcnJpZGVDb250ZW50VHlwZSgpLmlzRW1wdHkoKSkK