100583 2012-10-26 18:02:31 -0700 AX: file upload input text value is not exposed through accessibility 2012-11-13 12:30:48 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach apinheiro bdakin dmazzoni jdiggs webkit.review.bot oldest_to_newest 752627 0 cfleizach 2012-10-26 18:02:31 -0700 The value of the file upload button is not exposed on the Mac. This is a tough problem to solve on the Mac because there are three pieces of information. 1) the type of button, 2) the text on the button, 3) the text for the value The best compromise we think is to label this as a file upload button type in the role description, and then expose the file path text as the AXTitle. This will give the more relevant information and should be clear what is happening 752628 1 171065 cfleizach 2012-10-26 18:07:12 -0700 Created attachment 171065 patch 765935 2 171065 webkit.review.bot 2012-11-13 12:30:45 -0800 Comment on attachment 171065 patch Clearing flags on attachment: 171065 Committed r134465: <http://trac.webkit.org/changeset/134465> 765936 3 webkit.review.bot 2012-11-13 12:30:48 -0800 All reviewed patches have been landed. Closing bug. 171065 2012-10-26 18:07:12 -0700 2012-11-13 12:30:44 -0800 patch patch text/plain 7666 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjcxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEyLTEwLTI2ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGZpbGUgdXBsb2Fk IGlucHV0IHRleHQgdmFsdWUgaXMgbm90IGV4cG9zZWQgdGhyb3VnaCBhY2Nlc3NpYmlsaXR5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1ODMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEg aGFyZCBwcm9ibGVtIHRvIHNvbHZlIG9uIHRoZSBNYWMgYmVjYXVzZSB0aGVyZSBhcmUgdGhyZWUg cGllY2VzIG9mIGluZm9ybWF0aW9uCisgICAgICAgICAgICAgMSkgVGhlIHR5cGUgb2YgYnV0dG9u IDIpIFRoZSB0ZXh0IG9uIHRoZSBidXR0b24gMykgVGhlIHRleHQgZm9yIHRoZSB2YWx1ZS4KKyAg ICAgICAgSSB0aGluayB0aGUgYmVzdCBjb21wcm9taXNlIGlzIHRvIGxhYmVsIHRoaXMgYXMgYSBm aWxlIHVwbG9hZCBidXR0b24gdHlwZSBpbiB0aGUgcm9sZSBkZXNjcmlwdGlvbiwgCisgICAgICAg IGFuZCB0aGVuIGV4cG9zZSB0aGUgZmlsZSBwYXRoIHRleHQgYXMgdGhlIEFYVGl0bGUuIAorICAg ICAgICBUaGlzIHdpbGwgZ2l2ZSB0aGUgbW9yZSByZWxldmFudCBpbmZvcm1hdGlvbiBhbmQgc2hv dWxkIGJlIGNsZWFyIHdoYXQgaXMgaGFwcGVuaW5nLgorCisgICAgICAgIFRlc3Q6IHBsYXRmb3Jt L21hYy9hY2Nlc3NpYmlsaXR5L2ZpbGUtdXBsb2FkLWJ1dHRvbi1zdWJyb2xlLmh0bWwKKworICAg ICAgICAqIEVuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5nczoKKyAgICAgICAgKiBhY2Nl c3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5tbToKKyAgICAgICAg KC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgc3Vicm9sZV0pOgorICAgICAgICAoLVtX ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciByb2xlRGVzY3JpcHRpb25dKToKKyAgICAgICAg KC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eVRpdGxlXSk6Cisg ICAgICAgICogcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBWEZpbGVVcGxvYWRCdXR0b25UZXh0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2NhbGl6ZWRT dHJpbmdzLmg6CisKIDIwMTItMTAtMjYgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RA Z21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzI2OTUuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5oCShyZXZpc2lv biAxMzI0MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmgJ KHdvcmtpbmcgY29weSkKQEAgLTE1Miw2ICsxNTIsNyBAQAogICAgIFN0cmluZyBBWERlZmluaXRp b25MaXN0VGVybVRleHQoKTsKICAgICBTdHJpbmcgQVhEZWZpbml0aW9uTGlzdERlZmluaXRpb25U ZXh0KCk7CiAgICAgU3RyaW5nIEFYRm9vdGVyUm9sZURlc2NyaXB0aW9uVGV4dCgpOworICAgIFN0 cmluZyBBWEZpbGVVcGxvYWRCdXR0b25UZXh0KCk7CiAjaWYgUExBVEZPUk0oTUFDKQogICAgIFN0 cmluZyBBWEFSSUFDb250ZW50R3JvdXBUZXh0KGNvbnN0IFN0cmluZyYgYXJpYVR5cGUpOwogI2Vu ZGlmCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNw cAkocmV2aXNpb24gMTMyNDIxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemVk U3RyaW5ncy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3Miw2ICs1NzIsMTEgQEAKIHsKICAgICBy ZXR1cm4gV0VCX1VJX1NUUklORygiZm9vdGVyIiwgImFjY2Vzc2liaWxpdHkgcm9sZSBkZXNjcmlw dGlvbiBmb3IgYSBmb290ZXIiKTsKIH0KKyAgICAKK1N0cmluZyBBWEZpbGVVcGxvYWRCdXR0b25U ZXh0KCkKK3sKKyAgICByZXR1cm4gV0VCX1VJX1NUUklORygiZmlsZSB1cGxvYWQiLCAiYWNjZXNz aWJpbGl0eSByb2xlIGRlc2NyaXB0aW9uIGZvciBhIGZpbGUgdXBsb2FkIGJ1dHRvbiIpOworfQog CiAjaWYgUExBVEZPUk0oTUFDKQogU3RyaW5nIEFYQVJJQUNvbnRlbnRHcm91cFRleHQoY29uc3Qg U3RyaW5nJiBhcmlhVHlwZSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFj L1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1t CShyZXZpc2lvbiAxMzI0MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMTYzOSw2 ICsxNjM5LDkgQEAKICAgICAgICAgcmV0dXJuIE5TQWNjZXNzaWJpbGl0eURlY3JlbWVudEFycm93 U3Vicm9sZTsKICAgICB9CiAgICAgCisgICAgaWYgKG1fb2JqZWN0LT5pc0ZpbGVVcGxvYWRCdXR0 b24oKSkKKyAgICAgICAgcmV0dXJuIEAiQVhGaWxlVXBsb2FkQnV0dG9uIjsKKyAgICAKICAgICBp ZiAobV9vYmplY3QtPmlzVHJlZUl0ZW0oKSkKICAgICAgICAgcmV0dXJuIE5TQWNjZXNzaWJpbGl0 eU91dGxpbmVSb3dTdWJyb2xlOwogICAgIApAQCAtMTc5Miw2ICsxNzk1LDkgQEAKICAgICBpZiAo W2F4Um9sZSBpc0VxdWFsVG9TdHJpbmc6QCJBWEhlYWRpbmciXSkKICAgICAgICAgcmV0dXJuIEFY SGVhZGluZ1RleHQoKTsKIAorICAgIGlmIChtX29iamVjdC0+aXNGaWxlVXBsb2FkQnV0dG9uKCkp CisgICAgICAgIHJldHVybiBBWEZpbGVVcGxvYWRCdXR0b25UZXh0KCk7CisgICAgCiAgICAgLy8g QXBwS2l0IGFsc28gcmV0dXJucyBBWFRhYiBmb3IgdGhlIHJvbGUgZGVzY3JpcHRpb24gZm9yIGEg dGFiIGl0ZW0uCiAgICAgaWYgKG1fb2JqZWN0LT5pc1RhYkl0ZW0oKSkKICAgICAgICAgcmV0dXJu IE5TQWNjZXNzaWJpbGl0eVJvbGVEZXNjcmlwdGlvbihAIkFYVGFiIiwgbmlsKTsKQEAgLTE4NDIs NiArMTg0OCwxMiBAQAogICAgIGlmIChtX29iamVjdC0+cm9sZVZhbHVlKCkgPT0gU3RhdGljVGV4 dFJvbGUpCiAgICAgICAgIHJldHVybiBbTlNTdHJpbmcgc3RyaW5nXTsKIAorICAgIC8vIEEgZmls ZSB1cGxvYWQgYnV0dG9uIHByZXNlbnRzIGEgY2hhbGxlbmdlIGJlY2F1c2UgaXQgaGFzIGJ1dHRv biB0ZXh0IGFuZCBhIHZhbHVlLCBidXQgdGhlCisgICAgLy8gQVBJIGRvZXNuJ3Qgc3VwcG9ydCB0 aGlzIHBhcmFkaWdtLgorICAgIC8vIFRoZSBjb21wcm9taXNlIGlzIHRvIHJldHVybiB0aGUgYnV0 dG9uIHR5cGUgaW4gdGhlIHJvbGUgZGVzY3JpcHRpb24gYW5kIHRoZSB2YWx1ZSBvZiB0aGUgZmls ZSBwYXRoIGluIHRoZSB0aXRsZQorICAgIGlmIChtX29iamVjdC0+aXNGaWxlVXBsb2FkQnV0dG9u KCkpCisgICAgICAgIHJldHVybiBtX29iamVjdC0+c3RyaW5nVmFsdWUoKTsKKyAgICAKICAgICBW ZWN0b3I8QWNjZXNzaWJpbGl0eVRleHQ+IHRleHRPcmRlcjsKICAgICBtX29iamVjdC0+YWNjZXNz aWJpbGl0eVRleHQodGV4dE9yZGVyKTsKICAgICAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0VuZ2xp c2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9FbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MJKHJldmlzaW9uIDEzMjQyMSkKKysr IFNvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncwkod29ya2lu ZyBjb3B5KQpAQCAtNjEwLDYgKzYxMCw5IEBACiAALwAqACAAYQBjAGMAZQBzAHMAaQBiAGkAbABp AHQAeQAgAHIAbwBsAGUAIABkAGUAcwBjAHIAaQBwAHQAaQBvAG4AIABmAG8AcgAgAGYAYQBzAHQA IAByAGUAdgBlAHIAcwBlACAAYgB1AHQAdABvAG4AIAAqAC8ACiAAIgBmAGEAcwB0ACAAcgBlAHYA ZQByAHMAZQAiACAAPQAgACIAZgBhAHMAdAAgAHIAZQB2AGUAcgBzAGUAIgA7AAogAAorAC8AKgAg AGEAYwBjAGUAcwBzAGkAYgBpAGwAaQB0AHkAIAByAG8AbABlACAAZABlAHMAYwByAGkAcAB0AGkA bwBuACAAZgBvAHIAIABhACAAZgBpAGwAZQAgAHUAcABsAG8AYQBkACAAYgB1AHQAdABvAG4AIAAq AC8ACisAIgBmAGkAbABlACAAdQBwAGwAbwBhAGQAIgAgAD0AIAAiAGYAaQBsAGUAIAB1AHAAbABv AGEAZAAgAGIAdQB0AHQAbwBuACIAOwAKKwAKIAAvACoAIABhAGMAYwBlAHMAcwBpAGIAaQBsAGkA dAB5ACAAcgBvAGwAZQAgAGQAZQBzAGMAcgBpAHAAdABpAG8AbgAgAGYAbwByACAAYQAgAGYAbwBv AHQAZQByACAAKgAvAAogACIAZgBvAG8AdABlAHIAIgAgAD0AIAAiAGYAbwBvAHQAZQByACIAOwAK IAAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjcxNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTI2ICBDaHJpcyBGbGVpemFj aCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGZpbGUgdXBsb2FkIGlucHV0 IHRleHQgdmFsdWUgaXMgbm90IGV4cG9zZWQgdGhyb3VnaCBhY2Nlc3NpYmlsaXR5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1ODMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9h Y2Nlc3NpYmlsaXR5L2ZpbGUtdXBsb2FkLWJ1dHRvbi1zdWJyb2xlLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0 dG9uLXN1YnJvbGUuaHRtbDogQWRkZWQuCisKIDIwMTItMTAtMjYgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB3aGVuIG1ha2luZyBOUFJ1bnRp bWUgY2FsbHMgd2l0aCBhIG51bGwgTlBQIHBvaW50ZXIKSW5kZXg6IExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9hY2Nlc3NpYmlsaXR5L2ZpbGUtdXBsb2FkLWJ1dHRvbi1zdWJyb2xlLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0 eS9maWxlLXVwbG9hZC1idXR0b24tc3Vicm9sZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9maWxlLXVwbG9hZC1idXR0 b24tc3Vicm9sZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKwor VGhpcyB0ZXN0cyB0aGF0IGEgZmlsZSB1cGxvYWQgYnV0dG9uIHdpbGwgaGF2ZSBhIHNwZWNpZmlj IHN1YnJvbGUgYW5kIGEgdGl0bGUgdGhhdCBtYXRjaGVzIHRoZSBmaWxlcyBzZWxlY3RlZC4KKwor T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgdXBsb2FkQnV0dG9uLnN1YnJvbGUg aXMgJ0FYU3Vicm9sZTogQVhGaWxlVXBsb2FkQnV0dG9uJworUEFTUyB1cGxvYWRCdXR0b24ucm9s ZURlc2NyaXB0aW9uIGlzICdBWFJvbGVEZXNjcmlwdGlvbjogZmlsZSB1cGxvYWQgYnV0dG9uJwor UEFTUyB1cGxvYWRCdXR0b24udGl0bGUgaXMgJ0FYVGl0bGU6IG5vIGZpbGUgc2VsZWN0ZWQnCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0dG9u LXN1YnJvbGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNj ZXNzaWJpbGl0eS9maWxlLXVwbG9hZC1idXR0b24tc3Vicm9sZS5odG1sCShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0 dG9uLXN1YnJvbGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyOSBAQAorPCFET0NUWVBF IEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxz Y3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9keSI+CisKKzxpbnB1dCB0eXBlPSJmaWxlIiBp ZD0iZmlsZXVwbG9hZCI+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29u c29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0 aGF0IGEgZmlsZSB1cGxvYWQgYnV0dG9uIHdpbGwgaGF2ZSBhIHNwZWNpZmljIHN1YnJvbGUgYW5k IGEgdGl0bGUgdGhhdCBtYXRjaGVzIHRoZSBmaWxlcyBzZWxlY3RlZC4iKTsKKworICAgIGlmICh3 aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKworICAgICAgICAgIHZhciB1cGxvYWRC dXR0b24gPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoImZp bGV1cGxvYWQiKTsKKyAgICAgICAgICBzaG91bGRCZSgidXBsb2FkQnV0dG9uLnN1YnJvbGUiLCAi J0FYU3Vicm9sZTogQVhGaWxlVXBsb2FkQnV0dG9uJyIpOworICAgICAgICAgIHNob3VsZEJlKCJ1 cGxvYWRCdXR0b24ucm9sZURlc2NyaXB0aW9uIiwgIidBWFJvbGVEZXNjcmlwdGlvbjogZmlsZSB1 cGxvYWQgYnV0dG9uJyIpOworICAgICAgICAgIHNob3VsZEJlKCJ1cGxvYWRCdXR0b24udGl0bGUi LCAiJ0FYVGl0bGU6IG5vIGZpbGUgc2VsZWN0ZWQnIik7CisgICAgfQorCis8L3NjcmlwdD4KKwor PHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==