100579 2012-10-26 16:47:13 -0700 WKStringCopyCFString() should directly use 8 bit Strings data instead of up converting 2012-10-29 11:05:50 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 752581 0 msaboff 2012-10-26 16:47:13 -0700 WKStringCopyCFString(CFAllocatorRef, WKStringRef) calls CFStringCreateWithCharacters() using the result of characters() on the argument string. Instead it should check to see if the string is 8 or 16 bits and then use characters8() with CFStringCreateWithBytes() and characters16() in place of the current characters(). 752618 1 171062 msaboff 2012-10-26 17:39:13 -0700 Created attachment 171062 Patch 752802 2 171062 webkit.review.bot 2012-10-27 11:19:09 -0700 Comment on attachment 171062 Patch Rejecting attachment 171062 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Auto-merging Source/WebKit2/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog Failed to merge in the changes. Patch failed at 0001 Unreviewed gardening. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14605667 753621 3 msaboff 2012-10-29 11:05:50 -0700 Committed r132825: <http://trac.webkit.org/changeset/132825> 171062 2012-10-26 17:39:13 -0700 2012-10-27 11:19:09 -0700 Patch 100579.patch text/plain 1873 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjcxMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTI2ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFdLU3RyaW5nQ29weUNGU3Ry aW5nKCkgc2hvdWxkIGRpcmVjdGx5IHVzZSA4IGJpdCBTdHJpbmdzIGRhdGEgaW5zdGVhZCBvZiB1 cCBjb252ZXJ0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDA1NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaGFuZ2VkIHRvIHVzZSBDRlN0cmluZ0NyZWF0ZVdpdGhCeXRlcygpIGZvciA4IGJpdCBz dHJpbmdzIHVzaW5nIGNoYXJhY3RlcnM4KCkgZm9yIGFuIDggYml0IGFyZ3VtZW50IHN0cmluZy4K KyAgICAgICAgQ2hhbmdlZCB0aGUgY3VycmVudCBjYWxsIHRvIGNoYXJhY3RlcnMxNigpLgorCisg ICAgICAgICogU2hhcmVkL0FQSS9jL2NmL1dLU3RyaW5nQ0YuY3BwOgorICAgICAgICAoV0tTdHJp bmdDb3B5Q0ZTdHJpbmcpOgorCiAyMDEyLTEwLTI2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggd2hlbiBtYWtpbmcgTlBSdW50aW1lIGNhbGxz IHdpdGggYSBudWxsIE5QUCBwb2ludGVyCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L2MvY2YvV0tTdHJpbmdDRi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVk L0FQSS9jL2NmL1dLU3RyaW5nQ0YuY3BwCShyZXZpc2lvbiAxMzI1MTApCisrKyBTb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL2MvY2YvV0tTdHJpbmdDRi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0 LDUgKzQ0LDcgQEAgQ0ZTdHJpbmdSZWYgV0tTdHJpbmdDb3B5Q0ZTdHJpbmcoQ0ZBbGxvYwogCiAg ICAgLy8gTk9URTogVGhpcyBkb2VzIG5vdCB1c2UgU3RyaW5nSW1wbDo6Y3JlYXRlQ0ZTdHJpbmco KSBzaW5jZSB0aGF0IGZ1bmN0aW9uCiAgICAgLy8gZXhwZWN0cyB0byBiZSBjYWxsZWQgb24gdGhl IHRocmVhZCBydW5uaW5nIFdlYkNvcmUuCi0gICAgcmV0dXJuIENGU3RyaW5nQ3JlYXRlV2l0aENo YXJhY3RlcnMoYWxsb2NhdG9yUmVmLCByZWludGVycHJldF9jYXN0PGNvbnN0IFVuaUNoYXIqPih0 b0ltcGwoc3RyaW5nUmVmKS0+c3RyaW5nKCkuY2hhcmFjdGVycygpKSwgdG9JbXBsKHN0cmluZ1Jl ZiktPnN0cmluZygpLmxlbmd0aCgpKTsKKyAgICBpZiAodG9JbXBsKHN0cmluZ1JlZiktPnN0cmlu ZygpLmlzOEJpdCgpKQorICAgICAgICByZXR1cm4gQ0ZTdHJpbmdDcmVhdGVXaXRoQnl0ZXMoYWxs b2NhdG9yUmVmLCByZWludGVycHJldF9jYXN0PGNvbnN0IFVJbnQ4Kj4odG9JbXBsKHN0cmluZ1Jl ZiktPnN0cmluZygpLmNoYXJhY3RlcnM4KCkpLCB0b0ltcGwoc3RyaW5nUmVmKS0+c3RyaW5nKCku bGVuZ3RoKCksIGtDRlN0cmluZ0VuY29kaW5nSVNPTGF0aW4xLCB0cnVlKTsKKyAgICByZXR1cm4g Q0ZTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycyhhbGxvY2F0b3JSZWYsIHJlaW50ZXJwcmV0X2Nh c3Q8Y29uc3QgVW5pQ2hhcio+KHRvSW1wbChzdHJpbmdSZWYpLT5zdHJpbmcoKS5jaGFyYWN0ZXJz MTYoKSksIHRvSW1wbChzdHJpbmdSZWYpLT5zdHJpbmcoKS5sZW5ndGgoKSk7CiB9Cg==