100578 2012-10-26 16:47:06 -0700 String::split(UChar, Vector<String>&) shouldn't create a temporary String 2012-10-29 11:19:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin webkit.review.bot oldest_to_newest 752580 0 msaboff 2012-10-26 16:47:06 -0700 String::split(UChar separator, Vector<String>& result) creates a single character string from the first argument and then calls the String::split(const String&, bool, Vector<String>&). Instead it could call the (UChar, bool, Vector<String>&) version of String::split. 752617 1 171061 msaboff 2012-10-26 17:35:29 -0700 Created attachment 171061 Patch 752658 2 171061 webkit.review.bot 2012-10-26 19:27:22 -0700 Comment on attachment 171061 Patch Rejecting attachment 171061 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: erge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0002 Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14610261 752836 3 171061 darin 2012-10-27 14:01:39 -0700 Comment on attachment 171061 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171061&action=review > Source/WTF/wtf/text/WTFString.cpp:691 > void String::split(UChar separator, Vector<String>& result) const > { > - split(String(&separator, 1), false, result); > + split(separator, false, result); > } This could also be inlined in the header. 753593 4 171279 msaboff 2012-10-29 10:36:57 -0700 Created attachment 171279 Patch with inlined versions of 2 arg split() 753632 5 171279 webkit.review.bot 2012-10-29 11:19:13 -0700 Comment on attachment 171279 Patch with inlined versions of 2 arg split() Clearing flags on attachment: 171279 Committed r132828: <http://trac.webkit.org/changeset/132828> 753633 6 webkit.review.bot 2012-10-29 11:19:17 -0700 All reviewed patches have been landed. Closing bug. 171061 2012-10-26 17:35:29 -0700 2012-10-29 10:36:57 -0700 Patch 100578.patch text/plain 1244 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzI3MTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTI2ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZzo6c3BsaXQoVUNoYXIsIFZlY3RvcjxT dHJpbmc+Jikgc2hvdWxkbid0IGNyZWF0ZSBhIHRlbXBvcmFyeSBTdHJpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDU3OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZWQgc3BsaXQoVUNoYXIs IFZlY3RvcjxTdHJpbmc+JikgdG8gY2FsbCBzcGxpdChVQ2hhciwgYm9vbCwgVmVjdG9yPFN0cmlu Zz4mKSBpbnN0ZWFkIG9mIGNyZWF0aW5nIGEKKyAgICAgICAgc3RyaW5nIGFuZCBjYWxsaW5nIHRo ZSBzcGxpdChTdHJpbmcsLi4uKSB2ZXJzaW9uLgorCisgICAgICAgICogd3RmL3RleHQvV1RGU3Ry aW5nLmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nOjpzcGxpdCk6CisKIDIwMTItMTAtMjYgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzI2ODkuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90ZXh0L1dU RlN0cmluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcu Y3BwCShyZXZpc2lvbiAxMzI1MTApCisrKyBTb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTY4Nyw3ICs2ODcsNyBAQCB2b2lkIFN0cmluZzo6c3BsaXQo VUNoYXIgc2VwYXJhdG9yLCBib29sCiAKIHZvaWQgU3RyaW5nOjpzcGxpdChVQ2hhciBzZXBhcmF0 b3IsIFZlY3RvcjxTdHJpbmc+JiByZXN1bHQpIGNvbnN0CiB7Ci0gICAgc3BsaXQoU3RyaW5nKCZz ZXBhcmF0b3IsIDEpLCBmYWxzZSwgcmVzdWx0KTsKKyAgICBzcGxpdChzZXBhcmF0b3IsIGZhbHNl LCByZXN1bHQpOwogfQogCiBDU3RyaW5nIFN0cmluZzo6YXNjaWkoKSBjb25zdAo= 171279 2012-10-29 10:36:57 -0700 2012-10-29 11:19:13 -0700 Patch with inlined versions of 2 arg split() 100578-2.patch text/plain 3180 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzI4MTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTI5ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZzo6c3BsaXQoVUNoYXIsIFZlY3RvcjxT dHJpbmc+Jikgc2hvdWxkbid0IGNyZWF0ZSBhIHRlbXBvcmFyeSBTdHJpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDU3OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZWQgc3BsaXQoVUNoYXIs IFZlY3RvcjxTdHJpbmc+JikgdG8gY2FsbCBzcGxpdChVQ2hhciwgYm9vbCwgVmVjdG9yPFN0cmlu Zz4mKSBpbnN0ZWFkIG9mIGNyZWF0aW5nIGEKKyAgICAgICAgc3RyaW5nIGFuZCBjYWxsaW5nIHRo ZSBzcGxpdChTdHJpbmcsLi4uKSB2ZXJzaW9uIGFuZCBtb3ZlZCBpdCB0byBXVEZTdHJpbmcuaC4g IEFsc28gbW92ZWQKKyAgICAgICAgc3BsaXQoY29uc3QgU3RyaW5nJiBzZXBhcmF0b3IsIFZlY3Rv cjxTdHJpbmc+JiByZXN1bHQpIHRvIFdURlN0cmluZy5oLgorCisgICAgICAgICogd3RmL3RleHQv V1RGU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nOjpzcGxpdCk6CisgICAgICAgICog d3RmL3RleHQvV1RGU3RyaW5nLmg6CisgICAgICAgIChXVEY6OlN0cmluZzo6c3BsaXQpOgorCiAy MDEyLTEwLTI5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTMyNzM2LgpJbmRleDogU291cmNlL1dU Ri93dGYvdGV4dC9XVEZTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3Rl eHQvV1RGU3RyaW5nLmNwcAkocmV2aXNpb24gMTMyODA1KQorKysgU291cmNlL1dURi93dGYvdGV4 dC9XVEZTdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NjUsMTEgKzY2NSw2IEBAIHZvaWQg U3RyaW5nOjpzcGxpdChjb25zdCBTdHJpbmcmIHNlcGFyYXQKICAgICAgICAgcmVzdWx0LmFwcGVu ZChzdWJzdHJpbmcoc3RhcnRQb3MpKTsKIH0KIAotdm9pZCBTdHJpbmc6OnNwbGl0KGNvbnN0IFN0 cmluZyYgc2VwYXJhdG9yLCBWZWN0b3I8U3RyaW5nPiYgcmVzdWx0KSBjb25zdAotewotICAgIHNw bGl0KHNlcGFyYXRvciwgZmFsc2UsIHJlc3VsdCk7Ci19Ci0KIHZvaWQgU3RyaW5nOjpzcGxpdChV Q2hhciBzZXBhcmF0b3IsIGJvb2wgYWxsb3dFbXB0eUVudHJpZXMsIFZlY3RvcjxTdHJpbmc+JiBy ZXN1bHQpIGNvbnN0CiB7CiAgICAgcmVzdWx0LmNsZWFyKCk7CkBAIC02ODUsMTEgKzY4MCw2IEBA IHZvaWQgU3RyaW5nOjpzcGxpdChVQ2hhciBzZXBhcmF0b3IsIGJvb2wKICAgICAgICAgcmVzdWx0 LmFwcGVuZChzdWJzdHJpbmcoc3RhcnRQb3MpKTsKIH0KIAotdm9pZCBTdHJpbmc6OnNwbGl0KFVD aGFyIHNlcGFyYXRvciwgVmVjdG9yPFN0cmluZz4mIHJlc3VsdCkgY29uc3QKLXsKLSAgICBzcGxp dChTdHJpbmcoJnNlcGFyYXRvciwgMSksIGZhbHNlLCByZXN1bHQpOwotfQotCiBDU3RyaW5nIFN0 cmluZzo6YXNjaWkoKSBjb25zdAogewogICAgIC8vIFByaW50YWJsZSBBU0NJSSBjaGFyYWN0ZXJz IDMyLi4xMjcgYW5kIHRoZSBudWxsIGNoYXJhY3RlciBhcmUKSW5kZXg6IFNvdXJjZS9XVEYvd3Rm L3RleHQvV1RGU3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4dC9XVEZT dHJpbmcuaAkocmV2aXNpb24gMTMyODA1KQorKysgU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJp bmcuaAkod29ya2luZyBjb3B5KQpAQCAtMzUwLDEwICszNTAsMTYgQEAgcHVibGljOgogICAgIHN0 YXRpYyBTdHJpbmcgY3JlYXRlVW5pbml0aWFsaXplZCh1bnNpZ25lZCBsZW5ndGgsIFVDaGFyKiYg ZGF0YSkgeyByZXR1cm4gU3RyaW5nSW1wbDo6Y3JlYXRlVW5pbml0aWFsaXplZChsZW5ndGgsIGRh dGEpOyB9CiAgICAgc3RhdGljIFN0cmluZyBjcmVhdGVVbmluaXRpYWxpemVkKHVuc2lnbmVkIGxl bmd0aCwgTENoYXIqJiBkYXRhKSB7IHJldHVybiBTdHJpbmdJbXBsOjpjcmVhdGVVbmluaXRpYWxp emVkKGxlbmd0aCwgZGF0YSk7IH0KIAotICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSB2b2lkIHNw bGl0KGNvbnN0IFN0cmluZyYgc2VwYXJhdG9yLCBWZWN0b3I8U3RyaW5nPiYgcmVzdWx0KSBjb25z dDsKICAgICBXVEZfRVhQT1JUX1NUUklOR19BUEkgdm9pZCBzcGxpdChjb25zdCBTdHJpbmcmIHNl cGFyYXRvciwgYm9vbCBhbGxvd0VtcHR5RW50cmllcywgVmVjdG9yPFN0cmluZz4mIHJlc3VsdCkg Y29uc3Q7Ci0gICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIHZvaWQgc3BsaXQoVUNoYXIgc2VwYXJh dG9yLCBWZWN0b3I8U3RyaW5nPiYgcmVzdWx0KSBjb25zdDsKKyAgICB2b2lkIHNwbGl0KGNvbnN0 IFN0cmluZyYgc2VwYXJhdG9yLCBWZWN0b3I8U3RyaW5nPiYgcmVzdWx0KSBjb25zdAorICAgIHsK KyAgICAgICAgc3BsaXQoc2VwYXJhdG9yLCBmYWxzZSwgcmVzdWx0KTsKKyAgICB9CiAgICAgV1RG X0VYUE9SVF9TVFJJTkdfQVBJIHZvaWQgc3BsaXQoVUNoYXIgc2VwYXJhdG9yLCBib29sIGFsbG93 RW1wdHlFbnRyaWVzLCBWZWN0b3I8U3RyaW5nPiYgcmVzdWx0KSBjb25zdDsKKyAgICB2b2lkIHNw bGl0KFVDaGFyIHNlcGFyYXRvciwgVmVjdG9yPFN0cmluZz4mIHJlc3VsdCkgY29uc3QKKyAgICB7 CisgICAgICAgIHNwbGl0KHNlcGFyYXRvciwgZmFsc2UsIHJlc3VsdCk7CisgICAgfQogCiAgICAg V1RGX0VYUE9SVF9TVFJJTkdfQVBJIGludCB0b0ludFN0cmljdChib29sKiBvayA9IDAsIGludCBi YXNlID0gMTApIGNvbnN0OwogICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSB1bnNpZ25lZCB0b1VJ bnRTdHJpY3QoYm9vbCogb2sgPSAwLCBpbnQgYmFzZSA9IDEwKSBjb25zdDsK