100573 2012-10-26 16:28:20 -0700 [EFL][WK2][AC] Viewport size does not change when the window size changes 2012-10-28 05:31:26 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael yael gyuyoung.kim jturcotte kenneth laszlo.gombos lucas.de.marchi noam ostap73 rakuco webkit.review.bot oldest_to_newest 752559 0 yael 2012-10-26 16:28:20 -0700 Resizing the MiniBrowser window does not affect the size of the texture we draw into. The newly exposed area remains black. 752663 1 yael 2012-10-26 19:43:43 -0700 In EFL port, we create a new surface when the size changes. I did not find an API that allows resizing the surface instead. Looks like TextureMapperGL is caching the first surface that we create and it does not update after the size change. Calling exitAcceleratedCompositingMode and enterAcceleratedCompositingMode fix this problem by deleting and creating a new TextureMapperGL, but this is not optimal solution. 752843 2 yael 2012-10-27 15:33:20 -0700 Changing the title, since it is the viewport size that does not change after changing the size of a window. 752846 3 171108 yael 2012-10-27 15:44:32 -0700 Created attachment 171108 Patch The viewport size is set when we create the window the first time and does not change automatically afterwards. When we change the window size, we need to explicitly change the viewport size as well. 752847 4 171108 kenneth 2012-10-27 15:48:37 -0700 Comment on attachment 171108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171108&action=review > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:742 > + Evas_GL_API *gl = evas_gl_api_get(evasGl()); * position i wrong 752848 5 webkit.review.bot 2012-10-27 15:50:22 -0700 Attachment 171108 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:742: Declaration has space between type name and * in Evas_GL_API *gl [whitespace/declaration] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 752865 6 171108 webkit.review.bot 2012-10-27 18:34:05 -0700 Comment on attachment 171108 Patch Rejecting attachment 171108 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: uto-merging Source/WebKit2/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix AVFoundation build. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14615619 752867 7 171108 yael 2012-10-27 18:39:41 -0700 Comment on attachment 171108 Patch Looks like commit queue is sick. Let's try again. 752870 8 171113 yael 2012-10-27 19:07:49 -0700 Created attachment 171113 Patch for landing. Fixed the style issue. 752938 9 171113 webkit.review.bot 2012-10-28 05:31:21 -0700 Comment on attachment 171113 Patch for landing. Clearing flags on attachment: 171113 Committed r132751: <http://trac.webkit.org/changeset/132751> 752939 10 webkit.review.bot 2012-10-28 05:31:26 -0700 All reviewed patches have been landed. Closing bug. 171108 2012-10-27 15:44:32 -0700 2012-10-27 19:07:49 -0700 Patch 100573.patch text/plain 1509 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjc0MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTI3ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdW0FDXSBW aWV3cG9ydCBzaXplIGRvZXMgbm90IGNoYW5nZSB3aGVuIHRoZSB3aW5kb3cgc2l6ZSBjaGFuZ2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1NzMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdmll d3BvcnQgc2l6ZSBpcyBzZXQgd2hlbiB3ZSBjcmVhdGUgdGhlIHdpbmRvdyB0aGUgZmlyc3QgdGlt ZQorICAgICAgICBhbmQgZG9lcyBub3QgY2hhbmdlIGF1dG9tYXRpY2FsbHkgYWZ0ZXJ3YXJkcy4g V2hlbiB3ZSBjaGFuZ2UgdGhlIHdpbmRvdyBzaXplLAorICAgICAgICB3ZSBuZWVkIHRvIGV4cGxp Y2l0bHkgY2hhbmdlIHRoZSB2aWV3cG9ydCBzaXplIGFzIHdlbGwuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHA6CisgICAgICAgIChFd2tWaWV3SW1wbDo6Y3Jl YXRlR0xTdXJmYWNlKToKKwogMjAxMi0xMC0yNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFlldCBtb3JlIE1lc3NhZ2VSZWNlaXZlcmluZwpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAkocmV2aXNpb24g MTMyNzI0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MzcsNiArNzM3LDExIEBACiAgICAgZXZhc19nbF9uYXRp dmVfc3VyZmFjZV9nZXQobV9ldmFzR2wsIG1fZXZhc0dsU3VyZmFjZSwgJm5hdGl2ZVN1cmZhY2Up OwogICAgIGV2YXNfb2JqZWN0X2ltYWdlX25hdGl2ZV9zdXJmYWNlX3NldChzZC0+aW1hZ2UsICZu YXRpdmVTdXJmYWNlKTsKIAorICAgIGV2YXNfZ2xfbWFrZV9jdXJyZW50KG1fZXZhc0dsLCBtX2V2 YXNHbFN1cmZhY2UsIG1fZXZhc0dsQ29udGV4dCk7CisKKyAgICBFdmFzX0dMX0FQSSAqZ2wgPSBl dmFzX2dsX2FwaV9nZXQoZXZhc0dsKCkpOworICAgIGdsLT5nbFZpZXdwb3J0KDAsIDAsIHZpZXdT aXplLndpZHRoKCkgKyBzZC0+dmlldy54LCB2aWV3U2l6ZS5oZWlnaHQoKSArIHNkLT52aWV3Lnkp OworCiAgICAgcmV0dXJuIHRydWU7CiB9CiAK 171113 2012-10-27 19:07:49 -0700 2012-10-28 05:31:21 -0700 Patch for landing. 100573.patch text/plain 1521 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1w bC5jcHAJKHJldmlzaW9uIDEzMjcyNCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL0V3a1ZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzM3LDYgKzczNywxMSBAQAog ICAgIGV2YXNfZ2xfbmF0aXZlX3N1cmZhY2VfZ2V0KG1fZXZhc0dsLCBtX2V2YXNHbFN1cmZhY2Us ICZuYXRpdmVTdXJmYWNlKTsKICAgICBldmFzX29iamVjdF9pbWFnZV9uYXRpdmVfc3VyZmFjZV9z ZXQoc2QtPmltYWdlLCAmbmF0aXZlU3VyZmFjZSk7CiAKKyAgICBldmFzX2dsX21ha2VfY3VycmVu dChtX2V2YXNHbCwgbV9ldmFzR2xTdXJmYWNlLCBtX2V2YXNHbENvbnRleHQpOworCisgICAgRXZh c19HTF9BUEkqIGdsID0gZXZhc19nbF9hcGlfZ2V0KGV2YXNHbCgpKTsKKyAgICBnbC0+Z2xWaWV3 cG9ydCgwLCAwLCB2aWV3U2l6ZS53aWR0aCgpICsgc2QtPnZpZXcueCwgdmlld1NpemUuaGVpZ2h0 KCkgKyBzZC0+dmlldy55KTsKKwogICAgIHJldHVybiB0cnVlOwogfQogCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMzI3NDApCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMC0yNyAgWWFlbCBBaGFyb24gIDx5YWVsLmFo YXJvbkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXVtBQ10gVmlld3BvcnQgc2l6ZSBk b2VzIG5vdCBjaGFuZ2Ugd2hlbiB0aGUgd2luZG93IHNpemUgY2hhbmdlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNTczCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgVGhlIHZpZXdw b3J0IHNpemUgaXMgc2V0IHdoZW4gd2UgY3JlYXRlIHRoZSB3aW5kb3cgdGhlIGZpcnN0IHRpbWUK KyAgICAgICAgYW5kIGRvZXMgbm90IGNoYW5nZSBhdXRvbWF0aWNhbGx5IGFmdGVyd2FyZHMuIFdo ZW4gd2UgY2hhbmdlIHRoZSB3aW5kb3cgc2l6ZSwKKyAgICAgICAgd2UgbmVlZCB0byBleHBsaWNp dGx5IGNoYW5nZSB0aGUgdmlld3BvcnQgc2l6ZSBhcyB3ZWxsLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwOgorICAgICAgICAoRXdrVmlld0ltcGw6OmNyZWF0 ZUdMU3VyZmFjZSk6CisKIDIwMTItMTAtMjcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K IAogICAgICAgICBZZXQgbW9yZSBNZXNzYWdlUmVjZWl2ZXJpbmcK