100571 2012-10-26 16:16:43 -0700 [EFL] Refactor tooltip callback signal in WebKit1 2012-10-30 02:00:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song gyuyoung.kim lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 752545 0 jinwoo7.song 2012-10-26 16:16:43 -0700 Separate tooltip callback signal to 'tooltip,text,set' and 'tooltip,text,unset' to synchronize with WebKit2. 752585 1 171050 jinwoo7.song 2012-10-26 16:55:40 -0700 Created attachment 171050 Patch 754006 2 ryuan.choi 2012-10-29 23:25:55 -0700 (In reply to comment #1) > Created an attachment (id=171050) [details] > Patch LGTM. Thanks. 754018 3 171050 gyuyoung.kim 2012-10-30 00:13:32 -0700 Comment on attachment 171050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171050&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:-3494 > - * Set tooltip text and display if it is currently hidden. Should we remove this comment ? > Source/WebKit/efl/ewk/ewk_view.cpp:3495 > + */ Looks wrong indentation. 754021 4 171050 jinwoo7.song 2012-10-30 00:28:48 -0700 Comment on attachment 171050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171050&action=review >> Source/WebKit/efl/ewk/ewk_view.cpp:-3494 >> - * Set tooltip text and display if it is currently hidden. > > Should we remove this comment ? It's recommendation by Kenneth that we do not need to document the internal functions because they are tend to change. https://bugs.webkit.org/show_bug.cgi?id=98589 >> Source/WebKit/efl/ewk/ewk_view.cpp:3495 >> + */ > > Looks wrong indentation. I'll fix it. 754044 5 171389 jinwoo7.song 2012-10-30 01:03:58 -0700 Created attachment 171389 Patch 754082 6 171389 webkit.review.bot 2012-10-30 02:00:25 -0700 Comment on attachment 171389 Patch Clearing flags on attachment: 171389 Committed r132881: <http://trac.webkit.org/changeset/132881> 754083 7 webkit.review.bot 2012-10-30 02:00:30 -0700 All reviewed patches have been landed. Closing bug. 171050 2012-10-26 16:55:40 -0700 2012-10-30 01:03:51 -0700 Patch bug-100571-20121027085352.patch text/plain 5305 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggYTFiNjk2YzUz N2ZmYjc2MjZjNDhhZDY1NDFjNTc4ZjZjYTcyMzMwNC4uY2QwZTJkNjQyYjlkYzQ4OGM3NmUyNjBj MmRiMDBhMjdhZmYzMzRjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTEwLTI2ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXSBSZWZhY3RvciB0b29sdGlwIGNhbGxiYWNrIHNpZ25hbCBpbiBXZWJLaXQxCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1NzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXBhcmF0ZSB0b29s dGlwIGNhbGxiYWNrIHNpZ25hbCBpbnRvICd0b29sdGlwLHRleHQsc2V0JworICAgICAgICBhbmQg J3Rvb2x0aXAsdGV4dCx1bnNldCcgdG8gYmUgY29uc2lzdGVudCB3aXRoIFdlYktpdDIuCisKKyAg ICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfdG9vbHRpcF90ZXh0 X3NldCk6CisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIwMTItMTAtMjYgIEh5b3dvbiBL aW0gIDxodzEwMDgua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtUZXhtYXBdW0VGTF0gSW1w bGVtZW50YXRpb24gb2YgQUMgcmVsYXRlZCBmdW5jdGlvbnMgaW4gQ2hyb21lQ2xpZW50RWZsIGFu ZCBld2tWaWV3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNw cCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggMGVhYjQzODQwOTgz YjM3ZjI0YzA5ZmUxM2M3ZDdiMjMyZWNmYWZiZi4uNzAxZGVmMzAwMGQwNmYzNjk1MTQzMWRlZjBj N2JkZmMwZDAyZDlhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0xNTgsNiAr MTU4LDcgQEAgc3RhdGljIGNvbnN0IEV2YXNfU21hcnRfQ2JfRGVzY3JpcHRpb24gX2V3a192aWV3 X2NhbGxiYWNrX25hbWVzW10gPSB7CiAgICAgeyAidG9vbGJhcnMsdmlzaWJsZSxnZXQiLCAiYiIg fSwKICAgICB7ICJ0b29sYmFycyx2aXNpYmxlLHNldCIsICJiIiB9LAogICAgIHsgInRvb2x0aXAs dGV4dCxzZXQiLCAicyIgfSwKKyAgICB7ICJ0b29sdGlwLHRleHQsdW5zZXQiLCAicyIgfSwKICAg ICB7ICJ1cmksY2hhbmdlZCIsICJzIiB9LAogICAgIHsgInZpZXcscmVzaXplZCIsICIiIH0sCiAg ICAgeyAiem9vbSxhbmltYXRlZCxlbmQiLCAiIiB9LApAQCAtMzQ5MSwxOCArMzQ5MiwxNCBAQCB2 b2lkIGV3a192aWV3X21lbnViYXJfdmlzaWJsZV9nZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGJv b2wqIHZpc2libGUpCiAKIC8qKgogICogQGludGVybmFsCi0gKiBTZXQgdG9vbHRpcCB0ZXh0IGFu ZCBkaXNwbGF5IGlmIGl0IGlzIGN1cnJlbnRseSBoaWRkZW4uCi0gKgotICogQHBhcmFtIGV3a1Zp ZXcgVmlldy4KLSAqIEBwYXJhbSB0ZXh0IFRleHQgdG8gc2V0IHRvb2x0aXAgdG8uCi0gKgotICog RW1pdHMgc2lnbmFsOiAidG9vbHRpcCx0ZXh0LHNldCIgd2l0aCBhIHN0cmluZy4gSWYgdG9vbHRp cCBtdXN0IGJlIGFjdHVhbGx5Ci0gKiByZW1vdmVkLCB0ZXh0IHdpbGwgYmUgMCBvciAnXDAnCi0g Ki8KKyAgKi8KIHZvaWQgZXdrX3ZpZXdfdG9vbHRpcF90ZXh0X3NldChFdmFzX09iamVjdCogZXdr VmlldywgY29uc3QgY2hhciogdGV4dCkKIHsKICAgICBEQkcoImV3a1ZpZXc9JXAgdGV4dD0lcyIs IGV3a1ZpZXcsIHRleHQpOwotICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwoZXdr VmlldywgInRvb2x0aXAsdGV4dCxzZXQiLCAodm9pZCopdGV4dCk7CisgICAgaWYgKHRleHQgJiYg KnRleHQpCisgICAgICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwoZXdrVmlldywg InRvb2x0aXAsdGV4dCxzZXQiLCAodm9pZCopdGV4dCk7CisgICAgZWxzZQorICAgICAgICBldmFz X29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0b29sdGlwLHRleHQsdW5zZXQi LCAwKTsKIH0KIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Zp ZXcuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmluZGV4IGMxYTgxOWZhM2Rk ODVhZDU3MGM1MWRjZmM0M2EwODAxOTkzZTNkNWUuLmU4YmFmODcxZGJlODVhM2RjZjY4NjI1ZjJh Y2JkYmJhMjk1YTdjYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmll dy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC0xMDMsNyArMTAz LDggQEAKICAqICAgIHdpbGwgYmUgZGVsZXRlZC4KICAqICAtICJyZXN0b3JlIiwgRXZhc19PYmpl Y3QgKjogcmVwb3J0cyB0aGF0IHZpZXcgc2hvdWxkIGJlIHJlc3RvcmVkIHRvIGRlZmF1bHQgY29u ZGl0aW9ucwogICogICAgYW5kIGl0IGdpdmVzIGEgZnJhbWUgdGhhdCBvcmlnaW5hdGVkIHJlc3Rv cmUgYXMgYW4gYXJndW1lbnQuCi0gKiAgLSAidG9vbHRpcCx0ZXh0LHNldCIsIGNvbnN0IGNoYXIq OiBzZXRzIHRvb2x0aXAgdGV4dCBhbmQgZGlzcGxheXMgaWYgaXQgaXMgY3VycmVudGx5IGhpZGRl bi4KKyAqICAtICJ0b29sdGlwLHRleHQsc2V0IiwgY29uc3QgY2hhcio6IHRvb2x0aXAgd2FzIHNl dC4KKyAqICAtICJ0b29sdGlwLHRleHQsdW5zZXQiLCB2b2lkOiB0b29sdGlwIHdhcyB1bnNldC4K ICAqICAtICJ1cmksY2hhbmdlZCIsIGNvbnN0IGNoYXIqOiB1cmkgb2YgdGhlIG1haW4gZnJhbWUg d2FzIGNoYW5nZWQuCiAgKiAgLSAidmlldyxyZXNpemVkIiwgdm9pZDogdmlldyBvYmplY3QncyBz aXplIHdhcyBjaGFuZ2VkLgogICogIC0gInZpZXdwb3J0LGNoYW5nZWQiLCB2b2lkOiByZXBvcnRz IHRoYXQgdmlld3BvcnQgd2FzIGNoYW5nZWQuCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDkxODRmZDIzMDY5MTM1ZjdkYmY4YzAwZTcwNGMxMjY2 ZTBkZjE2Yy4uY2E1ZGQxZjI0ZjU3NTc1ZmNmNWZkYmQxMzdlYThlY2UzMmY1MjhlOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTEwLTI2ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBSZWZhY3RvciB0b29sdGlwIGNhbGxiYWNrIHNpZ25hbCBpbiBXZWJL aXQxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1 NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXBh cmF0ZSB0b29sdGlwIGNhbGxiYWNrIHNpZ25hbCBpbnRvICd0b29sdGlwLHRleHQsc2V0JworICAg ICAgICBhbmQgJ3Rvb2x0aXAsdGV4dCx1bnNldCcgdG8gYmUgY29uc2lzdGVudCB3aXRoIFdlYktp dDIuCisKKyAgICAgICAgKiBFV2ViTGF1bmNoZXIvbWFpbi5jOgorICAgICAgICAob25fdG9vbHRp cF90ZXh0X3NldCk6CisgICAgICAgIChvbl90b29sdGlwX3RleHRfdW5zZXQpOgorICAgICAgICAo YnJvd3NlckNyZWF0ZSk6CisKIDIwMTItMTAtMjYgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25p QGdvb2dsZS5jb20+CiAKICAgICAgICAgQVg6IE5vdGlmaWNhdGlvbiBzaG91bGQgYmUgc2VudCB3 aGVuIGFjY2Vzc2liaWxpdHlJc0lnbm9yZWQgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdl YkxhdW5jaGVyL21haW4uYyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKaW5kZXggZTE3Yzhj Yzg1NjJjOTc3ZGNjYTIwOWIxMTIxNzQ1MmQ0MmE1MGI5Mi4uZWJhOGYyMmU0YmY5NGQ2ZTdkZWFl OTg3N2FiMzEyNzgxMzZiOGIzMyAxMDA2NDQKLS0tIGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4u YworKysgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCkBAIC00MjYsOCArNDI2LDEzIEBAIHN0 YXRpYyB2b2lkCiBvbl90b29sdGlwX3RleHRfc2V0KHZvaWQqIHVzZXJfZGF0YSwgRXZhc19PYmpl Y3QqIHdlYnZpZXcsIHZvaWQqIGV2ZW50X2luZm8pCiB7CiAgICAgY29uc3QgY2hhciAqdGV4dCA9 IChjb25zdCBjaGFyICopZXZlbnRfaW5mbzsKLSAgICBpZiAodGV4dCAmJiAqdGV4dCAhPSAnXDAn KQotICAgICAgICBpbmZvKCIlc1xuIiwgdGV4dCk7CisgICAgaW5mbygiVG9vbHRpcCBpcyBzZXQ6 ICVzXG4iLCB0ZXh0KTsKK30KKworc3RhdGljIHZvaWQKK29uX3Rvb2x0aXBfdGV4dF91bnNldCh2 b2lkKiB1c2VyX2RhdGEsIEV2YXNfT2JqZWN0KiB3ZWJ2aWV3LCB2b2lkKiBldmVudF9pbmZvKQor eworICAgIGluZm8oIlRvb2x0aXAgaXMgdW5zZXRcbiIpOwogfQogCiBzdGF0aWMgdm9pZApAQCAt NzQ3LDYgKzc1Miw3IEBAIGJyb3dzZXJDcmVhdGUoY29uc3QgY2hhciAqdXJsLCBVc2VyX0FyZ3Vt ZW50cyAqdXNlckFyZ3MpCiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcEJy b3dzZXItPmJyb3dzZXIsICJ0b29sYmFycyx2aXNpYmxlLGdldCIsIG9uX3Rvb2xiYXJzX3Zpc2li bGVfZ2V0LCBhcHBCcm93c2VyKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQo YXBwQnJvd3Nlci0+YnJvd3NlciwgInRvb2xiYXJzLHZpc2libGUsc2V0Iiwgb25fdG9vbGJhcnNf dmlzaWJsZV9zZXQsIGFwcEJyb3dzZXIpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNr X2FkZChhcHBCcm93c2VyLT5icm93c2VyLCAidG9vbHRpcCx0ZXh0LHNldCIsIG9uX3Rvb2x0aXBf dGV4dF9zZXQsIGFwcEJyb3dzZXIpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2Fk ZChhcHBCcm93c2VyLT5icm93c2VyLCAidG9vbHRpcCx0ZXh0LHVuc2V0Iiwgb25fdG9vbHRpcF90 ZXh0X3Vuc2V0LCBhcHBCcm93c2VyKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19h ZGQoYXBwQnJvd3Nlci0+YnJvd3NlciwgInVyaSxjaGFuZ2VkIiwgb25fdXJsX2NoYW5nZWQsIGFw cEJyb3dzZXIpOwogCiAgICAgZXZhc19vYmplY3RfZXZlbnRfY2FsbGJhY2tfYWRkKGFwcEJyb3dz ZXItPmJyb3dzZXIsIEVWQVNfQ0FMTEJBQ0tfREVMLCBvbl9icm93c2VyX2RlbCwgYXBwQnJvd3Nl cik7Cg== 171389 2012-10-30 01:03:58 -0700 2012-10-30 02:00:25 -0700 Patch bug-100571-20121030170223.patch text/plain 5259 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggYTFiNjk2YzUz N2ZmYjc2MjZjNDhhZDY1NDFjNTc4ZjZjYTcyMzMwNC4uYWY1NGE4N2VkYzRjMTExNTAxYzA3NDc1 MDkxYTZiYjM2MDM0OTM3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTEwLTMwICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXSBSZWZhY3RvciB0b29sdGlwIGNhbGxiYWNrIHNpZ25hbCBpbiBXZWJLaXQxCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1NzEKKworICAg ICAgICBSZXZpZXdlZCBieSBHeXV5b3VuZyBLaW0uCisKKyAgICAgICAgU2VwYXJhdGUgdG9vbHRp cCBjYWxsYmFjayBzaWduYWwgaW50byAndG9vbHRpcCx0ZXh0LHNldCcKKyAgICAgICAgYW5kICd0 b29sdGlwLHRleHQsdW5zZXQnIHRvIGJlIGNvbnNpc3RlbnQgd2l0aCBXZWJLaXQyLgorCisgICAg ICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3Rvb2x0aXBfdGV4dF9z ZXQpOgorICAgICAgICAqIGV3ay9ld2tfdmlldy5oOgorCiAyMDEyLTEwLTI2ICBIeW93b24gS2lt ICA8aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbVGV4bWFwXVtFRkxdIEltcGxl bWVudGF0aW9uIG9mIEFDIHJlbGF0ZWQgZnVuY3Rpb25zIGluIENocm9tZUNsaWVudEVmbCBhbmQg ZXdrVmlldy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDBlYWI0Mzg0MDk4M2Iz N2YyNGMwOWZlMTNjN2Q3YjIzMmVjZmFmYmYuLjQzMjI1ZTk5YTlhMWFjY2IzZGUxMTY1ODcyZGQx ODdhNjJiNmFiOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMTU4LDYgKzE1 OCw3IEBAIHN0YXRpYyBjb25zdCBFdmFzX1NtYXJ0X0NiX0Rlc2NyaXB0aW9uIF9ld2tfdmlld19j YWxsYmFja19uYW1lc1tdID0gewogICAgIHsgInRvb2xiYXJzLHZpc2libGUsZ2V0IiwgImIiIH0s CiAgICAgeyAidG9vbGJhcnMsdmlzaWJsZSxzZXQiLCAiYiIgfSwKICAgICB7ICJ0b29sdGlwLHRl eHQsc2V0IiwgInMiIH0sCisgICAgeyAidG9vbHRpcCx0ZXh0LHVuc2V0IiwgInMiIH0sCiAgICAg eyAidXJpLGNoYW5nZWQiLCAicyIgfSwKICAgICB7ICJ2aWV3LHJlc2l6ZWQiLCAiIiB9LAogICAg IHsgInpvb20sYW5pbWF0ZWQsZW5kIiwgIiIgfSwKQEAgLTM0OTEsMTggKzM0OTIsMTQgQEAgdm9p ZCBld2tfdmlld19tZW51YmFyX3Zpc2libGVfZ2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBib29s KiB2aXNpYmxlKQogCiAvKioKICAqIEBpbnRlcm5hbAotICogU2V0IHRvb2x0aXAgdGV4dCBhbmQg ZGlzcGxheSBpZiBpdCBpcyBjdXJyZW50bHkgaGlkZGVuLgotICoKLSAqIEBwYXJhbSBld2tWaWV3 IFZpZXcuCi0gKiBAcGFyYW0gdGV4dCBUZXh0IHRvIHNldCB0b29sdGlwIHRvLgotICoKLSAqIEVt aXRzIHNpZ25hbDogInRvb2x0aXAsdGV4dCxzZXQiIHdpdGggYSBzdHJpbmcuIElmIHRvb2x0aXAg bXVzdCBiZSBhY3R1YWxseQotICogcmVtb3ZlZCwgdGV4dCB3aWxsIGJlIDAgb3IgJ1wwJwogICov CiB2b2lkIGV3a192aWV3X3Rvb2x0aXBfdGV4dF9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNv bnN0IGNoYXIqIHRleHQpCiB7CiAgICAgREJHKCJld2tWaWV3PSVwIHRleHQ9JXMiLCBld2tWaWV3 LCB0ZXh0KTsKLSAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0 b29sdGlwLHRleHQsc2V0IiwgKHZvaWQqKXRleHQpOworICAgIGlmICh0ZXh0ICYmICp0ZXh0KQor ICAgICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0b29sdGlw LHRleHQsc2V0IiwgKHZvaWQqKXRleHQpOworICAgIGVsc2UKKyAgICAgICAgZXZhc19vYmplY3Rf c21hcnRfY2FsbGJhY2tfY2FsbChld2tWaWV3LCAidG9vbHRpcCx0ZXh0LHVuc2V0IiwgMCk7CiB9 CiAKIC8qKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmggYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAppbmRleCBjMWE4MTlmYTNkZDg1YWQ1NzBj NTFkY2ZjNDNhMDgwMTk5M2UzZDVlLi5lOGJhZjg3MWRiZTg1YTNkY2Y2ODYyNWYyYWNiZGJiYTI5 NWE3Y2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaApAQCAtMTAzLDcgKzEwMyw4IEBACiAg KiAgICB3aWxsIGJlIGRlbGV0ZWQuCiAgKiAgLSAicmVzdG9yZSIsIEV2YXNfT2JqZWN0ICo6IHJl cG9ydHMgdGhhdCB2aWV3IHNob3VsZCBiZSByZXN0b3JlZCB0byBkZWZhdWx0IGNvbmRpdGlvbnMK ICAqICAgIGFuZCBpdCBnaXZlcyBhIGZyYW1lIHRoYXQgb3JpZ2luYXRlZCByZXN0b3JlIGFzIGFu IGFyZ3VtZW50LgotICogIC0gInRvb2x0aXAsdGV4dCxzZXQiLCBjb25zdCBjaGFyKjogc2V0cyB0 b29sdGlwIHRleHQgYW5kIGRpc3BsYXlzIGlmIGl0IGlzIGN1cnJlbnRseSBoaWRkZW4uCisgKiAg LSAidG9vbHRpcCx0ZXh0LHNldCIsIGNvbnN0IGNoYXIqOiB0b29sdGlwIHdhcyBzZXQuCisgKiAg LSAidG9vbHRpcCx0ZXh0LHVuc2V0Iiwgdm9pZDogdG9vbHRpcCB3YXMgdW5zZXQuCiAgKiAgLSAi dXJpLGNoYW5nZWQiLCBjb25zdCBjaGFyKjogdXJpIG9mIHRoZSBtYWluIGZyYW1lIHdhcyBjaGFu Z2VkLgogICogIC0gInZpZXcscmVzaXplZCIsIHZvaWQ6IHZpZXcgb2JqZWN0J3Mgc2l6ZSB3YXMg Y2hhbmdlZC4KICAqICAtICJ2aWV3cG9ydCxjaGFuZ2VkIiwgdm9pZDogcmVwb3J0cyB0aGF0IHZp ZXdwb3J0IHdhcyBjaGFuZ2VkLgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMv Q2hhbmdlTG9nCmluZGV4IDNjMzU1YWFmZDhjNmYzY2UxMjM1OGE3MWNjMmUzZDgzNmEwN2ZmNmIu LjA1NDQwNjIzZDQxMTIxNjY3OWJiNTg3MDU4M2RlYWRlOGE4NWJkOWEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx Mi0xMC0zMCAgSmlud29vIFNvbmcgIDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF0gUmVmYWN0b3IgdG9vbHRpcCBjYWxsYmFjayBzaWduYWwgaW4gV2ViS2l0MQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNTcxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcgS2ltLgorCisgICAgICAgIFNlcGFyYXRlIHRvb2x0 aXAgY2FsbGJhY2sgc2lnbmFsIGludG8gJ3Rvb2x0aXAsdGV4dCxzZXQnCisgICAgICAgIGFuZCAn dG9vbHRpcCx0ZXh0LHVuc2V0JyB0byBiZSBjb25zaXN0ZW50IHdpdGggV2ViS2l0Mi4KKworICAg ICAgICAqIEVXZWJMYXVuY2hlci9tYWluLmM6CisgICAgICAgIChvbl90b29sdGlwX3RleHRfc2V0 KToKKyAgICAgICAgKG9uX3Rvb2x0aXBfdGV4dF91bnNldCk6CisgICAgICAgIChicm93c2VyQ3Jl YXRlKToKKwogMjAxMi0xMC0yOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzI4MTkuCmRpZmYgLS1naXQg YS9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpp bmRleCA2ZjBhOGY1Y2EwYTFjYTI1OGNhODc0N2RiMDI4Y2UzMzNjZjYyNzIwLi44MTU4YTgxNjU3 OTE3MTlkZjExZTIzYWZhMmQ3NTlmNzQ0N2MzMGZmIDEwMDY0NAotLS0gYS9Ub29scy9FV2ViTGF1 bmNoZXIvbWFpbi5jCisrKyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKQEAgLTQyNiw4ICs0 MjYsMTMgQEAgc3RhdGljIHZvaWQKIG9uX3Rvb2x0aXBfdGV4dF9zZXQodm9pZCogdXNlcl9kYXRh LCBFdmFzX09iamVjdCogd2Vidmlldywgdm9pZCogZXZlbnRfaW5mbykKIHsKICAgICBjb25zdCBj aGFyICp0ZXh0ID0gKGNvbnN0IGNoYXIgKilldmVudF9pbmZvOwotICAgIGlmICh0ZXh0ICYmICp0 ZXh0ICE9ICdcMCcpCi0gICAgICAgIGluZm8oIiVzXG4iLCB0ZXh0KTsKKyAgICBpbmZvKCJUb29s dGlwIGlzIHNldDogJXNcbiIsIHRleHQpOworfQorCitzdGF0aWMgdm9pZAorb25fdG9vbHRpcF90 ZXh0X3Vuc2V0KHZvaWQqIHVzZXJfZGF0YSwgRXZhc19PYmplY3QqIHdlYnZpZXcsIHZvaWQqIGV2 ZW50X2luZm8pCit7CisgICAgaW5mbygiVG9vbHRpcCBpcyB1bnNldFxuIik7CiB9CiAKIHN0YXRp YyB2b2lkCkBAIC03NDcsNiArNzUyLDcgQEAgYnJvd3NlckNyZWF0ZShjb25zdCBjaGFyICp1cmws IFVzZXJfQXJndW1lbnRzICp1c2VyQXJncykKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFj a19hZGQoYXBwQnJvd3Nlci0+YnJvd3NlciwgInRvb2xiYXJzLHZpc2libGUsZ2V0Iiwgb25fdG9v bGJhcnNfdmlzaWJsZV9nZXQsIGFwcEJyb3dzZXIpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2Nh bGxiYWNrX2FkZChhcHBCcm93c2VyLT5icm93c2VyLCAidG9vbGJhcnMsdmlzaWJsZSxzZXQiLCBv bl90b29sYmFyc192aXNpYmxlX3NldCwgYXBwQnJvd3Nlcik7CiAgICAgZXZhc19vYmplY3Rfc21h cnRfY2FsbGJhY2tfYWRkKGFwcEJyb3dzZXItPmJyb3dzZXIsICJ0b29sdGlwLHRleHQsc2V0Iiwg b25fdG9vbHRpcF90ZXh0X3NldCwgYXBwQnJvd3Nlcik7CisgICAgZXZhc19vYmplY3Rfc21hcnRf Y2FsbGJhY2tfYWRkKGFwcEJyb3dzZXItPmJyb3dzZXIsICJ0b29sdGlwLHRleHQsdW5zZXQiLCBv bl90b29sdGlwX3RleHRfdW5zZXQsIGFwcEJyb3dzZXIpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0 X2NhbGxiYWNrX2FkZChhcHBCcm93c2VyLT5icm93c2VyLCAidXJpLGNoYW5nZWQiLCBvbl91cmxf Y2hhbmdlZCwgYXBwQnJvd3Nlcik7CiAKICAgICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19h ZGQoYXBwQnJvd3Nlci0+YnJvd3NlciwgRVZBU19DQUxMQkFDS19ERUwsIG9uX2Jyb3dzZXJfZGVs LCBhcHBCcm93c2VyKTsK