100553 2012-10-26 12:47:05 -0700 [chromium] Allow implicit conversion between gfx::Vector2d and WebSize 2012-11-01 11:36:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth backer cc-bugs dglazkov fishd jamesr piman tkent+wkapi webkit.review.bot oldest_to_newest 752294 0 danakj 2012-10-26 12:47:05 -0700 [chromium] Allow implicit conversion between gfx::Vector2d and WebSize 752296 1 170986 danakj 2012-10-26 12:48:09 -0700 Created attachment 170986 Patch 752297 2 danakj 2012-10-26 12:48:26 -0700 This depends on https://codereview.chromium.org/11269022/ for gfx::Vector2d to exist. 752299 3 webkit.review.bot 2012-10-26 12:54:43 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 752315 4 170986 jamesr 2012-10-26 13:12:42 -0700 Comment on attachment 170986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170986&action=review Be sure to reverse-roll before landing this > Source/Platform/ChangeLog:9 > + IntSize class is used equivalently inside WebCore. This let's us convert It's "lets", not "let's". (insert favorite apostrophe meme here) 752321 5 170986 webkit.review.bot 2012-10-26 13:19:31 -0700 Comment on attachment 170986 Patch Attachment 170986 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14605235 752328 6 170992 danakj 2012-10-26 13:30:36 -0700 Created attachment 170992 Patch 752329 7 danakj 2012-10-26 13:30:50 -0700 (In reply to comment #4) > (From update of attachment 170986 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170986&action=review > > Be sure to reverse-roll before landing this Yup! Thanks :) 756315 8 170992 webkit.review.bot 2012-11-01 09:03:20 -0700 Comment on attachment 170992 Patch Rejecting attachment 170992 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: '&' token Source/Platform/chromium/public/WebSize.h:101: error: 'WebKit::WebSize& WebKit::WebSize::operator=(...)' must not have variable number of arguments Source/Platform/chromium/public/WebSize.h:101: error: expected ';' before '&' token Source/Platform/chromium/public/WebSize.h:108: error: expected ';' before 'operator' Source/Platform/chromium/public/WebSize.h:113: error: expected type-specifier make: *** [out/Release/obj.target/cc/Source/WebKit/chromium/cc/layer_tree_host_impl.o] Error 1 Full output: http://queues.webkit.org/results/14686554 756488 9 170992 webkit.review.bot 2012-11-01 11:36:52 -0700 Comment on attachment 170992 Patch Clearing flags on attachment: 170992 Committed r133198: <http://trac.webkit.org/changeset/133198> 756489 10 webkit.review.bot 2012-11-01 11:36:56 -0700 All reviewed patches have been landed. Closing bug. 170986 2012-10-26 12:48:09 -0700 2012-10-26 13:30:33 -0700 Patch bug-100553-20121026154640.patch text/plain 2098 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzZDk4M2JhNTNkZDk0 OGI0NmVjYmRjNzkwZWU3OGYwYjM5OGQzZjgwLi4xYmM0MmY2OTUwOTMxNzE1M2FiODk0MzI5ODA2 MDdhYzg4NDI2ZTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMC0yNiAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEFsbG93IGltcGxpY2l0IGNvbnZlcnNpb24gYmV0d2VlbiBnZng6OlZlY3RvcjJkIGFuZCBXZWJT aXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1 NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg Z2Z4OjpWZWN0b3IyZCBjbGFzcyBpcyB1c2VkIGluIGNocm9taXVtIGZvciBkZWZpbmluZyBkaXN0 YW5jZXMuIFRoZQorICAgICAgICBJbnRTaXplIGNsYXNzIGlzIHVzZWQgZXF1aXZhbGVudGx5IGlu c2lkZSBXZWJDb3JlLiBUaGlzIGxldCdzIHVzIGNvbnZlcnQKKyAgICAgICAgYmV0d2VlbiB2ZWN0 b3JzIGFuZCBzaXplcyBhbG9uZyB0aGUgQVBJIGJvdW5kYXJ5LgorCisgICAgICAgICogY2hyb21p dW0vcHVibGljL1dlYlNpemUuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViU2l6ZTo6V2ViU2l6ZSk6 CisgICAgICAgIChXZWJTaXplKToKKyAgICAgICAgKFdlYktpdDo6V2ViU2l6ZTo6b3BlcmF0b3I9 KToKKyAgICAgICAgKFdlYktpdDo6V2ViU2l6ZTo6b3BlcmF0b3IgZ2Z4OjpWZWN0b3IyZCk6CisK IDIwMTItMTAtMjMgIERhdmlkIFJldmVtYW4gIDxyZXZlbWFuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbQ2hyb21pdW1dIEFkZCBDSFJPTUlVTV90ZXh0dXJlX2Zyb21faW1hZ2UgZXh0ZW5zaW9u IHN1cHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dl YlNpemUuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCmluZGV4 IDk0YTUzNjU0ZDU4NzQxNDIyMzBmZjNlZTg2MTNlYmVjZjU1NmFlZWUuLjk3YTI3OTljNWMzMTcx MGRlYzk3NDQ1N2ExMDA2NzFhZTdiNGY4YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9w dWJsaWMvV2ViU2l6ZS5oCkBAIC0zNyw2ICszNyw3IEBACiAjaW5jbHVkZSAiSW50U2l6ZS5oIgog I2Vsc2UKICNpbmNsdWRlIDx1aS9nZngvc2l6ZS5oPgorI2luY2x1ZGUgPHVpL2dmeC92ZWN0b3Iy ZC5oPgogI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtODQsNiArODUsMTIgQEAgc3Ry dWN0IFdlYlNpemUgewogICAgIHsKICAgICB9CiAKKyAgICBXZWJTaXplKGNvbnN0IGdmeDo6VmVj dG9yMmQmIHYpCisgICAgICAgIDogd2lkdGgodi54KCkpCisgICAgICAgICwgaGVpZ2h0KHYueSgp KQorICAgIHsKKyAgICB9CisKICAgICBXZWJTaXplJiBvcGVyYXRvcj0oY29uc3QgZ2Z4OjpTaXpl JiBzKQogICAgIHsKICAgICAgICAgd2lkdGggPSBzLndpZHRoKCk7CkBAIC05MSwxMCArOTgsMjIg QEAgc3RydWN0IFdlYlNpemUgewogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQogCisgICAg V2ViU2l6ZSYgb3BlcmF0b3I9KGNvbnN0IGdmeDo6VmVjdG9yMmQmIHYpCisgICAgeworICAgICAg ICB3aWR0aCA9IHYueCgpOworICAgICAgICBoZWlnaHQgPSB2LnkoKTsKKyAgICAgICAgcmV0dXJu ICp0aGlzOworICAgIH0KKwogICAgIG9wZXJhdG9yIGdmeDo6U2l6ZSgpIGNvbnN0CiAgICAgewog ICAgICAgICByZXR1cm4gZ2Z4OjpTaXplKHdpZHRoLCBoZWlnaHQpOwogICAgIH0KKworICAgIG9w ZXJhdG9yIGdmeDo6VmVjdG9yMmQoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGdmeDo6 VmVjdG9yMmQod2lkdGgsIGhlaWdodCk7CisgICAgfQogI2VuZGlmCiB9OwogCg== 170992 2012-10-26 13:30:36 -0700 2012-11-01 11:36:52 -0700 Patch bug-100553-20121026162908.patch text/plain 2097 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzZDk4M2JhNTNkZDk0 OGI0NmVjYmRjNzkwZWU3OGYwYjM5OGQzZjgwLi5lNjkwNDU3MGRhYWU5NmU3M2IyMGE4ZDRiMTRl NmUwMjk2YTU2ODU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMC0yNiAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEFsbG93IGltcGxpY2l0IGNvbnZlcnNpb24gYmV0d2VlbiBnZng6OlZlY3RvcjJkIGFuZCBXZWJT aXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1 NTMKKworICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KKworICAgICAgICBUaGUg Z2Z4OjpWZWN0b3IyZCBjbGFzcyBpcyB1c2VkIGluIGNocm9taXVtIGZvciBkZWZpbmluZyBkaXN0 YW5jZXMuIFRoZQorICAgICAgICBJbnRTaXplIGNsYXNzIGlzIHVzZWQgZXF1aXZhbGVudGx5IGlu c2lkZSBXZWJDb3JlLiBUaGlzIGxldHMgdXMgY29udmVydAorICAgICAgICBiZXR3ZWVuIHZlY3Rv cnMgYW5kIHNpemVzIGFsb25nIHRoZSBBUEkgYm91bmRhcnkuCisKKyAgICAgICAgKiBjaHJvbWl1 bS9wdWJsaWMvV2ViU2l6ZS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJTaXplOjpXZWJTaXplKToK KyAgICAgICAgKFdlYlNpemUpOgorICAgICAgICAoV2ViS2l0OjpXZWJTaXplOjpvcGVyYXRvcj0p OgorICAgICAgICAoV2ViS2l0OjpXZWJTaXplOjpvcGVyYXRvciBnZng6OlZlY3RvcjJkKToKKwog MjAxMi0xMC0yMyAgRGF2aWQgUmV2ZW1hbiAgPHJldmVtYW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtDaHJvbWl1bV0gQWRkIENIUk9NSVVNX3RleHR1cmVfZnJvbV9pbWFnZSBleHRlbnNpb24g c3VwcG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi U2l6ZS5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJTaXplLmgKaW5kZXgg OTRhNTM2NTRkNTg3NDE0MjIzMGZmM2VlODYxM2ViZWNmNTU2YWVlZS4uOTdhMjc5OWM1YzMxNzEw ZGVjOTc0NDU3YTEwMDY3MWFlN2I0ZjhiZSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2No cm9taXVtL3B1YmxpYy9XZWJTaXplLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJTaXplLmgKQEAgLTM3LDYgKzM3LDcgQEAKICNpbmNsdWRlICJJbnRTaXplLmgiCiAj ZWxzZQogI2luY2x1ZGUgPHVpL2dmeC9zaXplLmg+CisjaW5jbHVkZSA8dWkvZ2Z4L3ZlY3RvcjJk Lmg+CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC04NCw2ICs4NSwxMiBAQCBzdHJ1 Y3QgV2ViU2l6ZSB7CiAgICAgewogICAgIH0KIAorICAgIFdlYlNpemUoY29uc3QgZ2Z4OjpWZWN0 b3IyZCYgdikKKyAgICAgICAgOiB3aWR0aCh2LngoKSkKKyAgICAgICAgLCBoZWlnaHQodi55KCkp CisgICAgeworICAgIH0KKwogICAgIFdlYlNpemUmIG9wZXJhdG9yPShjb25zdCBnZng6OlNpemUm IHMpCiAgICAgewogICAgICAgICB3aWR0aCA9IHMud2lkdGgoKTsKQEAgLTkxLDEwICs5OCwyMiBA QCBzdHJ1Y3QgV2ViU2l6ZSB7CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKKyAgICBX ZWJTaXplJiBvcGVyYXRvcj0oY29uc3QgZ2Z4OjpWZWN0b3IyZCYgdikKKyAgICB7CisgICAgICAg IHdpZHRoID0gdi54KCk7CisgICAgICAgIGhlaWdodCA9IHYueSgpOworICAgICAgICByZXR1cm4g KnRoaXM7CisgICAgfQorCiAgICAgb3BlcmF0b3IgZ2Z4OjpTaXplKCkgY29uc3QKICAgICB7CiAg ICAgICAgIHJldHVybiBnZng6OlNpemUod2lkdGgsIGhlaWdodCk7CiAgICAgfQorCisgICAgb3Bl cmF0b3IgZ2Z4OjpWZWN0b3IyZCgpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gZ2Z4OjpW ZWN0b3IyZCh3aWR0aCwgaGVpZ2h0KTsKKyAgICB9CiAjZW5kaWYKIH07CiAK