100552 2012-10-26 12:03:05 -0700 Regression(r132647)-Enable WebGL in EwkView. 2012-10-30 08:46:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 100232 0 kondapallykalyan webkit-unassigned cdumez gyuyoung.kim lucas.de.marchi mikhail.pozdnyakov rakuco webkit.review.bot oldest_to_newest 752256 0 170981 kondapallykalyan 2012-10-26 12:03:05 -0700 Created attachment 170981 enable webgl Webgl seems to be enabled with http://trac.webkit.org/changeset/132627 . But some of the changes seem lost after http://trac.webkit.org/changeset/132647 . i.e setWebGLEnabled(true); in EwkViewImpl.cpp Bringing back the change. 752277 1 170981 yael 2012-10-26 12:23:42 -0700 Comment on attachment 170981 enable webgl Please add a changelog, and if you want this patch reviewed, you need to set the review flag. 752406 2 kondapallykalyan 2012-10-26 14:30:12 -0700 changing the bug title 752430 3 kondapallykalyan 2012-10-26 14:40:09 -0700 changing the bug title (In reply to comment #1) > (From update of attachment 170981 [details]) > Please add a changelog, and if you want this patch reviewed, you need to set the review flag. Yes, Preparing a new patch with it 752441 4 171019 kondapallykalyan 2012-10-26 14:50:57 -0700 Created attachment 171019 enable webgl ChangeLog was missing in the previous patch.Uploading a new patch with ChangeLog 752463 5 webkit.review.bot 2012-10-26 15:01:04 -0700 Attachment 171019 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:128: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 752522 6 171019 kenneth 2012-10-26 15:59:37 -0700 Comment on attachment 171019 enable webgl View in context: https://bugs.webkit.org/attachment.cgi?id=171019&action=review > Source/WebKit2/ChangeLog:8 > + Webgl is enabled with http://trac.webkit.org/changeset/132627. WebGL* > Source/WebKit2/ChangeLog:9 > + But some of the changes seem lost after http://trac.webkit.org/changeset/132647. seems is a bit vague, you need to make us confident of your change >> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:128 >> + //Enable Webgl Support > > Should have a space between // and comment [whitespace/comments] [4] This comments should be actual sentences. Ie. a space after // and a punctuation mark at the end. In this case the comment doesn't add any value, so it should be removed 752600 7 171055 kondapallykalyan 2012-10-26 17:13:07 -0700 Created attachment 171055 enable webgl Changes done as per the review 754137 8 171055 kenneth 2012-10-30 02:58:00 -0700 Comment on attachment 171055 enable webgl View in context: https://bugs.webkit.org/attachment.cgi?id=171055&action=review > Source/WebKit2/ChangeLog:8 > + WebGL is enabled with the following changeset: http://trac.webkit.org/changeset/132627 . I would just remove the . > Source/WebKit2/ChangeLog:10 > + But some of the changes are lost after the following changeset: http://trac.webkit.org/changeset/132647 . > + i.e setWebGLEnabled(true); in EwkViewImpl.cpp Bringing back the change. Bringing... seems like a new sentence. 754176 9 171055 gyuyoung.kim 2012-10-30 03:52:11 -0700 Comment on attachment 171055 enable webgl View in context: https://bugs.webkit.org/attachment.cgi?id=171055&action=review > Source/WebKit2/ChangeLog:3 > + [EFL][WK2][AC] Enable Webgl in EwkView. Bug title is different from this. Regression(r132647) - enable Webgl in EwkView 754358 10 171450 kalyan.kondapally 2012-10-30 07:40:19 -0700 Created attachment 171450 enablewebgl review changes 754361 11 kondapallykalyan 2012-10-30 07:45:38 -0700 bug title update 754398 12 171450 webkit.review.bot 2012-10-30 08:46:17 -0700 Comment on attachment 171450 enablewebgl Clearing flags on attachment: 171450 Committed r132912: <http://trac.webkit.org/changeset/132912> 754399 13 webkit.review.bot 2012-10-30 08:46:22 -0700 All reviewed patches have been landed. Closing bug. 170981 2012-10-26 12:03:05 -0700 2012-10-26 14:50:57 -0700 enable webgl webglenable.patch text/plain 1080 kondapallykalyan RnJvbSAzZDk5YmYxZTFiOTIxNDllMmVjYWFiOTNkYWI2ZDlhM2Q5NWJkODhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25kYXBhbGx5IEthbHlhbiA8a29uZGFwYWxseWthbHlhbkBn bWFpbC5jb20+CkRhdGU6IEZyaSwgMjYgT2N0IDIwMTIgMjA6MjA6MDIgKzAzMDAKU3ViamVjdDog W1BBVENIXSBFbmFibGluZyBXZWJnbC4gVGhpcyB3YXMgZG9uZSB3aXRoIENoYW5nZXNldCAxMzI2 MjcgYnV0CiBzZWVtcyBsb3N0IGFmdGVyIGNoYW5nZXNldCAxMzI2NDcKCi0tLQogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwIHwgICAgMyArKysKIDEgZmls ZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAKaW5kZXggMjRhZjYyYi4uNGIwNTY2NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcApAQCAt MTI1LDYgKzEyNSw5IEBAIEV3a1ZpZXdJbXBsOjpFd2tWaWV3SW1wbChFdmFzX09iamVjdCogdmll dywgUGFzc1JlZlB0cjxFd2tfQ29udGV4dD4gY29udGV4dCwgUGFzCiAjaWYgVVNFKENPT1JESU5B VEVEX0dSQVBISUNTKQogICAgIG1fcGFnZVByb3h5LT5wYWdlR3JvdXAoKS0+cHJlZmVyZW5jZXMo KS0+c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQodHJ1ZSk7CiAgICAgbV9wYWdlUHJv eHktPnBhZ2VHcm91cCgpLT5wcmVmZXJlbmNlcygpLT5zZXRGb3JjZUNvbXBvc2l0aW5nTW9kZSh0 cnVlKTsKKyNpZiBFTkFCTEUoV0VCR0wpCisgICAgbV9wYWdlUHJveHktPnBhZ2VHcm91cCgpLT5w cmVmZXJlbmNlcygpLT5zZXRXZWJHTEVuYWJsZWQodHJ1ZSk7CisjZW5kaWYKICAgICBtX3BhZ2VQ cm94eS0+c2V0VXNlRml4ZWRMYXlvdXQodHJ1ZSk7CiAjZW5kaWYKIAotLSAKMS43LjkuNQoK 171019 2012-10-26 14:50:57 -0700 2012-10-26 17:13:07 -0700 enable webgl webglpatch.patch text/plain 1558 kondapallykalyan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwYzAyMWYwLi43Mjc5MWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTAtMjYgIEtvbmRhcGFsbHkgS2FseWFuICA8a29uZGFwYWxseWthbHlhbkBnbWFp bC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXVtBQ10gRW5hYmxlIFdlYmdsIGluIEV3a1ZpZXcu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1NTIu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViZ2wg aXMgZW5hYmxlZCB3aXRoIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMjYyNy4K KyAgICAgICAgQnV0IHNvbWUgb2YgdGhlIGNoYW5nZXMgc2VlbSBsb3N0IGFmdGVyIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMjY0Ny4KKyAgICAgICAgaS5lIHNldFdlYkdMRW5h YmxlZCh0cnVlKTsgIGluIEV3a1ZpZXdJbXBsLmNwcCBCcmluZ2luZyBiYWNrIHRoZSBjaGFuZ2Uu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHA6CisgICAgICAg IChFd2tWaWV3SW1wbDo6RXdrVmlld0ltcGwpOgorCiAyMDEyLTEwLTI2ICBDaHJpc3RvcGhlIER1 bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CgogICAgICAgICBbRUZMXVtXSzJdIEdl dCByaWQgb2YgQydpc20gaW4gdGV4dCBjaGVja2VyIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCmluZGV4IDI0YWY2MmIuLjc4ODUwYjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5j cHAKQEAgLTEyNSw2ICsxMjUsMTAgQEAgRXdrVmlld0ltcGw6OkV3a1ZpZXdJbXBsKEV2YXNfT2Jq ZWN0KiB2aWV3LCBQYXNzUmVmUHRyPEV3a19Db250ZXh0PiBjb250ZXh0LCBQYXMKICNpZiBVU0Uo Q09PUkRJTkFURURfR1JBUEhJQ1MpCiAgICAgbV9wYWdlUHJveHktPnBhZ2VHcm91cCgpLT5wcmVm ZXJlbmNlcygpLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCh0cnVlKTsKICAgICBt X3BhZ2VQcm94eS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldEZvcmNlQ29tcG9zaXRp bmdNb2RlKHRydWUpOworICAgIC8vRW5hYmxlIFdlYmdsIFN1cHBvcnQKKyNpZiBFTkFCTEUoV0VC R0wpCisgICAgbV9wYWdlUHJveHktPnBhZ2VHcm91cCgpLT5wcmVmZXJlbmNlcygpLT5zZXRXZWJH TEVuYWJsZWQodHJ1ZSk7CisjZW5kaWYKICAgICBtX3BhZ2VQcm94eS0+c2V0VXNlRml4ZWRMYXlv dXQodHJ1ZSk7CiAjZW5kaWYKCg== 171055 2012-10-26 17:13:07 -0700 2012-10-30 07:45:57 -0700 enable webgl webglsettings.patch text/plain 1581 kondapallykalyan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwYzAyMWYwLi43Mjc5MWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTAtMjYgIEtvbmRhcGFsbHkgS2FseWFuICA8a29uZGFwYWxseWthbHlhbkBnbWFp bC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXVtBQ10gRW5hYmxlIFdlYmdsIGluIEV3a1ZpZXcu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1NTIu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViR0wg aXMgZW5hYmxlZCB3aXRoIHRoZSBmb2xsb3dpbmcgY2hhbmdlc2V0OiBodHRwOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC8xMzI2MjcgLgorICAgICAgICBCdXQgc29tZSBvZiB0aGUgY2hhbmdl cyBhcmUgbG9zdCBhZnRlciB0aGUgZm9sbG93aW5nIGNoYW5nZXNldDogaHR0cDovL3RyYWMud2Vi a2l0Lm9yZy9jaGFuZ2VzZXQvMTMyNjQ3IC4KKyAgICAgICAgaS5lIHNldFdlYkdMRW5hYmxlZCh0 cnVlKTsgIGluIEV3a1ZpZXdJbXBsLmNwcCBCcmluZ2luZyBiYWNrIHRoZSBjaGFuZ2UuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHA6CisgICAgICAgIChFd2tW aWV3SW1wbDo6RXdrVmlld0ltcGwpOgorCiAyMDEyLTEwLTI2ICBDaHJpc3RvcGhlIER1bWV6ICA8 Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CgogICAgICAgICBbRUZMXVtXSzJdIEdldCByaWQg b2YgQydpc20gaW4gdGV4dCBjaGVja2VyIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCmluZGV4IDQzYTMzNjMuLjdjYWNkZTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAKQEAg LTEyNSw2ICsxMjUsOSBAQCBFd2tWaWV3SW1wbDo6RXdrVmlld0ltcGwoRXZhc19PYmplY3QqIHZp ZXcsIFBhc3NSZWZQdHI8RXdrX0NvbnRleHQ+IGNvbnRleHQsIFBhcwogI2lmIFVTRShDT09SRElO QVRFRF9HUkFQSElDUykKICAgICBtX3BhZ2VQcm94eS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2Vz KCktPnNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKHRydWUpOwogICAgIG1fcGFnZVBy b3h5LT5wYWdlR3JvdXAoKS0+cHJlZmVyZW5jZXMoKS0+c2V0Rm9yY2VDb21wb3NpdGluZ01vZGUo dHJ1ZSk7CisjaWYgRU5BQkxFKFdFQkdMKQorICAgIG1fcGFnZVByb3h5LT5wYWdlR3JvdXAoKS0+ cHJlZmVyZW5jZXMoKS0+c2V0V2ViR0xFbmFibGVkKHRydWUpOworI2VuZGlmCiAgICAgbV9wYWdl UHJveHktPnNldFVzZUZpeGVkTGF5b3V0KHRydWUpOwogI2VuZGlmCgoK 171450 2012-10-30 07:40:19 -0700 2012-10-30 08:46:17 -0700 enablewebgl webglchange.patch text/plain 1590 kalyan.kondapally ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkZGIzNzk4Li4yYzI5ZTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMzAgIEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50 ZWwuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb24ocjEzMjY0NyktRW5hYmxlIFdlYkdMIGluIEV3 a1ZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDA1NTIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2ViR0wgaXMgZW5hYmxlZCB3aXRoIGZvbGxvd2luZyBjaGFuZ2VzZXQ6IGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzEzMjYyNy4KKyAgICAgICAgU29tZSBjaGFuZ2VzIGFyZSBsb3N0 IGFmdGVyIHRoZSBmb2xsb3dpbmcgY2hhbmdlc2V0OiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2No YW5nZXNldC8xMzI2NDcKKyAgICAgICAgaS5lIHNldFdlYkdMRW5hYmxlZCh0cnVlKTsgIGluIEV3 a1ZpZXdJbXBsLmNwcC4KKyAgICAgICAgVGhpcyBwYXRjaCByZS1hcHBsaWVzIHRoZSBsb3N0IGNo YW5nZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHA6Cisg ICAgICAgIChFd2tWaWV3SW1wbDo6RXdrVmlld0ltcGwpOgorCiAyMDEyLTEwLTI5ICBSYXBoYWVs IEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgoKICAgICAg ICAgVW5yZXZpZXdlZCBidWlsZCBmaXggYWZ0ZXIgcjEzMjcwOS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAppbmRleCBmNTRkNzZmLi44N2M5 NmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3 SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0lt cGwuY3BwCkBAIC0xMjUsNiArMTI1LDkgQEAgRXdrVmlld0ltcGw6OkV3a1ZpZXdJbXBsKEV2YXNf T2JqZWN0KiB2aWV3LCBQYXNzUmVmUHRyPEV3a19Db250ZXh0PiBjb250ZXh0LCBQYXMKICNpZiBV U0UoQ09PUkRJTkFURURfR1JBUEhJQ1MpCiAgICAgbV9wYWdlUHJveHktPnBhZ2VHcm91cCgpLT5w cmVmZXJlbmNlcygpLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCh0cnVlKTsKICAg ICBtX3BhZ2VQcm94eS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldEZvcmNlQ29tcG9z aXRpbmdNb2RlKHRydWUpOworI2lmIEVOQUJMRShXRUJHTCkKKyAgICBtX3BhZ2VQcm94eS0+cGFn ZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldFdlYkdMRW5hYmxlZCh0cnVlKTsKKyNlbmRpZgog ICAgIG1fcGFnZVByb3h5LT5zZXRVc2VGaXhlZExheW91dCh0cnVlKTsKICNlbmRpZgoK