10054 2006-07-21 15:47:25 -0700 ICU should be abstracted out from WebCore 2006-12-10 01:54:48 -0800 1 1 1 Unclassified WebKit Platform 420+ All All RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned ap hyatt mitz sam oldest_to_newest 50515 0 koivisto 2006-07-21 15:47:25 -0700 ICU library can not be used on all platforms. For example it is far too big to use in mobile devices. There should be a unicode abstraction layer (like JSC already has) which can map to ICU or some platform functionality. Creating a bug for tracking this. 50532 1 sam 2006-07-21 20:22:36 -0700 George Staikos has begun doing just this on the Unity project (branch?) and I am looking into working it back into the trunk. 42695 2 ap 2006-12-09 02:20:29 -0800 Done by Lars Knoll and Hyatt in r18098. 42541 3 ddkilzer 2006-12-09 03:56:46 -0800 (In reply to comment #2) > Done by Lars Knoll and Hyatt in r18098. Follow-up build fixes in r18099-r18105. 42543 4 ap 2006-12-09 04:03:35 -0800 > > Done by Lars Knoll and Hyatt in r18098. > Follow-up build fixes in r18099-r18105. This change has caused a failure in tables/mozilla/bugs/bug33855.html 42565 5 mitz 2006-12-10 00:28:07 -0800 (In reply to comment #4) > > > Done by Lars Knoll and Hyatt in r18098. > > Follow-up build fixes in r18099-r18105. > > This change has caused a failure in tables/mozilla/bugs/bug33855.html > Specifically this change in StringImpl.cpp: - return c <= 0x7F ? isspace(c) : (u_charDirection(c) == U_WHITE_SPACE_NEUTRAL); + return c <= 0x7F ? isspace(c) : WTF::Unicode::isSpace(c); 42566 6 hyatt 2006-12-10 00:35:41 -0800 Heh I caught that line in review and asked if it was still equivalent. I guess it isn't. 42567 7 hyatt 2006-12-10 00:49:11 -0800 Let's get a regression bug filed. 42569 8 mitz 2006-12-10 01:54:48 -0800 (In reply to comment #7) > Let's get a regression bug filed. > Bug 11795.