100523 2012-10-26 07:47:36 -0700 [Qt] MiniBrowser segfaults on exit after using WebGL. 2012-10-26 10:19:45 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno oldest_to_newest 752043 0 zeno 2012-10-26 07:47:36 -0700 In GraphicsSurfaceGLX the display connection must not be closed before destroying the offscreen window. 752044 1 170927 zeno 2012-10-26 07:49:09 -0700 Created attachment 170927 patch for review. 752050 2 170927 kenneth 2012-10-26 07:51:35 -0700 Comment on attachment 170927 patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=170927&action=review > Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:61 > + Window getXWindow() OffscreenXWindow? it actually feels more like a create method 752056 3 170927 zeno 2012-10-26 07:59:47 -0700 Comment on attachment 170927 patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=170927&action=review >> Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:61 >> + Window getXWindow() > > OffscreenXWindow? it actually feels more like a create method I was thinking about how to name these things properly as well. It is a create method, but only for a single instance. So it feels more like a get to me. (implicit creation) OffScreenRootWindow::getOffscreenXWindow() somehow feels very redundant as well, doesn't it? 752060 4 170927 kenneth 2012-10-26 08:07:19 -0700 Comment on attachment 170927 patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=170927&action=review >>> Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:61 >>> + Window getXWindow() >> >> OffscreenXWindow? it actually feels more like a create method > > I was thinking about how to name these things properly as well. > It is a create method, but only for a single instance. So it feels more like a get to me. (implicit creation) > OffScreenRootWindow::getOffscreenXWindow() somehow feels very redundant as well, doesn't it? You are right. It is fine! 752158 5 170927 zeno 2012-10-26 10:19:40 -0700 Comment on attachment 170927 patch for review. Clearing flags on attachment: 170927 Committed r132671: <http://trac.webkit.org/changeset/132671> 752159 6 zeno 2012-10-26 10:19:45 -0700 All reviewed patches have been landed. Closing bug. 170927 2012-10-26 07:49:09 -0700 2012-10-26 10:19:40 -0700 patch for review. 100523_20121026-164722.patch text/plain 5268 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlYzg5NTY1Li5lMDM5NTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTItMTAtMjYgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XSBNaW5pQnJvd3NlciBzZWdmYXVsdHMgb24gZXhpdCBhZnRlciB1c2luZyBXZWJHTC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDUyMwor CisgICAgICAgIFRoZSBkaXNwbGF5IGNvbm5lY3Rpb24gbXVzdCBub3QgYmUgY2xvc2VkIGJlZm9y ZQorICAgICAgICBkZXN0cm95aW5nIHRoZSBvZmZzY3JlZW4gd2luZG93LgorICAgICAgICBUaGVy ZWZvcmUgb3BlbmluZyB0aGUgY29ubmVjdGlvbiBpcyBtb3ZlZCB0byB0aGUKKyAgICAgICAgZ2V0 WFdpbmRvdygpIGZ1bmN0aW9uLiBBbmQgY2xvc2luZyB0aGUgY29ubmVjdGlvbgorICAgICAgICBp cyBiZWluZyBtb3ZlZCB0byB0aGUgZGVzdHJ1Y3RvciBvZiB0aGUgb2Zmc2NyZWVuIHdpbmRvdy4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok9mZlNjcmVlblJvb3RXaW5kb3c6Ok9mZlNjcmVlblJvb3RXaW5kb3cpOgor ICAgICAgICAoV2ViQ29yZTo6T2ZmU2NyZWVuUm9vdFdpbmRvdzo6Z2V0WFdpbmRvdyk6CisgICAg ICAgIChPZmZTY3JlZW5Sb290V2luZG93KToKKyAgICAgICAgKFdlYkNvcmU6Ok9mZlNjcmVlblJv b3RXaW5kb3c6OmRpc3BsYXkpOgorICAgICAgICAoV2ViQ29yZTo6T2ZmU2NyZWVuUm9vdFdpbmRv dzo6fk9mZlNjcmVlblJvb3RXaW5kb3cpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc1N1cmZhY2VQcml2YXRlOjpHcmFwaGljc1N1cmZhY2VQcml2YXRlKToK KyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzU3VyZmFjZVByaXZhdGU6On5HcmFwaGljc1N1cmZh Y2VQcml2YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzU3VyZmFjZVByaXZhdGU6OmNy ZWF0ZVN1cmZhY2UpOgorCiAyMDEyLTEwLTI2ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIHRoZSBvbi1ob3Zl ciBoaWdobGlnaHRpbmcgb2YgY29uc29sZSBtZXNzYWdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL3F0L0dyYXBoaWNz U3VyZmFjZUdMWC5jcHAKaW5kZXggMGUwZDc1Yi4uYmUwMGZhNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xY LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9xdC9H cmFwaGljc1N1cmZhY2VHTFguY3BwCkBAIC01NSw0MCArNTUsNTEgQEAgY2xhc3MgT2ZmU2NyZWVu Um9vdFdpbmRvdyB7CiBwdWJsaWM6CiAgICAgT2ZmU2NyZWVuUm9vdFdpbmRvdygpCiAgICAgewot ICAgICAgICArK3JlZkNvdW50OworICAgICAgICArK21fcmVmQ291bnQ7CiAgICAgfQogCi0gICAg V2luZG93KiBnZXQoRGlzcGxheSogZHB5KQorICAgIFdpbmRvdyBnZXRYV2luZG93KCkKICAgICB7 Ci0gICAgICAgIGlmICghd2luZG93KSB7Ci0gICAgICAgICAgICB3aW5kb3cgPSBYQ3JlYXRlU2lt cGxlV2luZG93KGRweSwgWERlZmF1bHRSb290V2luZG93KGRweSksIC0xLCAtMSwgMSwgMSwgMCwg QmxhY2tQaXhlbChkcHksIDApLCBXaGl0ZVBpeGVsKGRweSwgMCkpOworICAgICAgICBpZiAoIW1f d2luZG93KSB7CisgICAgICAgICAgICBEaXNwbGF5KiBkcHkgPSBkaXNwbGF5KCk7CisgICAgICAg ICAgICBtX3dpbmRvdyA9IFhDcmVhdGVTaW1wbGVXaW5kb3coZHB5LCBYRGVmYXVsdFJvb3RXaW5k b3coZHB5KSwgLTEsIC0xLCAxLCAxLCAwLCBCbGFja1BpeGVsKGRweSwgMCksIFdoaXRlUGl4ZWwo ZHB5LCAwKSk7CiAgICAgICAgICAgICBYU2V0V2luZG93QXR0cmlidXRlcyBhdHRyaWJ1dGVzOwog ICAgICAgICAgICAgYXR0cmlidXRlcy5vdmVycmlkZV9yZWRpcmVjdCA9IHRydWU7Ci0gICAgICAg ICAgICBYQ2hhbmdlV2luZG93QXR0cmlidXRlcyhkcHksIHdpbmRvdywgWDExT3ZlcnJpZGVSZWRp cmVjdCwgJmF0dHJpYnV0ZXMpOwotICAgICAgICAgICAgZGlzcGxheSA9IGRweTsKKyAgICAgICAg ICAgIFhDaGFuZ2VXaW5kb3dBdHRyaWJ1dGVzKGRweSwgbV93aW5kb3csIFgxMU92ZXJyaWRlUmVk aXJlY3QsICZhdHRyaWJ1dGVzKTsKICAgICAgICAgICAgIC8vIE1hcCB3aW5kb3cgdG8gdGhlIHNj cmVlbgotICAgICAgICAgICAgWE1hcFdpbmRvdyhkcHksIHdpbmRvdyk7CisgICAgICAgICAgICBY TWFwV2luZG93KGRweSwgbV93aW5kb3cpOwogICAgICAgICB9CiAKLSAgICAgICAgcmV0dXJuICZ3 aW5kb3c7CisgICAgICAgIHJldHVybiBtX3dpbmRvdzsKKyAgICB9CisKKyAgICBEaXNwbGF5KiBk aXNwbGF5KCkKKyAgICB7CisgICAgICAgIGlmICghbV9kaXNwbGF5KQorICAgICAgICAgICAgbV9k aXNwbGF5ID0gWE9wZW5EaXNwbGF5KDApOworICAgICAgICByZXR1cm4gbV9kaXNwbGF5OwogICAg IH0KIAogICAgIH5PZmZTY3JlZW5Sb290V2luZG93KCkKICAgICB7Ci0gICAgICAgIGlmICghLS1y ZWZDb3VudCkgewotICAgICAgICAgICAgWFVubWFwV2luZG93KGRpc3BsYXksIHdpbmRvdyk7Ci0g ICAgICAgICAgICBYRGVzdHJveVdpbmRvdyhkaXNwbGF5LCB3aW5kb3cpOworICAgICAgICBpZiAo IS0tbV9yZWZDb3VudCkgeworICAgICAgICAgICAgWFVubWFwV2luZG93KG1fZGlzcGxheSwgbV93 aW5kb3cpOworICAgICAgICAgICAgWERlc3Ryb3lXaW5kb3cobV9kaXNwbGF5LCBtX3dpbmRvdyk7 CisgICAgICAgICAgICBpZiAobV9kaXNwbGF5KQorICAgICAgICAgICAgICAgIFhDbG9zZURpc3Bs YXkobV9kaXNwbGF5KTsKKyAgICAgICAgICAgIG1fZGlzcGxheSA9IDA7CiAgICAgICAgIH0KICAg ICB9CiAKIHByaXZhdGU6Ci0gICAgc3RhdGljIGludCByZWZDb3VudDsKLSAgICBzdGF0aWMgV2lu ZG93IHdpbmRvdzsKLSAgICBEaXNwbGF5KiBkaXNwbGF5OworICAgIHN0YXRpYyBpbnQgbV9yZWZD b3VudDsKKyAgICBzdGF0aWMgV2luZG93IG1fd2luZG93OworICAgIHN0YXRpYyBEaXNwbGF5KiBt X2Rpc3BsYXk7CiB9OwogCi1pbnQgT2ZmU2NyZWVuUm9vdFdpbmRvdzo6cmVmQ291bnQgPSAwOwot V2luZG93IE9mZlNjcmVlblJvb3RXaW5kb3c6OndpbmRvdyA9IDA7CitpbnQgT2ZmU2NyZWVuUm9v dFdpbmRvdzo6bV9yZWZDb3VudCA9IDA7CitXaW5kb3cgT2ZmU2NyZWVuUm9vdFdpbmRvdzo6bV93 aW5kb3cgPSAwOworRGlzcGxheSogT2ZmU2NyZWVuUm9vdFdpbmRvdzo6bV9kaXNwbGF5ID0gMDsK IAogc3RhdGljIGNvbnN0IGludCBnbHhTcGVjW10gPSB7CiAgICAgLy8gVGhlIHNwZWNpZmljYXRp b24gaXMgYSBzZXQga2V5IHZhbHVlIHBhaXJzIHN0b3JlZCBpbiBhIHNpbXBsZSBhcnJheS4KQEAg LTE0Myw2ICsxNTQsNyBAQCBzdHJ1Y3QgR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZSB7CiAgICAgICAg IH0KICNlbmRpZgogCisgICAgICAgIG1fZGlzcGxheSA9IG1fb2ZmU2NyZWVuV2luZG93LmRpc3Bs YXkoKTsKICAgICAgICAgaW50IGF0dHJpYnV0ZXNbXSA9IHsKICAgICAgICAgICAgIEdMWF9MRVZF TCwgMCwKICAgICAgICAgICAgIEdMWF9EUkFXQUJMRV9UWVBFLCBHTFhfV0lORE9XX0JJVCwKQEAg LTE3MCw5ICsxODIsOCBAQCBzdHJ1Y3QgR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZSB7CiAgICAgICAg ICAgICBYRnJlZVBpeG1hcChtX2Rpc3BsYXksIG1feFBpeG1hcCk7CiAgICAgICAgIG1feFBpeG1h cCA9IDA7CiAKLSAgICAgICAgaWYgKG1fZGlzcGxheSkKLSAgICAgICAgICAgIFhDbG9zZURpc3Bs YXkobV9kaXNwbGF5KTsKLSAgICAgICAgbV9kaXNwbGF5ID0gMDsKKyAgICAgICAgaWYgKG1fZ2xD b250ZXh0KQorICAgICAgICAgICAgZ2xYRGVzdHJveUNvbnRleHQobV9kaXNwbGF5LCBtX2dsQ29u dGV4dCk7CiAgICAgfQogCiAgICAgdWludDMyX3QgY3JlYXRlU3VyZmFjZShjb25zdCBJbnRTaXpl JiBzaXplKQpAQCAtMTgxLDEyICsxOTIsMTIgQEAgc3RydWN0IEdyYXBoaWNzU3VyZmFjZVByaXZh dGUgewogICAgICAgICBpZiAoIXZpc3VhbEluZm8pCiAgICAgICAgICAgICByZXR1cm4gMDsKIAot ICAgICAgICBDb2xvcm1hcCBjbWFwID0gWENyZWF0ZUNvbG9ybWFwKG1fZGlzcGxheSwgKm1fb2Zm U2NyZWVuV2luZG93LmdldChtX2Rpc3BsYXkpLCB2aXN1YWxJbmZvLT52aXN1YWwsIEFsbG9jTm9u ZSk7CisgICAgICAgIENvbG9ybWFwIGNtYXAgPSBYQ3JlYXRlQ29sb3JtYXAobV9kaXNwbGF5LCBt X29mZlNjcmVlbldpbmRvdy5nZXRYV2luZG93KCksIHZpc3VhbEluZm8tPnZpc3VhbCwgQWxsb2NO b25lKTsKICAgICAgICAgWFNldFdpbmRvd0F0dHJpYnV0ZXMgYTsKICAgICAgICAgYS5iYWNrZ3Jv dW5kX3BpeGVsID0gV2hpdGVQaXhlbChtX2Rpc3BsYXksIDApOwogICAgICAgICBhLmJvcmRlcl9w aXhlbCA9IEJsYWNrUGl4ZWwobV9kaXNwbGF5LCAwKTsKICAgICAgICAgYS5jb2xvcm1hcCA9IGNt YXA7Ci0gICAgICAgIG1fc3VyZmFjZSA9IFhDcmVhdGVXaW5kb3cobV9kaXNwbGF5LCAqbV9vZmZT Y3JlZW5XaW5kb3cuZ2V0KG1fZGlzcGxheSksIDAsIDAsIHNpemUud2lkdGgoKSwgc2l6ZS5oZWln aHQoKSwKKyAgICAgICAgbV9zdXJmYWNlID0gWENyZWF0ZVdpbmRvdyhtX2Rpc3BsYXksIG1fb2Zm U2NyZWVuV2luZG93LmdldFhXaW5kb3coKSwgMCwgMCwgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdo dCgpLAogICAgICAgICAgICAgMCwgdmlzdWFsSW5mby0+ZGVwdGgsIElucHV0T3V0cHV0LCB2aXN1 YWxJbmZvLT52aXN1YWwsCiAgICAgICAgICAgICBDV0JhY2tQaXhlbCB8IENXQm9yZGVyUGl4ZWwg fCBDV0NvbG9ybWFwLCAmYSk7CiAgICAgICAgIFhTZXRXaW5kb3dCYWNrZ3JvdW5kUGl4bWFwKG1f ZGlzcGxheSwgbV9zdXJmYWNlLCAwKTsK