100498 2012-10-26 04:30:11 -0700 REGRESSION(r132589): Breaks font-face layout tests (Requested by pfeldman on #webkit). 2012-10-26 06:47:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100446 1 webkit.review.bot webkit.review.bot bashi mitz pfeldman oldest_to_newest 751847 0 webkit.review.bot 2012-10-26 04:30:11 -0700 http://trac.webkit.org/changeset/132589 broke the build: Breaks font-face layout tests (Requested by pfeldman on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 751849 1 170884 webkit.review.bot 2012-10-26 04:30:49 -0700 Created attachment 170884 ROLLOUT of r132589 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 751851 2 pfeldman 2012-10-26 04:31:33 -0700 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2Ffont-face-implicit-local-font.html%2Cfast%2Fcss%2Ffont-face-multiple-faces.html%2Csvg%2Fcustom%2Ffont-face-simple.svg%2Cfast%2Frepaint%2Fselection-after-remove.html 751867 3 170884 webkit.review.bot 2012-10-26 04:40:34 -0700 Comment on attachment 170884 ROLLOUT of r132589 Clearing flags on attachment: 170884 Committed r132620: <http://trac.webkit.org/changeset/132620> 751868 4 webkit.review.bot 2012-10-26 04:40:37 -0700 All reviewed patches have been landed. Closing bug. 751883 5 bashi 2012-10-26 04:52:55 -0700 This isn't a regression. These tests depend on how FontCache implicitly replaces font family. That's wrong. We need to update these tests. 751982 6 pfeldman 2012-10-26 06:47:29 -0700 (In reply to comment #5) > This isn't a regression. These tests depend on how FontCache implicitly replaces font family. That's wrong. We need to update these tests. I don't think so. The tests explicitly require different font families. I.e. either these tests are entirely wrong (should not exist) or you are introducing unexpected behavior change. 170884 2012-10-26 04:30:49 -0700 2012-10-26 04:40:34 -0700 ROLLOUT of r132589 bug-100498-20121026113714.patch text/plain 1596 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE1ZTZlZGExZTY3ODRh OGI2YWZiYjk4NjJmNjhjNmIwZTYyMTAzYy4uM2NiNDY5ZWU5MjBmYjIzOWJkYmU2OWZhMDcyMDJk YjU3NjNmZGU2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTI2ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTMyNTg5LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMzI1ODkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMDQ5OAorCisgICAgICAgIEJyZWFrcyBmb250LWZhY2UgbGF5b3V0IHRlc3Rz IChSZXF1ZXN0ZWQgYnkgcGZlbGRtYW4gb24KKyAgICAgICAgI3dlYmtpdCkuCisKKyAgICAgICAg KiBjc3MvQ1NTRm9udEZhY2VTb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTRm9udEZh Y2VTb3VyY2U6OmdldEZvbnREYXRhKToKKwogMjAxMi0xMC0yNiAgSmFlaHVuIExpbSAgPGxqYWVo dW4ubGltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtDTUFLRV0gQWRkIFRleHRBdXRvc2l6ZXIu Y3BwIGluIFdlYkNvcmUvQ01ha2VMaXN0cy50eHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NGb250RmFjZVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZh Y2VTb3VyY2UuY3BwCmluZGV4IDJmZDYzZjZmYWUwMDBmNDVkYzE1MjQyNzkxZjlkNDRkNmJmM2Rl NzYuLjVlNTI4OWY2ZDUyMjdhZTlmZDFjY2NhMjc0YjgxY2MxMmNlZDkxZGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU0ZvbnRGYWNlU291cmNlLmNwcApAQCAtMTA2LDggKzEwNiw3IEBAIFBhc3NS ZWZQdHI8U2ltcGxlRm9udERhdGE+IENTU0ZvbnRGYWNlU291cmNlOjpnZXRGb250RGF0YShjb25z dCBGb250RGVzY3JpcHRpb24mCiAjZW5kaWYKICAgICApIHsKICAgICAgICAgLy8gV2UncmUgbG9j YWwuIEp1c3QgcmV0dXJuIGEgU2ltcGxlRm9udERhdGEgZnJvbSB0aGUgbm9ybWFsIGNhY2hlLgot ICAgICAgICAvLyBXZSBkb24ndCB3YW50IHRvIGNoZWNrIGFsdGVybmF0ZSBmb250IGZhbWlseSBu YW1lcyBoZXJlLCBzbyBwYXNzIHRydWUgYXMgdGhlIGNoZWNraW5nQWx0ZXJuYXRlTmFtZSBwYXJh bWV0ZXIuCi0gICAgICAgIHJldHVybiBmb250Q2FjaGUoKS0+Z2V0Q2FjaGVkRm9udERhdGEoZm9u dERlc2NyaXB0aW9uLCBtX3N0cmluZywgdHJ1ZSk7CisgICAgICAgIHJldHVybiBmb250Q2FjaGUo KS0+Z2V0Q2FjaGVkRm9udERhdGEoZm9udERlc2NyaXB0aW9uLCBtX3N0cmluZyk7CiAgICAgfQog CiAgICAgLy8gU2VlIGlmIHdlIGhhdmUgYSBtYXBwaW5nIGluIG91ciBGb250RGF0YSBjYWNoZS4K