10049 2006-07-21 11:54:32 -0700 REGRESSION: thick focus ring is drawn around popup menus 2021-01-30 06:35:17 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 NEW http://www.superbus.co.il HasReduction, InRadar, Regression P1 Normal --- 1 ap webkit-unassigned aestes andersca dev+webkit emacemac7 jonathanjohnsson jonlee joost mbritto mitz myyodo simon.fraser oldest_to_newest 50496 0 ap 2006-07-21 11:54:32 -0700 Steps to reproduce: 1) Open <http://www.superbus.co.il>. 2) Open and close one of the popup menus in the top menu. Results: the focus ring apparently gets drawn multiple times, so it becomes solid color. 50520 1 darin 2006-07-21 19:47:31 -0700 Wow, that's a really neat effect! 51511 2 9842 jonathanjohnsson 2006-08-02 17:36:56 -0700 Created attachment 9842 Test case reduction 51512 3 jonathanjohnsson 2006-08-02 17:40:20 -0700 Changing to "HasReduction", even if it might be possible to make the current one shorter. I fiddled with it quite a bit without being able to reduce it more. 46680 4 slewis 2006-11-06 18:48:40 -0800 radar 4769769 34186 5 joost 2007-01-19 04:50:08 -0800 Why is this P1? Moving to P2... 34187 6 joost 2007-01-19 04:51:19 -0800 And I did notice that it's a regression, yet, somehow this doesn't seem that much of a priority to me :) 9788 7 mitz 2007-05-16 23:37:00 -0700 (In reply to comment #6) > And I did notice that it's a regression, yet, somehow this doesn't seem that > much of a priority to me :) > A variant of this bug, with a search field instead of a popup, affects <http://www.apple.com/buy/locator/>. 9785 8 hyatt 2007-05-16 23:42:20 -0700 Regression = p1. 2751 9 15883 mitz 2007-08-09 10:52:42 -0700 Created attachment 15883 Test case This test case demonstrates that the overpainting happens when WebHTMLView takes the "use unioned rect" code path, the focus ring lies in the "unioned rect" but not in any of the actual damaged rects. I think the reason is that in that case, the -[WebClipView _focusRingVisibleRect] includes the non-damaged area (which is clipped out for normal drawing). 2549 10 15926 mitz 2007-08-11 01:12:58 -0700 Created attachment 15926 Clip to the enclosing rectangle if you decide to paint all of it The idea here is that if WebHTMLView decides to paint the "unioned rect" instead of individual rects, it should clip to that. This patch may be a no-go due to performance considerations -- obviously the paint() methods will do the same amount of work, but maybe Core Graphics will have to work a lot harder. Another problem with this patch is that it makes the fast/repaint tests ineffective (another way to look at it is that it will often allow incremental repaint bugs to go unnoticed). And now while typing this comment I got the impression that this patch made "focus rings around text controls" bugs much more noticeable. 1068 11 mitz 2007-09-01 01:33:59 -0700 I'm also seeing doubly-painted focus rings in Gmail under certain Safari/OS combinations. 87130 12 ap 2008-07-28 02:20:27 -0700 Only the last reduction ("Test case") fails for me now. 238436 13 ap 2010-06-15 10:03:04 -0700 See also: bug 40597. 295030 14 aestes 2010-10-15 17:11:28 -0700 I see doubly-painted focus rings when I focus the search input field on http://developer.apple.com. 455792 15 jonlee 2011-08-23 16:14:29 -0700 For what it's worth it looks like this has been fixed in WK2, but still exists in WK1. 9842 2006-08-02 17:36:56 -0700 2006-08-02 17:36:56 -0700 Test case reduction reduction_bug10049.html text/html 575 jonathanjohnsson PGh0bWw+Cgk8aGVhZD4KCQk8dGl0bGU+CgkJPC90aXRsZT4KCQk8c2NyaXB0IGxhbmd1YWdlPSJq YXZhc2NyaXB0Ij4JCjwhLS0NCnN0YXJ0ID0gZnVuY3Rpb24gKCkKewogICAgY29udGFpbmVyRGl2 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ21hcnF1ZWVjb250YWluZXInKTsKICAgIGNvbnRh aW5lckRpdi5pbm5lckhUTUwgPSAnPGRpdj4nOwogICAgc2V0VGltZW91dCgnc3RhcnQoKScsIDAp Owp9OwotLT4KICAgIDwvc2NyaXB0PgoJPC9oZWFkPgoJPGJvZHkgb25sb2FkPSJzdGFydCgpIj4N CgkNCgk8ZGl2IGlkPSJtYXJxdWVlY29udGFpbmVyIj4NCgk8L2Rpdj4KDQogICAgPHRhYmxlIGhl aWdodD0iMTAwJSI+CiAgICAgICAgPHRyPgogICAgICAgICAgICA8dGQgcm93c3Bhbj0zPgogICAg ICAgICAgICA8L3RkPgogICAgICAgIDwvdHI+DQogICAgICAgIDx0cj4KCQkgICAgPHRkPgoJCQkJ PHNlbGVjdD4KCQkJPC90ZD4KCQk8L3RyPgoJCTx0cj4KCQkJPHRkIGhlaWdodD0iMTAwJSI+CiAg ICAgICAgICAgIDwvdGQ+DQogICAgICAgIDwvdHI+DQogICAgPC90YWJsZT4KCTwvYm9keT4KPC9o dG1sPgo= 15883 2007-08-09 10:52:42 -0700 2007-08-09 10:52:42 -0700 Test case button outline repaint.html text/html 596 mitz PHN0eWxlPgogICAgZGl2IHsgd2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDI1cHg7IH0KPC9zdHlsZT4K PGRpdiBpZD0iZDIiPjwvZGl2Pgo8ZGl2PgogICAgPGJ1dHRvbiBpZD0ic2VsZWN0IiBzdHlsZT0i bWFyZ2luOiAzcHg7Ij5CdXR0b248L2J1dHRvbj4KPC9kaXY+CjxkaXYgaWQ9ImQzIj48L2Rpdj4K PHNjcmlwdD4KICAgIHZhciBjb3VudCA9IDA7CiAgICBmdW5jdGlvbiB0b2dnbGUoKQogICAgewog ICAgICAgIGNvdW50Kys7CiAgICAgICAgdmFyIGNvbG9yID0gKGNvdW50ICUgMikgPyAicmVkIiA6 ICJncmVlbiI7CiAgICAgICAgZDIuc3R5bGUuYmFja2dyb3VuZCA9IGNvbG9yOwogICAgICAgIGQz LnN0eWxlLmJhY2tncm91bmQgPSBjb2xvcjsKCiAgICAgICAgaWYgKGNvdW50IDwgMTApCiAgICAg ICAgICAgIHNldFRpbWVvdXQodG9nZ2xlLCAxMCk7CiAgICB9CgogICAgZnVuY3Rpb24gc3RhcnQo KQogICAgewogICAgICAgIGNvdW50ID0gMDsKICAgICAgICBzZWxlY3QuZm9jdXMoKTsKICAgICAg ICBzZXRUaW1lb3V0KHRvZ2dsZSwgMTApOwogICAgfQo8L3NjcmlwdD4KPGJ1dHRvbiBvbmNsaWNr PSJzdGFydCgpIj5TdGFydDwvYnV0dG9uPgo= 15926 2007-08-11 01:12:58 -0700 2010-06-10 17:05:30 -0700 Clip to the enclosing rectangle if you decide to paint all of it 10049_r0.patch text/plain 1544 mitz SW5kZXg6IFdlYktpdC9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCShyZXZpc2lvbiAyNTAwNykKKysrIFdlYktpdC9XZWJW aWV3L1dlYkhUTUxWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNzU4LDYgKzI3NTgsMTEgQEAg c3RhdGljIHZvaWQgX3VwZGF0ZUFjdGl2ZVN0YXRlVGltZXJDYWxsYgogICAgIH0gTlNfRU5ESEFO RExFUgogfQogCistIChCT09MKXdhbnRzRGVmYXVsdENsaXBwaW5nCit7CisgICAgcmV0dXJuIE5P OworfQorCiAtICh2b2lkKWRyYXdSZWN0OihOU1JlY3QpcmVjdAogewogICAgIEFTU0VSVF9NQUlO X1RIUkVBRCgpOwpAQCAtMjc3MSwxMCArMjc3Niw2IEBAIHN0YXRpYyB2b2lkIF91cGRhdGVBY3Rp dmVTdGF0ZVRpbWVyQ2FsbGIKICAgICBpZiAoc3Vidmlld3NXZXJlU2V0QXNpZGUpCiAgICAgICAg IFtzZWxmIF9yZXN0b3JlU3Vidmlld3NdOwogCi0jaWZkZWYgX0tXUV9USU1JTkcKLSAgICBkb3Vi bGUgc3RhcnQgPSBDRkFic29sdXRlVGltZUdldEN1cnJlbnQoKTsKLSNlbmRpZgotCiAgICAgLy8g SWYgY291bnQgPT0gMCBoZXJlLCB1c2UgdGhlIHJlY3QgcGFzc2VkIGluIGZvciBkcmF3aW5nLiBU aGlzIGlzIGEgd29ya2Fyb3VuZCBmb3I6CiAgICAgLy8gPHJkYXI6Ly9wcm9ibGVtLzM5MDgyODI+ IFJFR1JFU1NJT04gKE1haWwpOiBObyBkcmFnIGltYWdlIGRyYWdnaW5nIHNlbGVjdGVkIHRleHQg aW4gQmxvdCBhbmQgTWFpbAogICAgIC8vIFRoZSByZWFzb24gZm9yIHRoZSB3b3JrYXJvdW5kIGlz IHRoYXQgdGhpcyBtZXRob2QgaXMgY2FsbGVkIGV4cGxpY2l0bHkgZnJvbSB0aGUgY29kZQpAQCAt Mjc5NSwxNiArMjc5NiwxNCBAQCBzdGF0aWMgdm9pZCBfdXBkYXRlQWN0aXZlU3RhdGVUaW1lckNh bGxiCiAgICAgICAgICAgICB1c2VVbmlvbmVkUmVjdCA9IFlFUzsKICAgICB9CiAgICAgCi0gICAg aWYgKHVzZVVuaW9uZWRSZWN0KQorICAgIGlmICh1c2VVbmlvbmVkUmVjdCkgeworICAgICAgICBO U1JlY3RDbGlwKHJlY3QpOwogICAgICAgICBbc2VsZiBkcmF3U2luZ2xlUmVjdDpyZWN0XTsKLSAg ICBlbHNlCisgICAgfSBlbHNlIHsKKyAgICAgICAgTlNSZWN0Q2xpcExpc3QocmVjdHMsIGNvdW50 KTsKICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBjb3VudDsgKytpKQogICAgICAgICAgICAg W3NlbGYgZHJhd1NpbmdsZVJlY3Q6cmVjdHNbaV1dOwotCi0jaWZkZWYgX0tXUV9USU1JTkcKLSAg ICBkb3VibGUgdGhpc1RpbWUgPSBDRkFic29sdXRlVGltZUdldEN1cnJlbnQoKSAtIHN0YXJ0Owot ICAgIExPRyhUaW1pbmcsICIlcyBkcmF3IHNlY29uZHMgPSAlZiIsIHdpZGdldC0+cGFydCgpLT5i YXNlVVJMKCkuVVJMKCkubGF0aW4xKCksIHRoaXNUaW1lKTsKLSNlbmRpZgorICAgIH0KIAogICAg IGlmIChzdWJ2aWV3c1dlcmVTZXRBc2lkZSkKICAgICAgICAgW3NlbGYgX3NldEFzaWRlU3Vidmll d3NdOwo=