100488 2012-10-26 02:56:25 -0700 Printing should use use high resolution images when available 2012-10-26 05:28:19 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 kenneth kenneth cmarcelo eric.carlson feature-media-reviews koivisto macpherson menard webkit.review.bot oldest_to_newest 751747 0 kenneth 2012-10-26 02:56:25 -0700 SSIA 751758 1 170862 kenneth 2012-10-26 03:01:09 -0700 Created attachment 170862 Patch 751916 2 170862 webkit.review.bot 2012-10-26 05:19:25 -0700 Comment on attachment 170862 Patch Rejecting attachment 170862 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14607049 751934 3 kenneth 2012-10-26 05:28:19 -0700 landed in 132633 170862 2012-10-26 03:01:09 -0700 2012-10-26 05:19:25 -0700 Patch bug-100488-20121026115940.patch text/plain 7075 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVmZmIwZTNiNTc1OWNi YTY2OWJkNWRjOWY0MGRlNjM5NjZjOTBjYi4uZjZlNGI5ZDdjNmYwNmI3MGU5NDk1ZmFlZWNlYzYx ZjY1N2Q5MmFlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTI2ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBQ cmludGluZyBzaG91bGQgdXNlIHVzZSBoaWdoIHJlc29sdXRpb24gaW1hZ2VzIHdoZW4gYXZhaWxh YmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA0 ODgKKworICAgICAgICBUaGUgaW1hZ2VzIGxvYWRlZCB1c2luZyAtd2Via2l0LWRldmljZS1waXhl bC1yYXRpbyBkZXBlbmRzIG9uCisgICAgICAgIHRoZSBkaXNwbGF5IHR5cGUgKGRldmljZVNjYWxl RmFjdG9yKSBhbmQgdGh1cyBhZmZlY3RzIHdoaWNoCisgICAgICAgIGltYWdlcyBhcmUgYmVpbmcg dXNlZCBmb3IgcHJpbnRpbmcuIFByaW50aW5nIHNob3VsZCBhbHdheXMKKyAgICAgICAgdXNlIHRo ZSBoaWdoZXIgcmVzb2x1dGlvbiBpbWFnZXMgKGFrYSAncmV0aW5hJyBpbWFnZXMpLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvbWVkaWEvbXEtcGl4ZWwtcmF0aW8tcHJpbnQuaHRtbAorCisgICAgICAg ICogY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZGV2aWNl X3BpeGVsX3JhdGlvTWVkaWFGZWF0dXJlRXZhbCk6CisKIDIwMTItMTAtMjYgIErDoW5vcyBCYWRp Y3MgIDxqYmFkaWNzQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdUkVHUkVTU0lPTihy MTMxNDI4KTogY29va2llcy5kYiBjcmVhdGVkIG9uIHdyb25nIHBsYWNlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeUV2YWx1YXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvTWVkaWFRdWVyeUV2YWx1YXRvci5jcHAKaW5kZXggMzM5NWFkOTJjYzdhNzk0ODc2MTVk ZjEzYjZkODBjYmU1MGI4NDhmYy4uMmNmNjk5OTBkNWQ3MzE3OTJkNzQ0NTc4YzYxYzMyZjRlMzk4 MGE4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3Iu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmNwcApAQCAt Mjg5LDEwICsyODksMjcgQEAgc3RhdGljIGJvb2wgZGV2aWNlX2FzcGVjdF9yYXRpb01lZGlhRmVh dHVyZUV2YWwoQ1NTVmFsdWUqIHZhbHVlLCBSZW5kZXJTdHlsZSosIEYKIAogc3RhdGljIGJvb2wg ZGV2aWNlX3BpeGVsX3JhdGlvTWVkaWFGZWF0dXJlRXZhbChDU1NWYWx1ZSAqdmFsdWUsIFJlbmRl clN0eWxlKiwgRnJhbWUqIGZyYW1lLCBNZWRpYUZlYXR1cmVQcmVmaXggb3ApCiB7Ci0gICAgaWYg KHZhbHVlKQotICAgICAgICByZXR1cm4gdmFsdWUtPmlzUHJpbWl0aXZlVmFsdWUoKSAmJiBjb21w YXJlVmFsdWUoZnJhbWUtPnBhZ2UoKS0+ZGV2aWNlU2NhbGVGYWN0b3IoKSwgc3RhdGljX2Nhc3Q8 Q1NTUHJpbWl0aXZlVmFsdWUqPih2YWx1ZSktPmdldEZsb2F0VmFsdWUoKSwgb3ApOworICAgIC8v IEZJWE1FOiBQb3NzaWJsZSBoYW5kbGUgb3RoZXIgbWVkaWEgdHlwZXMgdGhhbiAnc2NyZWVuJyBh bmQgJ3ByaW50Jy4KKyAgICBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvciA9IDA7CisKKyAgICAvLyBU aGlzIGNoZWNrcyB0aGUgYWN0dWFsIG1lZGlhIHR5cGUgYXBwbGllZCB0byB0aGUgZG9jdW1lbnQs IGFuZCB3ZSBrbm93CisgICAgLy8gdGhpcyBtZXRob2Qgb25seSBnb3QgY2FsbGVkIGlmIHRoaXMg bWVkaWEgdHlwZSBtYXRjaGVzIHRoZSBvbmUgZGVmaW5lZAorICAgIC8vIGluIHRoZSBxdWVyeS4g VGh1cywgaWYgaWYgdGhlIGRvY3VtZW50J3MgbWVkaWEgdHlwZSBpcyAicHJpbnQiLCB0aGUKKyAg ICAvLyBtZWRpYSB0eXBlIG9mIHRoZSBxdWVyeSB3aWxsIGVpdGhlciBiZSAicHJpbnQiIG9yICJh bGwiLgorICAgIFN0cmluZyBtZWRpYVR5cGUgPSBmcmFtZS0+dmlldygpLT5tZWRpYVR5cGUoKTsK KyAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UobWVkaWFUeXBlLCAic2NyZWVuIikpCisgICAgICAg IGRldmljZVNjYWxlRmFjdG9yID0gZnJhbWUtPnBhZ2UoKS0+ZGV2aWNlU2NhbGVGYWN0b3IoKTsK KyAgICBlbHNlIGlmIChlcXVhbElnbm9yaW5nQ2FzZShtZWRpYVR5cGUsICJwcmludCIpKSB7Cisg ICAgICAgIC8vIFRoZSByZXNvbHV0aW9uIG9mIGltYWdlcyB3aGlsZSBwcmludGluZyBzaG91bGQg bm90IGRlcGVuZCBvbiB0aGUgZHBpCisgICAgICAgIC8vIG9mIHRoZSBzY3JlZW4uIFVudGlsIHdl IHN1cHBvcnQgcHJvcGVyIHdheXMgb2YgcXVlcnlpbmcgdGhpcyBpbmZvCisgICAgICAgIC8vIHdl IHVzZSAzMDBweCB3aGljaCBpcyBjb25zaWRlcmVkIG1pbmltdW0gZm9yIGN1cnJlbnQgcHJpbnRl cnMuCisgICAgICAgIGRldmljZVNjYWxlRmFjdG9yID0gMy4xMjU7IC8vIDMwMGRwaSAvIDk2ZHBp OworICAgIH0KKworICAgIGlmICghdmFsdWUpCisgICAgICAgIHJldHVybiAhIWRldmljZVNjYWxl RmFjdG9yOwogCi0gICAgcmV0dXJuIGZyYW1lLT5wYWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCkg IT0gMDsKKyAgICByZXR1cm4gdmFsdWUtPmlzUHJpbWl0aXZlVmFsdWUoKSAmJiBjb21wYXJlVmFs dWUoZGV2aWNlU2NhbGVGYWN0b3IsIHN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odmFs dWUpLT5nZXRGbG9hdFZhbHVlKCksIG9wKTsKIH0KIAogc3RhdGljIGJvb2wgcmVzb2x1dGlvbk1l ZGlhRmVhdHVyZUV2YWwoQ1NTVmFsdWUqIHZhbHVlLCBSZW5kZXJTdHlsZSosIEZyYW1lKiBmcmFt ZSwgTWVkaWFGZWF0dXJlUHJlZml4IG9wKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFmNDYxOTdiYzhkY2NjMDhhYzcyMGYy MTk4ZDU3Y2M3NzgwZmRmNmQuLjI1NWM3MmQwMzM2MTc1MjNhNzc1MjljNGIzZGQ4ZjMxMzNhNDE1 NmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yNiAgS2VubmV0aCBSb2hkZSBDaHJp c3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUHJpbnRpbmcgc2hvdWxk IHVzZSB1c2UgaGlnaCByZXNvbHV0aW9uIGltYWdlcyB3aGVuIGF2YWlsYWJsZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNDg4CisKKyAgICAgICAg VGhlIGltYWdlcyBsb2FkZWQgdXNpbmcgLXdlYmtpdC1kZXZpY2UtcGl4ZWwtcmF0aW8gZGVwZW5k cyBvbgorICAgICAgICB0aGUgZGlzcGxheSB0eXBlIChkZXZpY2VTY2FsZUZhY3RvcikgYW5kIHRo dXMgYWZmZWN0cyB3aGljaAorICAgICAgICBpbWFnZXMgYXJlIGJlaW5nIHVzZWQgZm9yIHByaW50 aW5nLiBQcmludGluZyBzaG91bGQgYWx3YXlzCisgICAgICAgIHVzZSB0aGUgaGlnaGVyIHJlc29s dXRpb24gaW1hZ2VzIChha2EgJ3JldGluYScgaW1hZ2VzKS4KKworICAgICAgICBBZGRlZCBhIHRl c3QgdGVzdGluZyAtd2Via2l0LWRldmljZS1waXhlbC1yYXRpbyBtZWRpYSBxdWVyeQorICAgICAg ICBpbiBjb25qdW50aW9uIHdpdGggJ3ByaW50JyBtZWRpYSB0eXBlLgorCisgICAgICAgICogZmFz dC9tZWRpYS9tcS1waXhlbC1yYXRpby1wcmludC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvbWVkaWEvbXEtcGl4ZWwtcmF0aW8tcHJpbnQuaHRtbDogQWRkZWQuCisKIDIwMTIt MTAtMjYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIERpc2Fi bGUgRU5BQkxFX0lOUFVUX1RZUEVfV0VFSyBvbiBDaHJvbWl1bS9BbmRyb2lkCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhL21xLXBpeGVsLXJhdGlvLXByaW50LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWEvbXEtcGl4ZWwtcmF0aW8tcHJpbnQtZXhwZWN0ZWQu dHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjFkMDhhOWY5NTI3ZmI4YzRiMDRjNjU4YTdlYzdkMWM0OWVkOTliZTAK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhL21xLXBpeGVsLXJhdGlv LXByaW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE0IEBACitDU1MzIG1lZGlhIHF1ZXJ5IHRl c3Q6IC13ZWJraXQtZGV2aWNlLXBpeGVsLXJhdGlvIGNvbWJpbmVkIHdpdGggcHJpbnQuCisKK09u IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIG1hdGNoTWVkaWEoJygtd2Via2l0LW1p bi1kZXZpY2UtcGl4ZWwtcmF0aW86IDEpJykubWF0Y2hlcyBpcyB0cnVlCitQQVNTIHJlc29sdXRp b25Gcm9tU3R5bGUoKSBpcyAxCitQQVNTIG1hdGNoTWVkaWEoJygtd2Via2l0LW1pbi1kZXZpY2Ut cGl4ZWwtcmF0aW86IDMpJykubWF0Y2hlcyBpcyB0cnVlCitQQVNTIHJlc29sdXRpb25Gcm9tU3R5 bGUoKSBpcyAzCitQQVNTIHJlc29sdXRpb25Gcm9tU3R5bGUoKSBpcyAzLjEyNQorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvbWVkaWEvbXEtcGl4ZWwtcmF0aW8tcHJpbnQuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvbWVkaWEvbXEtcGl4ZWwtcmF0aW8tcHJpbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xZGNm OTYzOTcyZTY3OWI5NGJjNzhkMDlkYTAyZTE1NWY2NDRlMWE4Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9tZWRpYS9tcS1waXhlbC1yYXRpby1wcmludC5odG1sCkBAIC0wLDAg KzEsNTggQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIu Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorCis8ZGl2IGlkPSJkZXRl Y3RvciI+PC9kaXY+CisKKzxzdHlsZT4KKyAgICAjZGV0ZWN0b3IgeyB3aWR0aDogMTAwcHg7IH0K KyAgICBAbWVkaWEgKC13ZWJraXQtbWluLWRldmljZS1waXhlbC1yYXRpbzogMSkgeyAjZGV0ZWN0 b3IgeyB3aWR0aDogMTBweDsgfSB9CisgICAgQG1lZGlhIHByaW50IGFuZCAoLXdlYmtpdC1taW4t ZGV2aWNlLXBpeGVsLXJhdGlvOiAzKSB7ICNkZXRlY3RvciB7IHdpZHRoOiAzMHB4OyB9IH0KKzwv c3R5bGU+CisKKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24oIkNTUzMgbWVkaWEgcXVlcnkgdGVz dDogLXdlYmtpdC1kZXZpY2UtcGl4ZWwtcmF0aW8gY29tYmluZWQgd2l0aCBwcmludC4iKQorCisg ICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyICYmIHdpbmRvdy5pbnRlcm5hbHMpIHsKKyAgICAgICAg d2luZG93LnRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgIGZ1bmN0aW9uIHJlc29s dXRpb25Gcm9tU3R5bGUoKSB7CisgICAgICAgICAgICB2YXIgd2lkdGggPSBnZXRDb21wdXRlZFN0 eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkZXRlY3RvciIpKS53aWR0aDsKKyAgICAgICAg ICAgIHN3aXRjaCAod2lkdGgpIHsKKyAgICAgICAgICAgICAgICBjYXNlICIxMHB4IjoKKyAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIDE7CisgICAgICAgICAgICAgICAgY2FzZSAiMzBweCI6Cisg ICAgICAgICAgICAgICAgICAgIHJldHVybiAzOworICAgICAgICAgICAgICAgIGNhc2UgIjMxcHgi OgorICAgICAgICAgICAgICAgICAgICByZXR1cm4gMy4xMjU7CisgICAgICAgICAgICAgICAgZGVm YXVsdDoKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHVuZGVmaW5lZDsKKyAgICAgICAgICAg IH0KKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9uIGFwcGVuZE1lZGlhUnVsZShydWxlKSB7 CisgICAgICAgICAgICB2YXIgbGFzdFN0eWxlU2hlZXQgPSBkb2N1bWVudC5zdHlsZVNoZWV0c1tk b2N1bWVudC5zdHlsZVNoZWV0cy5sZW5ndGggLSAxXTsKKyAgICAgICAgICAgIGxhc3RTdHlsZVNo ZWV0Lmluc2VydFJ1bGUocnVsZSwgbGFzdFN0eWxlU2hlZXQuY3NzUnVsZXMubGVuZ3RoKTsKKyAg ICAgICAgfQorCisgICAgICAgIHNob3VsZEJlKCJtYXRjaE1lZGlhKCcoLXdlYmtpdC1taW4tZGV2 aWNlLXBpeGVsLXJhdGlvOiAxKScpLm1hdGNoZXMiLCAidHJ1ZSIpOworICAgICAgICBzaG91bGRC ZSgicmVzb2x1dGlvbkZyb21TdHlsZSgpIiwgIjEiKTsKKworICAgICAgICAvLyBUZXN0IHByaW50 aW5nLgorCisgICAgICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0TWVkaWFUeXBlT3Zl cnJpZGUoInByaW50Iik7CisgICAgICAgIHNob3VsZEJlKCJtYXRjaE1lZGlhKCcoLXdlYmtpdC1t aW4tZGV2aWNlLXBpeGVsLXJhdGlvOiAzKScpLm1hdGNoZXMiLCAidHJ1ZSIpOworCisgICAgICAg IC8vIFNob3VsZCBtYXRjaCB0aGUgb25lIHJlcXVpcmluZyAncHJpbnQnIG1lZGlhIHR5cGUuCisg ICAgICAgIHNob3VsZEJlKCJyZXNvbHV0aW9uRnJvbVN0eWxlKCkiLCAiMyIpOworCisgICAgICAg IC8vIEFzIHdlbGwgYXMgdGhvc2UgbWF0Y2hpbmcgJ2FsbCcuCisgICAgICAgIGFwcGVuZE1lZGlh UnVsZSgiQG1lZGlhICgtd2Via2l0LW1pbi1kZXZpY2UtcGl4ZWwtcmF0aW86IDMuMTI1KSB7ICNk ZXRlY3RvciB7IHdpZHRoOiAzMXB4OyB9IH0iKTsKKyAgICAgICAgc2hvdWxkQmUoInJlc29sdXRp b25Gcm9tU3R5bGUoKSIsICIzLjEyNSIpOworICAgIH0KKzwvc2NyaXB0PgorCis8c2NyaXB0IHNy Yz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+Cg==