100470 2012-10-25 23:49:43 -0700 Use switch/case statements instead of if/elseif in CSSSelector.cpp 2012-11-05 22:26:09 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato hayato allan.jensen cmarcelo macpherson menard webkit.review.bot oldest_to_newest 751606 0 hayato 2012-10-25 23:49:43 -0700 We can get compiler warnings in the future if we use switch/case statements here. 751614 1 170833 hayato 2012-10-25 23:57:04 -0700 Created attachment 170833 Use switch statements. 759241 2 172485 hayato 2012-11-05 22:00:24 -0800 Created attachment 172485 Patch for landing 759263 3 172485 webkit.review.bot 2012-11-05 22:26:06 -0800 Comment on attachment 172485 Patch for landing Clearing flags on attachment: 172485 Committed r133561: <http://trac.webkit.org/changeset/133561> 759264 4 webkit.review.bot 2012-11-05 22:26:09 -0800 All reviewed patches have been landed. Closing bug. 170833 2012-10-25 23:57:04 -0700 2012-11-05 22:00:19 -0800 Use switch statements. bug-100470-20121026155536.patch text/plain 2318 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjUxNDkxNTI5YThjZWU2 Mjg3NWE0MDNkODBjYTJjYjdiMzBjNTg0MS4uZTc2MTRjMjIzODdlODE1YWUwODkxMzUxZDY1NDRl YThiNDIyNGZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTI1ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBVc2Ugc3dpdGNoL2Nhc2Ug c3RhdGVtZW50cyBpbnN0ZWFkIG9mIGlmL2Vsc2VpZiBpbiBDU1NTZWxlY3Rvci5jcHAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDQ3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pbm9yIGNsZWFuIHVw LiBXZSBjYW4gZ2V0IGNvbXBpbGVyIHdhcm5pbmdzIGlmIHdlIHVzZSBzd2l0aGgvY2FzZSBzdGF0 ZW1lbnRzIGhlcmUuCisKKyAgICAgICAgTm8gY2hhbmdlcyB0byBmdW5jdGlvbmFsaXR5LCBzbyBu byBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0b3IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q1NTU2VsZWN0b3I6OnNlbGVjdG9yVGV4dCk6CisKIDIwMTItMTAtMjUgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgZmVlZCBh bmQgZmVlZHMgVVJMIHNjaGVtZSB3b3JrYXJvdW5kcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1NlbGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5j cHAKaW5kZXggZDJiYTc1Njc3NzIyM2VjYjVmZmNlZWIxZjY4YTU0MWMzMjdlMmYxZi4uMmUzMzdh ZDgwNGY4MWQ0NzRjNDFhODI4ZGEyNjllYTRhZjE3N2ZiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1NlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2Vs ZWN0b3IuY3BwCkBAIC02MjcsMTcgKzYyNywxOSBAQCBTdHJpbmcgQ1NTU2VsZWN0b3I6OnNlbGVj dG9yVGV4dCgpIGNvbnN0CiAKICAgICBpZiAoQ1NTU2VsZWN0b3IqIHRhZ0hpc3RvcnkgPSBjcy0+ dGFnSGlzdG9yeSgpKSB7CiAgICAgICAgIFN0cmluZyB0YWdIaXN0b3J5VGV4dCA9IHRhZ0hpc3Rv cnktPnNlbGVjdG9yVGV4dCgpOwotICAgICAgICBpZiAoY3MtPnJlbGF0aW9uKCkgPT0gQ1NTU2Vs ZWN0b3I6OkRpcmVjdEFkamFjZW50KQorICAgICAgICBzd2l0Y2ggKGNzLT5yZWxhdGlvbigpKSB7 CisgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OkRlc2NlbmRhbnQ6CisgICAgICAgICAgICByZXR1 cm4gdGFnSGlzdG9yeVRleHQgKyAiICIgKyBzdHIudG9TdHJpbmcoKTsKKyAgICAgICAgY2FzZSBD U1NTZWxlY3Rvcjo6Q2hpbGQ6CisgICAgICAgICAgICByZXR1cm4gdGFnSGlzdG9yeVRleHQgKyAi ID4gIiArIHN0ci50b1N0cmluZygpOworICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpEaXJlY3RB ZGphY2VudDoKICAgICAgICAgICAgIHJldHVybiB0YWdIaXN0b3J5VGV4dCArICIgKyAiICsgc3Ry LnRvU3RyaW5nKCk7Ci0gICAgICAgIGVsc2UgaWYgKGNzLT5yZWxhdGlvbigpID09IENTU1NlbGVj dG9yOjpJbmRpcmVjdEFkamFjZW50KQorICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpJbmRpcmVj dEFkamFjZW50OgogICAgICAgICAgICAgcmV0dXJuIHRhZ0hpc3RvcnlUZXh0ICsgIiB+ICIgKyBz dHIudG9TdHJpbmcoKTsKLSAgICAgICAgZWxzZSBpZiAoY3MtPnJlbGF0aW9uKCkgPT0gQ1NTU2Vs ZWN0b3I6OkNoaWxkKQotICAgICAgICAgICAgcmV0dXJuIHRhZ0hpc3RvcnlUZXh0ICsgIiA+ICIg KyBzdHIudG9TdHJpbmcoKTsKLSAgICAgICAgZWxzZSBpZiAoY3MtPnJlbGF0aW9uKCkgPT0gQ1NT U2VsZWN0b3I6OlNoYWRvd0Rlc2NlbmRhbnQpCisgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlN1 YlNlbGVjdG9yOgorICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGNh c2UgQ1NTU2VsZWN0b3I6OlNoYWRvd0Rlc2NlbmRhbnQ6CiAgICAgICAgICAgICByZXR1cm4gdGFn SGlzdG9yeVRleHQgKyBzdHIudG9TdHJpbmcoKTsKLSAgICAgICAgZWxzZSB7Ci0gICAgICAgICAg ICAvLyBEZXNjZW5kYW50Ci0gICAgICAgICAgICByZXR1cm4gdGFnSGlzdG9yeVRleHQgKyAiICIg KyBzdHIudG9TdHJpbmcoKTsKICAgICAgICAgfQogICAgIH0KIAo= 172485 2012-11-05 22:00:24 -0800 2012-11-05 22:26:05 -0800 Patch for landing bug-100470-20121106145837.patch text/plain 2346 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM1MDhmYzk2NzQxOTI5 YTg4ODRiYTY3MzkzZTVmZDIxMjI1NjZjMS4uODRmYTUzMjdkMDAxY2M5NjI5MDA5MzcyMDMyMzEw ODcwMjkzMDlhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA1ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBVc2Ugc3dpdGNoL2Nhc2Ug c3RhdGVtZW50cyBpbnN0ZWFkIG9mIGlmL2Vsc2VpZiBpbiBDU1NTZWxlY3Rvci5jcHAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDQ3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBNaW5vciBjbGVhbiB1cC4g V2UgY2FuIGdldCBjb21waWxlciB3YXJuaW5ncyBpZiB3ZSB1c2Ugc3dpdGNoL2Nhc2Ugc3RhdGVt ZW50cyBoZXJlLgorCisgICAgICAgIE5vIGNoYW5nZXMgdG8gZnVuY3Rpb25hbGl0eSwgc28gbm8g bmV3IHRlc3RzLgorCisgICAgICAgICogY3NzL0NTU1NlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNTU1NlbGVjdG9yOjpzZWxlY3RvclRleHQpOgorCiAyMDEyLTExLTA1ICBLZW5pY2hp IElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFVu aWNvZGUgY29tYmluaW5nIGRpYWNyaXRpY2FsIGFyZW4ndCBhbHdheXMgY29tYmluZWQgb24gTGlu dXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCmluZGV4IGQyYmE3NTY3NzcyMjNlY2I1ZmZj ZWViMWY2OGE1NDFjMzI3ZTJmMWYuLjJlMzM3YWQ4MDRmODFkNDc0YzQxYTgyOGRhMjY5ZWE0YWYx NzdmYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmNwcApAQCAtNjI3LDE3ICs2MjcsMTkg QEAgU3RyaW5nIENTU1NlbGVjdG9yOjpzZWxlY3RvclRleHQoKSBjb25zdAogCiAgICAgaWYgKENT U1NlbGVjdG9yKiB0YWdIaXN0b3J5ID0gY3MtPnRhZ0hpc3RvcnkoKSkgewogICAgICAgICBTdHJp bmcgdGFnSGlzdG9yeVRleHQgPSB0YWdIaXN0b3J5LT5zZWxlY3RvclRleHQoKTsKLSAgICAgICAg aWYgKGNzLT5yZWxhdGlvbigpID09IENTU1NlbGVjdG9yOjpEaXJlY3RBZGphY2VudCkKKyAgICAg ICAgc3dpdGNoIChjcy0+cmVsYXRpb24oKSkgeworICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpE ZXNjZW5kYW50OgorICAgICAgICAgICAgcmV0dXJuIHRhZ0hpc3RvcnlUZXh0ICsgIiAiICsgc3Ry LnRvU3RyaW5nKCk7CisgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OkNoaWxkOgorICAgICAgICAg ICAgcmV0dXJuIHRhZ0hpc3RvcnlUZXh0ICsgIiA+ICIgKyBzdHIudG9TdHJpbmcoKTsKKyAgICAg ICAgY2FzZSBDU1NTZWxlY3Rvcjo6RGlyZWN0QWRqYWNlbnQ6CiAgICAgICAgICAgICByZXR1cm4g dGFnSGlzdG9yeVRleHQgKyAiICsgIiArIHN0ci50b1N0cmluZygpOwotICAgICAgICBlbHNlIGlm IChjcy0+cmVsYXRpb24oKSA9PSBDU1NTZWxlY3Rvcjo6SW5kaXJlY3RBZGphY2VudCkKKyAgICAg ICAgY2FzZSBDU1NTZWxlY3Rvcjo6SW5kaXJlY3RBZGphY2VudDoKICAgICAgICAgICAgIHJldHVy biB0YWdIaXN0b3J5VGV4dCArICIgfiAiICsgc3RyLnRvU3RyaW5nKCk7Ci0gICAgICAgIGVsc2Ug aWYgKGNzLT5yZWxhdGlvbigpID09IENTU1NlbGVjdG9yOjpDaGlsZCkKLSAgICAgICAgICAgIHJl dHVybiB0YWdIaXN0b3J5VGV4dCArICIgPiAiICsgc3RyLnRvU3RyaW5nKCk7Ci0gICAgICAgIGVs c2UgaWYgKGNzLT5yZWxhdGlvbigpID09IENTU1NlbGVjdG9yOjpTaGFkb3dEZXNjZW5kYW50KQor ICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpTdWJTZWxlY3RvcjoKKyAgICAgICAgICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpTaGFkb3dEZXNjZW5k YW50OgogICAgICAgICAgICAgcmV0dXJuIHRhZ0hpc3RvcnlUZXh0ICsgc3RyLnRvU3RyaW5nKCk7 Ci0gICAgICAgIGVsc2UgewotICAgICAgICAgICAgLy8gRGVzY2VuZGFudAotICAgICAgICAgICAg cmV0dXJuIHRhZ0hpc3RvcnlUZXh0ICsgIiAiICsgc3RyLnRvU3RyaW5nKCk7CiAgICAgICAgIH0K ICAgICB9CiAK