100452 2012-10-25 21:09:34 -0700 Implement {get,set}FloatValueForKey 2012-10-26 00:35:23 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned andersca webkit.review.bot oldest_to_newest 751509 0 ljaehun.lim 2012-10-25 21:09:34 -0700 Add missing functions in WebPreferencesStore 751510 1 170803 ljaehun.lim 2012-10-25 21:15:53 -0700 Created attachment 170803 Patch I'm sorry, I missed some codes in my previous patch. Add missing implementations. 751518 2 ljaehun.lim 2012-10-25 21:38:58 -0700 Previous patch: https://bugs.webkit.org/show_bug.cgi?id=99419 751640 3 170803 webkit.review.bot 2012-10-26 00:35:19 -0700 Comment on attachment 170803 Patch Clearing flags on attachment: 170803 Committed r132578: <http://trac.webkit.org/changeset/132578> 751641 4 webkit.review.bot 2012-10-26 00:35:23 -0700 All reviewed patches have been landed. Closing bug. 170803 2012-10-25 21:15:53 -0700 2012-10-26 00:35:19 -0700 Patch patch.diff text/plain 1424 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiZWMwNmE4Li4yYjU0OWYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTAtMjUgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBJbXBsZW1lbnQge2dldCxzZXR9RmxvYXRWYWx1ZUZvcktleQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNDUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IG1pc3NpbmcgZnVu Y3Rpb25zIGluIFdlYlByZWZlcmVuY2VzU3RvcmUuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJl ZmVyZW5jZXNTdG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzU3RvcmU6 OnNldEZsb2F0VmFsdWVGb3JLZXkpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKFdlYktp dDo6V2ViUHJlZmVyZW5jZXNTdG9yZTo6Z2V0RmxvYXRWYWx1ZUZvcktleSk6CisKIDIwMTItMTAt MjUgIEJ5dW5nd29vIExlZSAgPGJ3ODAubGVlQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtXSzJd IFVzZSBwZXIgZGVzdGluYXRpb24gSUQgbWVzc2FnZSByZWNlaXZlcnMgZm9yIERvd25sb2FkUHJv eHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9y ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5jcHAKaW5k ZXggYTRmZjU2ZC4uZWMwNmNiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dl YlByZWZlcmVuY2VzU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVm ZXJlbmNlc1N0b3JlLmNwcApAQCAtMjI3LDQgKzIyNywxNCBAQCBkb3VibGUgV2ViUHJlZmVyZW5j ZXNTdG9yZTo6Z2V0RG91YmxlVmFsdWVGb3JLZXkoY29uc3QgU3RyaW5nJiBrZXkpIGNvbnN0CiAg ICAgcmV0dXJuIHZhbHVlRm9yS2V5KG1fZG91YmxlVmFsdWVzLCBrZXkpOwogfQogCitib29sIFdl YlByZWZlcmVuY2VzU3RvcmU6OnNldEZsb2F0VmFsdWVGb3JLZXkoY29uc3QgU3RyaW5nJiBrZXks IGZsb2F0IHZhbHVlKSAKK3sKKyAgICByZXR1cm4gc2V0VmFsdWVGb3JLZXkobV9mbG9hdFZhbHVl cywga2V5LCB2YWx1ZSk7Cit9CisKK2Zsb2F0IFdlYlByZWZlcmVuY2VzU3RvcmU6OmdldEZsb2F0 VmFsdWVGb3JLZXkoY29uc3QgU3RyaW5nJiBrZXkpIGNvbnN0Cit7CisgICAgcmV0dXJuIHZhbHVl Rm9yS2V5KG1fZmxvYXRWYWx1ZXMsIGtleSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=