100449 2012-10-25 20:21:39 -0700 Add PID tracking to WebMemorySampler. 2013-01-04 14:04:27 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 slewis slewis eric rakuco slewis oldest_to_newest 751483 0 slewis 2012-10-25 20:21:39 -0700 Make it easier to associate sample files with specific processes. Add the pid to the filename and to the output header. 751484 1 170796 slewis 2012-10-25 20:23:25 -0700 Created attachment 170796 patch.txt? 753182 2 rakuco 2012-10-29 02:18:13 -0700 I've landed a build fix in <http://trac.webkit.org/changeset/132776>. 800038 3 eric 2013-01-04 00:53:10 -0800 Attachment 170796 was posted by a committer and has review+, assigning to Stephanie Lewis for commit. 170796 2012-10-25 20:23:25 -0700 2012-10-26 15:47:07 -0700 patch.txt? addPidsToWebMemorySampler.txt text/plain 4292 slewis Y29tbWl0IDYzNzU3NjljOGYyZjExNWJmNDViYjJiNmJiNTkzYjZiMTc1ZTAxYjQKQXV0aG9yOiBT dGVwaGFuaWUgTGV3aXMgPHNsZXdpc0BhcHBsZS5jb20+CkRhdGU6ICAgVHVlIE9jdCAyMyAyMjo1 MTo0MyAyMDEyIC0wNzAwCgogICAgQWRkIHBpZHMgdG8gV2ViTWVtb3J5U2FtcGxlRmlsZXMuCiAg ICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCiAgICAKICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgogICAgCiAgICBNYWtlIGl0IGVhc2llciB0byBhc3NvY2lhdGUgV2ViTWVtb3J5U2Ft cGxlcyB3aXRoIGEgcHJvY2Vzcy4gIEFkZCB0aGUgcGlkIHRvIHRoZSBmaWxlbmFtZSBhbmQgaGVh ZGVyLgogICAgCiAgICAqIFNoYXJlZC9XZWJNZW1vcnlTYW1wbGVyLmNwcDoKICAgIChXZWJLaXQ6 OldlYk1lbW9yeVNhbXBsZXI6OmluaXRpYWxpemVUaW1lcnMpOiBVcGRhdGUgbm90aWZpY2F0aW9u LgogICAgKFdlYktpdDo6V2ViTWVtb3J5U2FtcGxlcjo6c3RvcCk6IFVwZGF0ZSBub3RpZmljYXRp b24uCiAgICAoV2ViS2l0OjpXZWJNZW1vcnlTYW1wbGVyOjp3cml0ZUhlYWRlcnMpOiBkdW1wIHBp ZCBpbiB0aGUgaGVhZGVyLgogICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5jcHA6CiAgICAoV2Vi S2l0OjpXZWJDb250ZXh0Ojpwcm9jZXNzRGlkRmluaXNoTGF1bmNoaW5nKTogYXBwZW5kIHBpZCB0 byBmaWxlbmFtZS4KCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmVjMDZhOC4uOTkyZjBjOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTIzICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBw bGUuY29tPgorCisgICAgICAgIEFkZCBwaWRzIHRvIFdlYk1lbW9yeVNhbXBsZUZpbGVzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNDQ5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBpdCBlYXNp ZXIgdG8gYXNzb2NpYXRlIFdlYk1lbW9yeVNhbXBsZXMgd2l0aCBhIHByb2Nlc3MuICBBZGQgdGhl IHBpZCB0byB0aGUgZmlsZW5hbWUgYW5kIGhlYWRlci4KKworICAgICAgICAqIFNoYXJlZC9XZWJN ZW1vcnlTYW1wbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTWVtb3J5U2FtcGxlcjo6aW5p dGlhbGl6ZVRpbWVycyk6IFVwZGF0ZSBub3RpZmljYXRpb24uCisgICAgICAgIChXZWJLaXQ6Oldl Yk1lbW9yeVNhbXBsZXI6OnN0b3ApOiBVcGRhdGUgbm90aWZpY2F0aW9uLgorICAgICAgICAoV2Vi S2l0OjpXZWJNZW1vcnlTYW1wbGVyOjp3cml0ZUhlYWRlcnMpOiBkdW1wIHBpZCBpbiB0aGUgaGVh ZGVyLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViQ29udGV4dDo6cHJvY2Vzc0RpZEZpbmlzaExhdW5jaGluZyk6IGFwcGVuZCBwaWQgdG8g ZmlsZW5hbWUuCisKIDIwMTItMTAtMjUgIEJ5dW5nd29vIExlZSAgPGJ3ODAubGVlQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFtXSzJdIFVzZSBwZXIgZGVzdGluYXRpb24gSUQgbWVzc2FnZSByZWNl aXZlcnMgZm9yIERvd25sb2FkUHJveHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvV2ViTWVtb3J5U2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViTWVtb3J5 U2FtcGxlci5jcHAKaW5kZXggMzQ0ZjdmNS4uZWU2NTNlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL1dlYk1lbW9yeVNhbXBsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9XZWJNZW1vcnlTYW1wbGVyLmNwcApAQCAtODIsNyArODIsNyBAQCB2b2lkIFdlYk1lbW9y eVNhbXBsZXI6OnN0YXJ0KGNvbnN0IFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSYgc2FtcGxlTG9n RmlsZUhhbmRsZQogdm9pZCBXZWJNZW1vcnlTYW1wbGVyOjppbml0aWFsaXplVGltZXJzKGRvdWJs ZSBpbnRlcnZhbCkKIHsKICAgICBtX3NhbXBsZVRpbWVyLnN0YXJ0UmVwZWF0aW5nKDEpOwotICAg IHByaW50ZigiU3RhcnRlZCBtZW1vcnkgc2FtcGxlciBmb3IgcHJvY2VzcyAlcyIsIHByb2Nlc3NO YW1lKCkudXRmOCgpLmRhdGEoKSk7CisgICAgcHJpbnRmKCJTdGFydGVkIG1lbW9yeSBzYW1wbGVy IGZvciBwcm9jZXNzICVzICVkIiwgcHJvY2Vzc05hbWUoKS51dGY4KCkuZGF0YSgpLCBnZXRwaWQo KSk7CiAgICAgaWYgKGludGVydmFsID4gMCkgewogICAgICAgICBtX3N0b3BUaW1lci5zdGFydE9u ZVNob3QoaW50ZXJ2YWwpOwogICAgICAgICBwcmludGYoIiBmb3IgYSBpbnRlcnZhbCBvZiAlZyBz ZWNvbmRzIiwgaW50ZXJ2YWwpOwpAQCAtOTgsNyArOTgsNyBAQCB2b2lkIFdlYk1lbW9yeVNhbXBs ZXI6OnN0b3AoKQogICAgICAgICByZXR1cm47CiAgICAgbV9zYW1wbGVUaW1lci5zdG9wKCk7CiAg ICAgbV9zYW1wbGVMb2dGaWxlID0gMDsKLSAgICBwcmludGYoIlN0b3BwZWQgbWVtb3J5IHNhbXBs ZXIgZm9yIHByb2Nlc3MgJXNcbiIsIHByb2Nlc3NOYW1lKCkudXRmOCgpLmRhdGEoKSk7CisgICAg cHJpbnRmKCJTdG9wcGVkIG1lbW9yeSBzYW1wbGVyIGZvciBwcm9jZXNzICVzICVkXG4iLCBwcm9j ZXNzTmFtZSgpLnV0ZjgoKS5kYXRhKCksIGdldHBpZCgpKTsKICAgICAvLyBGbHVzaCBzdGRvdXQg YnVmZmVyIHNvIHB5dGhvbiBzY3JpcHQgY2FuIGJlIGd1YXJhbnRlZWQgdG8gcmVhZCB1cCB0byB0 aGlzIHBvaW50LgogICAgIGZmbHVzaChzdGRvdXQpOwogICAgIG1faXNSdW5uaW5nID0gZmFsc2U7 CkBAIC0xMzUsNyArMTM1LDcgQEAgdm9pZCBXZWJNZW1vcnlTYW1wbGVyOjppbml0aWFsaXplU2Fu ZGJveGVkTG9nRmlsZShjb25zdCBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGUKIAogdm9pZCBXZWJN ZW1vcnlTYW1wbGVyOjp3cml0ZUhlYWRlcnMoKQogewotICAgIFN0cmluZyBwcm9jZXNzRGV0YWls cyA9ICJQcm9jZXNzOiAiICsgcHJvY2Vzc05hbWUoKSArICdcbic7CisgICAgU3RyaW5nIHByb2Nl c3NEZXRhaWxzID0gU3RyaW5nOjpmb3JtYXQoIlByb2Nlc3M6ICVzIFBpZDogJWRcbiIsIHByb2Nl c3NOYW1lKCkudXRmOCgpLmRhdGEoKSwgZ2V0cGlkKCkpOwogCiAgICAgQ1N0cmluZyB1dGY4U3Ry aW5nID0gcHJvY2Vzc0RldGFpbHMudXRmOCgpOwogICAgIHdyaXRlVG9GaWxlKG1fc2FtcGxlTG9n RmlsZSwgdXRmOFN0cmluZy5kYXRhKCksIHV0ZjhTdHJpbmcubGVuZ3RoKCkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCmluZGV4IDFlODQzN2IuLmZlNjlmMmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKQEAgLTQ5Nyw3ICs0OTcsNyBAQCB2 b2lkIFdlYkNvbnRleHQ6OnByb2Nlc3NEaWRGaW5pc2hMYXVuY2hpbmcoV2ViUHJvY2Vzc1Byb3h5 KiBwcm9jZXNzKQogICAgIGlmIChtX21lbW9yeVNhbXBsZXJFbmFibGVkKSB7CiAgICAgICAgIFNh bmRib3hFeHRlbnNpb246OkhhbmRsZSBzYW1wbGVMb2dTYW5kYm94SGFuZGxlOyAgICAgICAgCiAg ICAgICAgIGRvdWJsZSBub3cgPSBXVEY6OmN1cnJlbnRUaW1lKCk7Ci0gICAgICAgIFN0cmluZyBz YW1wbGVMb2dGaWxlUGF0aCA9IFN0cmluZzo6Zm9ybWF0KCJXZWJQcm9jZXNzJWxsdSIsIHN0YXRp Y19jYXN0PHVuc2lnbmVkIGxvbmcgbG9uZz4obm93KSk7CisgICAgICAgIFN0cmluZyBzYW1wbGVM b2dGaWxlUGF0aCA9IFN0cmluZzo6Zm9ybWF0KCJXZWJQcm9jZXNzJWxsdXBpZCVkIiwgc3RhdGlj X2Nhc3Q8dW5zaWduZWQgbG9uZyBsb25nPihub3cpLCBwcm9jZXNzLT5wcm9jZXNzSWRlbnRpZmll cigpKTsKICAgICAgICAgc2FtcGxlTG9nRmlsZVBhdGggPSBTYW5kYm94RXh0ZW5zaW9uOjpjcmVh dGVIYW5kbGVGb3JUZW1wb3JhcnlGaWxlKHNhbXBsZUxvZ0ZpbGVQYXRoLCBTYW5kYm94RXh0ZW5z aW9uOjpXcml0ZU9ubHksIHNhbXBsZUxvZ1NhbmRib3hIYW5kbGUpOwogICAgICAgICAKICAgICAg ICAgcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzczo6U3RhcnRNZW1vcnlTYW1wbGVy KHNhbXBsZUxvZ1NhbmRib3hIYW5kbGUsIHNhbXBsZUxvZ0ZpbGVQYXRoLCBtX21lbW9yeVNhbXBs ZXJJbnRlcnZhbCksIDApOwo=