100437 2012-10-25 17:16:12 -0700 SymbolTableIndexHashTraits::needsDestruction should be set to true 2012-10-26 09:21:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 751360 0 msaboff 2012-10-25 17:16:12 -0700 Due to the use of allocated rare data (FatEntry's) in SymbolTableEntry's, the hash trait needsDestruction should be set to true. The code is currently working due to the Key trait, HashTraits<RefPtr<StringImpl> > having needsDestruction set true. If the key or it's trait is set to false, then this would leak memory. 751362 1 msaboff 2012-10-25 17:17:07 -0700 <rdar://problem/12350394> 751369 2 170771 msaboff 2012-10-25 17:32:34 -0700 Created attachment 170771 Patch 751374 3 170771 mhahnenberg 2012-10-25 17:36:17 -0700 Comment on attachment 170771 Patch r=me 751487 4 170771 webkit.review.bot 2012-10-25 20:28:45 -0700 Comment on attachment 170771 Patch Clearing flags on attachment: 170771 Committed r132566: <http://trac.webkit.org/changeset/132566> 751488 5 webkit.review.bot 2012-10-25 20:28:48 -0700 All reviewed patches have been landed. Closing bug. 752125 6 170771 darin 2012-10-26 09:21:14 -0700 Comment on attachment 170771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170771&action=review > Source/JavaScriptCore/runtime/SymbolTable.h:340 > - static const bool needsDestruction = false; > + static const bool needsDestruction = true; A simpler correct fix is to simply remove this line entirely. It is true by default for structs, so no need to explicitly set it to true. 170771 2012-10-25 17:32:34 -0700 2012-10-26 09:21:14 -0700 Patch 100437.patch text/plain 1510 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMyNTQ1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTEwLTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFN5bWJvbFRhYmxlSW5kZXhIYXNoVHJhaXRzOjpuZWVkc0Rlc3RydWN0aW9uIHNob3VsZCBi ZSBzZXQgdG8gdHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAwNDM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRm9yIGNvcnJlY3RuZXNzLCBzZXQgU3ltYm9sVGFibGVJbmRleEhhc2hUcmFpdHM6Om5l ZWRzRGVzdHJ1Y3Rpb24gdG8gdHJ1ZSBzaW5jZSBTeW1ib2xUYWJsZUVudHJ5J3MgZG8KKyAgICAg ICAgbmVlZCB0byBoYXZlIHRoZWlyIGRlc3RydWN0b3IgY2FsbGVkIGR1ZSB0byB0aGUgcG9zc2li aWxpdHkgb2YgcmFyZSBkYXRhLgorCisgICAgICAgICogcnVudGltZS9TeW1ib2xUYWJsZS5oOgor ICAgICAgICAoU3ltYm9sVGFibGVJbmRleEhhc2hUcmFpdHMpOgorCiAyMDEyLTEwLTI1ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CiAKICAgICAgICAg Q29uZGl0aW9uYWxpemUgWEhSIHRpbWVvdXQgc3VwcG9ydApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TeW1ib2xUYWJsZS5oCShyZXZpc2lvbiAxMzI1MTApCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TeW1ib2xUYWJsZS5oCSh3b3JraW5nIGNvcHkpCkBA IC0zMzcsNyArMzM3LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICBzdHJ1Y3QgU3ltYm9sVGFi bGVJbmRleEhhc2hUcmFpdHMgOiBIYXNoVHJhaXRzPFN5bWJvbFRhYmxlRW50cnk+IHsKICAgICAg ICAgc3RhdGljIGNvbnN0IGJvb2wgZW1wdHlWYWx1ZUlzWmVybyA9IHRydWU7Ci0gICAgICAgIHN0 YXRpYyBjb25zdCBib29sIG5lZWRzRGVzdHJ1Y3Rpb24gPSBmYWxzZTsKKyAgICAgICAgc3RhdGlj IGNvbnN0IGJvb2wgbmVlZHNEZXN0cnVjdGlvbiA9IHRydWU7CiAgICAgfTsKIAogICAgIHR5cGVk ZWYgSGFzaE1hcDxSZWZQdHI8U3RyaW5nSW1wbD4sIFN5bWJvbFRhYmxlRW50cnksIElkZW50aWZp ZXJSZXBIYXNoLCBIYXNoVHJhaXRzPFJlZlB0cjxTdHJpbmdJbXBsPiA+LCBTeW1ib2xUYWJsZUlu ZGV4SGFzaFRyYWl0cz4gU3ltYm9sVGFibGU7Cg==