100436 2012-10-25 17:12:12 -0700 Build bot gives incorrect link to EWS build failure 2012-10-26 14:14:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu abarth dpranke ojan tony webkit.review.bot oldest_to_newest 751359 0 wangxianzhu 2012-10-25 17:12:12 -0700 I met this more than once. The most recent one is in bug 98144 #15: (From update of attachment 170698 [details]) Attachment 170698 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14555811 New failing tests: compositing/layer-creation/fixed-position-absolute-descendant.html The link "http://queues.webkit.org/results/14555811" is incorrect because it doesn't contain any information about the failed test. It seems the result of another patch. The links in http://queues.webkit.org/patch/170698 (from the EWS bubbles of the patch) are correct. 751363 1 wangxianzhu 2012-10-25 17:17:18 -0700 (In reply to comment #0) > The links in http://queues.webkit.org/patch/170698 (from the EWS bubbles of the patch) are correct. Actually the link in the message is the build result of: Unable to pass tests without patch (tree is red?) [results] in http://queues.webkit.org/patch/170698 page. Would be better to give the link to the failure of the patch itself. 751371 2 abarth 2012-10-25 17:33:43 -0700 Yes, we've had this bug for a while. The code is in Tools/Scripts/webkitpy if you're interested in fixing it. 751385 3 170774 wangxianzhu 2012-10-25 18:01:13 -0700 Created attachment 170774 Patch 751395 4 170774 abarth 2012-10-25 18:10:26 -0700 Comment on attachment 170774 Patch Great! Can you run test-webkitpy to make sure we didn't break any unit tests? We should also write a unit test for this change. 751406 5 ojan 2012-10-25 18:27:20 -0700 Oh my god! Thanks for fixing this! 751424 6 wangxianzhu 2012-10-25 18:46:56 -0700 test-webkitpy passed. Will add a unit test tomorrow. 752154 7 170950 wangxianzhu 2012-10-26 10:16:21 -0700 Created attachment 170950 Patch 752155 8 170950 wangxianzhu 2012-10-26 10:17:04 -0700 Comment on attachment 170950 Patch Reusing the existing CommitQueueTaskTest.test_red_tree_patch_rejection as the unit test. 752227 9 170950 webkit.review.bot 2012-10-26 11:44:55 -0700 Comment on attachment 170950 Patch Clearing flags on attachment: 170950 Committed r132679: <http://trac.webkit.org/changeset/132679> 752228 10 webkit.review.bot 2012-10-26 11:45:00 -0700 All reviewed patches have been landed. Closing bug. 752382 11 170950 abarth 2012-10-26 14:14:06 -0700 Comment on attachment 170950 Patch Nice test. Thank you. 170774 2012-10-25 18:01:13 -0700 2012-10-26 10:16:17 -0700 Patch bug-100436-20121025175946.patch text/plain 2104 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjExMDEyOGIyOTExZTIxNDI4MDljMjIzZmMwMDk1MDI3 YTBkNjVkZC4uMzY4NjM2Yzk1ZWFkYmM5YjYyYzU5Y2E0NzQ4NDg2MTU5MDZiYzg3ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTEwLTI1ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgQnVpbGQgYm90IGdpdmVzIGluY29ycmVjdCBsaW5rIHRvIEVXUyBidWlsZCBm YWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDA0MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHk6CisgICAgICAg IChQYXRjaEFuYWx5c2lzVGFzay5fdGVzdF9wYXRjaCk6IFVzZSB0aGUgZmFpbHVyZV9zdGF0dXNf aWQgb2YgdGVzdCB3aXRoIHBhdGNoIHdoZW4gdGVzdCB3aXRob3V0IHBhdGNoIGZhaWxzIGFuZCB0 ZXN0IHdpdGggcGF0Y2ggaGFzIHVuZXhwZWN0ZWQgZmFpbHVyZXMuCisKIDIwMTItMTAtMjUgIEtl bm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIFVwZGF0ZSBteSBjb250YWN0IGluZm8uCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3BhdGNoYW5hbHlzaXN0YXNrLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9wYXRjaGFuYWx5c2lzdGFzay5weQppbmRleCAwNWJhNzM3 OTg0MGQ3OWEzYmIwM2NhZDQzMDFhM2NlNWE2NmQyMDVhLi5jZGUxYzg0MmU5MDFkZmY0MGJjMDky NzZlY2NiODhkZTE0ODM4NTZiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvYm90L3BhdGNoYW5hbHlzaXN0YXNrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHkKQEAgLTE4Niw2ICsxODYsNyBAQCBjbGFzcyBQ YXRjaEFuYWx5c2lzVGFzayhvYmplY3QpOgogICAgICAgICBmaXJzdF9yZXN1bHRzID0gc2VsZi5f ZGVsZWdhdGUudGVzdF9yZXN1bHRzKCkKICAgICAgICAgZmlyc3RfcmVzdWx0c19hcmNoaXZlID0g c2VsZi5fZGVsZWdhdGUuYXJjaGl2ZV9sYXN0X3Rlc3RfcmVzdWx0cyhzZWxmLl9wYXRjaCkKICAg ICAgICAgZmlyc3Rfc2NyaXB0X2Vycm9yID0gc2VsZi5fc2NyaXB0X2Vycm9yCisgICAgICAgIGZp cnN0X2ZhaWx1cmVfc3RhdHVzX2lkID0gc2VsZi5mYWlsdXJlX3N0YXR1c19pZAogCiAgICAgICAg IGlmIHNlbGYuX2V4cGVjdGVkX2ZhaWx1cmVzLmZhaWx1cmVzX3dlcmVfZXhwZWN0ZWQoZmlyc3Rf cmVzdWx0cyk6CiAgICAgICAgICAgICByZXR1cm4gVHJ1ZQpAQCAtMjIzLDYgKzIyNCw3IEBAIGNs YXNzIFBhdGNoQW5hbHlzaXNUYXNrKG9iamVjdCk6CiAgICAgICAgICMgTm93IHRoYXQgd2UgaGF2 ZSB1cGRhdGVkIGluZm9ybWF0aW9uIGFib3V0IGZhaWxpbmcgdGVzdHMgd2l0aCBhIGNsZWFuIGNo ZWNrb3V0LCB3ZSBjYW4KICAgICAgICAgIyB0ZWxsIGlmIG91ciBvcmlnaW5hbCBmYWlsdXJlcyB3 ZXJlIHVuZXhwZWN0ZWQgYW5kIGZhaWwgdGhlIHBhdGNoIGlmIG5lY2Vzc2FyeS4KICAgICAgICAg aWYgc2VsZi5fZXhwZWN0ZWRfZmFpbHVyZXMudW5leHBlY3RlZF9mYWlsdXJlc19vYnNlcnZlZChm aXJzdF9yZXN1bHRzKToKKyAgICAgICAgICAgIHNlbGYuZmFpbHVyZV9zdGF0dXNfaWQgPSBmaXJz dF9mYWlsdXJlX3N0YXR1c19pZAogICAgICAgICAgICAgcmV0dXJuIHNlbGYucmVwb3J0X2ZhaWx1 cmUoZmlyc3RfcmVzdWx0c19hcmNoaXZlLCBmaXJzdF9yZXN1bHRzLCBmaXJzdF9zY3JpcHRfZXJy b3IpCiAKICAgICAgICAgIyBXZSBkb24ndCBrbm93IHdoYXQncyBnb2luZyBvbi4gIFRoZSB0cmVl IGlzIGxpa2VseSB2ZXJ5IHJlZCAoYmV5b25kIG91ciBsYXlvdXQtdGVzdC1yZXN1bHRzCg== 170950 2012-10-26 10:16:21 -0700 2012-10-26 14:14:06 -0700 Patch bug-100436-20121026101453.patch text/plain 4019 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjExMDEyOGIyOTExZTIxNDI4MDljMjIzZmMwMDk1MDI3 YTBkNjVkZC4uM2ViMzhmMzQyZTUwNmYyMDdjOTNiMzA4MzE4OGFmMzEyNGY1MTNhMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEwLTI1ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgQnVpbGQgYm90IGdpdmVzIGluY29ycmVjdCBsaW5rIHRvIEVXUyBidWlsZCBm YWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDA0MzYKKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHk6CisgICAg ICAgIChNb2NrQ29tbWl0UXVldWUuX19pbml0X18pOgorICAgICAgICAoTW9ja0NvbW1pdFF1ZXVl LmNvbW1hbmRfZmFpbGVkKTogUmV0dXJuIGluY3JlbWVudGFsIGZhaWx1cmVfc3RhdHVzX2lkCisg ICAgICAgIChDb21taXRRdWV1ZVRhc2tUZXN0LnRlc3RfcmVkX3RyZWVfcGF0Y2hfcmVqZWN0aW9u KTogQ2hlY2sgZmFpbHVyZV9zdGF0dXNfaWQKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvYm90L3BhdGNoYW5hbHlzaXN0YXNrLnB5OgorICAgICAgICAoUGF0Y2hBbmFseXNpc1Rhc2su X3Rlc3RfcGF0Y2gpOiBVc2UgdGhlIGZhaWx1cmVfc3RhdHVzX2lkIG9mIHRlc3Qgd2l0aCBwYXRj aCB3aGVuIHRlc3Qgd2l0aG91dCBwYXRjaCBmYWlscyBhbmQgdGVzdCB3aXRoIHBhdGNoIGhhcyB1 bmV4cGVjdGVkIGZhaWx1cmVzLgorCiAyMDEyLTEwLTI1ICBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUg bXkgY29udGFjdCBpbmZvLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvYm90L2NvbW1pdHF1ZXVldGFza191bml0dGVzdC5weQppbmRleCAwY2VmOGM4NjdiMjBh Y2MwNTdjYjNmOGVlMmE0ZTIzODVlMjJiNzM5Li44YjMzNDE2MjM0OTg1ZjMwZmM1N2VkNDE0Zjky OTFiMWM4Yjg2YTI5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90 L2NvbW1pdHF1ZXVldGFza191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvYm90L2NvbW1pdHF1ZXVldGFza191bml0dGVzdC5weQpAQCAtNDUsNiArNDUsNyBAQCBm cm9tIHdlYmtpdHB5LnRvb2wubW9ja3Rvb2wgaW1wb3J0IE1vY2tUb29sCiBjbGFzcyBNb2NrQ29t bWl0UXVldWUoQ29tbWl0UXVldWVUYXNrRGVsZWdhdGUpOgogICAgIGRlZiBfX2luaXRfXyhzZWxm LCBlcnJvcl9wbGFuKToKICAgICAgICAgc2VsZi5fZXJyb3JfcGxhbiA9IGVycm9yX3BsYW4KKyAg ICAgICAgc2VsZi5fZmFpbHVyZV9zdGF0dXNfaWQgPSAwCiAKICAgICBkZWYgcnVuX2NvbW1hbmQo c2VsZiwgY29tbWFuZCk6CiAgICAgICAgIGxvZygicnVuX3dlYmtpdF9wYXRjaDogJXMiICUgY29t bWFuZCkKQEAgLTYwLDcgKzYxLDggQEAgY2xhc3MgTW9ja0NvbW1pdFF1ZXVlKENvbW1pdFF1ZXVl VGFza0RlbGVnYXRlKToKICAgICBkZWYgY29tbWFuZF9mYWlsZWQoc2VsZiwgZmFpbHVyZV9tZXNz YWdlLCBzY3JpcHRfZXJyb3IsIHBhdGNoKToKICAgICAgICAgbG9nKCJjb21tYW5kX2ZhaWxlZDog ZmFpbHVyZV9tZXNzYWdlPSclcycgc2NyaXB0X2Vycm9yPSclcycgcGF0Y2g9JyVzJyIgJSAoCiAg ICAgICAgICAgICBmYWlsdXJlX21lc3NhZ2UsIHNjcmlwdF9lcnJvciwgcGF0Y2guaWQoKSkpCi0g ICAgICAgIHJldHVybiAzOTQ3CisgICAgICAgIHNlbGYuX2ZhaWx1cmVfc3RhdHVzX2lkICs9IDEK KyAgICAgICAgcmV0dXJuIHNlbGYuX2ZhaWx1cmVfc3RhdHVzX2lkCiAKICAgICBkZWYgcmVmZXRj aF9wYXRjaChzZWxmLCBwYXRjaCk6CiAgICAgICAgIHJldHVybiBwYXRjaApAQCAtNTIyLDYgKzUy NCw4IEBAIGNvbW1hbmRfZmFpbGVkOiBmYWlsdXJlX21lc3NhZ2U9J1VuYWJsZSB0byBwYXNzIHRl c3RzIHdpdGhvdXQgcGF0Y2ggKHRyZWUgaXMgcmVkCiAiIiIKICAgICAgICAgdGFzayA9IHNlbGYu X3J1bl90aHJvdWdoX3Rhc2soY29tbWl0X3F1ZXVlLCBleHBlY3RlZF9zdGRlcnIsIEdvbGRlblNj cmlwdEVycm9yKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHRhc2sucmVzdWx0c19mcm9tX3Bh dGNoX3Rlc3RfcnVuKHRhc2suX3BhdGNoKS5mYWlsaW5nX3Rlc3RzKCksIFsiZm9vLmh0bWwiLCAi YmFyLmh0bWwiXSkKKyAgICAgICAgIyBmYWlsdXJlX3N0YXR1c19pZCBzaG91bGQgYmUgb2YgdGhl IHRlc3Qgd2l0aCBwYXRjaCAoMSksIG5vdCB0aGUgdGVzdCB3aXRob3V0IHBhdGNoICgyKS4KKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbCh0YXNrLmZhaWx1cmVfc3RhdHVzX2lkLCAxKQogCiAgICAg ZGVmIHRlc3RfbGFuZF9mYWlsdXJlKHNlbGYpOgogICAgICAgICBjb21taXRfcXVldWUgPSBNb2Nr Q29tbWl0UXVldWUoWwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Jv dC9wYXRjaGFuYWx5c2lzdGFzay5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qv cGF0Y2hhbmFseXNpc3Rhc2sucHkKaW5kZXggMDViYTczNzk4NDBkNzlhM2JiMDNjYWQ0MzAxYTNj ZTVhNjZkMjA1YS4uY2RlMWM4NDJlOTAxZGZmNDBiYzA5Mjc2ZWNjYjg4ZGUxNDgzODU2YiAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9wYXRjaGFuYWx5c2lzdGFz ay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3BhdGNoYW5hbHlzaXN0 YXNrLnB5CkBAIC0xODYsNiArMTg2LDcgQEAgY2xhc3MgUGF0Y2hBbmFseXNpc1Rhc2sob2JqZWN0 KToKICAgICAgICAgZmlyc3RfcmVzdWx0cyA9IHNlbGYuX2RlbGVnYXRlLnRlc3RfcmVzdWx0cygp CiAgICAgICAgIGZpcnN0X3Jlc3VsdHNfYXJjaGl2ZSA9IHNlbGYuX2RlbGVnYXRlLmFyY2hpdmVf bGFzdF90ZXN0X3Jlc3VsdHMoc2VsZi5fcGF0Y2gpCiAgICAgICAgIGZpcnN0X3NjcmlwdF9lcnJv ciA9IHNlbGYuX3NjcmlwdF9lcnJvcgorICAgICAgICBmaXJzdF9mYWlsdXJlX3N0YXR1c19pZCA9 IHNlbGYuZmFpbHVyZV9zdGF0dXNfaWQKIAogICAgICAgICBpZiBzZWxmLl9leHBlY3RlZF9mYWls dXJlcy5mYWlsdXJlc193ZXJlX2V4cGVjdGVkKGZpcnN0X3Jlc3VsdHMpOgogICAgICAgICAgICAg cmV0dXJuIFRydWUKQEAgLTIyMyw2ICsyMjQsNyBAQCBjbGFzcyBQYXRjaEFuYWx5c2lzVGFzayhv YmplY3QpOgogICAgICAgICAjIE5vdyB0aGF0IHdlIGhhdmUgdXBkYXRlZCBpbmZvcm1hdGlvbiBh Ym91dCBmYWlsaW5nIHRlc3RzIHdpdGggYSBjbGVhbiBjaGVja291dCwgd2UgY2FuCiAgICAgICAg ICMgdGVsbCBpZiBvdXIgb3JpZ2luYWwgZmFpbHVyZXMgd2VyZSB1bmV4cGVjdGVkIGFuZCBmYWls IHRoZSBwYXRjaCBpZiBuZWNlc3NhcnkuCiAgICAgICAgIGlmIHNlbGYuX2V4cGVjdGVkX2ZhaWx1 cmVzLnVuZXhwZWN0ZWRfZmFpbHVyZXNfb2JzZXJ2ZWQoZmlyc3RfcmVzdWx0cyk6CisgICAgICAg ICAgICBzZWxmLmZhaWx1cmVfc3RhdHVzX2lkID0gZmlyc3RfZmFpbHVyZV9zdGF0dXNfaWQKICAg ICAgICAgICAgIHJldHVybiBzZWxmLnJlcG9ydF9mYWlsdXJlKGZpcnN0X3Jlc3VsdHNfYXJjaGl2 ZSwgZmlyc3RfcmVzdWx0cywgZmlyc3Rfc2NyaXB0X2Vycm9yKQogCiAgICAgICAgICMgV2UgZG9u J3Qga25vdyB3aGF0J3MgZ29pbmcgb24uICBUaGUgdHJlZSBpcyBsaWtlbHkgdmVyeSByZWQgKGJl eW9uZCBvdXIgbGF5b3V0LXRlc3QtcmVzdWx0cwo=