100435 2012-10-25 17:08:42 -0700 [chromium] Add implicit conversions between WebFloatPoint and gfx::PointF 2012-10-26 12:15:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth cc-bugs dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 751355 0 danakj 2012-10-25 17:08:42 -0700 [chromium] Add implicit conversions between WebFloatPoint and gfx::PointF 751356 1 170768 danakj 2012-10-25 17:09:31 -0700 Created attachment 170768 Patch 751358 2 webkit.review.bot 2012-10-25 17:11:04 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 751471 3 danakj 2012-10-25 19:59:44 -0700 jamesr@ please take a look 752209 4 170768 webkit.review.bot 2012-10-26 11:27:45 -0700 Comment on attachment 170768 Patch Rejecting attachment 170768 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14609146 752218 5 170969 danakj 2012-10-26 11:33:55 -0700 Created attachment 170969 Patch for landing 752273 6 170969 webkit.review.bot 2012-10-26 12:15:53 -0700 Comment on attachment 170969 Patch for landing Clearing flags on attachment: 170969 Committed r132683: <http://trac.webkit.org/changeset/132683> 752274 7 webkit.review.bot 2012-10-26 12:15:57 -0700 All reviewed patches have been landed. Closing bug. 170768 2012-10-25 17:09:31 -0700 2012-10-26 11:33:52 -0700 Patch bug-100435-20121025200804.patch text/plain 1798 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzZDk4M2JhNTNkZDk0 OGI0NmVjYmRjNzkwZWU3OGYwYjM5OGQzZjgwLi44MGEyYzQ5ZjBhNTA4NGYwZWUxZTQwZmFiYzQ3 ZDA4NDFlMTE1OGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMC0yNSAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEFkZCBpbXBsaWNpdCBjb252ZXJzaW9ucyBiZXR3ZWVuIFdlYkZsb2F0UG9pbnQgYW5kIGdmeDo6 UG9pbnRGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDA0MzUKKworICAgICAgICBUaGlzIGlzIHNpbWlsYXIgdG8gb3RoZXIgV2ViIGdlb21ldHJ5IHR5 cGVzLCBidXQgdGhlIFdlYkZsb2F0UG9pbnQgaXMKKyAgICAgICAgbWlzc2luZyBpdC4KKworICAg ICAgICAqIGNocm9taXVtL3B1YmxpYy9XZWJGbG9hdFBvaW50Lmg6CisgICAgICAgIChXZWJGbG9h dFBvaW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViRmxvYXRQb2ludDo6V2ViRmxvYXRQb2ludCk6 CisgICAgICAgIChXZWJLaXQ6OldlYkZsb2F0UG9pbnQ6Om9wZXJhdG9yPSk6CisgICAgICAgIChX ZWJLaXQ6OldlYkZsb2F0UG9pbnQ6Om9wZXJhdG9yIGdmeDo6UG9pbnRGKToKKwogMjAxMi0xMC0y MyAgRGF2aWQgUmV2ZW1hbiAgPHJldmVtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gQWRkIENIUk9NSVVNX3RleHR1cmVfZnJvbV9pbWFnZSBleHRlbnNpb24gc3VwcG9ydC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViRmxvYXRQb2lu dC5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJGbG9hdFBvaW50LmgKaW5k ZXggNGFmYzE2YjljODRlNmY1ZWEzMDQwM2ViM2U3N2VjNGYzZThmOWZiOS4uZDQ5YWI5Yjk0ZGNk NDFiNWQ3MDI0ZWExYjkwY2Y4MWRjN2FlOTc2OSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3Jt L2Nocm9taXVtL3B1YmxpYy9XZWJGbG9hdFBvaW50LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2No cm9taXVtL3B1YmxpYy9XZWJGbG9hdFBvaW50LmgKQEAgLTM1LDYgKzM1LDggQEAKIAogI2lmIFdF QktJVF9JTVBMRU1FTlRBVElPTgogI2luY2x1ZGUgIkZsb2F0UG9pbnQuaCIKKyNlbHNlCisjaW5j bHVkZSA8dWkvZ2Z4L3BvaW50X2YuaD4KICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAg LTczLDYgKzc1LDI1IEBAIHN0cnVjdCBXZWJGbG9hdFBvaW50IHsKICAgICB7CiAgICAgICAgIHJl dHVybiBXZWJDb3JlOjpGbG9hdFBvaW50KHgsIHkpOwogICAgIH0KKyNlbHNlCisgICAgV2ViRmxv YXRQb2ludChjb25zdCBnZng6OlBvaW50RiYgcCkKKyAgICAgICAgOiB4KHAueCgpKQorICAgICAg ICAsIHkocC55KCkpCisgICAgeworICAgIH0KKworICAgIFdlYkZsb2F0UG9pbnQmIG9wZXJhdG9y PShjb25zdCBnZng6OlBvaW50RiYgcCkKKyAgICB7CisgICAgICAgIHggPSBwLngoKTsKKyAgICAg ICAgeSA9IHAueSgpOworICAgICAgICByZXR1cm4gKnRoaXM7CisgICAgfQorCisgICAgb3BlcmF0 b3IgZ2Z4OjpQb2ludEYoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGdmeDo6UG9pbnRG KHgsIHkpOworICAgIH0KKwogI2VuZGlmCiB9OwogCg== 170969 2012-10-26 11:33:55 -0700 2012-10-26 12:15:53 -0700 Patch for landing bug-100435-20121026143227.patch text/plain 1837 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzZDk4M2JhNTNkZDk0 OGI0NmVjYmRjNzkwZWU3OGYwYjM5OGQzZjgwLi5lOTFlNDZjYTIyZTZhMzQzOGRlOWQ5MWRlZGRj Zjg4ZWZmZWI3OTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yNSAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEFkZCBpbXBsaWNpdCBjb252ZXJzaW9ucyBiZXR3ZWVuIFdlYkZsb2F0UG9pbnQgYW5kIGdmeDo6 UG9pbnRGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDA0MzUKKworICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KKworICAgICAgICBU aGlzIGlzIHNpbWlsYXIgdG8gb3RoZXIgV2ViIGdlb21ldHJ5IHR5cGVzLCBidXQgdGhlIFdlYkZs b2F0UG9pbnQgaXMKKyAgICAgICAgbWlzc2luZyBpdC4KKworICAgICAgICAqIGNocm9taXVtL3B1 YmxpYy9XZWJGbG9hdFBvaW50Lmg6CisgICAgICAgIChXZWJGbG9hdFBvaW50KToKKyAgICAgICAg KFdlYktpdDo6V2ViRmxvYXRQb2ludDo6V2ViRmxvYXRQb2ludCk6CisgICAgICAgIChXZWJLaXQ6 OldlYkZsb2F0UG9pbnQ6Om9wZXJhdG9yPSk6CisgICAgICAgIChXZWJLaXQ6OldlYkZsb2F0UG9p bnQ6Om9wZXJhdG9yIGdmeDo6UG9pbnRGKToKKwogMjAxMi0xMC0yMyAgRGF2aWQgUmV2ZW1hbiAg PHJldmVtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gQWRkIENIUk9NSVVN X3RleHR1cmVfZnJvbV9pbWFnZSBleHRlbnNpb24gc3VwcG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViRmxvYXRQb2ludC5oIGIvU291cmNlL1BsYXRm b3JtL2Nocm9taXVtL3B1YmxpYy9XZWJGbG9hdFBvaW50LmgKaW5kZXggNGFmYzE2YjljODRlNmY1 ZWEzMDQwM2ViM2U3N2VjNGYzZThmOWZiOS4uZDQ5YWI5Yjk0ZGNkNDFiNWQ3MDI0ZWExYjkwY2Y4 MWRjN2FlOTc2OSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9X ZWJGbG9hdFBvaW50LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJG bG9hdFBvaW50LmgKQEAgLTM1LDYgKzM1LDggQEAKIAogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElP TgogI2luY2x1ZGUgIkZsb2F0UG9pbnQuaCIKKyNlbHNlCisjaW5jbHVkZSA8dWkvZ2Z4L3BvaW50 X2YuaD4KICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAgLTczLDYgKzc1LDI1IEBAIHN0 cnVjdCBXZWJGbG9hdFBvaW50IHsKICAgICB7CiAgICAgICAgIHJldHVybiBXZWJDb3JlOjpGbG9h dFBvaW50KHgsIHkpOwogICAgIH0KKyNlbHNlCisgICAgV2ViRmxvYXRQb2ludChjb25zdCBnZng6 OlBvaW50RiYgcCkKKyAgICAgICAgOiB4KHAueCgpKQorICAgICAgICAsIHkocC55KCkpCisgICAg eworICAgIH0KKworICAgIFdlYkZsb2F0UG9pbnQmIG9wZXJhdG9yPShjb25zdCBnZng6OlBvaW50 RiYgcCkKKyAgICB7CisgICAgICAgIHggPSBwLngoKTsKKyAgICAgICAgeSA9IHAueSgpOworICAg ICAgICByZXR1cm4gKnRoaXM7CisgICAgfQorCisgICAgb3BlcmF0b3IgZ2Z4OjpQb2ludEYoKSBj b25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGdmeDo6UG9pbnRGKHgsIHkpOworICAgIH0KKwog I2VuZGlmCiB9OwogCg==