100430 2012-10-25 15:53:01 -0700 [V8] We can merge ActiveDOMObjectPrologueVisitor with ObjectVisitor 2012-10-25 20:12:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100432 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 751303 0 abarth 2012-10-25 15:53:01 -0700 [V8] We can merge ActiveDOMObjectPrologueVisitor with ObjectVisitor 751305 1 170754 abarth 2012-10-25 15:53:42 -0700 Created attachment 170754 Patch 751311 2 170754 eric 2012-10-25 15:59:26 -0700 Comment on attachment 170754 Patch So this saves a whole walk of the liveObjects? 751315 3 abarth 2012-10-25 16:04:50 -0700 > So this saves a whole walk of the liveObjects? We don't walk liveObjects. We accumulate liveObjects and then inform V8 about them. This shouldn't have any functional or performance change. We're just doing the walk in with one object rather than two. The eventual goal is to be able to do all the walks at once so we can drive them all from the V8 side. 751320 4 170754 eric 2012-10-25 16:08:01 -0700 Comment on attachment 170754 Patch Understood. LGTM. 751478 5 170754 webkit.review.bot 2012-10-25 20:12:04 -0700 Comment on attachment 170754 Patch Clearing flags on attachment: 170754 Committed r132564: <http://trac.webkit.org/changeset/132564> 751479 6 webkit.review.bot 2012-10-25 20:12:08 -0700 All reviewed patches have been landed. Closing bug. 170754 2012-10-25 15:53:42 -0700 2012-10-25 20:12:04 -0700 Patch bug-100430-20121025155215.patch text/plain 4192 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZmZjA1YzFmMGUxNGI2 YTkwZWU4OWY2ZGViYzllYzM2YmFiYWZjZC4uYzk2OTZiMDQ5NDFjMjcxNTU5OWY4ODRmZjEwMTg1 YjRhYWE0N2RmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTEwLTI1ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBXZSBjYW4gbWVyZ2Ug QWN0aXZlRE9NT2JqZWN0UHJvbG9ndWVWaXNpdG9yIHdpdGggT2JqZWN0VmlzaXRvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNDMwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUncyBubyByZWFz b24gZm9yIHRoZXNlIHZpc2l0b3JzIHRvIGJlIHNlcGFyYXRlIG9iamVjdHMgYW55bW9yZS4KKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok9iamVjdFZpc2l0b3I6Ok9iamVjdFZpc2l0b3IpOgorICAgICAgICAoV2ViQ29yZTo6T2Jq ZWN0VmlzaXRvcjo6dmlzaXRET01XcmFwcGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250 cm9sbGVyOjptYWpvckdDUHJvbG9ndWUpOgorCisyMDEyLTEwLTI1ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgW1Y4XSBBY3RpdmVET01Ob2RlcyBubyBsb25nZXIg cmVxdWlyZSBhIHNlcGFyYXRlIHdyYXBwZXIgbWFwCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzNTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCmluZGV4IDFlZWJiYmU1NWFkOGI5YjYyZWQ1ZTRiZTg1 MTFhZTA4OTFiYmFmMGYuLjZlNzc5MDdlMGRmZjY4OTY1ZGI3ODIzOGMzMTU5ZDg0NmNjMWMxZGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKQEAg LTY3LDE2ICs2NywxNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIEFjdGl2ZURP TU9iamVjdFByb2xvZ3VlVmlzaXRvciA6IHB1YmxpYyBET01XcmFwcGVyVmlzaXRvcjx2b2lkPiB7 CitjbGFzcyBPYmplY3RWaXNpdG9yIDogcHVibGljIERPTVdyYXBwZXJWaXNpdG9yPHZvaWQ+IHsK IHB1YmxpYzoKLSAgICBleHBsaWNpdCBBY3RpdmVET01PYmplY3RQcm9sb2d1ZVZpc2l0b3IoVmVj dG9yPHY4OjpQZXJzaXN0ZW50PHY4OjpWYWx1ZT4gPiogbGl2ZU9iamVjdHMpCisgICAgZXhwbGlj aXQgT2JqZWN0VmlzaXRvcihWZWN0b3I8djg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiA+KiBsaXZl T2JqZWN0cykKICAgICAgICAgOiBtX2xpdmVPYmplY3RzKGxpdmVPYmplY3RzKQogICAgIHsKICAg ICB9CiAKLSAgICB2b2lkIHZpc2l0RE9NV3JhcHBlcihET01EYXRhU3RvcmUqLCB2b2lkKiBvYmpl Y3QsIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIpCisgICAgdm9pZCB2aXNpdERP TVdyYXBwZXIoRE9NRGF0YVN0b3JlKiBzdG9yZSwgdm9pZCogb2JqZWN0LCB2ODo6UGVyc2lzdGVu dDx2ODo6T2JqZWN0PiB3cmFwcGVyKQogICAgIHsKLSAgICAgICAgV3JhcHBlclR5cGVJbmZvKiB0 eXBlID0gVjhET01XcmFwcGVyOjpkb21XcmFwcGVyVHlwZSh3cmFwcGVyKTsgIAorICAgICAgICBX cmFwcGVyVHlwZUluZm8qIHR5cGUgPSBWOERPTVdyYXBwZXI6OmRvbVdyYXBwZXJUeXBlKHdyYXBw ZXIpOwogCiAgICAgICAgIGlmIChWOE1lc3NhZ2VQb3J0OjppbmZvLmVxdWFscyh0eXBlKSkgewog ICAgICAgICAgICAgLy8gTWFyayBlYWNoIHBvcnQgYXMgaW4tdXNlIGlmIGl0J3MgZW50YW5nbGVk LiBGb3Igc2ltcGxpY2l0eSdzIHNha2UsCkBAIC04NSwyNiArODUsMTkgQEAgcHVibGljOgogICAg ICAgICAgICAgTWVzc2FnZVBvcnQqIHBvcnQgPSBzdGF0aWNfY2FzdDxNZXNzYWdlUG9ydCo+KG9i amVjdCk7CiAgICAgICAgICAgICBpZiAocG9ydC0+aXNFbnRhbmdsZWQoKSB8fCBwb3J0LT5oYXNQ ZW5kaW5nQWN0aXZpdHkoKSkKICAgICAgICAgICAgICAgICBtX2xpdmVPYmplY3RzLT5hcHBlbmQo d3JhcHBlcik7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICBBY3RpdmVET01PYmplY3QqIGFjdGl2ZURPTU9iamVjdCA9IHR5cGUtPnRvQWN0aXZlRE9N T2JqZWN0KHdyYXBwZXIpOworICAgICAgICAgICAgaWYgKGFjdGl2ZURPTU9iamVjdCAmJiBhY3Rp dmVET01PYmplY3QtPmhhc1BlbmRpbmdBY3Rpdml0eSgpKQorICAgICAgICAgICAgICAgIG1fbGl2 ZU9iamVjdHMtPmFwcGVuZCh3cmFwcGVyKTsKICAgICAgICAgfQogCi0gICAgICAgIEFjdGl2ZURP TU9iamVjdCogYWN0aXZlRE9NT2JqZWN0ID0gdHlwZS0+dG9BY3RpdmVET01PYmplY3Qod3JhcHBl cik7Ci0gICAgICAgIGlmIChhY3RpdmVET01PYmplY3QgJiYgYWN0aXZlRE9NT2JqZWN0LT5oYXNQ ZW5kaW5nQWN0aXZpdHkoKSkKLSAgICAgICAgICAgIG1fbGl2ZU9iamVjdHMtPmFwcGVuZCh3cmFw cGVyKTsKKyAgICAgICAgdHlwZS0+dmlzaXRET01XcmFwcGVyKHN0b3JlLCBvYmplY3QsIHdyYXBw ZXIpOwogICAgIH0KIAogcHJpdmF0ZToKICAgICBWZWN0b3I8djg6OlBlcnNpc3RlbnQ8djg6OlZh bHVlPiA+KiBtX2xpdmVPYmplY3RzOwogfTsKIAotY2xhc3MgT2JqZWN0VmlzaXRvciA6IHB1Ymxp YyBET01XcmFwcGVyVmlzaXRvcjx2b2lkPiB7Ci1wdWJsaWM6Ci0gICAgdm9pZCB2aXNpdERPTVdy YXBwZXIoRE9NRGF0YVN0b3JlKiBzdG9yZSwgdm9pZCogb2JqZWN0LCB2ODo6UGVyc2lzdGVudDx2 ODo6T2JqZWN0PiB3cmFwcGVyKQotICAgIHsKLSAgICAgICAgVjhET01XcmFwcGVyOjpkb21XcmFw cGVyVHlwZSh3cmFwcGVyKS0+dmlzaXRET01XcmFwcGVyKHN0b3JlLCBvYmplY3QsIHdyYXBwZXIp OwotICAgIH0KLX07Ci0KIHN0YXRpYyB2b2lkIGFkZEltcGxpY2l0UmVmZXJlbmNlc0Zvck5vZGVX aXRoRXZlbnRMaXN0ZW5lcnMoTm9kZSogbm9kZSwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4g d3JhcHBlcikKIHsKICAgICBBU1NFUlQobm9kZS0+aGFzRXZlbnRMaXN0ZW5lcnMoKSk7CkBAIC0y MzQsMTcgKzIyNywxNSBAQCB2b2lkIFY4R0NDb250cm9sbGVyOjptYWpvckdDUHJvbG9ndWUoKQog ICAgIFZlY3Rvcjx2ODo6UGVyc2lzdGVudDx2ODo6VmFsdWU+ID4gbGl2ZU9iamVjdHM7CiAgICAg bGl2ZU9iamVjdHMuYXBwZW5kKFY4UGVySXNvbGF0ZURhdGE6OmN1cnJlbnQoKS0+ZW5zdXJlTGl2 ZVJvb3QoKSk7CiAKLSAgICBBY3RpdmVET01PYmplY3RQcm9sb2d1ZVZpc2l0b3IgYWN0aXZlT2Jq ZWN0VmlzaXRvcigmbGl2ZU9iamVjdHMpOwotICAgIHZpc2l0QWN0aXZlRE9NT2JqZWN0cygmYWN0 aXZlT2JqZWN0VmlzaXRvcik7Ci0KICAgICBOb2RlVmlzaXRvciBub2RlVmlzaXRvcigmbGl2ZU9i amVjdHMpOwogICAgIHZpc2l0QWxsRE9NTm9kZXMoJm5vZGVWaXNpdG9yKTsKICAgICBub2RlVmlz aXRvci5hcHBseUdyb3VwaW5nKCk7CiAKLSAgICB2ODo6Vjg6OkFkZE9iamVjdEdyb3VwKGxpdmVP YmplY3RzLmRhdGEoKSwgbGl2ZU9iamVjdHMuc2l6ZSgpKTsKLQotICAgIE9iamVjdFZpc2l0b3Ig b2JqZWN0VmlzaXRvcjsKKyAgICBPYmplY3RWaXNpdG9yIG9iamVjdFZpc2l0b3IoJmxpdmVPYmpl Y3RzKTsKICAgICB2aXNpdERPTU9iamVjdHMoJm9iamVjdFZpc2l0b3IpOworICAgIHZpc2l0QWN0 aXZlRE9NT2JqZWN0cygmb2JqZWN0VmlzaXRvcik7CisKKyAgICB2ODo6Vjg6OkFkZE9iamVjdEdy b3VwKGxpdmVPYmplY3RzLmRhdGEoKSwgbGl2ZU9iamVjdHMuc2l6ZSgpKTsKIAogICAgIFY4UGVy SXNvbGF0ZURhdGEqIGRhdGEgPSBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCk7CiAgICAgZGF0 YS0+c3RyaW5nQ2FjaGUoKS0+Y2xlYXJPbkdDKCk7Cg==