100406 2012-10-25 13:05:12 -0700 Fix a layout test crash if a TestWebkitPlugin is put inside an iframe 2012-10-25 20:24:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 qinmin webkit-unassigned abarth webkit.review.bot oldest_to_newest 751138 0 qinmin 2012-10-25 13:05:12 -0700 Fix a layout test crash if a TestWebkitPlugin is put inside an iframe 751150 1 170718 qinmin 2012-10-25 13:10:07 -0700 Created attachment 170718 Patch 751429 2 170718 webkit.review.bot 2012-10-25 18:52:55 -0700 Comment on attachment 170718 Patch Rejecting attachment 170718 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14553916 751438 3 qinmin 2012-10-25 18:56:00 -0700 This is wierd, do I also need to modify Source/WebCore/ChangeLog ? 751442 4 170718 abarth 2012-10-25 18:59:39 -0700 Comment on attachment 170718 Patch Sorry, it's another bug with the bots. :) 751485 5 170718 webkit.review.bot 2012-10-25 20:24:06 -0700 Comment on attachment 170718 Patch Clearing flags on attachment: 170718 Committed r132565: <http://trac.webkit.org/changeset/132565> 751486 6 webkit.review.bot 2012-10-25 20:24:10 -0700 All reviewed patches have been landed. Closing bug. 170718 2012-10-25 13:10:07 -0700 2012-10-25 20:24:06 -0700 Patch bug-100406-20121025130840.patch text/plain 4152 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODA5MjBjZWY5NmJiYzE1YmI3ZThmZGM1MzU0MDNiNDM3 ZDI1MjI3Mi4uZDM0NDZmYzg3NmIxNGY1MmM0NWExMmUyNGVjNTM5YTE4ZDA5ZTMyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEwLTI1ICBNaW4gUWluICA8cWlubWluQGNocm9taXVtLm9yZz4KKworICAgICAg ICBGaXggYSBsYXlvdXQgdGVzdCBjcmFzaCBpZiBhIFRlc3RXZWJraXRQbHVnaW4gaXMgcHV0IGlu c2lkZSBhbiBpZnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMDQwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlc2l6ZSB0aGUgY29udGV4dCB3aXRoIGFuIGVtcHR5IHJlY3Qgd2lsbCBjYXVzZSBh IGdsX2Vycm9yIGluIGdsZXMyX2NtZF9kZWNvZGVyLmNjLgorICAgICAgICBEb24ndCBwYWludCB0 aGUgcGx1Z2luIGlmIG1fcmVjdCBpcyBlbXB0eS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RXZWJQbHVnaW4uY3BwOgorICAgICAgICAoVGVzdFdlYlBsdWdpbjo6dXBk YXRlR2VvbWV0cnkpOgorCiAyMDEyLTEwLTI1ICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZGluZyBteXNlbGYgYXMgYSBj b21taXR0ZXIuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 V2ViUGx1Z2luLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RXZWJQbHVn aW4uY3BwCmluZGV4IDcwODBiZWYxOGEyYjQyMzk5YTA4Mjk0OWY5YmUxMjhjMWE1ZWU3NTMuLjQx NGRiMmMxYzVmOWNhNjZhYzJiMzEyMDcxZTI1OTBmYTMyYzkzMzkgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RXZWJQbHVnaW4uY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RXZWJQbHVnaW4uY3BwCkBAIC0yMDYsNiArMjA2LDgg QEAgdm9pZCBUZXN0V2ViUGx1Z2luOjp1cGRhdGVHZW9tZXRyeShjb25zdCBXZWJSZWN0JiBmcmFt ZVJlY3QsCiAgICAgaWYgKGNsaXBSZWN0ID09IG1fcmVjdCkKICAgICAgICAgcmV0dXJuOwogICAg IG1fcmVjdCA9IGNsaXBSZWN0OworICAgIGlmIChtX3JlY3QuaXNFbXB0eSgpKQorICAgICAgICBy ZXR1cm47CiAKICAgICBtX2NvbnRleHQtPnJlc2hhcGUobV9yZWN0LndpZHRoLCBtX3JlY3QuaGVp Z2h0KTsKICAgICBtX2NvbnRleHQtPnZpZXdwb3J0KDAsIDAsIG1fcmVjdC53aWR0aCwgbV9yZWN0 LmhlaWdodCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNTMzM2FiNDJmZDhlYmExODRkNzU5ZGFlMDI2NTk4ZTE2NWY0YTQy OC4uNWJkYTNkZWJiZDc4YWE5NWVkNjg0MjEyYWJlZTQxNTZjMzcyZGI3OCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTEwLTI1ICBNaW4gUWluICA8cWlubWluQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBGaXggYSBsYXlvdXQgdGVzdCBjcmFzaCBpZiBhIFRlc3RXZWJraXRQbHVnaW4gaXMg cHV0IGluc2lkZSBhbiBpZnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMDQwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRlc3QgZm9yIGFkZGluZyBhIHdlYnBsdWdpbiBpbnRvIGFuIGlmcmFtZSBh bmQgbWFrZSBzdXJlIGl0IGRvZXNuJ3QgY3Jhc2guCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS9wbHVnaW5zL3BsdWdpbi1pbnNpZGUtaWZyYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9wbHVnaW4taW5zaWRlLWlmcmFtZS5o dG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL3Jlc291cmNl cy9wbHVnaW4tcGFnZS5odG1sOiBBZGRlZC4KKwogMjAxMi0xMC0yNSAgQ3NhYmEgT3N6dHJvZ29u w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5p bmcsIHNraXAgZmFpbGluZyB0ZXN0cyB0byBzcGVlZHVwIHRlc3RpbmcuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL3BsdWdpbi1pbnNpZGUtaWZyYW1l LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvcGx1 Z2luLWluc2lkZS1pZnJhbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM4ZjJjYWJlZmI2NzFl NmVkM2Q4MzgxNDdlZTk3MTdkMjJjYjFkZTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL3BsdWdpbi1pbnNpZGUtaWZyYW1lLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDIgQEAKKworVGhpcyB0ZXN0cyB0aGF0IHdlIGRvIG5vdCBjcmFzaCBi eSBwdXR0aW5nIGEgcGx1Z2luIGluc2lkZSBhbiBpZnJhbWUuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL3BsdWdpbi1pbnNpZGUtaWZyYW1lLmh0bWwg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL3BsdWdpbi1pbnNpZGUtaWZy YW1lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZTRkNjA4MTg0ODRkM2E1MjlhZGMyMjhjM2UxNDM1ZDNjNWE2 ZGRmYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Bs dWdpbnMvcGx1Z2luLWluc2lkZS1pZnJhbWUuaHRtbApAQCAtMCwwICsxLDE2IEBACis8IWRvY3R5 cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxpZnJhbWUgZnJhbWVi b3JkZXI9IjAiIHdpZHRoPSIyMDAiIGhlaWdodD0iMjAwIiBzcmM9InJlc291cmNlcy9wbHVnaW4t cGFnZS5odG1sIj48L2lmcmFtZT4KKzxzY3JpcHQ+CisgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5l cikgeworICAgICAgICBkb2N1bWVudC53cml0ZSgiVGhpcyB0ZXN0IGRvZXMgbm90IHdvcmsgaW4g bWFudWFsIG1vZGUuIik7CisgICAgfSBlbHNlIHsKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNU ZXh0KCk7CisgICAgfQorPC9zY3JpcHQ+Cis8ZGl2PlRoaXMgdGVzdHMgdGhhdCB3ZSBkbyBub3Qg Y3Jhc2ggYnkgcHV0dGluZyBhIHBsdWdpbiBpbnNpZGUgYW4gaWZyYW1lLjwvZGl2PgorPC9ib2R5 PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vcGx1 Z2lucy9yZXNvdXJjZXMvcGx1Z2luLXBhZ2UuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3BsdWdpbnMvcmVzb3VyY2VzL3BsdWdpbi1wYWdlLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2Jj ZGYzNDc1YzIzNjYyYWZlNzJlN2YzMjg1NDM3MDg3MGFlODY5NQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvcmVzb3VyY2VzL3BsdWdpbi1w YWdlLmh0bWwKQEAgLTAsMCArMSwxNyBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKzxoZWFk PgorPHN0eWxlPgorI3BsdWdpbiB7Citwb3NpdGlvbjogYWJzb2x1dGU7CitsZWZ0OiA1MHB4Owor dG9wOiA1MHB4Oword2lkdGg6IDEwMHB4OworaGVpZ2h0OiAxMDBweDsKK30KKzwvc3R5bGU+Cis8 L2hlYWQ+Cis8Ym9keT4KKzxlbWJlZCBpZD0icGx1Z2luIiB0eXBlPSJhcHBsaWNhdGlvbi94LXdl YmtpdC10ZXN0LXdlYnBsdWdpbiI+PC9lbWJlZD4KKzwvYm9keT4KKzwvaHRtbD4K