100396 2012-10-25 10:49:33 -0700 [chromium] Regression: navigating between composited pages doesn't cause redraw until scrolled 2012-10-25 14:04:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 99882 1 kbr jamesr enne vangelis webkit.review.bot oldest_to_newest 751001 0 kbr 2012-10-25 10:49:33 -0700 ( copied from http://crbug.com/157913 ) What steps will reproduce the problem? 1. Launch Chrome with --force-compositing-mode (note: does not repro on Linux, where it looks like force-compositing-mode has been explicitly disabled) 2. Navigate to https://chromiumcodereview.appspot.com/11266023 3. Click any of the "View" links under the side-by-side diffs column What is the expected output? What do you see instead? Expect that the new page is displayed. Instead, the old page continues to be drawn until scrolled. Bisecting indicates a WebKit roll: You are probably looking for a change made after 163537 (known good), but no later than 163543 (first known bad). WEBKIT CHANGELOG URL: http://trac.webkit.org/log/trunk/?rev=132193&stop_rev=132013&verbose=on&limit=10000 CHANGELOG URL: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=163537%3A163543 and investigation of the WebKit revisions points to: [chromium] Suppress compositor invalidations during FrameView recreation in force-compositing-mode ​https://bugs.webkit.org/show_bug.cgi?id=99882 http://trac.webkit.org/changeset/132173/trunk This was discovered on Canary on Mac, where I believe the force-compositing-mode experiment is still in place. 751155 1 170720 jamesr 2012-10-25 13:14:20 -0700 Created attachment 170720 Patch 751159 2 170720 enne 2012-10-25 13:21:19 -0700 Comment on attachment 170720 Patch R=me. 751189 3 170720 webkit.review.bot 2012-10-25 14:04:51 -0700 Comment on attachment 170720 Patch Clearing flags on attachment: 170720 Committed r132533: <http://trac.webkit.org/changeset/132533> 751190 4 webkit.review.bot 2012-10-25 14:04:55 -0700 All reviewed patches have been landed. Closing bug. 170720 2012-10-25 13:14:20 -0700 2012-10-25 14:04:51 -0700 Patch bug-100396-20121025131253.patch text/plain 3192 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDkxZDlkNWU1ODM1YzUyNWE2ODkxNjhhY2NlNDBlZGU0ZjE3ZTgzOGUuLjBlN2FmNGY1NDc5N2I1 YjY1NzFjNGE3NmNjNDliYjRiZDM4OWIxYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMjUgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFJlZ3Jlc3Npb246IG5hdmlnYXRpbmcgYmV0 d2VlbiBjb21wb3NpdGVkIHBhZ2VzIGRvZXNuJ3QgY2F1c2UgcmVkcmF3IHVudGlsIHNjcm9sbGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzOTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBh cnRpYWxseSByZXZlcnRzIHIxMzIxNzMuICBJdCdzIG5vdCB2YWxpZCB0byBzdXBwcmVzcyBpbnZh bGlkYXRpb25zIGluIGNvbW1pdERvY3VtZW50RGF0YSBzaW5jZSBmb3Igc21hbGwKKyAgICAgICAg b3IgY2FjaGVkIHBhZ2VzIHRoaXMgY291bGQgbG9hZCB1cCB0aGUgd2hvbGUgZG9jdW1lbnQuICBB bHNvIGFkZHMgYW5kIGltcHJvdmVzIHNvbWUgb2YgdGhlIHRyYWNpbmcuCisKKyAgICAgICAgKiBz cmMvV2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpjb21t aXREb2N1bWVudERhdGEpOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OmNyZWF0ZUZy YW1lVmlldyk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViVmlld0ltcGw6OnNjaGVkdWxlQ29tcG9zaXRlKToKKwogMjAxMi0xMC0yNSAgU2FtaSBL eW9zdGlsYSAgPHNreW9zdGlsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDb21wb3NpdGVkL0hX IGNvbnRlbnQgaGF2ZSB0aGUgcmVkIGFuZCBibHVlIGNoYW5uZWxzIGludmVydGVkIGluIERSVCBv biBDaHJvbWl1bSBBbmRyb2lkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJ bXBsLmNwcAppbmRleCA3ZWVmMjkzNDMxNTNmZTMxM2NhOTdkZWE4MDlmNTFhMTI5NTk1ZTc3Li44 YTg5YWE1YTFmYjBjY2E1ODBlYjkyYWJlZGU1ZDQ4ZDM1MzUzNTYwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTE0OCw2ICsxNDgsNyBAQAogI2lu Y2x1ZGUgIlN1YnN0aXR1dGVEYXRhLmgiCiAjaW5jbHVkZSAiVGV4dEFmZmluaXR5LmgiCiAjaW5j bHVkZSAiVGV4dEl0ZXJhdG9yLmgiCisjaW5jbHVkZSAiVHJhY2VFdmVudC5oIgogI2luY2x1ZGUg IlVzZXJHZXN0dXJlSW5kaWNhdG9yLmgiCiAjaW5jbHVkZSAiVjhET01GaWxlU3lzdGVtLmgiCiAj aW5jbHVkZSAiVjhEaXJlY3RvcnlFbnRyeS5oIgpAQCAtMTExNCwxNSArMTExNSw3IEBAIFdlYlVS TExvYWRlciogV2ViRnJhbWVJbXBsOjpjcmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKGNvbnN0IFdl YlVSTExvYWRlck9wdGlvbnMmCiAKIHZvaWQgV2ViRnJhbWVJbXBsOjpjb21taXREb2N1bWVudERh dGEoY29uc3QgY2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCkKIHsKLSAgICBXZWJWaWV3SW1wbCog d2ViVmlldyA9IHZpZXdJbXBsKCk7Ci0gICAgYm9vbCBpc01haW5GcmFtZSA9IHdlYlZpZXctPm1h aW5GcmFtZUltcGwoKS0+ZnJhbWUoKSA9PSBmcmFtZSgpOwotICAgIGlmIChpc01haW5GcmFtZSkK LSAgICAgICAgd2ViVmlldy0+c3VwcHJlc3NJbnZhbGlkYXRpb25zKHRydWUpOwotCiAgICAgZnJh bWUoKS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVyKCktPmNvbW1pdERhdGEoZGF0YSwgbGVuZ3Ro KTsKLQotICAgIGlmIChpc01haW5GcmFtZSkKLSAgICAgICAgd2ViVmlldy0+c3VwcHJlc3NJbnZh bGlkYXRpb25zKGZhbHNlKTsKIH0KIAogdW5zaWduZWQgV2ViRnJhbWVJbXBsOjp1bmxvYWRMaXN0 ZW5lckNvdW50KCkgY29uc3QKQEAgLTIyNzUsNiArMjI2OCw4IEBAIHZvaWQgV2ViRnJhbWVJbXBs OjpkaWRDaGFuZ2VDb250ZW50c1NpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkKIAogdm9pZCBXZWJG cmFtZUltcGw6OmNyZWF0ZUZyYW1lVmlldygpCiB7CisgICAgVFJBQ0VfRVZFTlQwKCJ3ZWJraXQi LCAiV2ViRnJhbWVJbXBsOjpjcmVhdGVGcmFtZVZpZXciKTsKKwogICAgIEFTU0VSVChmcmFtZSgp KTsgLy8gSWYgZnJhbWUoKSBkb2Vzbid0IGV4aXN0LCB3ZSBwcm9iYWJseSBkaWRuJ3QgaW5pdCBw cm9wZXJseS4KIAogICAgIFdlYlZpZXdJbXBsKiB3ZWJWaWV3ID0gdmlld0ltcGwoKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBjNWM4MzUxN2Q3NzIy MDU4MTFhZGJhYjQ3ZTYwNmRhNDg2OWY2MjQzLi5jZGI1NGQ4YzRmOGJmNTI0M2UxNmU5Y2U4NjVk NDM4YTJlNTEzNWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwCkBAIC00MTAyLDcgKzQxMDIsNyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpkaWRSZWNyZWF0ZU91 dHB1dFN1cmZhY2UoYm9vbCBzdWNjZXNzKQogdm9pZCBXZWJWaWV3SW1wbDo6c2NoZWR1bGVDb21w b3NpdGUoKQogewogICAgIGlmICAobV9zdXBwcmVzc0ludmFsaWRhdGlvbnMpIHsKLSAgICAgICAg VFJBQ0VfRVZFTlQwKCJ3ZWJraXQiLCAiV2ViVmlld0ltcGwgaW52YWxpZGF0aW9ucyBzdXBwcmVz c2VkIik7CisgICAgICAgIFRSQUNFX0VWRU5UX0lOU1RBTlQwKCJ3ZWJraXQiLCAiV2ViVmlld0lt cGwgaW52YWxpZGF0aW9ucyBzdXBwcmVzc2VkIik7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK