100390 2012-10-25 09:39:44 -0700 [v8] Get rid of ScriptController::clearForNavigation 2012-10-26 16:46:41 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100358 1 ojan ojan abarth arv haraken japhet webkit.review.bot oldest_to_newest 750929 0 ojan 2012-10-25 09:39:44 -0700 Get rid of ScriptController::clearForNavigation 750935 1 170675 ojan 2012-10-25 09:47:15 -0700 Created attachment 170675 Patch 750958 2 haraken 2012-10-25 10:12:20 -0700 LGTM. abarth will want to look. 751003 3 170675 abarth 2012-10-25 10:51:09 -0700 Comment on attachment 170675 Patch Thanks! 751038 4 170675 webkit.review.bot 2012-10-25 11:16:41 -0700 Comment on attachment 170675 Patch Clearing flags on attachment: 170675 Committed r132505: <http://trac.webkit.org/changeset/132505> 751039 5 webkit.review.bot 2012-10-25 11:16:45 -0700 All reviewed patches have been landed. Closing bug. 170675 2012-10-25 09:47:15 -0700 2012-10-25 11:16:41 -0700 Patch bug-100390-20121025094549.patch text/plain 3628 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMyZDU4OWFjOTBkNjRl YTM2MzdkYjE2ZDcxMjdlNjdjOGM3NWYzZS4uMGQwOTFiY2NlMzc5NDQ0NWI0MDNmYTg4MDNkZGYw YmUwOGNmZTA2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTI1ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgR2V0IHJpZCBvZiBTY3JpcHRD b250cm9sbGVyOjpjbGVhckZvck5hdmlnYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEdldCByaWQgb2YgY2xlYXJGb3JOYXZpZ2F0aW9uIGFuZCBj aGFuZ2UgcmVzZXRJc29sYXRlZFdvcmxkcworICAgICAgICB0byByZXNldCBzbyB0aGF0IGl0IGNh biBhbHNvIGRvIHRoZSBoaW50Rm9yQ29sbGVjdEdhcmJhZ2UgY2FsbC4KKyAgICAgICAgTm8gbmV3 IHRlc3RzLiBObyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3Jp cHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OnJl c2V0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmNsZWFyRm9yQ2xvc2Up OgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0Q29udHJvbGxlcjo6Y2xlYXJXaW5kb3dTaGVsbCk6 CisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oOgorICAgICAgICAoU2Ny aXB0Q29udHJvbGxlcik6CisKIDIwMTItMTAtMjUgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2Vu ICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgICdyZXNvbHV0aW9uJyBNUTogUHJpbnRp bmcgc2hvdWxkIHVzZSB1c2UgaGlnaCByZXNvbHV0aW9uIGltYWdlcyB3aGVuIGF2YWlsYWJsZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAppbmRl eCBiMmE5Yjk2YTlkODdkYWNjZmIxMjI4N2QyZjI5ZDkzNjkyYjlmZTRmLi5hZTJlMjVlYjM2MWE3 N2VkNDcxNTJjM2E2ODQ0ZjcxN2QxYjY1ZTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcApAQCAtMTQyLDI5ICsxNDIsMjIgQEAgdm9pZCBT Y3JpcHRDb250cm9sbGVyOjpjbGVhclNjcmlwdE9iamVjdHMoKQogI2VuZGlmCiB9CiAKLXZvaWQg U2NyaXB0Q29udHJvbGxlcjo6cmVzZXRJc29sYXRlZFdvcmxkcygpCit2b2lkIFNjcmlwdENvbnRy b2xsZXI6OnJlc2V0KCkKIHsKICAgICBmb3IgKElzb2xhdGVkV29ybGRNYXA6Oml0ZXJhdG9yIGl0 ZXIgPSBtX2lzb2xhdGVkV29ybGRzLmJlZ2luKCk7CiAgICAgICAgICBpdGVyICE9IG1faXNvbGF0 ZWRXb3JsZHMuZW5kKCk7ICsraXRlcikgewogICAgICAgICBpdGVyLT52YWx1ZS0+ZGVzdHJveUlz b2xhdGVkU2hlbGwoKTsKICAgICB9CiAgICAgbV9pc29sYXRlZFdvcmxkcy5jbGVhcigpOworICAg IFY4R0NDb250cm9sbGVyOjpoaW50Rm9yQ29sbGVjdEdhcmJhZ2UoKTsKIH0KIAogdm9pZCBTY3Jp cHRDb250cm9sbGVyOjpjbGVhckZvckNsb3NlKCkKIHsKLSAgICByZXNldElzb2xhdGVkV29ybGRz KCk7Ci0gICAgVjhHQ0NvbnRyb2xsZXI6OmhpbnRGb3JDb2xsZWN0R2FyYmFnZSgpOworICAgIHJl c2V0KCk7CiAgICAgd2luZG93U2hlbGwoKS0+Y2xlYXJGb3JDbG9zZSgpOwogfQogCi12b2lkIFNj cmlwdENvbnRyb2xsZXI6OmNsZWFyRm9yTmF2aWdhdGlvbigpCi17Ci0gICAgcmVzZXRJc29sYXRl ZFdvcmxkcygpOwotICAgIFY4R0NDb250cm9sbGVyOjpoaW50Rm9yQ29sbGVjdEdhcmJhZ2UoKTsK LSAgICB3aW5kb3dTaGVsbCgpLT5jbGVhckZvck5hdmlnYXRpb24oKTsKLX0KLQogdm9pZCBTY3Jp cHRDb250cm9sbGVyOjp1cGRhdGVTZWN1cml0eU9yaWdpbigpCiB7CiAgICAgd2luZG93U2hlbGwo KS0+dXBkYXRlU2VjdXJpdHlPcmlnaW4oKTsKQEAgLTYzNCwxMCArNjI3LDEwIEBAIE5QT2JqZWN0 KiBTY3JpcHRDb250cm9sbGVyOjpjcmVhdGVTY3JpcHRPYmplY3RGb3JQbHVnaW5FbGVtZW50KEhU TUxQbHVnSW5FbGVtZW50CiAKIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6Y2xlYXJXaW5kb3dTaGVs bChET01XaW5kb3cqLCBib29sKQogeworICAgIHJlc2V0KCk7CiAgICAgLy8gVjggYmluZGluZyBl eHBlY3RzIFNjcmlwdENvbnRyb2xsZXI6OmNsZWFyV2luZG93U2hlbGwgb25seSBiZSBjYWxsZWQK LSAgICAvLyB3aGVuIGEgZnJhbWUgaXMgbG9hZGluZyBhIG5ldyBwYWdlLiBTY3JpcHRDb250cm9s bGVyOjpjbGVhckZvck5hdmlnYXRpb24KLSAgICAvLyBjcmVhdGVzIGEgbmV3IGNvbnRleHQgZm9y IHRoZSBuZXcgcGFnZS4KLSAgICBjbGVhckZvck5hdmlnYXRpb24oKTsKKyAgICAvLyB3aGVuIGEg ZnJhbWUgaXMgbG9hZGluZyBhIG5ldyBwYWdlLiBUaGlzIGNyZWF0ZXMgYSBuZXcgY29udGV4dCBm b3IgdGhlIG5ldyBwYWdlLgorICAgIHdpbmRvd1NoZWxsKCktPmNsZWFyRm9yTmF2aWdhdGlvbigp OwogfQogCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1NjcmlwdENvbnRyb2xsZXIuaAppbmRleCA1YTFmZjQ1Nzg1YWMxMjU1NmYyMmJjNmU0MWUx OGI3ZTlhMmJlYzA4Li5iNjZjZWQ3ZmI0OWVkZDFjMWE0YzRlZjU5NjhmZTg3ODA1YjA5ODdhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCkBAIC0x NjcsNyArMTY3LDYgQEAgcHVibGljOgogICAgIHZvaWQgdXBkYXRlUGxhdGZvcm1TY3JpcHRPYmpl Y3RzKCk7CiAgICAgdm9pZCBjbGVhbnVwU2NyaXB0T2JqZWN0c0ZvclBsdWdpbihXaWRnZXQqKTsK IAotICAgIHZvaWQgY2xlYXJGb3JOYXZpZ2F0aW9uKCk7CiAgICAgdm9pZCBjbGVhckZvckNsb3Nl KCk7CiAKICAgICBOUE9iamVjdCogY3JlYXRlU2NyaXB0T2JqZWN0Rm9yUGx1Z2luRWxlbWVudChI VE1MUGx1Z0luRWxlbWVudCopOwpAQCAtMTkyLDcgKzE5MSw3IEBAIHByaXZhdGU6CiAgICAgLy8g Y2FsbCB3b3JsZC0+ZGVzdHJveUlzb2xhdGVkU2hlbGwoKS4KICAgICB0eXBlZGVmIEhhc2hNYXA8 aW50LCBWOERPTVdpbmRvd1NoZWxsKj4gSXNvbGF0ZWRXb3JsZE1hcDsKIAotICAgIHZvaWQgcmVz ZXRJc29sYXRlZFdvcmxkcygpOworICAgIHZvaWQgcmVzZXQoKTsKIAogICAgIEZyYW1lKiBtX2Zy YW1lOwogICAgIGNvbnN0IFN0cmluZyogbV9zb3VyY2VVUkw7Cg==