100386 2012-10-25 09:23:51 -0700 [Qt] Enable JSC's disassembler on x86, x86_64 Linux 2012-10-26 03:51:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P3 Normal --- 1 gaborb webkit-unassigned abecsi benjamin gaborb hausmann kkristof ossy vestbo webkit.review.bot oldest_to_newest 750913 0 gaborb 2012-10-25 09:23:51 -0700 It works fine on Linux x86, x86_64 just needs to be enabled in the QtWebKit build system. 750919 1 170671 gaborb 2012-10-25 09:30:27 -0700 Created attachment 170671 Patch 751635 2 170671 hausmann 2012-10-26 00:28:47 -0700 Comment on attachment 170671 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170671&action=review LGTM, but I suggest to use an if() before landing. > Source/JavaScriptCore/DerivedSources.pri:108 > +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") { I suggest to write this as linux-*:if(isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64")) { to be on the very safe side. > Source/JavaScriptCore/JavaScriptCore.pri:42 > +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") { Same here 751818 3 kkristof 2012-10-26 03:51:26 -0700 Committed r132606: <http://trac.webkit.org/changeset/132606> 170671 2012-10-25 09:30:27 -0700 2012-10-26 00:28:47 -0700 Patch disasx86upstream.patch text/plain 4611 gaborb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDIzOWU0OGMuLjJmMDcxMWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTI1ICBHYWJvciBCYWxsYWJh cyAgPGdhYm9yYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBFbmFibGUgSlNDJ3Mg ZGlzYXNzZW1ibGVyIG9uIHg4NiwgeDg2XzY0IExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzODYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCB3b3JrcyBmaW5lIG9uIExpbnV4IHg4NiwgeDg2 XzY0IGp1c3QgbmVlZHMgdG8gYmUgZW5hYmxlZCBpbiB0aGUKKyAgICAgICAgUXRXZWJLaXQgYnVp bGQgc3lzdGVtLgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMucHJpOgorICAgICAgICAqIEph dmFTY3JpcHRDb3JlLnByaToKKyAgICAgICAgKiBUYXJnZXQucHJpOgorCiAyMDEyLTEwLTI0ICBZ dXFpYW5nIFhpYW4gIDx5dXFpYW5nLnhpYW5AaW50ZWwuY29tPgogCiAgICAgICAgIFJlZmFjdG9y IExMSW50NjQgdG8gZGlzdGluZ3Vpc2ggdGhlIHBvaW50ZXIgb3BlcmF0aW9ucyBmcm9tIHRoZSA2 NC1iaXQgaW50ZWdlciBvcGVyYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvRGVyaXZlZFNvdXJjZXMucHJpIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0Rlcml2ZWRTb3Vy Y2VzLnByaQppbmRleCA3NWZkNWFjLi4zY2VhOThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvRGVyaXZlZFNvdXJjZXMucHJpCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9E ZXJpdmVkU291cmNlcy5wcmkKQEAgLTQwLDYgKzQwLDEzIEBAIExMSU5UX0RFUEVOREVOQ1kgPSBc CiAgICAgJCRQV0QvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbSBcCiAgICAgJCRQ V0QvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQogCitESVNBU1NFTUJMRVJfRklMRVMg PSBcCisgICAgZGlzYXNzZW1ibGVyL3VkaXM4Ni9vcHRhYmxlLnhtbAorCitESVNBU1NFTUJMRVJf REVQRU5ERU5DWSA9IFwKKyAgICAkJFBXRC9kaXNhc3NlbWJsZXIvdWRpczg2L3VkX29wY29kZS5w eSBcCisgICAgJCRQV0QvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZF9vcHRhYmxlLnB5CisKICMgR0VO RVJBVE9SIDEtQTogTFVUIGNyZWF0b3IKIGx1dC5vdXRwdXQgPSAke1FNQUtFX0ZJTEVfQkFTRX0u bHV0LmgKIGx1dC5pbnB1dCA9IExVVF9GSUxFUwpAQCAtOTcsMyArMTA0LDE0IEBAIGxpbnV4LSo6 IWVxdWFscyhRVF9BUkNILCAiYXJtIikgewogICAgIGxsaW50LmNvbW1hbmRzID0gcnVieSAkJGxs aW50LnNjcmlwdCAke1FNQUtFX0ZJTEVfTkFNRX0gTExJbnRPZmZzZXRzRXh0cmFjdG9yICR7UU1B S0VfRklMRV9PVVR9CiAgICAgR0VORVJBVE9SUyArPSBsbGludAogfQorCitsaW51eC0qOmlzRXF1 YWwoUVRfQVJDSCwgImkzODYiKXxpc0VxdWFsKFFUX0FSQ0gsICJ4ODZfNjQiKSB7CisgICAgIyBH RU5FUkFUT1I6IGRpc2Fzc2VtYmxlcgorICAgIGRpc2Fzc2VtYmxlci5vdXRwdXQgPSB1ZGlzODZf aXRhYi5jCisgICAgZGlzYXNzZW1ibGVyLmlucHV0ID0gRElTQVNTRU1CTEVSX0ZJTEVTCisgICAg ZGlzYXNzZW1ibGVyLnNjcmlwdCA9ICQkUFdEL2Rpc2Fzc2VtYmxlci91ZGlzODYvaXRhYi5weQor ICAgIGRpc2Fzc2VtYmxlci5kZXBlbmRzID0gJCRESVNBU1NFTUJMRVJfREVQRU5ERU5DWQorICAg IGRpc2Fzc2VtYmxlci5jb21tYW5kcyA9IHB5dGhvbiAkJGRpc2Fzc2VtYmxlci5zY3JpcHQgJHtR TUFLRV9GSUxFX05BTUV9CisgICAgZGlzYXNzZW1ibGVyLkNPTkZJRyArPSBub19saW5rCisgICAg R0VORVJBVE9SUyArPSBkaXNhc3NlbWJsZXIKK30KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxl CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQppbmRleCBmYWQzNmM5Li5j NDcxYWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUu cHJpCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKQEAgLTM4 LDMgKzM4LDcgQEAgd2luY2UqIHsKICAgICBJTkNMVURFUEFUSCArPSAkJFFULmNvcmUuc291cmNl cy8uLi8zcmRwYXJ0eS9jZS1jb21wYXQKICAgICBJTkNMVURFUEFUSCArPSAkJFNPVVJDRV9ESVIv b3Mtd2luMzIKIH0KKworbGludXgtKjppc0VxdWFsKFFUX0FSQ0gsICJpMzg2Iil8aXNFcXVhbChR VF9BUkNILCAieDg2XzY0IikgeworICAgIElOQ0xVREVQQVRIICs9ICQkU09VUkNFX0RJUi9kaXNh c3NlbWJsZXIvdWRpczg2Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvVGFy Z2V0LnByaSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9UYXJnZXQucHJpCmluZGV4IDg2MWRiYzcu LjM5MDNhYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9UYXJnZXQucHJpCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9UYXJnZXQucHJpCkBAIC0yNzMsNiArMjczLDE4IEBA IFNPVVJDRVMgKz0gXAogICAgIHRvb2xzL0NvZGVQcm9maWxpbmcuY3BwIFwKICAgICB5YXJyL1lh cnJKSVQuY3BwIFwKIAorbGludXgtKjppc0VxdWFsKFFUX0FSQ0gsICJpMzg2Iil8aXNFcXVhbChR VF9BUkNILCAieDg2XzY0IikgeworICAgIFNPVVJDRVMgKz0gXAorICAgICAgICBkaXNhc3NlbWJs ZXIvVURpczg2RGlzYXNzZW1ibGVyLmNwcCBcCisgICAgICAgIGRpc2Fzc2VtYmxlci91ZGlzODYv dWRpczg2LmMgXAorICAgICAgICBkaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9kZWNvZGUuYyBc CisgICAgICAgIGRpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X2lucHV0LmMgXAorICAgICAgICBk aXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9pdGFiX2hvbGRlci5jIFwKKyAgICAgICAgZGlzYXNz ZW1ibGVyL3VkaXM4Ni91ZGlzODZfc3luLWF0dC5jIFwKKyAgICAgICAgZGlzYXNzZW1ibGVyL3Vk aXM4Ni91ZGlzODZfc3luLWludGVsLmMgXAorICAgICAgICBkaXNhc3NlbWJsZXIvdWRpczg2L3Vk aXM4Nl9zeW4uYyBcCit9CisKIEhFQURFUlMgKz0gJCRmaWxlcygqLmgsIHRydWUpCiAKICpzaDQq IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VM b2cKaW5kZXggM2YwYjg2OC4uN2E1OGYyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMC0y NSAgR2Fib3IgQmFsbGFiYXMgIDxnYWJvcmJAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtR dF0gRW5hYmxlIEpTQydzIGRpc2Fzc2VtYmxlciBvbiB4ODYsIHg4Nl82NCBMaW51eAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMzg2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgd29ya3MgZmluZSBv biBMaW51eCB4ODYsIHg4Nl82NCBqdXN0IG5lZWRzIHRvIGJlIGVuYWJsZWQgaW4gdGhlCisgICAg ICAgIFF0V2ViS2l0IGJ1aWxkIHN5c3RlbS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgor CiAyMDEyLTA5LTI3ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IHByb3ZpZGUgbWVtb3J5IGluc3RydW1lbnRhdGlvbiBmb3Ig TGlzdEhhc2hTZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3Vy Y2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDNjMjYzYzUuLmM0ZTVhZDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0u aApAQCAtODkxLDcgKzg5MSw4IEBACiAvKiBJZiBwb3NzaWJsZSwgdHJ5IHRvIGVuYWJsZSBhIGRp c2Fzc2VtYmxlci4gVGhpcyBpcyBvcHRpb25hbC4gV2UgcHJvY2VlZCBpbiB0d28KICAgIHN0ZXBz OiBmaXJzdCB3ZSB0cnkgdG8gZmluZCBzb21lIGRpc2Fzc2VtYmxlciB0aGF0IHdlIGNhbiB1c2Us IGFuZCB0aGVuIHdlCiAgICBkZWNpZGUgaWYgdGhlIGhpZ2gtbGV2ZWwgZGlzYXNzZW1ibGVyIEFQ SSBjYW4gYmUgZW5hYmxlZC4gKi8KLSNpZiAhZGVmaW5lZChXVEZfVVNFX1VESVM4NikgJiYgRU5B QkxFKEpJVCkgJiYgUExBVEZPUk0oTUFDKSAmJiAoQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkpCisj aWYgIWRlZmluZWQoV1RGX1VTRV9VRElTODYpICYmIEVOQUJMRShKSVQpICYmIChQTEFURk9STShN QUMpIHx8IChQTEFURk9STShRVCkgJiYgT1MoTElOVVgpKSkgXAorICAgICYmIChDUFUoWDg2KSB8 fCBDUFUoWDg2XzY0KSkKICNkZWZpbmUgV1RGX1VTRV9VRElTODYgMQogI2VuZGlmCiAK