<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100379</bug_id>
          
          <creation_ts>2012-10-25 07:27:20 -0700</creation_ts>
          <short_desc>[Win] WebView didReceiveIcon delegate call doesn&apos;t have the icon in it</short_desc>
          <delta_ts>2013-07-23 12:00:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>peavo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>peavo</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>750800</commentid>
    <comment_count>0</comment_count>
    <who name="">peavo</who>
    <bug_when>2012-10-25 07:27:20 -0700</bug_when>
    <thetext>Pass HBITMAP favicon to load delegate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>750802</commentid>
    <comment_count>1</comment_count>
      <attachid>170645</attachid>
    <who name="">peavo</who>
    <bug_when>2012-10-25 07:29:33 -0700</bug_when>
    <thetext>Created attachment 170645
Patch as diff, output from svn-create-patch script.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>751007</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-10-25 10:54:51 -0700</bug_when>
    <thetext>&lt;rdar://problem/5491010&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>751011</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-10-25 10:55:54 -0700</bug_when>
    <thetext>Would you be willing to submit a patch for inclusion in WebKit? Please follow the steps in &lt;http://www.webkit.org/coding/contributing.html&gt; - in particular, every patch needs a ChangeLog, and needs to be marked for review to be in review queue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>752169</commentid>
    <comment_count>4</comment_count>
    <who name="">peavo</who>
    <bug_when>2012-10-26 10:39:05 -0700</bug_when>
    <thetext>Yes, will submit a patch soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753465</commentid>
    <comment_count>5</comment_count>
      <attachid>171249</attachid>
    <who name="">peavo</who>
    <bug_when>2012-10-29 08:14:31 -0700</bug_when>
    <thetext>Created attachment 171249
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>758625</commentid>
    <comment_count>6</comment_count>
      <attachid>171249</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-11-05 09:53:36 -0800</bug_when>
    <thetext>Comment on attachment 171249
Patch

Brady should probably review this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>764323</commentid>
    <comment_count>7</comment_count>
    <who name="">peavo</who>
    <bug_when>2012-11-12 05:57:37 -0800</bug_when>
    <thetext>Any takers? :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>900172</commentid>
    <comment_count>8</comment_count>
      <attachid>171249</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-06-13 10:16:31 -0700</bug_when>
    <thetext>Comment on attachment 171249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171249&amp;action=review

Looks good.  I think it would be simpler to create one IntSize and use it in both API calls that need it.  Can you make that small change and I&apos;ll r+ this?

&gt; Source/WebKit/win/WebView.cpp:2842
&gt; +        sz.cy = 16;

Why not just create the IntSize directly, then use it later?

&gt; Source/WebKit/win/WebView.cpp:2844
&gt; +        BitmapInfo bmInfo = BitmapInfo::create(IntSize(sz));

Use the IntSize here...

&gt; Source/WebKit/win/WebView.cpp:2848
&gt; +        Image* icon = iconDatabase().synchronousIconForPageURL(str, IntSize(sz));

... and here!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>900510</commentid>
    <comment_count>9</comment_count>
      <attachid>204703</attachid>
    <who name="">peavo</who>
    <bug_when>2013-06-14 05:01:16 -0700</bug_when>
    <thetext>Created attachment 204703
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>900511</commentid>
    <comment_count>10</comment_count>
    <who name="">peavo</who>
    <bug_when>2013-06-14 05:02:48 -0700</bug_when>
    <thetext>Modifed patch after review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>911032</commentid>
    <comment_count>11</comment_count>
    <who name="">peavo</who>
    <bug_when>2013-07-23 07:22:04 -0700</bug_when>
    <thetext>(In reply to comment #8)

&gt; Looks good.  I think it would be simpler to create one IntSize and use it in both API calls that need it.  Can you make that small change and I&apos;ll r+ this?

r+? ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>911067</commentid>
    <comment_count>12</comment_count>
      <attachid>204703</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-07-23 09:52:01 -0700</bug_when>
    <thetext>Comment on attachment 204703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204703&amp;action=review

Sorry -- I didn&apos;t notice that we would have to cast that sz variable from IntSize to SIZE. Please correct that and I&apos;ll r+ it (today!)

&gt; Source/WebKit/win/WebView.cpp:2882
&gt; +            icon-&gt;getHBITMAPOfSize(hBitmap, &amp;(SIZE)sz);

This should be written as &quot;&amp;static_cast&lt;SIZE&gt;(sz)&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>911091</commentid>
    <comment_count>13</comment_count>
      <attachid>207339</attachid>
    <who name="">peavo</who>
    <bug_when>2013-07-23 11:17:24 -0700</bug_when>
    <thetext>Created attachment 207339
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>911092</commentid>
    <comment_count>14</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-07-23 11:19:48 -0700</bug_when>
    <thetext>r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>911095</commentid>
    <comment_count>15</comment_count>
    <who name="">peavo</who>
    <bug_when>2013-07-23 11:20:41 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; r=me

Thanks for reviewing!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>911112</commentid>
    <comment_count>16</comment_count>
      <attachid>207339</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-07-23 12:00:51 -0700</bug_when>
    <thetext>Comment on attachment 207339
Patch

Clearing flags on attachment: 207339

Committed r153059: &lt;http://trac.webkit.org/changeset/153059&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>911113</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-07-23 12:00:55 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>170645</attachid>
            <date>2012-10-25 07:29:33 -0700</date>
            <delta_ts>2012-10-29 08:14:24 -0700</delta_ts>
            <desc>Patch as diff, output from svn-create-patch script.</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>1245</size>
            <attacher>peavo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAxMzI0NzcpCisrKyBTb3VyY2UvV2Vi
S2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgzNCw5ICsyODM0LDMwIEBA
IHZvaWQgV2ViVmlldzo6ZGlzcGF0Y2hEaWRSZWNlaXZlSWNvbkZyb20KIHsKICAgICByZWdpc3Rl
ckZvckljb25Ob3RpZmljYXRpb24oZmFsc2UpOwogCi0gICAgaWYgKG1fZnJhbWVMb2FkRGVsZWdh
dGUpCi0gICAgICAgIC8vIEZJWE1FOiA8cmRhcjovL3Byb2JsZW0vNTQ5MTAxMD4gLSBQYXNzIGlu
IHRoZSByaWdodCBIQklUTUFQLiAKLSAgICAgICAgbV9mcmFtZUxvYWREZWxlZ2F0ZS0+ZGlkUmVj
ZWl2ZUljb24odGhpcywgMCwgZnJhbWUpOworICAgIGlmIChtX2ZyYW1lTG9hZERlbGVnYXRlKSB7
CisgICAgICAgIFN0cmluZyBzdHIgPSBmcmFtZS0+dXJsKCkuc3RyaW5nKCk7CisKKyAgICAgICAg
U0laRSBzejsKKyAgICAgICAgc3ouY3ggPSAxNjsKKyAgICAgICAgc3ouY3kgPSAxNjsKKworICAg
ICAgICBCaXRtYXBJbmZvIGJtSW5mbyA9IEJpdG1hcEluZm86OmNyZWF0ZShJbnRTaXplKHN6KSk7
CisKKwkJSEJJVE1BUCBoQml0bWFwID0gTlVMTDsKKworICAgICAgICBJbWFnZSogaWNvbiA9IGlj
b25EYXRhYmFzZSgpLnN5bmNocm9ub3VzSWNvbkZvclBhZ2VVUkwoc3RyLCBJbnRTaXplKHN6KSk7
CisKKyAgICAgICAgaWYgKGljb24gJiYgaWNvbi0+d2lkdGgoKSkgeworICAgICAgICAgICAgSFdu
ZERDIGRjKDApOworICAgICAgICAgICAgaEJpdG1hcCA9IENyZWF0ZURJQlNlY3Rpb24oZGMsICZi
bUluZm8sIERJQl9SR0JfQ09MT1JTLCAwLCAwLCAwKTsKKyAgICAgICAgICAgIGljb24tPmdldEhC
SVRNQVBPZlNpemUoaEJpdG1hcCwgJnN6KTsKKyAgICAgICAgfQorCisgICAgICAgIEhSRVNVTFQg
aHIgPSBtX2ZyYW1lTG9hZERlbGVnYXRlLT5kaWRSZWNlaXZlSWNvbih0aGlzLCAoT0xFX0hBTkRM
RSloQml0bWFwLCBmcmFtZSk7CisgICAgICAgIGlmIChociA9PSBFX05PVElNUEwpIHsKKyAgICAg
ICAgICAgIERlbGV0ZU9iamVjdChoQml0bWFwKTsKKyAgICAgICAgfQorICAgIH0KIH0KIAogSFJF
U1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjpzZXRVSURlbGVnYXRlKCAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171249</attachid>
            <date>2012-10-29 08:14:31 -0700</date>
            <delta_ts>2013-06-14 05:01:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100379-20121029161257.patch</filename>
            <type>text/plain</type>
            <size>1885</size>
            <attacher>peavo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjYxNSkKKysrIFNvdXJjZS9XZWJLaXQv
d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTI2
ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIEFkZGVk
IG1pc3NpbmcgaWNvbiB0byBXZWJWaWV3IGRpZFJlY2VpdmVJY29uIGRlbGVnYXRlIGNhbGwsIGZp
eGVzIDxyZGFyOi8vcHJvYmxlbS81NDkxMDEwPi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDM3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJWaWV3Ojpk
aXNwYXRjaERpZFJlY2VpdmVJY29uRnJvbVdlYkZyYW1lKToKKwogMjAxMi0xMC0yNCAgQnJhZHkg
RWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgc3RyYXRlZ3kgZm9y
IGxvYWRlciBjdXN0b21pemF0aW9uLgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9u
IDEzMjYwOSkKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkp
CkBAIC0yODM0LDkgKzI4MzQsMjkgQEAgdm9pZCBXZWJWaWV3OjpkaXNwYXRjaERpZFJlY2VpdmVJ
Y29uRnJvbQogewogICAgIHJlZ2lzdGVyRm9ySWNvbk5vdGlmaWNhdGlvbihmYWxzZSk7CiAKLSAg
ICBpZiAobV9mcmFtZUxvYWREZWxlZ2F0ZSkKLSAgICAgICAgLy8gRklYTUU6IDxyZGFyOi8vcHJv
YmxlbS81NDkxMDEwPiAtIFBhc3MgaW4gdGhlIHJpZ2h0IEhCSVRNQVAuIAotICAgICAgICBtX2Zy
YW1lTG9hZERlbGVnYXRlLT5kaWRSZWNlaXZlSWNvbih0aGlzLCAwLCBmcmFtZSk7CisgICAgaWYg
KG1fZnJhbWVMb2FkRGVsZWdhdGUpIHsKKyAgICAgICAgU3RyaW5nIHN0ciA9IGZyYW1lLT51cmwo
KS5zdHJpbmcoKTsKKworICAgICAgICBTSVpFIHN6OworICAgICAgICBzei5jeCA9IDE2OworICAg
ICAgICBzei5jeSA9IDE2OworCisgICAgICAgIEJpdG1hcEluZm8gYm1JbmZvID0gQml0bWFwSW5m
bzo6Y3JlYXRlKEludFNpemUoc3opKTsKKworICAgICAgICBIQklUTUFQIGhCaXRtYXAgPSAwOwor
CisgICAgICAgIEltYWdlKiBpY29uID0gaWNvbkRhdGFiYXNlKCkuc3luY2hyb25vdXNJY29uRm9y
UGFnZVVSTChzdHIsIEludFNpemUoc3opKTsKKworICAgICAgICBpZiAoaWNvbiAmJiBpY29uLT53
aWR0aCgpKSB7CisgICAgICAgICAgICBIV25kREMgZGMoMCk7CisgICAgICAgICAgICBoQml0bWFw
ID0gQ3JlYXRlRElCU2VjdGlvbihkYywgJmJtSW5mbywgRElCX1JHQl9DT0xPUlMsIDAsIDAsIDAp
OworICAgICAgICAgICAgaWNvbi0+Z2V0SEJJVE1BUE9mU2l6ZShoQml0bWFwLCAmc3opOworICAg
ICAgICB9CisKKyAgICAgICAgSFJFU1VMVCBociA9IG1fZnJhbWVMb2FkRGVsZWdhdGUtPmRpZFJl
Y2VpdmVJY29uKHRoaXMsIChPTEVfSEFORExFKWhCaXRtYXAsIGZyYW1lKTsKKyAgICAgICAgaWYg
KGhyID09IEVfTk9USU1QTCkKKyAgICAgICAgICAgIERlbGV0ZU9iamVjdChoQml0bWFwKTsKKyAg
ICB9CiB9CiAKIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViVmlldzo6c2V0VUlEZWxlZ2F0
ZSggCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>204703</attachid>
            <date>2013-06-14 05:01:16 -0700</date>
            <delta_ts>2013-07-23 11:17:15 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100379-20130614135901.patch</filename>
            <type>text/plain</type>
            <size>1937</size>
            <attacher>peavo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTU4OSkKKysrIFNvdXJjZS9XZWJLaXQv
d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTE0
ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5d
IFdlYlZpZXcgZGlkUmVjZWl2ZUljb24gZGVsZWdhdGUgY2FsbCBkb2Vzbid0IGhhdmUgdGhlIGlj
b24gaW4gaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTEwMDM3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkZGVkIG1pc3NpbmcgaWNvbiB0byBXZWJWaWV3IGRpZFJlY2VpdmVJY29uIGRlbGVnYXRlIGNh
bGwsIGZpeGVzIDxyZGFyOi8vcHJvYmxlbS81NDkxMDEwPi4KKworICAgICAgICAqIFdlYlZpZXcu
Y3BwOgorICAgICAgICAoV2ViVmlldzo6ZGlzcGF0Y2hEaWRSZWNlaXZlSWNvbkZyb21XZWJGcmFt
ZSk6CisKIDIwMTMtMDYtMTIgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAK
ICAgICAgICAgW1dpbmRvd3NdIEltcGxlbWVudCBBY2Nlc3NpYmlsaXR5MiBBUElzIGluIFdpbmRv
d3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTUxNTgxKQorKysgU291cmNl
L1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4NjUsOSArMjg2NSwy
NyBAQCB2b2lkIFdlYlZpZXc6OmRpc3BhdGNoRGlkUmVjZWl2ZUljb25Gcm9tCiB7CiAgICAgcmVn
aXN0ZXJGb3JJY29uTm90aWZpY2F0aW9uKGZhbHNlKTsKIAotICAgIGlmIChtX2ZyYW1lTG9hZERl
bGVnYXRlKQotICAgICAgICAvLyBGSVhNRTogPHJkYXI6Ly9wcm9ibGVtLzU0OTEwMTA+IC0gUGFz
cyBpbiB0aGUgcmlnaHQgSEJJVE1BUC4gCi0gICAgICAgIG1fZnJhbWVMb2FkRGVsZWdhdGUtPmRp
ZFJlY2VpdmVJY29uKHRoaXMsIDAsIGZyYW1lKTsKKyAgICBpZiAobV9mcmFtZUxvYWREZWxlZ2F0
ZSkgeworICAgICAgICBTdHJpbmcgc3RyID0gZnJhbWUtPnVybCgpLnN0cmluZygpOworCisgICAg
ICAgIEludFNpemUgc3ooMTYsIDE2KTsKKworICAgICAgICBCaXRtYXBJbmZvIGJtSW5mbyA9IEJp
dG1hcEluZm86OmNyZWF0ZShzeik7CisKKyAgICAgICAgSEJJVE1BUCBoQml0bWFwID0gMDsKKwor
ICAgICAgICBJbWFnZSogaWNvbiA9IGljb25EYXRhYmFzZSgpLnN5bmNocm9ub3VzSWNvbkZvclBh
Z2VVUkwoc3RyLCBzeik7CisKKyAgICAgICAgaWYgKGljb24gJiYgaWNvbi0+d2lkdGgoKSkgewor
ICAgICAgICAgICAgSFduZERDIGRjKDApOworICAgICAgICAgICAgaEJpdG1hcCA9IENyZWF0ZURJ
QlNlY3Rpb24oZGMsICZibUluZm8sIERJQl9SR0JfQ09MT1JTLCAwLCAwLCAwKTsKKyAgICAgICAg
ICAgIGljb24tPmdldEhCSVRNQVBPZlNpemUoaEJpdG1hcCwgJihTSVpFKXN6KTsKKyAgICAgICAg
fQorCisgICAgICAgIEhSRVNVTFQgaHIgPSBtX2ZyYW1lTG9hZERlbGVnYXRlLT5kaWRSZWNlaXZl
SWNvbih0aGlzLCAoT0xFX0hBTkRMRSloQml0bWFwLCBmcmFtZSk7CisgICAgICAgIGlmIChociA9
PSBFX05PVElNUEwpCisgICAgICAgICAgICBEZWxldGVPYmplY3QoaEJpdG1hcCk7CisgICAgfQog
fQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYlZpZXc6OnNldFVJRGVsZWdhdGUoIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>207339</attachid>
            <date>2013-07-23 11:17:24 -0700</date>
            <delta_ts>2013-07-23 12:00:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100379-20130723201717.patch</filename>
            <type>text/plain</type>
            <size>1933</size>
            <attacher>peavo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzA0OCkKKysrIFNvdXJjZS9XZWJLaXQv
d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTIz
ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5d
IFdlYlZpZXcgZGlkUmVjZWl2ZUljb24gZGVsZWdhdGUgY2FsbCBkb2Vzbid0IGhhdmUgdGhlIGlj
b24gaW4gaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTEwMDM3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkZGVkIG1pc3NpbmcgaWNvbiB0byBXZWJWaWV3IGRpZFJlY2VpdmVJY29uIGRlbGVnYXRlIGNh
bGwsIGZpeGVzIDxyZGFyOi8vcHJvYmxlbS81NDkxMDEwPi4KKworICAgICAgICAqIFdlYlZpZXcu
Y3BwOgorICAgICAgICAoV2ViVmlldzo6ZGlzcGF0Y2hEaWRSZWNlaXZlSWNvbkZyb21XZWJGcmFt
ZSk6CisKIDIwMTMtMDctMjIgIHBlYXZvQG91dGxvb2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+
CiAKICAgICAgICAgW0N1cmxdIERvd25sb2FkIGZhaWxzIGZvciBjZXJ0YWluIHVybHMuCkluZGV4
OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTUzMDQ4KQorKysgU291cmNlL1dlYktpdC93
aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4NjYsOSArMjg2NiwyNyBAQCB2b2lk
IFdlYlZpZXc6OmRpc3BhdGNoRGlkUmVjZWl2ZUljb25Gcm9tCiB7CiAgICAgcmVnaXN0ZXJGb3JJ
Y29uTm90aWZpY2F0aW9uKGZhbHNlKTsKIAotICAgIGlmIChtX2ZyYW1lTG9hZERlbGVnYXRlKQot
ICAgICAgICAvLyBGSVhNRTogPHJkYXI6Ly9wcm9ibGVtLzU0OTEwMTA+IC0gUGFzcyBpbiB0aGUg
cmlnaHQgSEJJVE1BUC4gCi0gICAgICAgIG1fZnJhbWVMb2FkRGVsZWdhdGUtPmRpZFJlY2VpdmVJ
Y29uKHRoaXMsIDAsIGZyYW1lKTsKKyAgICBpZiAobV9mcmFtZUxvYWREZWxlZ2F0ZSkgeworICAg
ICAgICBTdHJpbmcgc3RyID0gZnJhbWUtPnVybCgpLnN0cmluZygpOworCisgICAgICAgIEludFNp
emUgc3ooMTYsIDE2KTsKKworICAgICAgICBCaXRtYXBJbmZvIGJtSW5mbyA9IEJpdG1hcEluZm86
OmNyZWF0ZShzeik7CisKKyAgICAgICAgSEJJVE1BUCBoQml0bWFwID0gMDsKKworICAgICAgICBJ
bWFnZSogaWNvbiA9IGljb25EYXRhYmFzZSgpLnN5bmNocm9ub3VzSWNvbkZvclBhZ2VVUkwoc3Ry
LCBzeik7CisKKyAgICAgICAgaWYgKGljb24gJiYgaWNvbi0+d2lkdGgoKSkgeworICAgICAgICAg
ICAgSFduZERDIGRjKDApOworICAgICAgICAgICAgaEJpdG1hcCA9IENyZWF0ZURJQlNlY3Rpb24o
ZGMsICZibUluZm8sIERJQl9SR0JfQ09MT1JTLCAwLCAwLCAwKTsKKyAgICAgICAgICAgIGljb24t
PmdldEhCSVRNQVBPZlNpemUoaEJpdG1hcCwgJnN0YXRpY19jYXN0PFNJWkU+KHN6KSk7CisgICAg
ICAgIH0KKworICAgICAgICBIUkVTVUxUIGhyID0gbV9mcmFtZUxvYWREZWxlZ2F0ZS0+ZGlkUmVj
ZWl2ZUljb24odGhpcywgKE9MRV9IQU5ETEUpaEJpdG1hcCwgZnJhbWUpOworICAgICAgICBpZiAo
aHIgPT0gRV9OT1RJTVBMKQorICAgICAgICAgICAgRGVsZXRlT2JqZWN0KGhCaXRtYXApOworICAg
IH0KIH0KIAogSFJFU1VMVCBXZWJWaWV3OjpzZXRBY2Nlc3NpYmlsaXR5RGVsZWdhdGUoCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>