100364 2012-10-25 04:10:47 -0700 LLInt C_Loop build is broken 2012-10-25 07:51:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 100345 P2 Normal --- 97648 1 hausmann webkit-unassigned mark.lam oldest_to_newest 750652 0 hausmann 2012-10-25 04:10:47 -0700 The build with the C_LOOP back-end is broken in two ways: The error is: generated/LLIntAssembly.h: In static member function 'static JSC::JSValue JSC::LLInt::CLoop::execute(JSC::CallFrame*, JSC::OpcodeID, bool)': generated/LLIntAssembly.h:3731:14: error: label 'llint_op_resolve' used but not defined generated/LLIntAssembly.h:3917:10: error: label 'llint_op_resolve_base' used but not defined These errors come from the following two snippets in LowLevelInterpreter.asm: _llint_op_resolve_base_to_global_dynamic: jmp _llint_op_resolve_base and as part of _llint_op_resolve_global_property: bpneq JSCell::m_structure[t1], t2, _llint_op_resolve In both cases the destination label is referred to in the same way as it is defined. When creating the destination labels, offlineasm/asm.rb uses OFFLINE_ASM_OPCODE_LABEL for both because their name contains with llint_op_. However labels passed to _OPCODE_LABEL() have the _llint_ prefix stripped, so the resulting label in LLIntAssembly.h is actually op_resolve_base and op_resolve. Therefore the "jmp _llint_op_resolve_base" and the bpneq cannot find their targets. The second error is that even if LowLevelInterpreter.asm used _op_resolve_base as target if C_LOOP, turning the jmp into a "goto op_resolve_base;", the build breaks when computed gotos are not available, because the OFFLINE_ASM_OPCODE_LABEL only defines a "case Foo:" target instead of a combined target that can also be used with goto, like GLUE_LABEL does it: case label: label: A possible workaround for both issues seems to be to use an extra local label: --- a/Source/JavaScriptCore/llint/LowLevelInterpreter.asm +++ b/Source/JavaScriptCore/llint/LowLevelInterpreter.asm @@ -662,7 +662,7 @@ _llint_op_resolve_global_property: loadp CodeBlock[cfr], t1 loadp CodeBlock::m_globalObject[t1], t1 loadp ResolveOperation::m_structure[t0], t2 - bpneq JSCell::m_structure[t1], t2, _llint_op_resolve + bpneq JSCell::m_structure[t1], t2, ._llint_op_resolve loadis ResolveOperation::m_offset[t0], t0 if JSVALUE64 loadPropertyAtVariableOffsetKnownNotInline(t0, t1, t2) @@ -746,6 +746,7 @@ _llint_op_resolve_scoped_var_with_top_scope_check: moveJSValue(t1, t2, cfr, t3, 4, t0) dispatch(5) +._llint_op_resolve: _llint_op_resolve: traceExecution() getResolveOperation(3, t0, t1) @@ -780,7 +781,7 @@ _llint_op_resolve_base_to_global: dispatch(7) _llint_op_resolve_base_to_global_dynamic: - jmp _llint_op_resolve_base + jmp ._llint_resolve_base _llint_op_resolve_base_to_scope: traceExecution() @@ -827,6 +828,7 @@ _llint_op_resolve_base_to_scope_with_top_scope_check: end dispatch(7) +._llint_resolve_base: _llint_op_resolve_base: traceExecution() callSlowPath(_llint_slow_path_resolve_base) But I'm not familiar enough with LLInt to be sure that this is the right solution. 750676 1 170617 hausmann 2012-10-25 04:40:58 -0700 Created attachment 170617 Workaround as attachment 750827 2 mark.lam 2012-10-25 07:51:36 -0700 The proper fix is awaiting review at <https://bugs.webkit.org/show_bug.cgi?id=100345>. *** This bug has been marked as a duplicate of bug 100345 *** 170617 2012-10-25 04:40:58 -0700 2012-10-25 04:40:58 -0700 Workaround as attachment patch.txt text/plain 1377 hausmann ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl dGVyLmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy LmFzbQppbmRleCAwMjI2MzdkLi40MDllYzQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC02NjIsNyArNjYyLDcgQEAg X2xsaW50X29wX3Jlc29sdmVfZ2xvYmFsX3Byb3BlcnR5OgogICAgIGxvYWRwIENvZGVCbG9ja1tj ZnJdLCB0MQogICAgIGxvYWRwIENvZGVCbG9jazo6bV9nbG9iYWxPYmplY3RbdDFdLCB0MQogICAg IGxvYWRwIFJlc29sdmVPcGVyYXRpb246Om1fc3RydWN0dXJlW3QwXSwgdDIKLSAgICBicG5lcSBK U0NlbGw6Om1fc3RydWN0dXJlW3QxXSwgdDIsIF9sbGludF9vcF9yZXNvbHZlCisgICAgYnBuZXEg SlNDZWxsOjptX3N0cnVjdHVyZVt0MV0sIHQyLCAuX2xsaW50X29wX3Jlc29sdmUKICAgICBsb2Fk aXMgUmVzb2x2ZU9wZXJhdGlvbjo6bV9vZmZzZXRbdDBdLCB0MAogICAgIGlmIEpTVkFMVUU2NAog ICAgICAgICBsb2FkUHJvcGVydHlBdFZhcmlhYmxlT2Zmc2V0S25vd25Ob3RJbmxpbmUodDAsIHQx LCB0MikKQEAgLTc0Niw2ICs3NDYsNyBAQCBfbGxpbnRfb3BfcmVzb2x2ZV9zY29wZWRfdmFyX3dp dGhfdG9wX3Njb3BlX2NoZWNrOgogICAgIG1vdmVKU1ZhbHVlKHQxLCB0MiwgY2ZyLCB0MywgNCwg dDApCiAgICAgZGlzcGF0Y2goNSkKIAorLl9sbGludF9vcF9yZXNvbHZlOgogX2xsaW50X29wX3Jl c29sdmU6CiAgICAgdHJhY2VFeGVjdXRpb24oKQogICAgIGdldFJlc29sdmVPcGVyYXRpb24oMywg dDAsIHQxKQpAQCAtNzgwLDcgKzc4MSw3IEBAIF9sbGludF9vcF9yZXNvbHZlX2Jhc2VfdG9fZ2xv YmFsOgogICAgIGRpc3BhdGNoKDcpCiAKIF9sbGludF9vcF9yZXNvbHZlX2Jhc2VfdG9fZ2xvYmFs X2R5bmFtaWM6Ci0gICAgam1wIF9sbGludF9vcF9yZXNvbHZlX2Jhc2UKKyAgICBqbXAgLl9sbGlu dF9yZXNvbHZlX2Jhc2UKIAogX2xsaW50X29wX3Jlc29sdmVfYmFzZV90b19zY29wZToKICAgICB0 cmFjZUV4ZWN1dGlvbigpCkBAIC04MjcsNiArODI4LDcgQEAgX2xsaW50X29wX3Jlc29sdmVfYmFz ZV90b19zY29wZV93aXRoX3RvcF9zY29wZV9jaGVjazoKICAgICBlbmQKICAgICBkaXNwYXRjaCg3 KQogCisuX2xsaW50X3Jlc29sdmVfYmFzZToKIF9sbGludF9vcF9yZXNvbHZlX2Jhc2U6CiAgICAg dHJhY2VFeGVjdXRpb24oKQogICAgIGNhbGxTbG93UGF0aChfbGxpbnRfc2xvd19wYXRoX3Jlc29s dmVfYmFzZSkK