100351 2012-10-25 01:34:08 -0700 [V8] We can handle ActiveDOMNodes and DOMNodes in the same GC visitor 2012-10-25 02:48:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100352 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 750545 0 abarth 2012-10-25 01:34:08 -0700 [V8] We can handle ActiveDOMNodes and DOMNodes in the same GC visitor 750547 1 170585 abarth 2012-10-25 01:35:17 -0700 Created attachment 170585 Patch 750551 2 170585 eric 2012-10-25 01:40:37 -0700 Comment on attachment 170585 Patch LGTM. 750556 3 haraken 2012-10-25 01:46:25 -0700 LGTM too. 750594 4 170585 webkit.review.bot 2012-10-25 02:48:01 -0700 Comment on attachment 170585 Patch Clearing flags on attachment: 170585 Committed r132464: <http://trac.webkit.org/changeset/132464> 750595 5 webkit.review.bot 2012-10-25 02:48:04 -0700 All reviewed patches have been landed. Closing bug. 170585 2012-10-25 01:35:17 -0700 2012-10-25 02:48:01 -0700 Patch bug-100351-20121025013351.patch text/plain 6266 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZlNTQ1ZDIwNjYxOGRj MzIyNDI0OTdjNzc3NWM4MzljNzI0YWEwMS4uOTVhMTEyY2VkOThkN2YwZGU0MjlhZjA0MmQwM2My MzU5MTI5NTJhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEwLTI1ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBXZSBjYW4gaGFuZGxl IEFjdGl2ZURPTU5vZGVzIGFuZCBET01Ob2RlcyBpbiB0aGUgc2FtZSBHQyB2aXNpdG9yCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzNTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBubyBy ZWFzb24gdG8gaGFuZGxlIGFjdGl2ZSBET00gbm9kZXMgaW4gYSBzZXBhcmF0ZSBwYXNzIGZyb20K KyAgICAgICAgcmVndWxhciBET00gbm9kZXMgYW55bW9yZS4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4RE9NTWFwLmNwcDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTU1hcC5oOgorICAg ICAgICAoV2ViQ29yZSk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QWN0aXZlRE9NT2JqZWN0UHJvbG9ndWVWaXNpdG9yOjp2aXNp dERPTVdyYXBwZXIpOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZVZpc2l0b3I6Ok5vZGVWaXNpdG9y KToKKyAgICAgICAgKE5vZGVWaXNpdG9yKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGVWaXNpdG9y Ojp2aXNpdE5vZGVXcmFwcGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpt YWpvckdDUHJvbG9ndWUpOgorCiAyMDEyLTEwLTI0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW1Y4XSBET01EYXRhU3RvcmVIYW5kbGUgc2VydmVzIG5vIHB1cnBv c2UgYW5kIGNhbiBiZSByZW1vdmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOERPTU1hcC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5j cHAKaW5kZXggMjMwNGVkODE1Y2UzY2YyMTYyODhlODA4ZDFmZGVjMjNlMTYxZGMzMi4uY2ExZjMw NTRmYzg3OWYwMWYzYzlhMWE4YzczYTRjOTM5MjE5NTY5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4RE9NTWFwLmNwcApAQCAtOTksMTggKzk5LDYgQEAgdm9pZCB2aXNpdEFsbERPTU5v ZGVzKE5vZGVXcmFwcGVyVmlzaXRvciogdmlzaXRvcikKICAgICB2ODo6Vjg6OlZpc2l0SGFuZGxl c1dpdGhDbGFzc0lkcygmdmlzaXRvckFkYXB0ZXIpOwogfQogCi12b2lkIHZpc2l0QWN0aXZlRE9N Tm9kZXMoRE9NV3JhcHBlclZpc2l0b3I8Tm9kZT4qIHZpc2l0b3IpCi17Ci0gICAgdjg6OkhhbmRs ZVNjb3BlIHNjb3BlOwotCi0gICAgVmVjdG9yPERPTURhdGFTdG9yZSo+JiBsaXN0ID0gVjhQZXJJ c29sYXRlRGF0YTo6Y3VycmVudCgpLT5hbGxTdG9yZXMoKTsKLSAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IGxpc3Quc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgRE9NRGF0YVN0b3JlKiBzdG9yZSA9 IGxpc3RbaV07Ci0KLSAgICAgICAgc3RvcmUtPmFjdGl2ZURvbU5vZGVNYXAoKS52aXNpdChzdG9y ZSwgdmlzaXRvcik7Ci0gICAgfQotfQotCiB2b2lkIHZpc2l0RE9NT2JqZWN0cyhET01XcmFwcGVy VmlzaXRvcjx2b2lkPiogdmlzaXRvcikKIHsKICAgICB2ODo6SGFuZGxlU2NvcGUgc2NvcGU7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAuaAppbmRleCA2ODZkNzYyNjdhYzA4ZTY4ZTQ5 MmZjNzAxMjY4MDJmNjhiM2FiYzA5Li5mNjJkM2Y0NDNhYjIyNzZlMzRkYzdkMDAzMzk1YjEyYjkw NzgxYThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmgKQEAgLTQ0LDcgKzQ0 LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgRE9NV3JhcHBlck1hcDxOb2RlPiYgZ2V0 RE9NTm9kZU1hcCh2ODo6SXNvbGF0ZSogPSAwKTsKICAgICBET01XcmFwcGVyTWFwPE5vZGU+JiBn ZXRBY3RpdmVET01Ob2RlTWFwKHY4OjpJc29sYXRlKiA9IDApOwotICAgIHZvaWQgdmlzaXRBY3Rp dmVET01Ob2RlcyhET01XcmFwcGVyVmlzaXRvcjxOb2RlPiopOwogCiAgICAgY2xhc3MgTm9kZVdy YXBwZXJWaXNpdG9yIHsKICAgICBwdWJsaWM6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEdDQ29udHJvbGxlci5jcHAKaW5kZXggMjUxYWE4ZTNjYTA5ZTgxMDQ1ZGNhZWJiZTBiOGI2 Mzg5MGJkMDNmMS4uMWVlYmJiZTU1YWQ4YjliNjJlZDVlNGJlODUxMWFlMDg5MWJiYWYwZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApAQCAtNjcs MjkgKzY3LDI4IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotdGVtcGxhdGU8dHlwZW5hbWUg VD4KLWNsYXNzIEFjdGl2ZURPTU9iamVjdFByb2xvZ3VlVmlzaXRvciA6IHB1YmxpYyBET01XcmFw cGVyVmlzaXRvcjxUPiB7CitjbGFzcyBBY3RpdmVET01PYmplY3RQcm9sb2d1ZVZpc2l0b3IgOiBw dWJsaWMgRE9NV3JhcHBlclZpc2l0b3I8dm9pZD4gewogcHVibGljOgogICAgIGV4cGxpY2l0IEFj dGl2ZURPTU9iamVjdFByb2xvZ3VlVmlzaXRvcihWZWN0b3I8djg6OlBlcnNpc3RlbnQ8djg6OlZh bHVlPiA+KiBsaXZlT2JqZWN0cykKICAgICAgICAgOiBtX2xpdmVPYmplY3RzKGxpdmVPYmplY3Rz KQogICAgIHsKICAgICB9CiAKLSAgICB2b2lkIHZpc2l0RE9NV3JhcHBlcihET01EYXRhU3RvcmUq LCBUKiBvYmplY3QsIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIpCisgICAgdm9p ZCB2aXNpdERPTVdyYXBwZXIoRE9NRGF0YVN0b3JlKiwgdm9pZCogb2JqZWN0LCB2ODo6UGVyc2lz dGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQogICAgIHsKLSAgICAgICAgV3JhcHBlclR5cGVJbmZv KiB0eXBlSW5mbyA9IFY4RE9NV3JhcHBlcjo6ZG9tV3JhcHBlclR5cGUod3JhcHBlcik7ICAKKyAg ICAgICAgV3JhcHBlclR5cGVJbmZvKiB0eXBlID0gVjhET01XcmFwcGVyOjpkb21XcmFwcGVyVHlw ZSh3cmFwcGVyKTsgIAogCi0gICAgICAgIGlmIChWOE1lc3NhZ2VQb3J0OjppbmZvLmVxdWFscyh0 eXBlSW5mbykpIHsKKyAgICAgICAgaWYgKFY4TWVzc2FnZVBvcnQ6OmluZm8uZXF1YWxzKHR5cGUp KSB7CiAgICAgICAgICAgICAvLyBNYXJrIGVhY2ggcG9ydCBhcyBpbi11c2UgaWYgaXQncyBlbnRh bmdsZWQuIEZvciBzaW1wbGljaXR5J3Mgc2FrZSwKICAgICAgICAgICAgIC8vIHdlIGFzc3VtZSBh bGwgcG9ydHMgYXJlIHJlbW90ZWx5IGVudGFuZ2xlZCwgc2luY2UgdGhlIENocm9taXVtIHBvcnQK ICAgICAgICAgICAgIC8vIGltcGxlbWVudGF0aW9uIGNhbid0IHRlbGwgdGhlIGRpZmZlcmVuY2Uu Ci0gICAgICAgICAgICBNZXNzYWdlUG9ydCogcG9ydCA9IHJlaW50ZXJwcmV0X2Nhc3Q8TWVzc2Fn ZVBvcnQqPihvYmplY3QpOworICAgICAgICAgICAgTWVzc2FnZVBvcnQqIHBvcnQgPSBzdGF0aWNf Y2FzdDxNZXNzYWdlUG9ydCo+KG9iamVjdCk7CiAgICAgICAgICAgICBpZiAocG9ydC0+aXNFbnRh bmdsZWQoKSB8fCBwb3J0LT5oYXNQZW5kaW5nQWN0aXZpdHkoKSkKICAgICAgICAgICAgICAgICBt X2xpdmVPYmplY3RzLT5hcHBlbmQod3JhcHBlcik7CiAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgIH0KIAotICAgICAgICBBY3RpdmVET01PYmplY3QqIGFjdGl2ZURPTU9iamVjdCA9IHR5cGVJ bmZvLT50b0FjdGl2ZURPTU9iamVjdCh3cmFwcGVyKTsKKyAgICAgICAgQWN0aXZlRE9NT2JqZWN0 KiBhY3RpdmVET01PYmplY3QgPSB0eXBlLT50b0FjdGl2ZURPTU9iamVjdCh3cmFwcGVyKTsKICAg ICAgICAgaWYgKGFjdGl2ZURPTU9iamVjdCAmJiBhY3RpdmVET01PYmplY3QtPmhhc1BlbmRpbmdB Y3Rpdml0eSgpKQogICAgICAgICAgICAgbV9saXZlT2JqZWN0cy0+YXBwZW5kKHdyYXBwZXIpOwog ICAgIH0KQEAgLTE2OCwxMSArMTY3LDIyIEBAIGJvb2wgb3BlcmF0b3I8KGNvbnN0IEltcGxpY2l0 Q29ubmVjdGlvbiYgbGVmdCwgY29uc3QgSW1wbGljaXRDb25uZWN0aW9uJiByaWdodCkKIAogY2xh c3MgTm9kZVZpc2l0b3IgOiBwdWJsaWMgTm9kZVdyYXBwZXJWaXNpdG9yIHsKIHB1YmxpYzoKKyAg ICBleHBsaWNpdCBOb2RlVmlzaXRvcihWZWN0b3I8djg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiA+ KiBsaXZlT2JqZWN0cykKKyAgICAgICAgOiBtX2xpdmVPYmplY3RzKGxpdmVPYmplY3RzKQorICAg IHsKKyAgICB9CisKICAgICB2b2lkIHZpc2l0Tm9kZVdyYXBwZXIoTm9kZSogbm9kZSwgdjg6OlBl cnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKICAgICB7CiAgICAgICAgIGlmIChub2RlLT5o YXNFdmVudExpc3RlbmVycygpKQogICAgICAgICAgICAgYWRkSW1wbGljaXRSZWZlcmVuY2VzRm9y Tm9kZVdpdGhFdmVudExpc3RlbmVycyhub2RlLCB3cmFwcGVyKTsKIAorICAgICAgICBXcmFwcGVy VHlwZUluZm8qIHR5cGUgPSBWOERPTVdyYXBwZXI6OmRvbVdyYXBwZXJUeXBlKHdyYXBwZXIpOyAg CisKKyAgICAgICAgQWN0aXZlRE9NT2JqZWN0KiBhY3RpdmVET01PYmplY3QgPSB0eXBlLT50b0Fj dGl2ZURPTU9iamVjdCh3cmFwcGVyKTsKKyAgICAgICAgaWYgKGFjdGl2ZURPTU9iamVjdCAmJiBh Y3RpdmVET01PYmplY3QtPmhhc1BlbmRpbmdBY3Rpdml0eSgpKQorICAgICAgICAgICAgbV9saXZl T2JqZWN0cy0+YXBwZW5kKHdyYXBwZXIpOworCiAgICAgICAgIE5vZGUqIHJvb3QgPSByb290Rm9y R0Mobm9kZSk7CiAgICAgICAgIGlmICghcm9vdCkKICAgICAgICAgICAgIHJldHVybjsKQEAgLTE5 OSw2ICsyMDksNyBAQCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRlOgorICAgIFZlY3Rvcjx2ODo6 UGVyc2lzdGVudDx2ODo6VmFsdWU+ID4qIG1fbGl2ZU9iamVjdHM7CiAgICAgVmVjdG9yPEltcGxp Y2l0Q29ubmVjdGlvbj4gbV9jb25uZWN0aW9uczsKIH07CiAKQEAgLTIyMiwxNiArMjMzLDE2IEBA IHZvaWQgVjhHQ0NvbnRyb2xsZXI6Om1ham9yR0NQcm9sb2d1ZSgpCiAKICAgICBWZWN0b3I8djg6 OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiA+IGxpdmVPYmplY3RzOwogICAgIGxpdmVPYmplY3RzLmFw cGVuZChWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCktPmVuc3VyZUxpdmVSb290KCkpOwotICAg IEFjdGl2ZURPTU9iamVjdFByb2xvZ3VlVmlzaXRvcjx2b2lkPiBhY3RpdmVPYmplY3RWaXNpdG9y KCZsaXZlT2JqZWN0cyk7CisKKyAgICBBY3RpdmVET01PYmplY3RQcm9sb2d1ZVZpc2l0b3IgYWN0 aXZlT2JqZWN0VmlzaXRvcigmbGl2ZU9iamVjdHMpOwogICAgIHZpc2l0QWN0aXZlRE9NT2JqZWN0 cygmYWN0aXZlT2JqZWN0VmlzaXRvcik7Ci0gICAgQWN0aXZlRE9NT2JqZWN0UHJvbG9ndWVWaXNp dG9yPE5vZGU+IGFjdGl2ZU5vZGVWaXNpdG9yKCZsaXZlT2JqZWN0cyk7Ci0gICAgdmlzaXRBY3Rp dmVET01Ob2RlcygmYWN0aXZlTm9kZVZpc2l0b3IpOwotICAgIHY4OjpWODo6QWRkT2JqZWN0R3Jv dXAobGl2ZU9iamVjdHMuZGF0YSgpLCBsaXZlT2JqZWN0cy5zaXplKCkpOwogCi0gICAgTm9kZVZp c2l0b3Igbm9kZVZpc2l0b3I7CisgICAgTm9kZVZpc2l0b3Igbm9kZVZpc2l0b3IoJmxpdmVPYmpl Y3RzKTsKICAgICB2aXNpdEFsbERPTU5vZGVzKCZub2RlVmlzaXRvcik7CiAgICAgbm9kZVZpc2l0 b3IuYXBwbHlHcm91cGluZygpOwogCisgICAgdjg6OlY4OjpBZGRPYmplY3RHcm91cChsaXZlT2Jq ZWN0cy5kYXRhKCksIGxpdmVPYmplY3RzLnNpemUoKSk7CisKICAgICBPYmplY3RWaXNpdG9yIG9i amVjdFZpc2l0b3I7CiAgICAgdmlzaXRET01PYmplY3RzKCZvYmplY3RWaXNpdG9yKTsKIAo=