100349 2012-10-25 01:24:26 -0700 Init timeout flag in ResourceErrorCF 2012-11-14 19:49:44 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 102271 P2 Normal --- 100509 98397 1 d-r d-r ap roger_fong webkit.review.bot oldest_to_newest 750533 0 d-r 2012-10-25 01:24:26 -0700 Similar to bug 99478, we'd need to initialize the timeout flag from the CFError in order for XHR timeouts to work (Bug 74802). 750540 1 170583 d-r 2012-10-25 01:27:44 -0700 Created attachment 170583 Patch 750541 2 d-r 2012-10-25 01:30:29 -0700 Roger, do you have an Apple Win build where you could test this? 750542 3 d-r 2012-10-25 01:32:04 -0700 This should fix the failures on the Apple Win 7 Release bot for the following test cases: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html 750811 4 d-r 2012-10-25 07:40:59 -0700 Alternatively, can we commit this experimentally and see whether the tests then pass on the bot? 750898 5 170583 ap 2012-10-25 09:09:48 -0700 Comment on attachment 170583 Patch > Alternatively, can we commit this experimentally and see whether the tests then pass on the bot? I think that we should. 750917 6 170583 webkit.review.bot 2012-10-25 09:29:01 -0700 Comment on attachment 170583 Patch Clearing flags on attachment: 170583 Committed r132493: <http://trac.webkit.org/changeset/132493> 750918 7 webkit.review.bot 2012-10-25 09:29:05 -0700 All reviewed patches have been landed. Closing bug. 750989 8 d-r 2012-10-25 10:37:59 -0700 Looks like it didn't quite cut it, but there's some hiccup with the buildmaster, let's have a look later again: http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29256 750996 9 roger_fong 2012-10-25 10:44:54 -0700 Ah, sorry, I do have a windows build. I'll test it out there as well. 751098 10 roger_fong 2012-10-25 12:12:16 -0700 still broken, is there a feature define I need to enable? 751925 11 webkit.review.bot 2012-10-26 05:21:47 -0700 Re-opened since this is blocked by bug 100509 751932 12 d-r 2012-10-26 05:26:27 -0700 Experimental fix rolled out in r132630. 751950 13 d-r 2012-10-26 05:57:11 -0700 Skipped for Win in r132638. 751951 14 d-r 2012-10-26 05:59:32 -0700 (In reply to comment #10) > still broken, is there a feature define I need to enable? There wasn't, but now there is, cmp. http://trac.webkit.org/changeset/132513 I currently have no build to test or work on this. If you'd like to take a look, the issue most like is just about checking what error code is CFNetworking is returning and then intializing the ResourceErrorBase's m_isTimeout to true, similar to the patch I tried. 767489 15 ddkilzer 2012-11-14 17:02:50 -0800 See also Bug 102271. 767638 16 ap 2012-11-14 19:49:44 -0800 *** This bug has been marked as a duplicate of bug 102271 *** 170583 2012-10-25 01:27:44 -0700 2012-10-25 09:29:01 -0700 Patch bug-100349-20121025112939.patch text/plain 1641 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ1OWU4NjhkZWRhNTUy Zjg0OGM3NjI4YTU5ZjgzODE5NjU5NzdhNS4uZTFlNThlMDI0OGRkNjU3Y2NjNTU1MDJhZGFjNThm Njg3OThlZTFhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTI1ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg SW5pdCB0aW1lb3V0IGZsYWcgaW4gUmVzb3VyY2VFcnJvckNGCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzNDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbml0aWFsaXplIHRoZSB0aW1lb3V0IHByb3Bl cnR5IHRvIHRydWUgaWYgdGhlIG5ldHdvcmsgZXJyb3Igd2FzIGEgdGltZW91dCBlcnJvci4KKyAg ICAgICAgVGhpcyBpcyBhIHNwZWN1bGF0aXZlIGZpeCBmb3IgdGhlIFhIUiB0aW1lb3V0IHRlc3Qg Y2FzZXMgZmFpbGluZyBvbiBBcHBsZSBXaW4gLQorICAgICAgICBJIGNhbid0IHZlcmlmeSB0aGlz IG9uIGEgbG9jYWwgbWFjaGluZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkK KyAgICAgICAgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC90aW1lb3V0LyoK KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VFcnJvckNGLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlc291cmNlRXJyb3I6OlJlc291cmNlRXJyb3IpOiBJbml0IG1fdGlt ZW91dCBmcm9tIGVycm9yIGNvZGUuCisKIDIwMTItMTAtMjUgIEVsbGlvdHQgU3ByZWhuICA8ZXNw cmVobkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIGRlYWQgTm9kZTo6aXNCbG9ja0Zs b3dPckJsb2NrVGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VFcnJvckNGLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VFcnJvckNGLmNwcAppbmRleCAzNTRmZDI3NTg2NDIwN2I3OWVmYzIxYWY3 ZDE5OWRiMGIzMDEyMGI0Li42ZmRmNWFkYjk5Y2Q4M2U2N2NjYjJmYjBmMDQ3NGYwN2JhODM1YzVk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNl RXJyb3JDRi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNv dXJjZUVycm9yQ0YuY3BwCkBAIC00NSw2ICs0NSw4IEBAIFJlc291cmNlRXJyb3I6OlJlc291cmNl RXJyb3IoQ0ZFcnJvclJlZiBjZkVycm9yKQogICAgICwgbV9wbGF0Zm9ybUVycm9yKGNmRXJyb3Ip CiB7CiAgICAgbV9pc051bGwgPSAhY2ZFcnJvcjsKKyAgICBpZiAoIW1faXNOdWxsKQorICAgICAg ICBtX2lzVGltZW91dCA9IENGRXJyb3JHZXRDb2RlKG1fcGxhdGZvcm1FcnJvci5nZXQoKSkgPT0g a0NGVVJMRXJyb3JUaW1lZE91dDsKIH0KIAogI2lmIFBMQVRGT1JNKFdJTikK