100347 2012-10-25 01:10:00 -0700 A mistake in WebCore::JavaScriptCallFrame::evaluate which will cause assert failed 2014-04-24 16:45:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99801 0 PeterHWang webkit-unassigned charles.wei fpizlo ggaren mark.lam mhahnenberg oliver timothy webkit.review.bot yurys oldest_to_newest 750523 0 PeterHWang 2012-10-25 01:10:00 -0700 When WebCore::JavaScriptCallFrame::evaluate is invoked in worker context, this statement JSLockHolder lock(JSDOMWindowBase::commonJSGlobalData()); will cause assert, since there is "ASSERT(isMainThread());" in JSDOMWindowBase::commonJSGlobalData. 750529 1 170581 PeterHWang 2012-10-25 01:15:15 -0700 Created attachment 170581 Patch 750613 2 PeterHWang 2012-10-25 03:24:17 -0700 it comes from <http://trac.webkit.org/changeset/121381>, a small neglect. 750852 3 170581 mark.lam 2012-10-25 08:26:47 -0700 Comment on attachment 170581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170581&action=review > Source/WebCore/ChangeLog:11 > + No new test cae. Typo in this line ("cae" ==> "case"). Just delete the line as it doesn't add any info. Otherwise, LGTM, but need r+ from someone else. 750878 4 fpizlo 2012-10-25 08:49:34 -0700 (In reply to comment #3) > (From update of attachment 170581 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170581&action=review > > > Source/WebCore/ChangeLog:11 > > + No new test cae. > > Typo in this line ("cae" ==> "case"). Just delete the line as it doesn't add any info. In WebCore changelogs we usually have a line about test cases. Peter, please fix the typo before landing. My preference would be to keep this line. > > Otherwise, LGTM, but need r+ from someone else. 751397 5 PeterHWang 2012-10-25 18:16:07 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 170581 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=170581&action=review > > > > > Source/WebCore/ChangeLog:11 > > > + No new test cae. > > > > Typo in this line ("cae" ==> "case"). Just delete the line as it doesn't add any info. > > In WebCore changelogs we usually have a line about test cases. Peter, please fix the typo before landing. My preference would be to keep this line. > > > > > Otherwise, LGTM, but need r+ from someone else. Sorry, thx. 751412 6 170781 PeterHWang 2012-10-25 18:36:02 -0700 Created attachment 170781 Patch 751416 7 170781 PeterHWang 2012-10-25 18:39:04 -0700 Comment on attachment 170781 Patch correct a mistake in ChangeLog according comment#5 and land this patch. 751418 8 170781 webkit.review.bot 2012-10-25 18:40:23 -0700 Comment on attachment 170781 Patch Rejecting attachment 170781 from review queue. peter.wang@torchmobile.com.cn does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 751420 9 170781 webkit.review.bot 2012-10-25 18:41:05 -0700 Comment on attachment 170781 Patch Rejecting attachment 170781 from commit-queue. peter.wang@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 751553 10 170781 webkit.review.bot 2012-10-25 22:41:43 -0700 Comment on attachment 170781 Patch Clearing flags on attachment: 170781 Committed r132573: <http://trac.webkit.org/changeset/132573> 751555 11 webkit.review.bot 2012-10-25 22:41:47 -0700 All reviewed patches have been landed. Closing bug. 1003874 12 darin 2014-04-24 16:45:57 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 170581 2012-10-25 01:15:15 -0700 2012-10-25 18:35:52 -0700 Patch bug-100347-20121025161341.patch text/plain 1604 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTdhNGIxYmYwMThmM2Yy OTRhMDQwNDc1MzFhNTk2N2I3MjA0YjY5OS4uYjI1NWEyODBiN2UzY2I2NzE4Zjg5M2I3MmMwMTU5 NTE2NmEwNzFiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTI1ICBQZXRl ciBXYW5nICA8cGV0ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgQSBtaXN0 YWtlIGluIFdlYkNvcmU6OkphdmFTY3JpcHRDYWxsRnJhbWU6OmV2YWx1YXRlIHdoaWNoIHdpbGwg Y2F1c2UgYXNzZXJ0IGZhaWxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAwMzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW4gd29ya2VyIGNvbnRleHQsIGNhbGxpbmcgIkpTRE9NV2luZG93QmFzZTo6 Y29tbW9uSlNHbG9iYWxEYXRhIiB3aWxsIGNhdXNlIGFzc2VydCwKKyAgICAgICAgc2luY2UgdGhl cmUgaXMgIkFTU0VSVChpc01haW5UaHJlYWQoKSkiIGluICJKU0RPTVdpbmRvd0Jhc2U6OmNvbW1v bkpTR2xvYmFsRGF0YSIuCisKKyAgICAgICAgTm8gbmV3IHRlc3QgY2FlLgorCisgICAgICAgICog YmluZGluZ3MvanMvSmF2YVNjcmlwdENhbGxGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpK YXZhU2NyaXB0Q2FsbEZyYW1lOjpldmFsdWF0ZSk6CisKIDIwMTItMTAtMjMgIEFuZHJhcyBCZWNz aSAgPGFuZHJhcy5iZWNzaUBkaWdpYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGRldmljZVBpeGVs UmF0aW8gZnJvbSBWaWV3cG9ydEF0dHJpYnV0ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0phdmFTY3JpcHRDYWxsRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSmF2YVNjcmlwdENhbGxGcmFtZS5jcHAKaW5kZXggOGQxOWQ1MWQ3Mzc3MjAzZTNm ZmZhYzQxNjc2OTU0ZDZkMzM5ZmEyYi4uNDVlM2I2ODY0MTVhMGUyMTNlMDFiMDFjODFlYzdhZmJl MTUxMGE5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSmF2YVNjcmlw dENhbGxGcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSmF2YVNjcmlw dENhbGxGcmFtZS5jcHAKQEAgLTExNSw3ICsxMTUsNyBAQCBKU1ZhbHVlIEphdmFTY3JpcHRDYWxs RnJhbWU6OmV2YWx1YXRlKGNvbnN0IFN0cmluZyYgc2NyaXB0LCBKU1ZhbHVlJiBleGNlcHRpb24p CiAgICAgaWYgKCFtX2lzVmFsaWQpCiAgICAgICAgIHJldHVybiBqc051bGwoKTsKIAotICAgIEpT TG9ja0hvbGRlciBsb2NrKEpTRE9NV2luZG93QmFzZTo6Y29tbW9uSlNHbG9iYWxEYXRhKCkpOwor ICAgIEpTTG9ja0hvbGRlciBsb2NrKG1fZGVidWdnZXJDYWxsRnJhbWUuY2FsbEZyYW1lKCkpOwog ICAgIHJldHVybiBtX2RlYnVnZ2VyQ2FsbEZyYW1lLmV2YWx1YXRlKHNjcmlwdCwgZXhjZXB0aW9u KTsKIH0KIAo= 170781 2012-10-25 18:36:02 -0700 2012-10-25 22:41:43 -0700 Patch bug-100347-20121026093426.patch text/plain 1643 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTdhNGIxYmYwMThmM2Yy OTRhMDQwNDc1MzFhNTk2N2I3MjA0YjY5OS4uODRjZDVmYWE0MzlmM2YzMTYzOTk1ZmQyYmE3YTAx OGJiZWQwYjIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTI1ICBQZXRl ciBXYW5nICA8cGV0ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgQSBtaXN0 YWtlIGluIFdlYkNvcmU6OkphdmFTY3JpcHRDYWxsRnJhbWU6OmV2YWx1YXRlIHdoaWNoIHdpbGwg Y2F1c2UgYXNzZXJ0IGZhaWxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAwMzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBMYW0gYW5kIEZp bGlwIFBpemxvLgorCisgICAgICAgIEluIHdvcmtlciBjb250ZXh0LCBjYWxsaW5nICJKU0RPTVdp bmRvd0Jhc2U6OmNvbW1vbkpTR2xvYmFsRGF0YSIgd2lsbCBjYXVzZSBhc3NlcnQsCisgICAgICAg IHNpbmNlIHRoZXJlIGlzICJBU1NFUlQoaXNNYWluVGhyZWFkKCkpIiBpbiAiSlNET01XaW5kb3dC YXNlOjpjb21tb25KU0dsb2JhbERhdGEiLgorCisgICAgICAgIE5vIG5ldyB0ZXN0IGNhc2UsIHNp bmNlIG5vIGJlaGF2aW91ciBjaGFuZ2VkLgorCisgICAgICAgICogYmluZGluZ3MvanMvSmF2YVNj cmlwdENhbGxGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKYXZhU2NyaXB0Q2FsbEZyYW1l OjpldmFsdWF0ZSk6CisKIDIwMTItMTAtMjMgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBk aWdpYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGRldmljZVBpeGVsUmF0aW8gZnJvbSBWaWV3cG9y dEF0dHJpYnV0ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0phdmFT Y3JpcHRDYWxsRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSmF2YVNjcmlw dENhbGxGcmFtZS5jcHAKaW5kZXggOGQxOWQ1MWQ3Mzc3MjAzZTNmZmZhYzQxNjc2OTU0ZDZkMzM5 ZmEyYi4uNDVlM2I2ODY0MTVhMGUyMTNlMDFiMDFjODFlYzdhZmJlMTUxMGE5YyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSmF2YVNjcmlwdENhbGxGcmFtZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSmF2YVNjcmlwdENhbGxGcmFtZS5jcHAKQEAg LTExNSw3ICsxMTUsNyBAQCBKU1ZhbHVlIEphdmFTY3JpcHRDYWxsRnJhbWU6OmV2YWx1YXRlKGNv bnN0IFN0cmluZyYgc2NyaXB0LCBKU1ZhbHVlJiBleGNlcHRpb24pCiAgICAgaWYgKCFtX2lzVmFs aWQpCiAgICAgICAgIHJldHVybiBqc051bGwoKTsKIAotICAgIEpTTG9ja0hvbGRlciBsb2NrKEpT RE9NV2luZG93QmFzZTo6Y29tbW9uSlNHbG9iYWxEYXRhKCkpOworICAgIEpTTG9ja0hvbGRlciBs b2NrKG1fZGVidWdnZXJDYWxsRnJhbWUuY2FsbEZyYW1lKCkpOwogICAgIHJldHVybiBtX2RlYnVn Z2VyQ2FsbEZyYW1lLmV2YWx1YXRlKHNjcmlwdCwgZXhjZXB0aW9uKTsKIH0KIAo=