100346 2012-10-25 00:45:58 -0700 [EFL] DRT doesn't clean up after itself 2012-10-31 08:54:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100678 1 d-r tmpsantos abarth dpranke laszlo.gombos ojan pnormand rakuco tmpsantos webkit.review.bot zan oldest_to_newest 750506 0 d-r 2012-10-25 00:45:58 -0700 leaving a lot of DumpRenderTree-Efl-CacheDir-* files in /tmp. 754256 1 171428 tmpsantos 2012-10-30 05:37:16 -0700 Created attachment 171428 Patch 754377 2 171428 d-r 2012-10-30 08:10:55 -0700 Comment on attachment 171428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171428&action=review > Tools/ChangeLog:10 > + set on both WebKitTestRunner and DumpRenderTree. As discussed, would be good to explain how the manually set directory gets created (as you said, by the test driver, earlier). 755148 3 171618 tmpsantos 2012-10-31 04:27:47 -0700 Created attachment 171618 Patch 755160 4 laszlo.gombos 2012-10-31 04:41:10 -0700 xvfb driver is using DG_CACHE_HOME variable in webkitpy/layout_tests/port/xvfbdriver.py - perhaps that should be removed as well together with this patch ? 755168 5 tmpsantos 2012-10-31 04:53:28 -0700 (In reply to comment #4) > xvfb driver is using DG_CACHE_HOME variable in webkitpy/layout_tests/port/xvfbdriver.py - perhaps that should be removed as well together with this patch ? xvfb uses case is different, it is using XDG_CACHE_HOME to store the results of the test run. I checked if it was really necessary and looks like it is. 755321 6 tmpsantos 2012-10-31 08:21:57 -0700 (In reply to comment #5) > (In reply to comment #4) > > xvfb driver is using DG_CACHE_HOME variable in webkitpy/layout_tests/port/xvfbdriver.py - perhaps that should be removed as well together with this patch ? > > xvfb uses case is different, it is using XDG_CACHE_HOME to store the results of the test run. I checked if it was really necessary and looks like it is. OK, I did a investigation here. Currently there is no way of setting the Application cache via code. The only way is by setting XDG_CACHE_HOME. That means the xvfb test driver is wrong and should be setting it to inside DUMPRENDERTREE_TEMP/something. Gonna fix that on another bug though. 755356 7 171618 webkit.review.bot 2012-10-31 08:54:16 -0700 Comment on attachment 171618 Patch Clearing flags on attachment: 171618 Committed r133036: <http://trac.webkit.org/changeset/133036> 755357 8 webkit.review.bot 2012-10-31 08:54:20 -0700 All reviewed patches have been landed. Closing bug. 171428 2012-10-30 05:37:16 -0700 2012-10-31 04:27:39 -0700 Patch bug-100346-20121030143929.patch text/plain 1710 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzE2M2VlMWEyMDRhMDE1M2I4OGIwZjVmZjNmZWFlOTE4 NGM3YmJkZC4uMWMwOTg5M2QwY2M4OWZhNDY5Zjg4NDE5NWM1ZjM0YTBhMGM1ZmJjYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEyLTEwLTMwICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgogCisgICAgICAgIFtFRkxdIERSVCBkb2Vzbid0IGNsZWFuIHVwIGFmdGVyIGl0 c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw MzQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug ZG9uJ3QgbmVlZCB0byBjcmVhdGUgdGhlc2UgcGF0aHMgYW5kIHNldCB0aGVzZSBlbnZpcm9ubWVu dAorICAgICAgICB2YXJpYWJsZXMgYmVjYXVzZSBhbGwgdGhlIGRhdGEgYW5kIGNhY2hlIGRpcmVj dG9yaWVzIGFyZSBtYW51YWxseQorICAgICAgICBzZXQgb24gYm90aCBXZWJLaXRUZXN0UnVubmVy IGFuZCBEdW1wUmVuZGVyVHJlZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvZWZsLnB5OgorICAgICAgICAoRWZsUG9ydC5zZXR1cF9lbnZpcm9uX2Zvcl9z ZXJ2ZXIpOgorCisyMDEyLTEwLTMwICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5z YW50b3NAaW50ZWwuY29tPgorCiAgICAgICAgIFtXVFJdIFdlYktpdFRlc3RSdW5uZXIgaXMgbm90 IGNsZWFuaW5nIHVwIHRoZSBpY29uIGRhdGFiYXNlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA2NzgKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9lZmwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weQppbmRleCAxMDIyY2Q3YjcwMzFhZTBkNDk1MGM4 OTUzMzIzNTBiZTBiODhlMTk0Li42ZDFkZTA2NWJmZTkyMjZhZDlhZjI5MThmOGE2MDJiY2U1ZDMz MDcyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2VmbC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Vm bC5weQpAQCAtNjIsOCArNjIsNiBAQCBjbGFzcyBFZmxQb3J0KFBvcnQsIFB1bHNlQXVkaW9TYW5p dGl6ZXIpOgogICAgICAgICBpZiBzZWxmLndlYnByb2Nlc3NfY21kX3ByZWZpeDoKICAgICAgICAg ICAgIGVudlsnV0VCX1BST0NFU1NfQ01EX1BSRUZJWCddID0gc2VsZi53ZWJwcm9jZXNzX2NtZF9w cmVmaXgKIAotICAgICAgICBlbnZbJ1hER19DQUNIRV9IT01FJ10gPSBzdHIoc2VsZi5fZmlsZXN5 c3RlbS5ta2R0ZW1wKHByZWZpeD0nJXMtRWZsLUNhY2hlRGlyLScgJSBzZWxmLmRyaXZlcl9uYW1l KCkpKQotICAgICAgICBlbnZbJ1hER19EQVRBX0hPTUUnXSA9IHN0cihzZWxmLl9maWxlc3lzdGVt Lm1rZHRlbXAocHJlZml4PSclcy1FZmwtRGF0YURpci0nICUgc2VsZi5kcml2ZXJfbmFtZSgpKSkK ICAgICAgICAgcmV0dXJuIGVudgogCiAgICAgZGVmIGRlZmF1bHRfdGltZW91dF9tcyhzZWxmKToK 171618 2012-10-31 04:27:47 -0700 2012-10-31 08:54:16 -0700 Patch bug-100346-20121031133000.patch text/plain 1879 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMDA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmZkNWExNGQ5NDkyMDQ3Y2FkMGFjMmNjZTMyNDIzMGY1 MmRhYmY1MC4uMDQ1Njc0MzY4N2ZkM2IwNTQ3YWYxNGVjOTAzOWEzNzA1ZmEzZGZlNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTEwLTMxICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIERSVCBkb2Vzbid0IGNsZWFuIHVwIGFmdGVyIGl0 c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw MzQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHRlc3QgZHJpdmVyIGV4cG9ydHMgYW4gZW52aXJvbm1lbnQgdmFyaWFibGUgRFVNUFJFTkRFUlRS RUVfVEVNUAorICAgICAgICB3aGljaCBpcyB1c2VkIGJ5IGJvdGggRFJUIGFuZCBXVFIgYXMgdGhl IGZvbGRlciBmb3Igc3RvcmluZyBpY29ucywKKyAgICAgICAgZGF0YWJhc2VzLCBhcHBsaWNhdGlv biBjYWNoZSwgZXRjLCBvdmVycmlkaW5nIHRoZSBkZWZhdWx0IFhER18qIHBhdGguCisKKyAgICAg ICAgV2UgZG9uJ3QgbmVlZCB0byBjcmVhdGUgdGhlc2UgZm9sZGVycyBiZWNhdXNlIGluIGZhY3Qs IHRoZXkgYXJlIG5ldmVyCisgICAgICAgIHVzZWQgYW5kIGFsc28gbmV2ZXIgY2xlYW5lZC4gVGhp bmdzIGNyZWF0ZWQgaW5zaWRlIERVTVBSRU5ERVJUUkVFX1RFTVAKKyAgICAgICAgYXJlIGF1dG9t YXRpY2FsbHkgcmVtb3ZlZCBhZnRlciB0aGUgdGVzdCBydW4uCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weToKKyAgICAgICAgKEVmbFBvcnQuc2V0 dXBfZW52aXJvbl9mb3Jfc2VydmVyKToKKwogMjAxMi0xMC0zMSAgTWlrZSBXZXN0ICA8bWt3c3RA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNjcmlwdCBydW4gZnJvbSBhbiBpc29sYXRlZCB3b3Js ZCBzaG91bGQgYnlwYXNzIGEgcGFnZSdzIENTUC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9lZmwucHkKaW5kZXggMWU5ZWQxMDc5MjY0NDdjYzE0MjQ3NTBj MTlmZjUzMDJmMjdmYjNjMC4uMGM5YWNkOGQ4ZGVmODEwZmU0MDQzMmY0Yzg2OGFkMzYxNDQyYTlj MCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9l ZmwucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9lZmwu cHkKQEAgLTYyLDggKzYyLDYgQEAgY2xhc3MgRWZsUG9ydChQb3J0LCBQdWxzZUF1ZGlvU2FuaXRp emVyKToKICAgICAgICAgaWYgc2VsZi53ZWJwcm9jZXNzX2NtZF9wcmVmaXg6CiAgICAgICAgICAg ICBlbnZbJ1dFQl9QUk9DRVNTX0NNRF9QUkVGSVgnXSA9IHNlbGYud2VicHJvY2Vzc19jbWRfcHJl Zml4CiAKLSAgICAgICAgZW52WydYREdfQ0FDSEVfSE9NRSddID0gc3RyKHNlbGYuX2ZpbGVzeXN0 ZW0ubWtkdGVtcChwcmVmaXg9JyVzLUVmbC1DYWNoZURpci0nICUgc2VsZi5kcml2ZXJfbmFtZSgp KSkKLSAgICAgICAgZW52WydYREdfREFUQV9IT01FJ10gPSBzdHIoc2VsZi5fZmlsZXN5c3RlbS5t a2R0ZW1wKHByZWZpeD0nJXMtRWZsLURhdGFEaXItJyAlIHNlbGYuZHJpdmVyX25hbWUoKSkpCiAg ICAgICAgIHJldHVybiBlbnYKIAogICAgIGRlZiBkZWZhdWx0X3RpbWVvdXRfbXMoc2VsZik6Cg==