<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100343</bug_id>
          
          <creation_ts>2012-10-25 00:23:06 -0700</creation_ts>
          <short_desc>AX: file upload input cannot be activated with VoiceOver</short_desc>
          <delta_ts>2012-11-25 22:08:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="chris fleizach">cfleizach</reporter>
          <assigned_to name="chris fleizach">cfleizach</assigned_to>
          <cc>apinheiro</cc>
    
    <cc>bdakin</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>jdiggs</cc>
    
    <cc>mifenton</cc>
    
    <cc>sam</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>750472</commentid>
    <comment_count>0</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2012-10-25 00:23:06 -0700</bug_when>
    <thetext>AXPress as an action does not activate file upload input controls</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>750473</commentid>
    <comment_count>1</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2012-10-25 00:23:17 -0700</bug_when>
    <thetext>rdar://11400485</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>751544</commentid>
    <comment_count>2</comment_count>
      <attachid>170812</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2012-10-25 22:21:16 -0700</bug_when>
    <thetext>Created attachment 170812
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>765961</commentid>
    <comment_count>3</comment_count>
      <attachid>170812</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-11-13 13:02:48 -0800</bug_when>
    <thetext>Comment on attachment 170812
patch

I don&apos;t think this is the right approach.  Instead, we note that we are processing a user event when we enter the part of the accessibility code that will fire the click.  That could either be in [WebAccessibilityObjectWrapper accessibilityPerformPressAction] or maybe AccessibilityObject::press() and the derived versions.  You can use the UserGestureIndicator class to set the state.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768770</commentid>
    <comment_count>4</comment_count>
      <attachid>174576</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2012-11-15 17:51:21 -0800</bug_when>
    <thetext>Created attachment 174576
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768772</commentid>
    <comment_count>5</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2012-11-15 17:52:10 -0800</bug_when>
    <thetext>Sam, could you take another look.
Thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>769770</commentid>
    <comment_count>6</comment_count>
      <attachid>174576</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2012-11-16 16:45:42 -0800</bug_when>
    <thetext>Comment on attachment 174576
patch

Attachment 174576 did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14859547

New failing tests:
inspector-protocol/nmi-webaudio.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>771312</commentid>
    <comment_count>7</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-11-19 17:54:30 -0800</bug_when>
    <thetext>Thanks for tackling this Chris.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>775141</commentid>
    <comment_count>8</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2012-11-25 22:08:44 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/135680</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>170812</attachid>
            <date>2012-10-25 22:21:16 -0700</date>
            <delta_ts>2012-11-15 17:51:21 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>6219</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Nb3VzZUV2ZW50LmNwcAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvV2ViQ29yZS9kb20vTW91c2VFdmVudC5jcHAJKHJldmlzaW9uIDEzMjQyMSkKKysrIFNv
dXJjZS9XZWJDb3JlL2RvbS9Nb3VzZUV2ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA5LDYg
KzIwOSwxMSBAQAogICAgIH0KIH0KIAorYm9vbCBTaW11bGF0ZWRNb3VzZUV2ZW50Ojppc1NpbXVs
YXRlZEV2ZW50KCkgY29uc3QKK3sKKyAgICByZXR1cm4gdHJ1ZTsKK30KKyAgICAKIFBhc3NSZWZQ
dHI8TW91c2VFdmVudERpc3BhdGNoTWVkaWF0b3I+IE1vdXNlRXZlbnREaXNwYXRjaE1lZGlhdG9y
OjpjcmVhdGUoUGFzc1JlZlB0cjxNb3VzZUV2ZW50PiBtb3VzZUV2ZW50KQogewogICAgIHJldHVy
biBhZG9wdFJlZihuZXcgTW91c2VFdmVudERpc3BhdGNoTWVkaWF0b3IobW91c2VFdmVudCkpOwpJ
bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViQ29yZS9kb20vRXZlbnQuY3BwCShyZXZpc2lvbiAxMzI0MjEpCisrKyBTb3VyY2UvV2ViQ29y
ZS9kb20vRXZlbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzIsNiArMTMyLDExIEBACiAgICAg
cmV0dXJuIGZhbHNlOwogfQogCitib29sIEV2ZW50Ojppc1NpbXVsYXRlZEV2ZW50KCkgY29uc3QK
K3sKKyAgICByZXR1cm4gZmFsc2U7Cit9CisgICAgCiBib29sIEV2ZW50Ojppc0RyYWdFdmVudCgp
IGNvbnN0CiB7CiAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL01v
dXNlRXZlbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTW91c2VFdmVudC5o
CShyZXZpc2lvbiAxMzI0MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vTW91c2VFdmVudC5oCSh3
b3JraW5nIGNvcHkpCkBAIC0xMTEsNiArMTExLDcgQEAKIAogcHJpdmF0ZToKICAgICBTaW11bGF0
ZWRNb3VzZUV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBQYXNzUmVmUHRyPEFi
c3RyYWN0Vmlldz4sIFBhc3NSZWZQdHI8RXZlbnQ+IHVuZGVybHlpbmdFdmVudCk7CisgICAgdmly
dHVhbCBib29sIGlzU2ltdWxhdGVkRXZlbnQoKSBjb25zdDsKIH07CiAKIGNsYXNzIE1vdXNlRXZl
bnREaXNwYXRjaE1lZGlhdG9yIDogcHVibGljIEV2ZW50RGlzcGF0Y2hNZWRpYXRvciB7CkluZGV4
OiBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y
ZS9kb20vRXZlbnQuaAkocmV2aXNpb24gMTMyNDIxKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0V2
ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNSw3ICsxMjUsOCBAQAogICAgIHZpcnR1YWwgYm9v
bCBpc01vdXNlRXZlbnQoKSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wgaXNLZXlib2FyZEV2ZW50
KCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzVG91Y2hFdmVudCgpIGNvbnN0OwotCisgICAg
dmlydHVhbCBib29sIGlzU2ltdWxhdGVkRXZlbnQoKSBjb25zdDsKKyAgICAKICAgICAvLyBEcmFn
IGV2ZW50cyBhcmUgYSBzdWJzZXQgb2YgbW91c2UgZXZlbnRzLgogICAgIHZpcnR1YWwgYm9vbCBp
c0RyYWdFdmVudCgpIGNvbnN0OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzI1NzEpCisr
KyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyOCBA
QAorMjAxMi0xMC0yNSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisg
ICAgICAgIEFYOiBmaWxlIHVwbG9hZCBpbnB1dCBjYW5ub3QgYmUgYWN0aXZhdGVkIHdpdGggVm9p
Y2VPdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x
MDAzNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT
aW11bGF0ZWQgZXZlbnRzIHdlcmUgbm90IGFsbG93ZWQgdG8gYmUgcHJvY2Vzc2VkIGluIHRoZSBm
aWxlIGlucHV0IHR5cGUgaW4gdGhlIERPTUFjdGl2YXRlIGhhbmRsZXIuCisgICAgICAgIFRoaXMg
d2FzIGEgcHJvYmxlbSBmb3IgYWNjZXNzaWJpbGl0eSBjbGllbnRzIHdoaWNoIHJlbHkgb24gc2lt
dWxhdGVkIGV2ZW50cy4KKworICAgICAgICBUaGUgc29sdXRpb24gaXMgdG8gYWxsb3cgc2ltdWxh
dGVkIGV2ZW50cyB0byBiZSBpZGVudGlmaWVkIGFzIHN1Y2ggYW5kIGFsbG93IHRoZW0gdG8gYmUg
cHJvY2Vzc2VkLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0
dG9uLXdpdGgtYXhwcmVzcy5odG1sCisKKyAgICAgICAgKiBkb20vRXZlbnQuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6RXZlbnQ6OmlzU2ltdWxhdGVkRXZlbnQpOgorICAgICAgICAqIGRvbS9FdmVu
dC5oOgorICAgICAgICAoRXZlbnQpOgorICAgICAgICAqIGRvbS9Nb3VzZUV2ZW50LmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlNpbXVsYXRlZE1vdXNlRXZlbnQ6OmlzU2ltdWxhdGVkRXZlbnQpOgor
ICAgICAgICAqIGRvbS9Nb3VzZUV2ZW50Lmg6CisgICAgICAgIChTaW11bGF0ZWRNb3VzZUV2ZW50
KToKKyAgICAgICAgKiBodG1sL0ZpbGVJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
RmlsZUlucHV0VHlwZTo6aGFuZGxlRE9NQWN0aXZhdGVFdmVudCk6CisKIDIwMTItMTAtMjUgIEFk
YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBbVjhdIFdlIGNhbiBtZXJn
ZSB0aGUgd3JhcHBlciBtYXBzIGZvciBET00gb2JqZWN0cyBhbmQgYWN0aXZlIERPTSBvYmplY3Rz
CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0ZpbGVJbnB1dFR5cGUuY3BwCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5jcHAJKHJldmlzaW9uIDEzMjQy
MSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlucHV0VHlwZS5jcHAJKHdvcmtpbmcgY29w
eSkKQEAgLTE3OCw3ICsxNzgsOSBAQAogICAgIGlmIChlbGVtZW50KCktPmRpc2FibGVkKCkpCiAg
ICAgICAgIHJldHVybjsKIAotICAgIGlmICghU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1Vz
ZXJHZXN0dXJlKCkpCisgICAgLy8gU2ltdWxhdGVkIGV2ZW50cyBjYW4gb3JpZ2luYXRlIGZyb20g
YWNjZXNzS2V5QWN0aW9ucyBvciBhY2Nlc3NpYmlsaXR5IGNsaWVudHMuCisgICAgYm9vbCBpc1Np
bXVsYXRlZEV2ZW50ID0gZXZlbnQtPnVuZGVybHlpbmdFdmVudCgpICYmIGV2ZW50LT51bmRlcmx5
aW5nRXZlbnQoKS0+aXNTaW11bGF0ZWRFdmVudCgpOworICAgIGlmICghU2NyaXB0Q29udHJvbGxl
cjo6cHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCkgJiYgIWlzU2ltdWxhdGVkRXZlbnQpCiAgICAgICAg
IHJldHVybjsKIAogICAgIGlmIChDaHJvbWUqIGNocm9tZSA9IHRoaXMtPmNocm9tZSgpKSB7Cklu
ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxMzI1NzEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp
bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMC0yNSAgQ2hyaXMgRmxlaXphY2ggIDxj
ZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBmaWxlIHVwbG9hZCBpbnB1dCBjYW5u
b3QgYmUgYWN0aXZhdGVkIHdpdGggVm9pY2VPdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0dG9u
LXdpdGgtYXhwcmVzcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxp
dHkvZmlsZS11cGxvYWQtYnV0dG9uLXdpdGgtYXhwcmVzcy5odG1sOiBBZGRlZC4KKwogMjAxMi0x
MC0yNSAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9t
aXVtXSBBZGQgZXhwZWN0YXRpb25zIGZvciBmYXN0L2ltYWdlcy9leGlmLW9yaWVudGF0aW9uLmh0
bWwKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0dG9uLXdp
dGgtYXhwcmVzcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNz
aWJpbGl0eS9maWxlLXVwbG9hZC1idXR0b24td2l0aC1heHByZXNzLWV4cGVjdGVkLnR4dAkocmV2
aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0dG9u
LXdpdGgtYXhwcmVzcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAK
KworVGhpcyB0ZXN0cyB0aGF0IHdoZW4gQVhQcmVzcyBpcyB1c2VkIERPTUFjdGl2YXRlIHdpbGwg
YmUgaGFuZGxlZCBieSB0aGUgaW5wdXQgZmlsZSB0eXBlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2ls
bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q
TEVURSIuCisKK0RPTUFjdGl2YXRlIHdhcyBjYWxsZWQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk
IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls
aXR5L2ZpbGUtdXBsb2FkLWJ1dHRvbi13aXRoLWF4cHJlc3MuaHRtbAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM
YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2ZpbGUtdXBsb2FkLWJ1dHRvbi13aXRoLWF4cHJlc3Mu
aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZmlsZS11cGxv
YWQtYnV0dG9uLXdpdGgtYXhwcmVzcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMyIEBA
Cis8IURPQ1RZUEUgSFRNTD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9q
cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorCis8aW5wdXQgaWQ9ImZpbGV0
eXBlIiB0eXBlPSJmaWxlIj4KKworPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBp
ZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3Rz
IHRoYXQgd2hlbiBBWFByZXNzIGlzIHVzZWQgRE9NQWN0aXZhdGUgd2lsbCBiZSBoYW5kbGVkIGJ5
IHRoZSBpbnB1dCBmaWxlIHR5cGUuIikKKworaWYgKHdpbmRvdy50ZXN0UnVubmVyICYmIHdpbmRv
dy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworICAgIHdpbmRvdy50ZXN0UnVubmVyLndhaXRV
bnRpbERvbmUoKTsKKyAgICAKKyAgICB2YXIgaW5wdXRGaWxlID0gZG9jdW1lbnQuZ2V0RWxlbWVu
dEJ5SWQoImZpbGV0eXBlIik7CisKKyAgICBpbnB1dEZpbGUuYWRkRXZlbnRMaXN0ZW5lcigiRE9N
QWN0aXZhdGUiLCBmdW5jdGlvbigpIHsgCisgICAgICAgIGRlYnVnKCJET01BY3RpdmF0ZSB3YXMg
Y2FsbGVkIik7IAorICAgICAgICB3aW5kb3cudGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7IAorICAg
IH0pOworCisgICAgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlk
KCJmaWxldHlwZSIpLnByZXNzKCk7Cit9CisKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4v
ZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwv
aHRtbD4K
</data>
<flag name="review"
          id="184543"
          type_id="1"
          status="-"
          setter="sam"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>174576</attachid>
            <date>2012-11-15 17:51:21 -0800</date>
            <delta_ts>2012-11-19 17:54:13 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>4373</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNDg3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE1ICBDaHJpcyBG
bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGZpbGUgdXBsb2Fk
IGlucHV0IGNhbm5vdCBiZSBhY3RpdmF0ZWQgd2l0aCBWb2ljZU92ZXIKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDM0MworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXVsYXRlZCBldmVudHMgd2VyZSBu
b3QgYWxsb3dlZCB0byBiZSBwcm9jZXNzZWQgaW4gdGhlIGZpbGUgaW5wdXQgdHlwZSBpbiB0aGUg
RE9NQWN0aXZhdGUgaGFuZGxlci4KKyAgICAgICAgVGhpcyB3YXMgYSBwcm9ibGVtIGZvciBhY2Nl
c3NpYmlsaXR5IGNsaWVudHMgd2hpY2ggcmVseSBvbiBzaW11bGF0ZWQgZXZlbnRzLgorCisgICAg
ICAgIFRoZSBzb2x1dGlvbiBpcyB0byBtYXJrIHRoZSBVc2VyR2VzdHVyZUluZGljYXRvciBhcyBk
ZWZpbml0ZWx5IHByb2Nlc3NpbmcgYW4gZXZlbnQuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJp
bGl0eS9maWxlLXVwbG9hZC1idXR0b24td2l0aC1heHByZXNzLmh0bWwKKworICAgICAgICAqIGFj
Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpB
Y2Nlc3NpYmlsaXR5T2JqZWN0OjpwcmVzcyk6CisKIDIwMTItMTEtMTUgIFhpbmduYW4gV2FuZyAg
PHhpbmduYW4ud2FuZ0BpbnRlbC5jb20+CiAKICAgICAgICAgT3B0aW1pemUgdGhlIG11bHRpcGx5
LWFkZCBpbiBCaXF1YWQuY3BwOjpwcm9jZXNzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np
YmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD
b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJKHJldmlzaW9uIDEzNDgy
MCkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5j
cHAJKHdvcmtpbmcgY29weSkKQEAgLTU1LDYgKzU1LDcgQEAKICNpbmNsdWRlICJUZXh0Q2hlY2tl
ckNsaWVudC5oIgogI2luY2x1ZGUgIlRleHRDaGVja2luZ0hlbHBlci5oIgogI2luY2x1ZGUgIlRl
eHRJdGVyYXRvci5oIgorI2luY2x1ZGUgIlVzZXJHZXN0dXJlSW5kaWNhdG9yLmgiCiAjaW5jbHVk
ZSAiaHRtbGVkaXRpbmcuaCIKICNpbmNsdWRlICJ2aXNpYmxlX3VuaXRzLmgiCiAjaW5jbHVkZSA8
d3RmL1N0ZExpYkV4dHJhcy5oPgpAQCAtNTQwLDYgKzU0MSw4IEBACiAgICAgICAgIHJldHVybiBm
YWxzZTsKICAgICBpZiAoRnJhbWUqIGYgPSBhY3Rpb25FbGVtLT5kb2N1bWVudCgpLT5mcmFtZSgp
KQogICAgICAgICBmLT5sb2FkZXIoKS0+cmVzZXRNdWx0aXBsZUZvcm1TdWJtaXNzaW9uUHJvdGVj
dGlvbigpOworICAgIAorICAgIFVzZXJHZXN0dXJlSW5kaWNhdG9yIGdlc3R1cmVJbmRpY2F0b3Io
RGVmaW5pdGVseVByb2Nlc3NpbmdVc2VyR2VzdHVyZSk7CiAgICAgYWN0aW9uRWxlbS0+YWNjZXNz
S2V5QWN0aW9uKHRydWUpOwogICAgIHJldHVybiB0cnVlOwogfQpJbmRleDogTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g
MTM0ODcwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMTItMTEtMTUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNv
bT4KKworICAgICAgICBBWDogZmlsZSB1cGxvYWQgaW5wdXQgY2Fubm90IGJlIGFjdGl2YXRlZCB3
aXRoIFZvaWNlT3ZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTAwMzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1Y2ggYXMgYXBwcm9h
Y2gsIHJhdGlvbmFsZS4gUGxlYXNlIGFkZCBwZXItZnVuY3Rpb24gZGVzY3JpcHRpb25zIGJlbG93
IChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2ZpbGUtdXBsb2FkLWJ1dHRvbi13
aXRoLWF4cHJlc3MtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5
L2ZpbGUtdXBsb2FkLWJ1dHRvbi13aXRoLWF4cHJlc3MuaHRtbDogQWRkZWQuCisKIDIwMTItMTEt
MTUgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVz
ZSBjb21wbGV4IHBhdGggZm9yIHRoZSByZWZlcmVuY2UgdGV4dCBpbiBmYXN0L3RleHQvaW50ZXJu
YXRpb25hbC9jb21iaW5pbmctbWFya3MtcG9zaXRpb24uaHRtbApJbmRleDogTGF5b3V0VGVzdHMv
YWNjZXNzaWJpbGl0eS9maWxlLXVwbG9hZC1idXR0b24td2l0aC1heHByZXNzLWV4cGVjdGVkLnR4
dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2ZpbGUtdXBsb2FkLWJ1
dHRvbi13aXRoLWF4cHJlc3MtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz
dHMvYWNjZXNzaWJpbGl0eS9maWxlLXVwbG9hZC1idXR0b24td2l0aC1heHByZXNzLWV4cGVjdGVk
LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorCitUaGlzIHRlc3RzIHRoYXQgd2hl
biBBWFByZXNzIGlzIHVzZWQgRE9NQWN0aXZhdGUgd2lsbCBiZSBoYW5kbGVkIGJ5IHRoZSBpbnB1
dCBmaWxlIHR5cGUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT
UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworRE9NQWN0aXZhdGUg
d2FzIGNhbGxlZAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM
RVRFCisKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZmlsZS11cGxvYWQtYnV0dG9u
LXdpdGgtYXhwcmVzcy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxp
dHkvZmlsZS11cGxvYWQtYnV0dG9uLXdpdGgtYXhwcmVzcy5odG1sCShyZXZpc2lvbiAwKQorKysg
TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9maWxlLXVwbG9hZC1idXR0b24td2l0aC1heHByZXNz
Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzIgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0
bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBy
ZS5qcyI+PC9zY3JpcHQ+CisKKzxpbnB1dCBpZD0iZmlsZXR5cGUiIHR5cGU9ImZpbGUiPgorCis8
ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKwor
PHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB3aGVuIEFYUHJlc3MgaXMg
dXNlZCBET01BY3RpdmF0ZSB3aWxsIGJlIGhhbmRsZWQgYnkgdGhlIGlucHV0IGZpbGUgdHlwZS4i
KQorCitpZiAod2luZG93LnRlc3RSdW5uZXIgJiYgd2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9s
bGVyKSB7CisgICAgd2luZG93LnRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIAorICAg
IHZhciBpbnB1dEZpbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZmlsZXR5cGUiKTsKKwor
ICAgIGlucHV0RmlsZS5hZGRFdmVudExpc3RlbmVyKCJET01BY3RpdmF0ZSIsIGZ1bmN0aW9uKCkg
eyAKKyAgICAgICAgZGVidWcoIkRPTUFjdGl2YXRlIHdhcyBjYWxsZWQiKTsgCisgICAgICAgIHdp
bmRvdy50ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsgCisgICAgfSk7CisKKyAgICBhY2Nlc3NpYmls
aXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoImZpbGV0eXBlIikucHJlc3MoKTsK
K30KKworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10
ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=
</data>
<flag name="review"
          id="189682"
          type_id="1"
          status="+"
          setter="sam"
    />
    <flag name="commit-queue"
          id="189979"
          type_id="3"
          status="-"
          setter="buildbot"
    />
          </attachment>
      

    </bug>

</bugzilla>