100342 2012-10-25 00:13:22 -0700 [WK2] Use per destination ID message receivers for DownloadProxy. 2012-10-25 18:03:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100310 1 bw80.lee bw80.lee andersca cdumez kenneth sam webkit.review.bot oldest_to_newest 750466 0 bw80.lee 2012-10-25 00:13:22 -0700 There is below assertion after r132386 when dispatching ipc message about DownloadProxy. ASSERTION FAILED: !decoder.destinationID() /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.cpp(79) : bool CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) To fix the assertion problem, adding/removing messageReceiver for DownloadProxy need to use new addMessageReceiver() function with downloadID for destinationID parameter. 750477 1 170569 bw80.lee 2012-10-25 00:26:49 -0700 Created attachment 170569 Patch 750495 2 170569 kenneth 2012-10-25 00:40:37 -0700 Comment on attachment 170569 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170569&action=review > Source/WebKit2/ChangeLog:8 > + Per destination ID message receivers are proposed at r132386. in r... not at > Source/WebKit2/ChangeLog:10 > + so the messages should be handled by per destination ID message receivers. by per sounds weird. by? 750500 3 bw80.lee 2012-10-25 00:44:15 -0700 (In reply to comment #2) > (From update of attachment 170569 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170569&action=review > > > Source/WebKit2/ChangeLog:8 > > + Per destination ID message receivers are proposed at r132386. > > in r... not at Ok. I'll change it. > > > Source/WebKit2/ChangeLog:10 > > + so the messages should be handled by per destination ID message receivers. > > by per sounds weird. by? How about this? 'so the messages should be handled by the message receivers that is newly proposed.' 750509 4 170569 cdumez 2012-10-25 00:48:50 -0700 Comment on attachment 170569 Patch Looks reasonable to me but it would be nice if Andersca took a look. 750599 5 170598 bw80.lee 2012-10-25 02:51:09 -0700 Created attachment 170598 Patch 750601 6 bw80.lee 2012-10-25 02:53:04 -0700 Applied the comments from kenneth. 750870 7 170598 andersca 2012-10-25 08:45:16 -0700 Comment on attachment 170598 Patch Looks great! r=me. 751365 8 170598 bw80.lee 2012-10-25 17:19:31 -0700 Comment on attachment 170598 Patch Thank you for the review :) 751389 9 170598 webkit.review.bot 2012-10-25 18:03:05 -0700 Comment on attachment 170598 Patch Clearing flags on attachment: 170598 Committed r132548: <http://trac.webkit.org/changeset/132548> 751390 10 webkit.review.bot 2012-10-25 18:03:10 -0700 All reviewed patches have been landed. Closing bug. 170569 2012-10-25 00:26:49 -0700 2012-10-25 02:51:03 -0700 Patch bug-100342-20121025162522.patch text/plain 4453 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmQ5YjMyOGIxMDAzZjJm OTBjMTdhYjc5MjkxNGNmYjI3YjVkMGJhMy4uNWExMTQxZGM0MjA0MTM4YWRjMDJjNjNiNWFkOTJl OTMzODA2Y2QyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTI1ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBVc2UgcGVy IGRlc3RpbmF0aW9uIElEIG1lc3NhZ2UgcmVjZWl2ZXJzIGZvciBEb3dubG9hZFByb3h5LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMzQyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVyIGRlc3RpbmF0 aW9uIElEIG1lc3NhZ2UgcmVjZWl2ZXJzIGFyZSBwcm9wb3NlZCBhdCByMTMyMzg2LgorICAgICAg ICBJUEMgbWVzc2FnZXMgb2YgRG93bmxvYWRQcm94eSB1c2UgZG93bmxvYWQgaWQgZm9yIGRlc3Rp bmF0aW9uIElELAorICAgICAgICBzbyB0aGUgbWVzc2FnZXMgc2hvdWxkIGJlIGhhbmRsZWQgYnkg cGVyIGRlc3RpbmF0aW9uIElEIG1lc3NhZ2UgcmVjZWl2ZXJzLgorCisgICAgICAgICogVUlQcm9j ZXNzL1dlYkNvbnRleHQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0OjpXZWJDb250 ZXh0KToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6Y3JlYXRlRG93bmxvYWRQcm94eSk6 CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OmRvd25sb2FkRmluaXNoZWQpOgorICAgICAg ICAoV2ViS2l0OjpXZWJDb250ZXh0OjphZGRNZXNzYWdlUmVjZWl2ZXIpOgorICAgICAgICAoV2Vi S2l0KToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6cmVtb3ZlTWVzc2FnZVJlY2VpdmVy KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5oOgorICAgICAgICAoV2ViQ29udGV4 dCk6CisKIDIwMTItMTAtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGlu dGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIEdldCByaWQgb2YgRXdrX1ZpZXcgcHJpdmF0 ZSBDIEFQSSAoUGFydCAxKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCmlu ZGV4IDU2YTAxN2M2ZmM5YTJkOTM2MzUxZDgzOWIwNzkwYTU0ODA5NzA2ODUuLjFlODQzN2JhOWY0 Y2NhZTI2YTA4MjFmOGZkNWM3YTliZTdmODA4OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViQ29udGV4dC5jcHAKQEAgLTEzNiw3ICsxMzYsNiBAQCBXZWJDb250ZXh0OjpXZWJDb250ZXh0 KFByb2Nlc3NNb2RlbCBwcm9jZXNzTW9kZWwsIGNvbnN0IFN0cmluZyYgaW5qZWN0ZWRCdW5kbGVQ YQogI2VuZGlmCiB7CiAgICAgYWRkTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpXZWJDb250ZXh0 OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIHRoaXMpOwotICAgIGFkZE1lc3NhZ2VSZWNlaXZlcihN ZXNzYWdlczo6RG93bmxvYWRQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCB0aGlzKTsKICAg ICBhZGRNZXNzYWdlUmVjZWl2ZXIoQ29yZUlQQzo6TWVzc2FnZUtpbmRUcmFpdHM8V2ViQ29udGV4 dExlZ2FjeU1lc3NhZ2U6OktpbmQ+OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIHRoaXMpOwogCiAg ICAgLy8gTk9URTogVGhlc2Ugc3ViLW9iamVjdHMgbXVzdCBiZSBpbml0aWFsaXplZCBhZnRlciBt X21lc3NhZ2VSZWNlaXZlck1hcC4uCkBAIC03NjIsNiArNzYxLDcgQEAgRG93bmxvYWRQcm94eSog V2ViQ29udGV4dDo6Y3JlYXRlRG93bmxvYWRQcm94eSgpCiB7CiAgICAgUmVmUHRyPERvd25sb2Fk UHJveHk+IGRvd25sb2FkUHJveHkgPSBEb3dubG9hZFByb3h5OjpjcmVhdGUodGhpcyk7CiAgICAg bV9kb3dubG9hZHMuc2V0KGRvd25sb2FkUHJveHktPmRvd25sb2FkSUQoKSwgZG93bmxvYWRQcm94 eSk7CisgICAgYWRkTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpEb3dubG9hZFByb3h5OjptZXNz YWdlUmVjZWl2ZXJOYW1lKCksIGRvd25sb2FkUHJveHktPmRvd25sb2FkSUQoKSwgdGhpcyk7CiAg ICAgcmV0dXJuIGRvd25sb2FkUHJveHkuZ2V0KCk7CiB9CiAKQEAgLTc3MCw2ICs3NzAsNyBAQCB2 b2lkIFdlYkNvbnRleHQ6OmRvd25sb2FkRmluaXNoZWQoRG93bmxvYWRQcm94eSogZG93bmxvYWRQ cm94eSkKICAgICBBU1NFUlQobV9kb3dubG9hZHMuY29udGFpbnMoZG93bmxvYWRQcm94eS0+ZG93 bmxvYWRJRCgpKSk7CiAKICAgICBkb3dubG9hZFByb3h5LT5pbnZhbGlkYXRlKCk7CisgICAgcmVt b3ZlTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpEb3dubG9hZFByb3h5OjptZXNzYWdlUmVjZWl2 ZXJOYW1lKCksIGRvd25sb2FkUHJveHktPmRvd25sb2FkSUQoKSk7CiAgICAgbV9kb3dubG9hZHMu cmVtb3ZlKGRvd25sb2FkUHJveHktPmRvd25sb2FkSUQoKSk7CiB9CiAKQEAgLTc5MCw2ICs3OTEs MTYgQEAgdm9pZCBXZWJDb250ZXh0OjphZGRNZXNzYWdlUmVjZWl2ZXIoQ29yZUlQQzo6U3RyaW5n UmVmZXJlbmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUKICAgICBtX21lc3NhZ2VSZWNlaXZlck1hcC5h ZGRNZXNzYWdlUmVjZWl2ZXIobWVzc2FnZVJlY2VpdmVyTmFtZSwgbWVzc2FnZVJlY2VpdmVyKTsK IH0KIAordm9pZCBXZWJDb250ZXh0OjphZGRNZXNzYWdlUmVjZWl2ZXIoQ29yZUlQQzo6U3RyaW5n UmVmZXJlbmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUsIHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQsIENv cmVJUEM6Ok1lc3NhZ2VSZWNlaXZlciogbWVzc2FnZVJlY2VpdmVyKQoreworICAgIG1fbWVzc2Fn ZVJlY2VpdmVyTWFwLmFkZE1lc3NhZ2VSZWNlaXZlcihtZXNzYWdlUmVjZWl2ZXJOYW1lLCBkZXN0 aW5hdGlvbklELCBtZXNzYWdlUmVjZWl2ZXIpOworfQorCit2b2lkIFdlYkNvbnRleHQ6OnJlbW92 ZU1lc3NhZ2VSZWNlaXZlcihDb3JlSVBDOjpTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZVJlY2VpdmVy TmFtZSwgdWludDY0X3QgZGVzdGluYXRpb25JRCkKK3sKKyAgICBtX21lc3NhZ2VSZWNlaXZlck1h cC5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIobWVzc2FnZVJlY2VpdmVyTmFtZSwgZGVzdGluYXRpb25J RCk7Cit9CisKIGJvb2wgV2ViQ29udGV4dDo6ZGlzcGF0Y2hNZXNzYWdlKENvcmVJUEM6OkNvbm5l Y3Rpb24qIGNvbm5lY3Rpb24sIENvcmVJUEM6Ok1lc3NhZ2VJRCBtZXNzYWdlSUQsIENvcmVJUEM6 Ok1lc3NhZ2VEZWNvZGVyJiBkZWNvZGVyKQogewogICAgIHJldHVybiBtX21lc3NhZ2VSZWNlaXZl ck1hcC5kaXNwYXRjaE1lc3NhZ2UoY29ubmVjdGlvbiwgbWVzc2FnZUlELCBkZWNvZGVyKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCmluZGV4IDkzZGM2OGU3MGRjZTI3ZjdlMzVh NWJlNGJiMzNjYzRkNGMxODNhMDguLjBkNDQ0NTRiYWI2M2E2MTYzYjM2MzZmODYxYTM1YjQ3ZWIw MzQ0OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaApAQCAtODcsNiArODcs OSBAQCBwdWJsaWM6CiAgICAgc3RhdGljIGNvbnN0IFZlY3RvcjxXZWJDb250ZXh0Kj4mIGFsbENv bnRleHRzKCk7CiAKICAgICB2b2lkIGFkZE1lc3NhZ2VSZWNlaXZlcihDb3JlSVBDOjpTdHJpbmdS ZWZlcmVuY2UgbWVzc2FnZVJlY2VpdmVyTmFtZSwgQ29yZUlQQzo6TWVzc2FnZVJlY2VpdmVyKik7 CisgICAgdm9pZCBhZGRNZXNzYWdlUmVjZWl2ZXIoQ29yZUlQQzo6U3RyaW5nUmVmZXJlbmNlIG1l c3NhZ2VSZWNlaXZlck5hbWUsIHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQsIENvcmVJUEM6Ok1lc3Nh Z2VSZWNlaXZlciopOworICAgIHZvaWQgcmVtb3ZlTWVzc2FnZVJlY2VpdmVyKENvcmVJUEM6OlN0 cmluZ1JlZmVyZW5jZSBtZXNzYWdlUmVjZWl2ZXJOYW1lLCB1aW50NjRfdCBkZXN0aW5hdGlvbklE KTsKKwogICAgIGJvb2wgZGlzcGF0Y2hNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24qLCBDb3Jl SVBDOjpNZXNzYWdlSUQsIENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyJik7CiAgICAgYm9vbCBkaXNw YXRjaFN5bmNNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24qLCBDb3JlSVBDOjpNZXNzYWdlSUQs IENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyJiwgT3duUHRyPENvcmVJUEM6Ok1lc3NhZ2VFbmNvZGVy PiYpOwogCg== 170598 2012-10-25 02:51:09 -0700 2012-10-25 18:03:05 -0700 Patch bug-100342-20121025184942.patch text/plain 4472 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmQ5YjMyOGIxMDAzZjJm OTBjMTdhYjc5MjkxNGNmYjI3YjVkMGJhMy4uYjNlNWFkMDdkNDI4OTQ1MmFhOTM4ZGFjY2Y4YmZh M2NhNzVmYzU4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEwLTI1ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBVc2UgcGVy IGRlc3RpbmF0aW9uIElEIG1lc3NhZ2UgcmVjZWl2ZXJzIGZvciBEb3dubG9hZFByb3h5LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMzQyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVyIGRlc3RpbmF0 aW9uIElEIG1lc3NhZ2UgcmVjZWl2ZXJzIHdlcmUgcHJvcG9zZWQgaW4gcjEzMjM4Ni4KKyAgICAg ICAgSVBDIG1lc3NhZ2VzIG9mIERvd25sb2FkUHJveHkgdXNlIGRvd25sb2FkIElEIGZvciBkZXN0 aW5hdGlvbiBJRCwKKyAgICAgICAgc28gdGhlIG1lc3NhZ2VzIHNob3VsZCBiZSBoYW5kbGVkIGJ5 IHRoZSBtZXNzc2FnZSByZWNlaXZlciB0aGF0IHdhcworICAgICAgICBuZXdseSBwcm9wb3NlZC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViQ29udGV4dDo6V2ViQ29udGV4dCk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OmNy ZWF0ZURvd25sb2FkUHJveHkpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0Ojpkb3dubG9h ZEZpbmlzaGVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6YWRkTWVzc2FnZVJlY2Vp dmVyKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnJl bW92ZU1lc3NhZ2VSZWNlaXZlcik6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHQuaDoK KyAgICAgICAgKFdlYkNvbnRleHQpOgorCiAyMDEyLTEwLTI0ICBDaHJpc3RvcGhlIER1bWV6ICA8 Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBHZXQgcmlk IG9mIEV3a19WaWV3IHByaXZhdGUgQyBBUEkgKFBhcnQgMSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJDb250ZXh0LmNwcAppbmRleCA1NmEwMTdjNmZjOWEyZDkzNjM1MWQ4MzliMDc5MGE1NDgw OTcwNjg1Li4xZTg0MzdiYTlmNGNjYWUyNmEwODIxZjhmZDVjN2E5YmU3ZjgwODliIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCkBAIC0xMzYsNyArMTM2LDYgQEAgV2Vi Q29udGV4dDo6V2ViQ29udGV4dChQcm9jZXNzTW9kZWwgcHJvY2Vzc01vZGVsLCBjb25zdCBTdHJp bmcmIGluamVjdGVkQnVuZGxlUGEKICNlbmRpZgogewogICAgIGFkZE1lc3NhZ2VSZWNlaXZlcihN ZXNzYWdlczo6V2ViQ29udGV4dDo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCB0aGlzKTsKLSAgICBh ZGRNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OkRvd25sb2FkUHJveHk6Om1lc3NhZ2VSZWNlaXZl ck5hbWUoKSwgdGhpcyk7CiAgICAgYWRkTWVzc2FnZVJlY2VpdmVyKENvcmVJUEM6Ok1lc3NhZ2VL aW5kVHJhaXRzPFdlYkNvbnRleHRMZWdhY3lNZXNzYWdlOjpLaW5kPjo6bWVzc2FnZVJlY2VpdmVy TmFtZSgpLCB0aGlzKTsKIAogICAgIC8vIE5PVEU6IFRoZXNlIHN1Yi1vYmplY3RzIG11c3QgYmUg aW5pdGlhbGl6ZWQgYWZ0ZXIgbV9tZXNzYWdlUmVjZWl2ZXJNYXAuLgpAQCAtNzYyLDYgKzc2MSw3 IEBAIERvd25sb2FkUHJveHkqIFdlYkNvbnRleHQ6OmNyZWF0ZURvd25sb2FkUHJveHkoKQogewog ICAgIFJlZlB0cjxEb3dubG9hZFByb3h5PiBkb3dubG9hZFByb3h5ID0gRG93bmxvYWRQcm94eTo6 Y3JlYXRlKHRoaXMpOwogICAgIG1fZG93bmxvYWRzLnNldChkb3dubG9hZFByb3h5LT5kb3dubG9h ZElEKCksIGRvd25sb2FkUHJveHkpOworICAgIGFkZE1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6 RG93bmxvYWRQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBkb3dubG9hZFByb3h5LT5kb3du bG9hZElEKCksIHRoaXMpOwogICAgIHJldHVybiBkb3dubG9hZFByb3h5LmdldCgpOwogfQogCkBA IC03NzAsNiArNzcwLDcgQEAgdm9pZCBXZWJDb250ZXh0Ojpkb3dubG9hZEZpbmlzaGVkKERvd25s b2FkUHJveHkqIGRvd25sb2FkUHJveHkpCiAgICAgQVNTRVJUKG1fZG93bmxvYWRzLmNvbnRhaW5z KGRvd25sb2FkUHJveHktPmRvd25sb2FkSUQoKSkpOwogCiAgICAgZG93bmxvYWRQcm94eS0+aW52 YWxpZGF0ZSgpOworICAgIHJlbW92ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6RG93bmxvYWRQ cm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBkb3dubG9hZFByb3h5LT5kb3dubG9hZElEKCkp OwogICAgIG1fZG93bmxvYWRzLnJlbW92ZShkb3dubG9hZFByb3h5LT5kb3dubG9hZElEKCkpOwog fQogCkBAIC03OTAsNiArNzkxLDE2IEBAIHZvaWQgV2ViQ29udGV4dDo6YWRkTWVzc2FnZVJlY2Vp dmVyKENvcmVJUEM6OlN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlUmVjZWl2ZXJOYW1lCiAgICAgbV9t ZXNzYWdlUmVjZWl2ZXJNYXAuYWRkTWVzc2FnZVJlY2VpdmVyKG1lc3NhZ2VSZWNlaXZlck5hbWUs IG1lc3NhZ2VSZWNlaXZlcik7CiB9CiAKK3ZvaWQgV2ViQ29udGV4dDo6YWRkTWVzc2FnZVJlY2Vp dmVyKENvcmVJUEM6OlN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlUmVjZWl2ZXJOYW1lLCB1aW50NjRf dCBkZXN0aW5hdGlvbklELCBDb3JlSVBDOjpNZXNzYWdlUmVjZWl2ZXIqIG1lc3NhZ2VSZWNlaXZl cikKK3sKKyAgICBtX21lc3NhZ2VSZWNlaXZlck1hcC5hZGRNZXNzYWdlUmVjZWl2ZXIobWVzc2Fn ZVJlY2VpdmVyTmFtZSwgZGVzdGluYXRpb25JRCwgbWVzc2FnZVJlY2VpdmVyKTsKK30KKwordm9p ZCBXZWJDb250ZXh0OjpyZW1vdmVNZXNzYWdlUmVjZWl2ZXIoQ29yZUlQQzo6U3RyaW5nUmVmZXJl bmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUsIHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQpCit7CisgICAg bV9tZXNzYWdlUmVjZWl2ZXJNYXAucmVtb3ZlTWVzc2FnZVJlY2VpdmVyKG1lc3NhZ2VSZWNlaXZl ck5hbWUsIGRlc3RpbmF0aW9uSUQpOworfQorCiBib29sIFdlYkNvbnRleHQ6OmRpc3BhdGNoTWVz c2FnZShDb3JlSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uLCBDb3JlSVBDOjpNZXNzYWdlSUQg bWVzc2FnZUlELCBDb3JlSVBDOjpNZXNzYWdlRGVjb2RlciYgZGVjb2RlcikKIHsKICAgICByZXR1 cm4gbV9tZXNzYWdlUmVjZWl2ZXJNYXAuZGlzcGF0Y2hNZXNzYWdlKGNvbm5lY3Rpb24sIG1lc3Nh Z2VJRCwgZGVjb2Rlcik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi Q29udGV4dC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAppbmRleCA5 M2RjNjhlNzBkY2UyN2Y3ZTM1YTViZTRiYjMzY2M0ZDRjMTgzYTA4Li4wZDQ0NDU0YmFiNjNhNjE2 M2IzNjM2Zjg2MWEzNWI0N2ViMDM0NDhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViQ29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250 ZXh0LmgKQEAgLTg3LDYgKzg3LDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBWZWN0b3I8 V2ViQ29udGV4dCo+JiBhbGxDb250ZXh0cygpOwogCiAgICAgdm9pZCBhZGRNZXNzYWdlUmVjZWl2 ZXIoQ29yZUlQQzo6U3RyaW5nUmVmZXJlbmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUsIENvcmVJUEM6 Ok1lc3NhZ2VSZWNlaXZlciopOworICAgIHZvaWQgYWRkTWVzc2FnZVJlY2VpdmVyKENvcmVJUEM6 OlN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlUmVjZWl2ZXJOYW1lLCB1aW50NjRfdCBkZXN0aW5hdGlv bklELCBDb3JlSVBDOjpNZXNzYWdlUmVjZWl2ZXIqKTsKKyAgICB2b2lkIHJlbW92ZU1lc3NhZ2VS ZWNlaXZlcihDb3JlSVBDOjpTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZVJlY2VpdmVyTmFtZSwgdWlu dDY0X3QgZGVzdGluYXRpb25JRCk7CisKICAgICBib29sIGRpc3BhdGNoTWVzc2FnZShDb3JlSVBD OjpDb25uZWN0aW9uKiwgQ29yZUlQQzo6TWVzc2FnZUlELCBDb3JlSVBDOjpNZXNzYWdlRGVjb2Rl ciYpOwogICAgIGJvb2wgZGlzcGF0Y2hTeW5jTWVzc2FnZShDb3JlSVBDOjpDb25uZWN0aW9uKiwg Q29yZUlQQzo6TWVzc2FnZUlELCBDb3JlSVBDOjpNZXNzYWdlRGVjb2RlciYsIE93blB0cjxDb3Jl SVBDOjpNZXNzYWdlRW5jb2Rlcj4mKTsKIAo=