100333 2012-10-24 23:06:33 -0700 [V8] DOMDataStoreHandle serves no purpose and can be removed 2012-10-25 01:15:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100316 1 abarth abarth eric haraken webkit.review.bot oldest_to_newest 750395 0 abarth 2012-10-24 23:06:33 -0700 [V8] DOMDataStoreHandle serves no purpose and can be removed 750399 1 170554 abarth 2012-10-24 23:07:17 -0700 Created attachment 170554 Patch 750407 2 170554 eric 2012-10-24 23:19:35 -0700 Comment on attachment 170554 Patch LGTM. 750409 3 170554 eric 2012-10-24 23:20:08 -0700 Comment on attachment 170554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review > Source/WebCore/bindings/v8/DOMWrapperWorld.h:89 > + m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld)); is adoptPtr necessary for OwnPtrs? 750422 4 abarth 2012-10-24 23:29:43 -0700 (In reply to comment #3) > (From update of attachment 170554 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review > > > Source/WebCore/bindings/v8/DOMWrapperWorld.h:89 > > + m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld)); > > is adoptPtr necessary for OwnPtrs? Yes. That's a result of the "strict OwnPtr" work from a year or so ago. 750530 5 170554 webkit.review.bot 2012-10-25 01:15:15 -0700 Comment on attachment 170554 Patch Clearing flags on attachment: 170554 Committed r132458: <http://trac.webkit.org/changeset/132458> 750531 6 webkit.review.bot 2012-10-25 01:15:19 -0700 All reviewed patches have been landed. Closing bug. 170554 2012-10-24 23:07:17 -0700 2012-10-25 01:15:15 -0700 Patch bug-100333-20121024230551.patch text/plain 4171 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU1NzdiNTdlZDhiNjg0 Y2VkNjk2Zjc0YTdjNzJmOWFkMzExNTRjOS4uYjZlNTQ1ZDIwNjYxOGRjMzIyNDI0OTdjNzc3NWM4 MzljNzI0YWEwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTEwLTI0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBET01EYXRhU3RvcmVI YW5kbGUgc2VydmVzIG5vIHB1cnBvc2UgYW5kIGNhbiBiZSByZW1vdmVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMzE2LAorICAgICAgICBET01EYXRhU3RvcmVIYW5k bGUgaXMganVzdCBhIGdsb3JpZmllZCBPd25QdHIuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9E T01XcmFwcGVyV29ybGQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdyYXBwZXJXb3JsZDo6ZG9t RGF0YVN0b3JlKToKKyAgICAgICAgKERPTVdyYXBwZXJXb3JsZCk6CisgICAgICAgIChXZWJDb3Jl OjpET01XcmFwcGVyV29ybGQ6OkRPTVdyYXBwZXJXb3JsZCk6CisgICAgICAgICogYmluZGluZ3Mv djgvVjhET01NYXAuY3BwOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NTWFwLmg6CisKKzIw MTItMTAtMjQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAgICBbVjhd IFdlIGNhbiBtZXJnZSBET01EYXRhU3RvcmUsIFNjb3BlZERPTURhdGFTdG9yZSwgYW5kIFN0YXRp Y0RPTURhdGFTdG9yZSBpbnRvIG9uZSBjbGFzcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMzE2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvRE9NV3JhcHBlcldvcmxkLmgKaW5kZXggNWZjOTcxNjNiZTRlYzU5NjBiYjdhMzM2ZmYyZWE1 YWIyYjE2ZTEyYS4uYWY1NWM5NDA5MGYwNmQxMzEwMmQ3YjAwOTcwY2ViNzIxOGRjM2IyZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmgKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmgKQEAgLTMxLDYg KzMxLDcgQEAKICNpZm5kZWYgRE9NV3JhcHBlcldvcmxkX2gKICNkZWZpbmUgRE9NV3JhcHBlcldv cmxkX2gKIAorI2luY2x1ZGUgIkRPTURhdGFTdG9yZS5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3Jp Z2luLmgiCiAjaW5jbHVkZSAiVjhET01NYXAuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5o PgpAQCAtNjcsNyArNjgsNyBAQCBwdWJsaWM6CiAgICAgRE9NRGF0YVN0b3JlKiBkb21EYXRhU3Rv cmUoKSBjb25zdAogICAgIHsKICAgICAgICAgQVNTRVJUKG1fd29ybGRJZCAhPSB1bmluaXRpYWxp emVkV29ybGRJZCk7Ci0gICAgICAgIHJldHVybiBtX2RvbURhdGFTdG9yZS5nZXRTdG9yZSgpOwor ICAgICAgICByZXR1cm4gbV9kb21EYXRhU3RvcmUuZ2V0KCk7CiAgICAgfQogICAgIHZvaWQgZGVy ZWYoKQogICAgIHsKQEAgLTc5LDE5ICs4MCwxOCBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBpbnQg aXNvbGF0ZWRXb3JsZENvdW50OwogICAgIHN0YXRpYyBQYXNzUmVmUHRyPERPTVdyYXBwZXJXb3Js ZD4gY3JlYXRlTWFpbldvcmxkKCk7CiAgICAgc3RhdGljIHZvaWQgZGVhbGxvY2F0ZShET01XcmFw cGVyV29ybGQqKTsKKwogICAgIERPTVdyYXBwZXJXb3JsZChpbnQgd29ybGRJZCwgaW50IGV4dGVu c2lvbkdyb3VwKQogICAgICAgICA6IG1fd29ybGRJZCh3b3JsZElkKQogICAgICAgICAsIG1fZXh0 ZW5zaW9uR3JvdXAoZXh0ZW5zaW9uR3JvdXApCi0gICAgICAgICwgbV9kb21EYXRhU3RvcmUod29y bGRJZCAhPSB1bmluaXRpYWxpemVkV29ybGRJZCkKICAgICB7CisgICAgICAgIGlmICh3b3JsZElk ICE9IHVuaW5pdGlhbGl6ZWRXb3JsZElkKQorICAgICAgICAgICAgbV9kb21EYXRhU3RvcmUgPSBh ZG9wdFB0cihuZXcgRE9NRGF0YVN0b3JlKERPTURhdGFTdG9yZTo6SXNvbGF0ZWRXb3JsZCkpOwog ICAgIH0KIAogICAgIGNvbnN0IGludCBtX3dvcmxkSWQ7CiAgICAgY29uc3QgaW50IG1fZXh0ZW5z aW9uR3JvdXA7Ci0gICAgLy8gVGhlIGJhY2tpbmcgc3RvcmUgZm9yIHRoZSBpc29sYXRlZCB3b3Js ZCdzIERPTSB3cmFwcGVycy4gVGhpcyBjbGFzcwotICAgIC8vIGRvZXNuJ3QgaGF2ZSB2aXNpYmls aXR5IGludG8gdGhlIHdyYXBwZXJzLiBUaGlzIGhhbmRsZSBzaW1wbHkgaGVscHMKLSAgICAvLyBt YW5hZ2UgdGhlaXIgbGlmZXRpbWUuCi0gICAgRE9NRGF0YVN0b3JlSGFuZGxlIG1fZG9tRGF0YVN0 b3JlOworICAgIE93blB0cjxET01EYXRhU3RvcmU+IG1fZG9tRGF0YVN0b3JlOwogCiAgICAgZnJp ZW5kIERPTVdyYXBwZXJXb3JsZCogbWFpblRocmVhZE5vcm1hbFdvcmxkKCk7CiB9OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAuY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAuY3BwCmluZGV4IDNiYjQ3Y2RhYWEwOTQ4YmM3Njll M2Q3NzAyYmQzNTg0ZmJmYTYyZGYuLjIzMDRlZDgxNWNlM2NmMjE2Mjg4ZTgwOGQxZmRlYzIzZTE2 MWRjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5jcHAKQEAgLTM4LDE2 ICszOCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotRE9NRGF0YVN0b3JlSGFuZGxlOjpE T01EYXRhU3RvcmVIYW5kbGUoYm9vbCBpbml0aWFsaXplKQotewotICAgIGlmIChpbml0aWFsaXpl KQotICAgICAgICBtX3N0b3JlID0gYWRvcHRQdHIobmV3IERPTURhdGFTdG9yZShET01EYXRhU3Rv cmU6Oklzb2xhdGVkV29ybGQpKTsKLX0KLQotRE9NRGF0YVN0b3JlSGFuZGxlOjp+RE9NRGF0YVN0 b3JlSGFuZGxlKCkKLXsKLX0KLQogTm9kZVdyYXBwZXJWaXNpdG9yOjp+Tm9kZVdyYXBwZXJWaXNp dG9yKCkKIHsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9N TWFwLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5oCmluZGV4IDY2OWQw MWFmNTQxODY1NGQ4NTA3NTMwYTY4MTYwMWZjZmQ5NDYwZjkuLjY4NmQ3NjI2N2FjMDhlNjhlNDky ZmM3MDEyNjgwMmY2OGIzYWJjMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4RE9NTWFwLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAu aApAQCAtNDIsMjEgKzQyLDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0gICAgY2xhc3Mg RE9NRGF0YVN0b3JlOwotCi0gICAgLy8gQSB1dGlsaXR5IGNsYXNzIHRvIG1hbmFnZSB0aGUgbGlm ZXRpbWUgb2Ygc2V0IG9mIERPTSB3cmFwcGVycy4KLSAgICBjbGFzcyBET01EYXRhU3RvcmVIYW5k bGUgewotICAgIHB1YmxpYzoKLSAgICAgICAgZXhwbGljaXQgRE9NRGF0YVN0b3JlSGFuZGxlKGJv b2wgaW5pdGlhbGl6ZSk7Ci0gICAgICAgIH5ET01EYXRhU3RvcmVIYW5kbGUoKTsKLQotICAgICAg ICBET01EYXRhU3RvcmUqIGdldFN0b3JlKCkgY29uc3QgeyByZXR1cm4gbV9zdG9yZS5nZXQoKTsg fQotCi0gICAgcHJpdmF0ZToKLSAgICAgICAgT3duUHRyPERPTURhdGFTdG9yZT4gbV9zdG9yZTsK LSAgICB9OwotCi0gICAgLy8gQSBtYXAgZnJvbSBET00gbm9kZSB0byBpdHMgSlMgd3JhcHBlci4K ICAgICBET01XcmFwcGVyTWFwPE5vZGU+JiBnZXRET01Ob2RlTWFwKHY4OjpJc29sYXRlKiA9IDAp OwogICAgIERPTVdyYXBwZXJNYXA8Tm9kZT4mIGdldEFjdGl2ZURPTU5vZGVNYXAodjg6Oklzb2xh dGUqID0gMCk7CiAgICAgdm9pZCB2aXNpdEFjdGl2ZURPTU5vZGVzKERPTVdyYXBwZXJWaXNpdG9y PE5vZGU+Kik7Cg==