100303 2012-10-24 16:13:44 -0700 [EFL] Fix failure to highlight nodes on web inspector 2012-10-30 23:00:08 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 91592 0 seokju.kwon webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 750168 0 seokju.kwon 2012-10-24 16:13:44 -0700 It is not working to highlight nodes on web inspector when webview has SBS(Single Backing Store). 750247 1 170522 seokju.kwon 2012-10-24 17:40:42 -0700 Created attachment 170522 Patch 751581 2 170522 ryuan.choi 2012-10-25 23:14:26 -0700 Comment on attachment 170522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170522&action=review > Source/WebKit/efl/ewk/ewk_paint_context.cpp:172 > +#if ENABLE(INSPECTOR) > + WebCore::Page* page = view->frame()->page(); > + if (page) { > + WebCore::InspectorController* controller = page->inspectorController(); > + if (controller->highlightedNode()) > + controller->drawHighlight(*context->graphicContext); > + } > +#endif SBS calls ewk_paint_context many times for every dirty rect. How about moving this into ewk_view_single to call only one time. 751624 3 seokju.kwon 2012-10-26 00:09:37 -0700 (In reply to comment #2) > (From update of attachment 170522 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170522&action=review > > > Source/WebKit/efl/ewk/ewk_paint_context.cpp:172 > > +#if ENABLE(INSPECTOR) > > + WebCore::Page* page = view->frame()->page(); > > + if (page) { > > + WebCore::InspectorController* controller = page->inspectorController(); > > + if (controller->highlightedNode()) > > + controller->drawHighlight(*context->graphicContext); > > + } > > +#endif > > SBS calls ewk_paint_context many times for every dirty rect. > > How about moving this into ewk_view_single to call only one time. Ok. I will move it. 751627 4 170836 seokju.kwon 2012-10-26 00:11:53 -0700 Created attachment 170836 Patch 754932 5 ryuan.choi 2012-10-30 21:15:36 -0700 (In reply to comment #4) > Created an attachment (id=170836) [details] > Patch LGTM. 754961 6 170836 gyuyoung.kim 2012-10-30 22:11:32 -0700 Comment on attachment 170836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170836&action=review > Source/WebKit/efl/ewk/ewk_view_single.cpp:276 > + if (page) { WebKit prefers to use early return. 754979 7 170836 gyuyoung.kim 2012-10-30 22:53:44 -0700 Comment on attachment 170836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170836&action=review >> Source/WebKit/efl/ewk/ewk_view_single.cpp:276 >> + if (page) { > > WebKit prefers to use early return. As we talk in private, we can't return early in this case. If we do early return, remaining functions won't be called. 754985 8 170836 webkit.review.bot 2012-10-30 23:00:03 -0700 Comment on attachment 170836 Patch Clearing flags on attachment: 170836 Committed r132987: <http://trac.webkit.org/changeset/132987> 754986 9 webkit.review.bot 2012-10-30 23:00:08 -0700 All reviewed patches have been landed. Closing bug. 170522 2012-10-24 17:40:42 -0700 2012-10-26 00:11:47 -0700 Patch bug-100303-20121025093922.patch text/plain 1818 seokju.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZjI2NTZiYzBm NTgxMTk0NTQ1YTZmYTcwYTE4ODMxZmYxMTFiYWRmZi4uMjYzNmVjZGQxOTBjNDU1Y2IzZjczZTBl MjY5ZTBlNzM5ZDlhOTU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTEwLTI0ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEZpeCBmYWlsdXJlIHRvIGhpZ2hsaWdodCBub2RlcyBvbiB3ZWIgaW5zcGVjdG9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBub3Qg d29ya2luZyB0byBoaWdobGlnaHQgbm9kZXMgb24gd2ViIGluc3BlY3RvcgorICAgICAgICB3aGVu IHVzaW5nICdTaW5nbGUgQmFja2luZyBTdG9yZScuCisgICAgICAgIEFkZCBjb2RlIGZvciBkcmF3 aW5nIGl0IGlmIHRoZXJlIGlzIHRoZSBoaWdobGlnaHRlZCBub2RlLgorCisgICAgICAgICogZXdr L2V3a19wYWludF9jb250ZXh0LmNwcDoKKyAgICAgICAgKGV3a19wYWludF9jb250ZXh0X3BhaW50 KToKKwogMjAxMi0xMC0yNCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIGEgc3RyYXRlZ3kgZm9yIGxvYWRlciBjdXN0b21pemF0aW9uLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wYWludF9jb250ZXh0LmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfcGFpbnRfY29udGV4dC5jcHAKaW5kZXggYmRiZDg5OWJjYjEzMTZj MTZkOThiMDU1YWM3YzNhNGY2YmZjNmE1Zi4uYjk2NTA3OTdjMjQwMWZmNTU0ZWJjNjYzMmVlYjAx YzUwOGViZTQ5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wYWludF9j b250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3BhaW50X2NvbnRleHQu Y3BwCkBAIC0xNjEsNiArMTYxLDE1IEBAIHZvaWQgZXdrX3BhaW50X2NvbnRleHRfcGFpbnQoRXdr X1BhaW50X0NvbnRleHQqIGNvbnRleHQsIFdlYkNvcmU6OkZyYW1lVmlldyogdmllCiAgICAgaWYg KHZpZXctPmlzVHJhbnNwYXJlbnQoKSkKICAgICAgICAgY29udGV4dC0+Z3JhcGhpY0NvbnRleHQt PmNsZWFyUmVjdChwYWludEFyZWEpOwogICAgIHZpZXctPnBhaW50KGNvbnRleHQtPmdyYXBoaWND b250ZXh0LmdldCgpLCBwYWludEFyZWEpOworCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKKyAgICBX ZWJDb3JlOjpQYWdlKiBwYWdlID0gdmlldy0+ZnJhbWUoKS0+cGFnZSgpOworICAgIGlmIChwYWdl KSB7CisgICAgICAgIFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXIqIGNvbnRyb2xsZXIgPSBw YWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCk7CisgICAgICAgIGlmIChjb250cm9sbGVyLT5oaWdo bGlnaHRlZE5vZGUoKSkKKyAgICAgICAgICAgIGNvbnRyb2xsZXItPmRyYXdIaWdobGlnaHQoKmNv bnRleHQtPmdyYXBoaWNDb250ZXh0KTsKKyAgICB9CisjZW5kaWYKIH0KIAogdm9pZCBld2tfcGFp bnRfY29udGV4dF9wYWludF9jb250ZW50cyhFd2tfUGFpbnRfQ29udGV4dCogY29udGV4dCwgV2Vi Q29yZTo6RnJhbWVWaWV3KiB2aWV3LCBjb25zdCBFaW5hX1JlY3RhbmdsZSogYXJlYSkK 170836 2012-10-26 00:11:53 -0700 2012-10-30 23:00:03 -0700 Patch bug-100303-20121026161033.patch text/plain 2076 seokju.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZjI2NTZiYzBm NTgxMTk0NTQ1YTZmYTcwYTE4ODMxZmYxMTFiYWRmZi4uZWYxOGU2ZGE5Njg1MjY5YWY4OTNiZWFi ZmQwYWJiNGZhOGNhNjUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTEwLTI1ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEZpeCBmYWlsdXJlIHRvIGhpZ2hsaWdodCBub2RlcyBvbiB3ZWIgaW5zcGVjdG9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBub3Qg d29ya2luZyB0byBoaWdobGlnaHQgbm9kZXMgb24gd2ViIGluc3BlY3RvcgorICAgICAgICB3aGVu IHVzaW5nICdTaW5nbGUgQmFja2luZyBTdG9yZScuCisgICAgICAgIEFkZCBjb2RlIGZvciBkcmF3 aW5nIGl0IGlmIHRoZXJlIGlzIHRoZSBoaWdobGlnaHRlZCBub2RlLgorCisgICAgICAgICogZXdr L2V3a192aWV3X3NpbmdsZS5jcHA6CisgICAgICAgIChfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X3Jl cGFpbnRzX3Byb2Nlc3MpOgorCiAyMDEyLTEwLTI0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBzdHJhdGVneSBmb3IgbG9hZGVyIGN1c3RvbWl6YXRp b24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfc2luZ2xlLmNw cCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuY3BwCmluZGV4IDI5NGJi YzhlMWM2YTUwMjk2M2NiYWEwOTNlNTQwYmIyMjBlMWE4ZmYuLmRlMGViODk3Y2E2NmYyM2Y0NjU2 ZGE1OTc0NGUwYjM5YWRmMjQzMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlld19zaW5nbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19z aW5nbGUuY3BwCkBAIC0zMCw2ICszMCwxMSBAQAogI2luY2x1ZGUgPGVpbmFfc2FmZXR5X2NoZWNr cy5oPgogI2luY2x1ZGUgPHN0cmluZy5oPgogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKKyNpbmNs dWRlICJJbnNwZWN0b3JDb250cm9sbGVyLmgiCisjaW5jbHVkZSAiUGFnZS5oIgorI2VuZGlmCisK IHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBfcGFyZW50X3NjID0gRVdLX1ZJRVdfU01BUlRf Q0xBU1NfSU5JVF9OVUxMOwogCiBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfc2luZ2xlX29uX2RlbCh2 b2lkKiBkYXRhLCBFdmFzKiwgRXZhc19PYmplY3QqLCB2b2lkKikKQEAgLTI2Niw2ICsyNzEsMTUg QEAgc3RhdGljIEVpbmFfQm9vbCBfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X3JlcGFpbnRzX3Byb2Nl c3MoRXdrX1ZpZXdfU21hcnRfRGF0YSogc20KICAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZGF0 YV91cGRhdGVfYWRkKHNtYXJ0RGF0YS0+YmFja2luZ19zdG9yZSwgcmVjdC0+eCwgcmVjdC0+eSwg cmVjdC0+dywgcmVjdC0+aCk7CiAgICAgfQogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKKyAgICBX ZWJDb3JlOjpQYWdlKiBwYWdlID0gRVdLUHJpdmF0ZTo6Y29yZVBhZ2Uoc21hcnREYXRhLT5zZWxm KTsKKyAgICBpZiAocGFnZSkgeworICAgICAgICBXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVy KiBjb250cm9sbGVyID0gcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpOworICAgICAgICBpZiAo Y29udHJvbGxlci0+aGlnaGxpZ2h0ZWROb2RlKCkpCisgICAgICAgICAgICBjb250cm9sbGVyLT5k cmF3SGlnaGxpZ2h0KCpjb250ZXh0LT5ncmFwaGljQ29udGV4dCk7CisgICAgfQorI2VuZGlmCisK ICAgICBld2tfcGFpbnRfY29udGV4dF9yZXN0b3JlKGNvbnRleHQpOwogICAgIGV3a19wYWludF9j b250ZXh0X2ZyZWUoY29udGV4dCk7CiAK