100298 2012-10-24 15:50:07 -0700 [cairo] unneeded FloatRect object creation in BitmapImage::draw 2012-10-24 18:26:18 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier d-r eric mrobinson webkit.review.bot oldest_to_newest 750146 0 a.renevier 2012-10-24 15:50:07 -0700 Hi, in BitmapImage::draw, FloatRect& arguments are copied to srcRect and dstRect variables. But srcRect and dstRect are not modified, and we could use dst and src directly. 750153 1 170498 a.renevier 2012-10-24 15:56:19 -0700 Created attachment 170498 Patch patch proposal 750275 2 170498 webkit.review.bot 2012-10-24 18:26:15 -0700 Comment on attachment 170498 Patch Clearing flags on attachment: 170498 Committed r132438: <http://trac.webkit.org/changeset/132438> 750276 3 webkit.review.bot 2012-10-24 18:26:18 -0700 All reviewed patches have been landed. Closing bug. 170498 2012-10-24 15:56:19 -0700 2012-10-24 18:26:15 -0700 Patch bug-100298-20121024155452.patch text/plain 2998 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjRiNzdmNjA4ZjAwZjE1 MmQ1ZGY0OGNmMDgxZTkyNTk1MjkyNzg3MC4uYWY5NGE1Y2ZlMWMwOTY5Yzk3NjUzMDE2OWRhNzll ZGRlNDRhNDcyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTEwLTI0ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW2Nh aXJvXSB1bm5lZWRlZCBGbG9hdFJlY3Qgb2JqZWN0IGNyZWF0aW9uIGluIEJpdG1hcEltYWdlOjpk cmF3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAy OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBu b3QgY29weSBGbG9hdFJlY3QgYXJndW1lbnRzIHNyYyBhbmQgZHN0IHRvIGxvY2FsIHZhcmlhYmxl cy4KKyAgICAgICAgSW5zdGVhZCwgdXNlIHNyYyBhbmQgZHN0IGRpcmVjdGx5LgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vQml0bWFwSW1hZ2VDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpCaXRtYXBJbWFnZTo6ZHJhdyk6CisKKzIwMTItMTAtMjQgIEFybmF1ZCBSZW5ldmllciAgPGEu cmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KKwogICAgICAgICBpbmNvbnNpc3RlbmN5IGluIGRy YXdJbWFnZSB3aXRoIHRhcmdldCByZWN0IG5lZ2F0aXZlIGRpbWVuc2lvbnMuCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAwMjYKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQml0bWFwSW1hZ2VDYWly by5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9CaXRtYXBJbWFn ZUNhaXJvLmNwcAppbmRleCA4M2ZhYzFmZGEzZDdjMmQxNjk2OGE4MTliNjlmZjE5OTBiNmU4YmUy Li4yY2JmOGQ2ZGM2NzYzMjJlZTUyNjY5NzA5ZTk1MGI3MDg4NmQ2NGZhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9CaXRtYXBJbWFnZUNhaXJvLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9CaXRtYXBJbWFn ZUNhaXJvLmNwcApAQCAtNzMsMTAgKzczLDcgQEAgQml0bWFwSW1hZ2U6OkJpdG1hcEltYWdlKE5h dGl2ZUltYWdlQ2Fpcm8qIG5hdGl2ZUltYWdlLCBJbWFnZU9ic2VydmVyKiBvYnNlcnZlcikKIAog dm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEZs b2F0UmVjdCYgZHN0LCBjb25zdCBGbG9hdFJlY3QmIHNyYywgQ29sb3JTcGFjZSBzdHlsZUNvbG9y U3BhY2UsIENvbXBvc2l0ZU9wZXJhdG9yIG9wKQogewotICAgIEZsb2F0UmVjdCBzcmNSZWN0KHNy Yyk7Ci0gICAgRmxvYXRSZWN0IGRzdFJlY3QoZHN0KTsKLQotICAgIGlmICghZHN0UmVjdC53aWR0 aCgpIHx8ICFkc3RSZWN0LmhlaWdodCgpIHx8ICFzcmNSZWN0LndpZHRoKCkgfHwgIXNyY1JlY3Qu aGVpZ2h0KCkpCisgICAgaWYgKCFkc3Qud2lkdGgoKSB8fCAhZHN0LmhlaWdodCgpIHx8ICFzcmMu d2lkdGgoKSB8fCAhc3JjLmhlaWdodCgpKQogICAgICAgICByZXR1cm47CiAKICAgICBzdGFydEFu aW1hdGlvbigpOwpAQCAtODYsNyArODMsNyBAQCB2b2lkIEJpdG1hcEltYWdlOjpkcmF3KEdyYXBo aWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiBkc3QsIGNvbnN0IEZsbwogICAg ICAgICByZXR1cm47CiAKICAgICBpZiAobWF5RmlsbFdpdGhTb2xpZENvbG9yKCkpIHsKLSAgICAg ICAgZmlsbFdpdGhTb2xpZENvbG9yKGNvbnRleHQsIGRzdFJlY3QsIHNvbGlkQ29sb3IoKSwgc3R5 bGVDb2xvclNwYWNlLCBvcCk7CisgICAgICAgIGZpbGxXaXRoU29saWRDb2xvcihjb250ZXh0LCBk c3QsIHNvbGlkQ29sb3IoKSwgc3R5bGVDb2xvclNwYWNlLCBvcCk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKQEAgLTEwMSwxMiArOTgsMTIgQEAgdm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFw aGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgZHN0LCBjb25zdCBGbG8KICNp ZiBFTkFCTEUoSU1BR0VfREVDT0RFUl9ET1dOX1NBTVBMSU5HKQogICAgIGNhaXJvX3N1cmZhY2Vf dCogc3VyZmFjZSA9IG5hdGl2ZUltYWdlLT5zdXJmYWNlKCk7CiAgICAgSW50U2l6ZSBzY2FsZWRT aXplKGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X3dpZHRoKHN1cmZhY2UpLCBjYWlyb19pbWFnZV9z dXJmYWNlX2dldF9oZWlnaHQoc3VyZmFjZSkpOwotICAgIEZsb2F0UmVjdCBhZGp1c3RlZFNyY1Jl Y3QgPSBhZGp1c3RTb3VyY2VSZWN0Rm9yRG93blNhbXBsaW5nKHNyY1JlY3QsIHNjYWxlZFNpemUp OworICAgIEZsb2F0UmVjdCBhZGp1c3RlZFNyY1JlY3QgPSBhZGp1c3RTb3VyY2VSZWN0Rm9yRG93 blNhbXBsaW5nKHNyYywgc2NhbGVkU2l6ZSk7CiAjZWxzZQotICAgIEZsb2F0UmVjdCBhZGp1c3Rl ZFNyY1JlY3Qoc3JjUmVjdCk7CisgICAgRmxvYXRSZWN0IGFkanVzdGVkU3JjUmVjdChzcmMpOwog I2VuZGlmCiAKLSAgICBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+ZHJhd1N1cmZhY2VUb0Nv bnRleHQobmF0aXZlSW1hZ2UtPnN1cmZhY2UoKSwgZHN0UmVjdCwgYWRqdXN0ZWRTcmNSZWN0LCBj b250ZXh0KTsKKyAgICBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+ZHJhd1N1cmZhY2VUb0Nv bnRleHQobmF0aXZlSW1hZ2UtPnN1cmZhY2UoKSwgZHN0LCBhZGp1c3RlZFNyY1JlY3QsIGNvbnRl eHQpOwogCiAgICAgY29udGV4dC0+cmVzdG9yZSgpOwogCg==