100296 2012-10-24 15:23:42 -0700 [WK2][Qt] Enable hover and mouse events in flickable WebView 2012-10-30 10:08:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar abecsi cmarcelo hausmann kenneth lokesh.kumar.goel menard svillar webkit.review.bot oldest_to_newest 750115 0 svillar 2012-10-24 15:23:42 -0700 [WK2][Qt] Enable hover and mouse events in flickable WebView 750122 1 170488 svillar 2012-10-24 15:29:04 -0700 Created attachment 170488 Patch 750131 2 svillar 2012-10-24 15:37:16 -0700 So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling. Apart from that I talked to Kenneth on IRC and he told me that the idea of the WebKitQt maintainers is to move towards having all the functionality of the legacy webView to the flickable one. So this might be a step in the right direction. I was not sure if I should include a patch to the MiniBrowser also, because right now it's generating touch events from mouse events and we might think about removing that. I guess it was done for testing purposes or the like, but don't know all the details as I'm more familiar with the Gtk+ port. 750610 3 abecsi 2012-10-25 03:20:00 -0700 (In reply to comment #2) > So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling. Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also. > > Apart from that I talked to Kenneth on IRC and he told me that the idea of the WebKitQt maintainers is to move towards having all the functionality of the legacy webView to the flickable one. So this might be a step in the right direction. > > I was not sure if I should include a patch to the MiniBrowser also, because right now it's generating touch events from mouse events and we might think about removing that. I guess it was done for testing purposes or the like, but don't know all the details as I'm more familiar with the Gtk+ port. MiniBrowser also does multi-touch mocking for mouse events when pressing the Ctrl key which is useful for testing pinch-zoom on a desktop without a touch device, thus it should remain as is for testing purposes. 750612 4 170488 abecsi 2012-10-25 03:23:11 -0700 Comment on attachment 170488 Patch Enabling hover events should be safe now, I think, so the patch looks OK. 750693 5 abecsi 2012-10-25 05:01:14 -0700 (In reply to comment #3) > (In reply to comment #2) > > So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling. > > Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also. > That said, having a device that has both mouse and touch capabilities might result in some unexpected behaviour, especially because the gesture recognition logic is not prepared for some possible corner cases with alternating input events. This should be addressed later. 751286 6 svillar 2012-10-25 15:35:39 -0700 (In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #2) > > > So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling. > > > > Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also. > > > > That said, having a device that has both mouse and touch capabilities might result in some unexpected behaviour, especially because the gesture recognition logic is not prepared for some possible corner cases with alternating input events. > This should be addressed later. That's true but might be it should be addressed in a separate bug. So anything to change in the current patch? 754454 7 abecsi 2012-10-30 09:51:47 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling. > > > > > > Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also. > > > > > > > That said, having a device that has both mouse and touch capabilities might result in some unexpected behaviour, especially because the gesture recognition logic is not prepared for some possible corner cases with alternating input events. > > This should be addressed later. > > That's true but might be it should be addressed in a separate bug. So anything to change in the current patch? The patch is fine. Of course other issues we find in relation to mouse and touch at the same time should be addressed in separate bugs. 754468 8 170488 svillar 2012-10-30 10:08:15 -0700 Comment on attachment 170488 Patch Clearing flags on attachment: 170488 Committed r132919: <http://trac.webkit.org/changeset/132919> 754469 9 svillar 2012-10-30 10:08:20 -0700 All reviewed patches have been landed. Closing bug. 170488 2012-10-24 15:29:04 -0700 2012-10-30 10:08:13 -0700 Patch bug-100296-20121024152738.patch text/plain 2770 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODdmNzU1NGU0NzRjYzQ4 NDUyYjBkOGRkMjk5OWZhNTFmZWNhNjQ0MC4uNDYyMDg2ZDQwZGRkMjdjNjVhYTZhNTFhMDY5ODA0 NmYyMjIwYzI4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTI0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdW1F0 XSBFbmFibGUgaG92ZXIgYW5kIG1vdXNlIGV2ZW50cyBpbiBmbGlja2FibGUgV2ViVmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjk2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmxpY2thYmxlIFdl YlZpZXcgaXMgbm93IGFsbG93ZWQgdG8gaGFuZGxlIGJvdGggaG92ZXIgYW5kIG1vdXNlCisgICAg ICAgIGV2ZW50cy4gRmxpY2thYmxlIHdhcyBpbml0aWFsbHkgbWVhbnQgdG8gYmUgdGhlIG1vYmls ZSBpbnRlcmZhY2UgYW5kCisgICAgICAgIHdhcyBvbmx5IGhhbmRsaW5nIHRvdWNoIGV2ZW50cywg YnV0IG5vdyB0aGUgaWRlYSBpcyB0aGF0IGl0IHdpbGwgYmUKKyAgICAgICAgdGhlIFdlYlZpZXcg Zm9yIGJvdGggbW9iaWxlIGFuZCBkZXNrdG9wIGVudmlyb25tZW50cy4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3 UHJpdmF0ZTo6aW5pdGlhbGl6ZSk6IHJlZmFjdG9yZWQgaG92ZXIgYW5kIG1vdXNlCisgICAgICAg IGV2ZW50IGhhbmRsaW5nIGZyb20gY2hpbGRyZW4gY2xhc3Nlcy4KKyAgICAgICAgKFFRdWlja1dl YlZpZXdMZWdhY3lQcml2YXRlOjppbml0aWFsaXplKToKKyAgICAgICAgKFFRdWlja1dlYlZpZXdG bGlja2FibGVQcml2YXRlOjpRUXVpY2tXZWJWaWV3RmxpY2thYmxlUHJpdmF0ZSk6CisKIDIwMTIt MTAtMjMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBl bmNvZGUgc2hvdWxkIHRha2UgYW4gQXJndW1lbnRFbmNvZGVyIHJlZmVyZW5jZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggZDJj ODc1NDE3MjUzNDNlMDFmMTc0NmJmNjFkMzYxMTdmNDYyYzRlYy4uZDc1YWY3NzYzMmM2YTkyZDgy M2E0NjAwMmVlMTIxYmI2YmIxYWUyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC0zMjIsNiArMzIyLDkgQEAgdm9pZCBRUXVp Y2tXZWJWaWV3UHJpdmF0ZTo6aW5pdGlhbGl6ZShXS0NvbnRleHRSZWYgY29udGV4dFJlZiwgV0tQ YWdlR3JvdXBSZWYgcGEKIAogICAgIHBhZ2VDbGllbnQuaW5pdGlhbGl6ZShxX3B0ciwgcGFnZVZp ZXdQcml2YXRlLT5ldmVudEhhbmRsZXIuZGF0YSgpLCAmdW5kb0NvbnRyb2xsZXIpOwogICAgIHdl YlBhZ2VQcm94eS0+aW5pdGlhbGl6ZVdlYlBhZ2UoKTsKKworICAgIHFfcHRyLT5zZXRBY2NlcHRl ZE1vdXNlQnV0dG9ucyhRdDo6TW91c2VCdXR0b25NYXNrKTsKKyAgICBxX3B0ci0+c2V0QWNjZXB0 SG92ZXJFdmVudHModHJ1ZSk7CiB9CiAKIHZvaWQgUVF1aWNrV2ViVmlld1ByaXZhdGU6OmxvYWRE aWRTdG9wKCkKQEAgLTgwNiwxMiArODA5LDggQEAgUVF1aWNrV2ViVmlld0xlZ2FjeVByaXZhdGU6 OlFRdWlja1dlYlZpZXdMZWdhY3lQcml2YXRlKFFRdWlja1dlYlZpZXcqIHZpZXdwb3J0KQogCiB2 b2lkIFFRdWlja1dlYlZpZXdMZWdhY3lQcml2YXRlOjppbml0aWFsaXplKFdLQ29udGV4dFJlZiBj b250ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvdXBSZWYpCiB7Ci0gICAgUV9RKFFRdWlj a1dlYlZpZXcpOwogICAgIFFRdWlja1dlYlZpZXdQcml2YXRlOjppbml0aWFsaXplKGNvbnRleHRS ZWYsIHBhZ2VHcm91cFJlZik7CiAKLSAgICBxLT5zZXRBY2NlcHRlZE1vdXNlQnV0dG9ucyhRdDo6 TW91c2VCdXR0b25NYXNrKTsKLSAgICBxLT5zZXRBY2NlcHRIb3ZlckV2ZW50cyh0cnVlKTsKLQog ICAgIC8vIFRyaWdnZXIgc2V0dGluZyBvZiBjb3JyZWN0IHZpc2liaWxpdHkgZmxhZ3MgYWZ0ZXIg ZXZlcnl0aGluZyB3YXMgYWxsb2NhdGVkIGFuZCBpbml0aWFsaXplZC4KICAgICBfcV9vblZpc2li bGVDaGFuZ2VkKCk7CiB9CkBAIC04NDgsNyArODQ3LDYgQEAgdm9pZCBRUXVpY2tXZWJWaWV3TGVn YWN5UHJpdmF0ZTo6c2V0Wm9vbUZhY3RvcihxcmVhbCBmYWN0b3IpCiBRUXVpY2tXZWJWaWV3Rmxp Y2thYmxlUHJpdmF0ZTo6UVF1aWNrV2ViVmlld0ZsaWNrYWJsZVByaXZhdGUoUVF1aWNrV2ViVmll dyogdmlld3BvcnQpCiAgICAgOiBRUXVpY2tXZWJWaWV3UHJpdmF0ZSh2aWV3cG9ydCkKIHsKLSAg ICB2aWV3cG9ydC0+c2V0QWNjZXB0SG92ZXJFdmVudHMoZmFsc2UpOwogfQogCiB2b2lkIFFRdWlj a1dlYlZpZXdGbGlja2FibGVQcml2YXRlOjppbml0aWFsaXplKFdLQ29udGV4dFJlZiBjb250ZXh0 UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvdXBSZWYpCg==