100295 2012-10-24 15:20:02 -0700 [V8] WorkerContextExecutionProxy doesn't need to track events 2012-10-24 16:17:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100175 1 abarth abarth dglazkov dimich eric haraken inferno japhet webkit.review.bot oldest_to_newest 750108 0 abarth 2012-10-24 15:20:02 -0700 [V8] WorkerContextExecutionProxy doesn't need to track events 750109 1 eric 2012-10-24 15:20:43 -0700 His patch may explain some set of our crash-on-shutdown bugs. 750112 2 170484 abarth 2012-10-24 15:21:52 -0700 Created attachment 170484 Patch 750114 3 abarth 2012-10-24 15:23:34 -0700 /cc the author and reviewer of http://trac.webkit.org/changeset/41862 750118 4 inferno 2012-10-24 15:27:27 -0700 Nice catch. I just did a search for "Vector<Event*" across our codebase and this seems like the only place left. 750170 5 170484 webkit.review.bot 2012-10-24 16:17:48 -0700 Comment on attachment 170484 Patch Clearing flags on attachment: 170484 Committed r132417: <http://trac.webkit.org/changeset/132417> 750171 6 webkit.review.bot 2012-10-24 16:17:51 -0700 All reviewed patches have been landed. Closing bug. 170484 2012-10-24 15:21:52 -0700 2012-10-24 16:17:48 -0700 Patch bug-100295-20121024152027.patch text/plain 5649 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIxZTc1NjIzZGJmNzAx MWQyMjRlOTllY2NiODE1Y2Q2MDdiYTcxZi4uYjA4OTNmYWU5YTBmNjQwMDRhYmQ3MjJkOGUyZDg5 YzM4NWNiOWYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTI0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBXb3JrZXJDb250ZXh0 RXhlY3V0aW9uUHJveHkgZG9lc24ndCBuZWVkIHRvIHRyYWNrIGV2ZW50cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjk1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjb2RlIHdhcyBhZGRlZCB3 aGVuIHRoaXMgY29kZSB3YXMgb3JpZ2luYWxseSB1cHN0cmVhbWVkIGFzIHBhcnQgb2YKKyAgICAg ICAgdGhlIENocm9taXVtIHBvcnQuIFRoZXJlIGRvZXNuJ3QgYXBwZWFyIHRvIGJlIGFueSByZWFz b24gd2h5CisgICAgICAgIFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eSBuZWVkcyB0byBrZWVw IGEgVmVjdG9yIG9mIHJhdyBldmVudAorICAgICAgICBwb2ludGVycy4gVGhvc2UgcG9pbnRzIGFy ZSBsaWtlbHkgdG8gYmVjb21lIGRhbmdsaW5nLCBtYWtpbmcgdGhlIHJlc3QKKyAgICAgICAgb2Yg d2hhdCB0aGlzIGNvZGUgZG9lcyB2ZXJ5IHNrZXRjaHkuCisKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9WOFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4 V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXI6OmNhbGxMaXN0ZW5lckZ1bmN0aW9uKToKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6V29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5OjpkaXNwb3NlKToKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuaDoKKyAgICAgICAg KFdlYkNvcmU6OldvcmtlckNvbnRleHRFeGVjdXRpb25TdGF0ZTo6V29ya2VyQ29udGV4dEV4ZWN1 dGlvblN0YXRlKToKKyAgICAgICAgKFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eSk6CisKIDIw MTItMTAtMjQgIENvc21pbiBUcnV0YSAgPGN0cnV0YUByaW0uY29tPgogCiAgICAgICAgIEluY29y cmVjdCBjb25kaXRpb25hbCB1c2Ugb2YgTG9nRlRQCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOFdvcmtlckNvbnRleHRFdmVudExpc3RlbmVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXIuY3BwCmluZGV4 IGQ5YmI5NTU0NTQ0NDdkOGZiNzA1ODk1NTlhM2EwNTkwMTcxY2NjMmUuLjc0YWEwM2M1NzAzMzNm NzllYmRiOGI0NmYxZGMxZmJkNTFiY2VlNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4V29ya2VyQ29udGV4dEV2ZW50TGlzdGVuZXIuY3BwCkBAIC0x MTAsOSArMTEwLDYgQEAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gVjhXb3JrZXJDb250ZXh0RXZlbnRM aXN0ZW5lcjo6Y2FsbExpc3RlbmVyRnVuY3Rpb24oU2NyaXB0RXgKICAgICBWOFJlY3Vyc2lvblNj b3BlIHJlY3Vyc2lvblNjb3BlKGNvbnRleHQpOwogICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHJl c3VsdCA9IGhhbmRsZXJGdW5jdGlvbi0+Q2FsbChyZWNlaXZlciwgMSwgcGFyYW1ldGVycyk7CiAK LSAgICBpZiAoV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5KiBwcm94eSA9IHdvcmtlclByb3h5 KGNvbnRleHQpKQotICAgICAgICBwcm94eS0+dHJhY2tFdmVudChldmVudCk7Ci0KICAgICBJbnNw ZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZENhbGxGdW5jdGlvbihjb29raWUpOwogCiAgICAgcmV0 dXJuIHJlc3VsdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtl ckNvbnRleHRFeGVjdXRpb25Qcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9X b3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuY3BwCmluZGV4IDkzNTRiYjNiMmVhOWQyY2EyNzAw MTBjNzRjNGFjMTQyMzhhZGM5ZGUuLjQ0NWQ0YmVjZjQ0OGJkMmE4ZDg4MDg2N2Y5NGExN2EwNDEz ZTA3YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRl eHRFeGVjdXRpb25Qcm94eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29y a2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmNwcApAQCAtOTksMTQgKzk5LDYgQEAgV29ya2VyQ29u dGV4dEV4ZWN1dGlvblByb3h5Ojp+V29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5KCkKIAogdm9p ZCBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmRpc3Bvc2UoKQogewotICAgIC8vIERldGFj aCBhbGwgZXZlbnRzIGZyb20gdGhlaXIgSlMgd3JhcHBlcnMuCi0gICAgZm9yIChzaXplX3QgZXZl bnRJbmRleCA9IDA7IGV2ZW50SW5kZXggPCBtX2V2ZW50cy5zaXplKCk7ICsrZXZlbnRJbmRleCkg ewotICAgICAgICBFdmVudCogZXZlbnQgPSBtX2V2ZW50c1tldmVudEluZGV4XTsKLSAgICAgICAg aWYgKGZvcmdldFY4RXZlbnRPYmplY3QoZXZlbnQpKQotICAgICAgICAgIGV2ZW50LT5kZXJlZigp OwotICAgIH0KLSAgICBtX2V2ZW50cy5jbGVhcigpOwotCiAgICAgbV9wZXJDb250ZXh0RGF0YS5j bGVhcigpOwogCiAgICAgLy8gRGlzcG9zZSB0aGUgY29udGV4dC4KQEAgLTE5NSwxNSArMTg3LDYg QEAgYm9vbCBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmluaXRpYWxpemVJZk5lZWRlZCgp CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLWJvb2wgV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5 Ojpmb3JnZXRWOEV2ZW50T2JqZWN0KEV2ZW50KiBldmVudCkKLXsKLSAgICBpZiAoZ2V0RE9NT2Jq ZWN0TWFwKCkuY29udGFpbnMoZXZlbnQpKSB7Ci0gICAgICAgIGdldERPTU9iamVjdE1hcCgpLmZv cmdldChldmVudCk7Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KLSAgICByZXR1cm4gZmFs c2U7Ci19Ci0KIFNjcmlwdFZhbHVlIFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6ZXZhbHVh dGUoY29uc3QgU3RyaW5nJiBzY3JpcHQsIGNvbnN0IFN0cmluZyYgZmlsZU5hbWUsIGNvbnN0IFRl eHRQb3NpdGlvbiYgc2NyaXB0U3RhcnRQb3NpdGlvbiwgV29ya2VyQ29udGV4dEV4ZWN1dGlvblN0 YXRlKiBzdGF0ZSkKIHsKICAgICBWOEdDQ29udHJvbGxlcjo6Y2hlY2tNZW1vcnlVc2FnZSgpOwpA QCAtMjU4LDExICsyNDEsNiBAQCB2b2lkIFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6c2V0 RXZhbEFsbG93ZWQoYm9vbCBlbmFibGUsIGNvbnN0IFN0cmluZyYgZXJybwogICAgIG1fZGlzYWJs ZUV2YWxQZW5kaW5nID0gZW5hYmxlID8gU3RyaW5nKCkgOiBlcnJvck1lc3NhZ2U7CiB9CiAKLXZv aWQgV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5Ojp0cmFja0V2ZW50KEV2ZW50KiBldmVudCkK LXsKLSAgICBtX2V2ZW50cy5hcHBlbmQoZXZlbnQpOwotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoV09SS0VSUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5oIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmgKaW5kZXggNGMw MjRkMDJkYTUwMDAzZmMzODI3NzI3NTc4YjllODAwYTMyOGM2OS4uZDg4ODM5MWNlMDRjZGE0MGI3 Mzg2MzU1NzhhZGU0MGJkNjI0NDY4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmgKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmgKQEAgLTQ5LDcgKzQ5LDEx IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBzdHJ1Y3QgV3JhcHBlclR5cGVJbmZvOwogCiAg ICAgc3RydWN0IFdvcmtlckNvbnRleHRFeGVjdXRpb25TdGF0ZSB7Ci0gICAgICAgIFdvcmtlckNv bnRleHRFeGVjdXRpb25TdGF0ZSgpIDogaGFkRXhjZXB0aW9uKGZhbHNlKSwgbGluZU51bWJlcigw KSB7IH0KKyAgICAgICAgV29ya2VyQ29udGV4dEV4ZWN1dGlvblN0YXRlKCkKKyAgICAgICAgICAg IDogaGFkRXhjZXB0aW9uKGZhbHNlKQorICAgICAgICAgICAgLCBsaW5lTnVtYmVyKDApCisgICAg ICAgIHsKKyAgICAgICAgfQogCiAgICAgICAgIGJvb2wgaGFkRXhjZXB0aW9uOwogICAgICAgICBT Y3JpcHRWYWx1ZSBleGNlcHRpb247CkBAIC02MCwxNCArNjQsOSBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKICAgICBjbGFzcyBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkgewogICAgIHB1Ymxp YzoKLSAgICAgICAgV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5KFdvcmtlckNvbnRleHQqKTsK KyAgICAgICAgZXhwbGljaXQgV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5KFdvcmtlckNvbnRl eHQqKTsKICAgICAgICAgfldvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eSgpOwogCi0gICAgICAg IC8vIFRyYWNrIHRoZSBldmVudCBzbyB0aGF0IHdlIGNhbiBkZXRhY2ggaXQgZnJvbSB0aGUgSlMg d3JhcHBlciB3aGVuIGEgd29ya2VyCi0gICAgICAgIC8vIHRlcm1pbmF0ZXMuIFRoaXMgaXMgbmVl ZGVkIGJlY2F1c2Ugd2UgbmVlZCB0byBiZSBhYmxlIHRvIGRpc3Bvc2UgdGhlc2UKLSAgICAgICAg Ly8gZXZlbnRzIGFuZCByZWxlYXNlcyByZWZlcmVuY2VzIHRvIHRoZWlyIGV2ZW50IHRhcmdldHM6 IFdvcmtlckNvbnRleHQuCi0gICAgICAgIHZvaWQgdHJhY2tFdmVudChFdmVudCopOwotCiAgICAg ICAgIC8vIEFsb3cgdXNlIG9mIGV2YWwoKSBhbmQgaXMgZXF1aXZhbGVudHMgaW4gc2NyaXB0cy4K ICAgICAgICAgdm9pZCBzZXRFdmFsQWxsb3dlZChib29sIGVuYWJsZSwgY29uc3QgU3RyaW5nJiBl cnJvck1lc3NhZ2UpOwogCkBAIC04MiwxNyArODEsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICBib29sIGluaXRpYWxpemVJZk5lZWRlZCgpOwogICAgICAgICB2b2lkIGRpc3Bvc2Uo KTsKIAotICAgICAgICBzdGF0aWMgYm9vbCBmb3JnZXRWOEV2ZW50T2JqZWN0KEV2ZW50Kik7Ci0K ICAgICAgICAgc3RhdGljIGNvbnN0IGludCBrV29ya2VyTWF4U3RhY2tTaXplID0gNTAwICogMTAy NDsKIAogICAgICAgICBXb3JrZXJDb250ZXh0KiBtX3dvcmtlckNvbnRleHQ7CiAgICAgICAgIHY4 OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0PiBtX2NvbnRleHQ7Ci0KLSAgICAgICAgVmVjdG9yPEV2 ZW50Kj4gbV9ldmVudHM7Ci0KICAgICAgICAgT3duUHRyPFY4UGVyQ29udGV4dERhdGE+IG1fcGVy Q29udGV4dERhdGE7Ci0KICAgICAgICAgU3RyaW5nIG1fZGlzYWJsZUV2YWxQZW5kaW5nOwogICAg IH07CiAK