100272 2012-10-24 11:25:09 -0700 Layout Test fast/media/w3c/test_media_queries.html is slow on Chromium debug bots after r132352 2012-10-25 02:15:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fmedia%2Fw3c%2Ftest_media_queries.html P2 Normal --- 1 leviw alexander.shalamov alexander.shalamov kenneth kling rniwa webkit.review.bot oldest_to_newest 749855 0 leviw 2012-10-24 11:25:09 -0700 It may just be slow. I'm updating test expectations and watching to find out. 749926 1 leviw 2012-10-24 12:41:37 -0700 It looks like they really are just slow... First bot just passed at 12 seconds, the cutoff for Timeout when not marked slow. 749980 2 leviw 2012-10-24 13:29:49 -0700 Confirmed, they're all passing now, just slow (as much as 17 seconds!). 750050 3 kenneth 2012-10-24 14:33:54 -0700 Maybe interesting for the performance people/bots :-) 750475 4 alexander.shalamov 2012-10-25 00:25:57 -0700 (In reply to comment #3) > Maybe interesting for the performance people/bots :-) Yes, looks strange. I tested on quite slow machine, gtk and efl debug builds with RESOLUTION_MEDIA_QUERY disabled and test was executed within few seconds. If slowness is a problem, we could relax W3C resolution tests and reduce number of queries that are trying to find dpi of the media. // Find the resolution using max-resolution var resolution = 0; do { ++resolution; if (resolution > 10000) { break; } } while (!query_applies("(max-resolution: " + resolution + "dpi)")); I think we could change it to "resolution > 500". Kenneth, what do you think? 750491 5 kenneth 2012-10-25 00:37:24 -0700 (In reply to comment #4) > (In reply to comment #3) > > Maybe interesting for the performance people/bots :-) > > Yes, looks strange. I tested on quite slow machine, gtk and efl debug builds with RESOLUTION_MEDIA_QUERY disabled and test was executed within few seconds. > > If slowness is a problem, we could relax W3C resolution tests and reduce number of queries that are trying to find dpi of the media. > > // Find the resolution using max-resolution > var resolution = 0; > do { > ++resolution; > if (resolution > 10000) { > break; > } > } while (!query_applies("(max-resolution: " + resolution + "dpi)")); > > I think we could change it to "resolution > 500". > Kenneth, what do you think? I am pretty sure it will bail out way before 500, anyway. Ah you are right, it won't if they have it disabled. We should run (resolution) first to check whether it is supported or not. 750544 6 170584 alexander.shalamov 2012-10-25 01:33:29 -0700 Created attachment 170584 Patch 1 - Added check for resolution media query tests 750574 7 170584 webkit.review.bot 2012-10-25 02:15:43 -0700 Comment on attachment 170584 Patch 1 Clearing flags on attachment: 170584 Committed r132461: <http://trac.webkit.org/changeset/132461> 750575 8 webkit.review.bot 2012-10-25 02:15:47 -0700 All reviewed patches have been landed. Closing bug. 170584 2012-10-25 01:33:29 -0700 2012-10-25 02:15:42 -0700 Patch 1 w3c_test_media_query_performance_1.patch text/plain 1796 alexander.shalamov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZWNlYTFkLi41NWZjNjI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAt MjUgIEFsZXhhbmRlciBTaGFsYW1vdiAgPGFsZXhhbmRlci5zaGFsYW1vdkBpbnRlbC5jb20+CisK KyAgICAgICAgTGF5b3V0IFRlc3QgZmFzdC9tZWRpYS93M2MvdGVzdF9tZWRpYV9xdWVyaWVzLmh0 bWwgaXMgc2xvdyBvbiBDaHJvbWl1bSBkZWJ1ZyBib3RzIGFmdGVyIHIxMzIzNTIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDI3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgaWYgcmVzb2x1dGlv biBtZWRpYSBxdWVyeSBpcyBzdXBwb3J0ZWQgYmVmb3JlIGlkZW50aWZ5aW5nIGRwaSBvZiB0aGUg bWVkaWEuCisKKyAgICAgICAgKiBmYXN0L21lZGlhL3czYy90ZXN0X21lZGlhX3F1ZXJpZXMuaHRt bDoKKwogMjAxMi0xMC0yNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgog CiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcsIHNraXAgYSBuZXcgZmFpbGluZyB0 ZXN0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYS93M2MvdGVzdF9tZWRpYV9x dWVyaWVzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhL3czYy90ZXN0X21lZGlhX3F1ZXJp ZXMuaHRtbAppbmRleCBhZmFkODUwLi5jMWI1MWM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9m YXN0L21lZGlhL3czYy90ZXN0X21lZGlhX3F1ZXJpZXMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L21lZGlhL3czYy90ZXN0X21lZGlhX3F1ZXJpZXMuaHRtbApAQCAtMzUzLDE0ICszNTMsMjEg QEAgZnVuY3Rpb24gcnVuKCkgewogCiAgICAgLy8gRmluZCB0aGUgcmVzb2x1dGlvbiB1c2luZyBt YXgtcmVzb2x1dGlvbgogICAgIHZhciByZXNvbHV0aW9uID0gMDsKLSAgICBkbyB7Ci0gICAgICAr K3Jlc29sdXRpb247Ci0gICAgICBpZiAocmVzb2x1dGlvbiA+IDEwMDAwKSB7Ci0gICAgICAgIGJy ZWFrOwotICAgICAgfQotICAgIH0gd2hpbGUgKCFxdWVyeV9hcHBsaWVzKCIobWF4LXJlc29sdXRp b246ICIgKyByZXNvbHV0aW9uICsgImRwaSkiKSk7CisgICAgdmFyIG1heF9yZXNvbHV0aW9uID0g MTAwMDsKKworICAgIGlmIChxdWVyeV9hcHBsaWVzKCIocmVzb2x1dGlvbikiKSkgeworICAgICAg ICBkbyB7CisgICAgICAgICAgKytyZXNvbHV0aW9uOworICAgICAgICAgIGlmIChyZXNvbHV0aW9u ID4gbWF4X3Jlc29sdXRpb24pIHsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgIH0KKyAg ICAgICAgfSB3aGlsZSAoIXF1ZXJ5X2FwcGxpZXMoIihtYXgtcmVzb2x1dGlvbjogIiArIHJlc29s dXRpb24gKyAiZHBpKSIpKTsKKyAgICB9IGVsc2UgeworICAgICAgICByZXNvbHV0aW9uID0gbWF4 X3Jlc29sdXRpb24gKyAxOworICAgIH0KKwogICAgIHRlc3QoZnVuY3Rpb24oKSB7Ci0gICAgICBh c3NlcnRfZmFsc2Vfd3JhcHBlcigxMDAwMCA8IHJlc29sdXRpb24pOworICAgICAgYXNzZXJ0X2Zh bHNlX3dyYXBwZXIobWF4X3Jlc29sdXRpb24gPCByZXNvbHV0aW9uKTsKICAgICB9LCAiZmluZF9y ZXNvbHV0aW9uIik7CiAKICAgICAvLyByZXNvbHV0aW9uIHNob3VsZCBub3cgYmUgTWF0aC5jZWls KCkgb2YgdGhlIGFjdHVhbCByZXNvbHV0aW9uLgo=