100268 2012-10-24 10:46:31 -0700 MathML tests trigger font cache assertions in debug bots 2012-10-24 16:50:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=mathml%2Fpresentation%2Frow.xhtml P2 Normal --- 1 leviw dbarton bdakin dbarton eric leviw mitz msaboff pdr schenney spartha80 webkit.review.bot oldest_to_newest 749817 0 leviw 2012-10-24 10:46:31 -0700 Same sort of backtrace on both: STDERR: ASSERTION FAILED: m_purgePreventCount STDERR: /Volumes/data/b/build/slave/webkit-mac-latest-dbg/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/graphics/FontCache.cpp(317) : PassRefPtr<WebCore::SimpleFontData> WebCore::FontCache::getCachedFontData(const WebCore::FontPlatformData *, WebCore::FontCache::ShouldRetain) STDERR: 1 0x12b11cb9 WebCore::FontCache::getCachedFontData(WebCore::FontPlatformData const*, WebCore::FontCache::ShouldRetain) STDERR: 2 0x12c3c6d9 WebCore::FontCache::getFontDataForCharacters(WebCore::Font const&, unsigned short const*, int) STDERR: 3 0x12b2f3de WebCore::Font::glyphDataAndPageForCharacter(int, bool, WebCore::FontDataVariant) const STDERR: 4 0x12b323b3 WebCore::Font::glyphDataForCharacter(int, bool, WebCore::FontDataVariant) const STDERR: 5 0x13f087a6 WebCore::RenderMathMLOperator::glyphHeightForCharacter(unsigned short) STDERR: 6 0x13f08b53 WebCore::RenderMathMLOperator::updateFromElement() STDERR: 7 0x13f08620 WebCore::RenderMathMLOperator::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) STDERR: 8 0x13e14f48 WebCore::RenderObject::setStyle(WTF::PassRefPtr<WebCore::RenderStyle>) STDERR: 9 0x13e1456c WebCore::RenderObject::setAnimatableStyle(WTF::PassRefPtr<WebCore::RenderStyle>) STDERR: 10 0x124d33e7 WebCore::Node::setRenderStyle(WTF::PassRefPtr<WebCore::RenderStyle>) STDERR: 11 0x1245e685 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) STDERR: 12 0x1245eb08 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) STDERR: 13 0x1245eb08 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) STDERR: 14 0x1245eb08 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) STDERR: 15 0x1245eb08 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) STDERR: 16 0x1245eb08 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) STDERR: 17 0x12396a1c WebCore::Document::recalcStyle(WebCore::Node::StyleChange) STDERR: 18 0x12392e67 WebCore::Document::styleResolverChanged(WebCore::StyleResolverUpdateFlag) STDERR: 19 0x13b36cf9 WebCore::XMLDocumentParser::end() STDERR: 20 0x13b36e3d WebCore::XMLDocumentParser::finish() STDERR: 21 0x1386a4bd WebCore::DocumentWriter::end() STDERR: 22 0x13844c0c WebCore::DocumentLoader::finishedLoading() STDERR: 23 0x138ab56b WebCore::MainResourceLoader::didFinishLoading(double) STDERR: 24 0x138cfe4f WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) STDERR: 25 0x12ce35aa WebCore::ResourceHandleInternal::didFinishLoading(WebKit::WebURLLoader*, double) STDERR: 26 0x1c64ddfe webkit_glue::WebURLLoaderImpl::Context::OnCompletedRequest(int, bool, std::string const&, base::TimeTicks const&) STDERR: 27 0x1108a3ad (anonymous namespace)::RequestProxy::NotifyCompletedRequest(int, std::string const&, base::TimeTicks const&) STDERR: 28 0x1108abc7 base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(int, std::string const&, base::TimeTicks const&)>::Run((anonymous namespace)::RequestProxy*, int const&, std::string const&, base::TimeTicks const&) STDERR: 29 0x1108aac6 base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(int, std::string const&, base::TimeTicks const&)>, void ()((anonymous namespace)::RequestProxy* const&, int const&, std::string const&, base::TimeTicks const&)>::MakeItSo(base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(int, std::string const&, base::TimeTicks const&)>, (anonymous namespace)::RequestProxy* const&, int const&, std::string const&, base::TimeTicks const&) STDERR: 30 0x1108aa05 base::internal::Invoker<4, base::internal::BindState<base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(int, std::string const&, base::TimeTicks const&)>, void ()((anonymous namespace)::RequestProxy*, int, std::string const&, base::TimeTicks const&), void ()((anonymous namespace)::RequestProxy*, int, std::string, base::TimeTicks)>, void ()((anonymous namespace)::RequestProxy*, int, std::string const&, base::TimeTicks const&)>::Run(base::internal::BindStateBase*) 749835 1 dbarton 2012-10-24 11:03:39 -0700 Levi, can you tell which revision caused this? When did it start? (Is it often enough to tell?) 749849 2 pdr 2012-10-24 11:14:20 -0700 (In reply to comment #1) > Levi, can you tell which revision caused this? When did it start? (Is it often enough to tell?) Dave, Sometimes this is noisy, but it might help in tracking this down: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=mathml%2Fpresentation%2Fmo-stretch.html 749872 3 dbarton 2012-10-24 11:48:17 -0700 Thanks to pdr and leviw. I see the flaky dashboard in Chrome now. Is there a way I can look at the stacktraces like Levi posted in comment 0? 749881 4 leviw 2012-10-24 11:55:12 -0700 (In reply to comment #3) > Thanks to pdr and leviw. I see the flaky dashboard in Chrome now. Is there a way I can look at the stacktraces like Levi posted in comment 0? Click on "Show results" when on that page :) 750008 5 dbarton 2012-10-24 13:57:15 -0700 Those are the two tests with stretched () [] and integral sign at *various sizes*. The assertion failures only occur on Snow Leopard (10.6), where there are no STIX fonts on the bots. There are other fonts that provide the needed extender glyphs though. Actually, I see now that style-changed.html and subsup.xhtml and mo.xhtml have crashed also, though less often. These have stretched parens also, though sometimes at just one size. As Levi says, the backtraces are all similar. In the most recent failures, Levi's 17 Document::recalcStyle got called [via WebCore::Document::updateStyleIfNeeded()] inside Document::styleRecalcTimerFired in the 3 rarer crashes, and inside Document::finishedParsing() for mo-stretch.html, and as in comment 0 for row.xhtml. I believe the fix for this is to add a FontCachePurgePreventer to RenderMathMLOperator::glyphHeightForCharacter. I will submit a patch for this, but really need a font or at least WebKit expert to review it. Thanks in advance! 750014 6 dbarton 2012-10-24 14:01:12 -0700 Would it be better to put the FontCachePurgePreventer in RenderMathMLOperator::glyphHeightForCharacter's caller? Is it possible we're going to trigger a lot of slow purges, and should worry about minimizing that? 750019 7 pdr 2012-10-24 14:03:41 -0700 (In reply to comment #6) > Would it be better to put the FontCachePurgePreventer in RenderMathMLOperator::glyphHeightForCharacter's caller? Is it possible we're going to trigger a lot of slow purges, and should worry about minimizing that? +schenney Schenney and Eseidel recently did some work on FontCachePurgePreventer. 750047 8 eric 2012-10-24 14:30:09 -0700 schenney is your man. 750066 9 leviw 2012-10-24 14:43:16 -0700 Changing the bug title as 2 more tests have exhibited this flake now: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=mathml%2Fpresentation%2Fmroot-pref-width.html%2Cmathml%2Fpresentation%2Fstyle-changed.html 750116 10 170485 dbarton 2012-10-24 15:26:20 -0700 Created attachment 170485 Patch 750194 11 170485 eric 2012-10-24 16:33:38 -0700 Comment on attachment 170485 Patch LGTM. 750206 12 dbarton 2012-10-24 16:45:31 -0700 Thanks, Eric. Apparently schenney is in an airplane. [Seems kind of extreme just to avoid reviewing one of my patches. :) ] 750211 13 170485 webkit.review.bot 2012-10-24 16:50:06 -0700 Comment on attachment 170485 Patch Clearing flags on attachment: 170485 Committed r132424: <http://trac.webkit.org/changeset/132424> 750212 14 webkit.review.bot 2012-10-24 16:50:12 -0700 All reviewed patches have been landed. Closing bug. 170485 2012-10-24 15:26:20 -0700 2012-10-24 16:50:06 -0700 Patch bug-100268-20121024152455.patch text/plain 3391 dbarton SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjQxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTI0ICBEYXZpZCBC YXJ0b24gIDxkYmFydG9uQG1hdGhzY3JpYmUuY29tPgorCisgICAgICAgIE1hdGhNTCB0ZXN0cyB0 cmlnZ2VyIGZvbnQgY2FjaGUgYXNzZXJ0aW9ucyBpbiBkZWJ1ZyBib3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAyNjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBGb250Q2FjaGVQdXJnZVBy ZXZlbnRlciB0byBmaXggdGhpcy4KKworICAgICAgICBUZXN0ZWQgYnkgZXhpc3RpbmcgdGVzdHMu CisKKyAgICAgICAgKiByZW5kZXJpbmcvbWF0aG1sL1JlbmRlck1hdGhNTE9wZXJhdG9yLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck1hdGhNTE9wZXJhdG9yOjp1cGRhdGVGcm9tRWxlbWVu dCk6CisKIDIwMTItMTAtMjQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgTnVsbC1jaGVjayB0aGUgUmVuZGVyVmlldyBpbiBvY3VtZW50Ojp3aW5kb3dT Y3JlZW5EaWRDaGFuZ2UgdG8gZml4IGEgY3Jhc2ggd2hlbiBzYXZpbmcgUERGcwpJbmRleDogU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL21hdGhtbC9SZW5kZXJNYXRoTUxPcGVyYXRvci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL21hdGhtbC9SZW5kZXJNYXRoTUxP cGVyYXRvci5jcHAJKHJldmlzaW9uIDEzMjM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9tYXRobWwvUmVuZGVyTWF0aE1MT3BlcmF0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2 ICszMCw3IEBACiAKICNpbmNsdWRlICJSZW5kZXJNYXRoTUxPcGVyYXRvci5oIgogCisjaW5jbHVk ZSAiRm9udENhY2hlLmgiCiAjaW5jbHVkZSAiRm9udFNlbGVjdG9yLmgiCiAjaW5jbHVkZSAiTWF0 aE1MTmFtZXMuaCIKICNpbmNsdWRlICJSZW5kZXJUZXh0LmgiCkBAIC0xODUsNiArMTg2LDkgQEAg dm9pZCBSZW5kZXJNYXRoTUxPcGVyYXRvcjo6dXBkYXRlRnJvbUVsZQogICAgIGludCBtaWRkbGVH bHlwaEhlaWdodCA9IDA7CiAgICAgaWYgKHNob3VsZFN0YWNrKSB7CiAgICAgICAgIHBhcnRzRGF0 YSA9ICZzdHJldGNoeUNoYXJhY3RlcnNbaW5kZXhdOworICAgICAgICAKKyAgICAgICAgRm9udENh Y2hlUHVyZ2VQcmV2ZW50ZXIgZm9udENhY2hlUHVyZ2VQcmV2ZW50ZXI7CisgICAgICAgIAogICAg ICAgICB0b3BHbHlwaEhlaWdodCA9IGdseXBoSGVpZ2h0Rm9yQ2hhcmFjdGVyKHBhcnRzRGF0YS0+ dG9wR2x5cGgpOwogICAgICAgICBleHRlbnNpb25HbHlwaEhlaWdodCA9IGdseXBoSGVpZ2h0Rm9y Q2hhcmFjdGVyKHBhcnRzRGF0YS0+ZXh0ZW5zaW9uR2x5cGgpIC0gMTsKICAgICAgICAgYm90dG9t R2x5cGhIZWlnaHQgPSBnbHlwaEhlaWdodEZvckNoYXJhY3RlcihwYXJ0c0RhdGEtPmJvdHRvbUds eXBoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjQxMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEwLTI0ICBEYXZpZCBCYXJ0 b24gIDxkYmFydG9uQG1hdGhzY3JpYmUuY29tPgorCisgICAgICAgIE1hdGhNTCB0ZXN0cyB0cmln Z2VyIGZvbnQgY2FjaGUgYXNzZXJ0aW9ucyBpbiBkZWJ1ZyBib3RzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAyNjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rlc3RF eHBlY3RhdGlvbnM6CisKIDIwMTItMTAtMjQgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBNYXJraW5nIHRoZSBzb2Z0 d2FyZSBjb21wb3NpdGluZyB2ZXJzaW9uIG9mCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDEzMjQxMCkKKysrIExheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkK QEAgLTE5OTAsMTEgKzE5OTAsNiBAQCB3ZWJraXQub3JnL2IvOTczOTAgWyBNYWMgXSBtYXRobWwv cHJlc2VuCiB3ZWJraXQub3JnL2IvOTczOTAgWyBNYWMgXSBtYXRobWwvcHJlc2VudGF0aW9uL21z dWJzdXAtYmFzZS1jaGFuZ2VkLnhodG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KICMgT25j ZSBjaHJvbWl1bSBkZWNpZGVzIHRvIGRlZmluaXRlbHkgZW5hYmxlIE1hdGhNTCwgd2UgY2FuIGRl bGV0ZSB0aGUgb2xkIHBsYXRmb3JtL2Nocm9taXVtIGJhc2VsaW5lIGZvciB0aGlzOgogd2Via2l0 Lm9yZy9iLzk2OTYwIGh0dHAvdGVzdHMveG1sdmlld2VyL2R1bXBBc1RleHQvbWF0aG1sLnhtbCBb IFBhc3MgRmFpbHVyZSBdCi0jIFNvbWUgbWF0aG1sIHRlc3RzIGFyZSBmbGFreSBjcmFzaGVycyBv biBNYWMgRGVidWcgYm90cwotd2Via2l0Lm9yZy9iLzEwMDI2OCBbIE1hYyBEZWJ1ZyBdIG1hdGht bC9wcmVzZW50YXRpb24vcm93LnhodG1sIFsgUGFzcyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMTAw MjY4IFsgTWFjIERlYnVnIF0gbWF0aG1sL3ByZXNlbnRhdGlvbi9tby1zdHJldGNoLmh0bWwgWyBQ YXNzIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8xMDAyNjggWyBNYWMgRGVidWcgXSBtYXRobWwvcHJl c2VudGF0aW9uL21yb290LXByZWYtd2lkdGguaHRtbCBbIFBhc3MgQ3Jhc2ggXQotd2Via2l0Lm9y Zy9iLzEwMDI2OCBbIE1hYyBEZWJ1ZyBdIG1hdGhtbC9wcmVzZW50YXRpb24vc3R5bGUtY2hhbmdl ZC5odG1sIFsgUGFzcyBDcmFzaCBdCiAKICMgV2ViS2l0IHVwZGF0ZSA0ODc5Njo0ODgyMAogIyBU ZXN0ICM5IHRocm93cyBhbiBleGNlcHRpb24uCg==