<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100260</bug_id>
          
          <creation_ts>2012-10-24 08:53:27 -0700</creation_ts>
          <short_desc>Incorrect conditional use of LogFTP</short_desc>
          <delta_ts>2012-10-24 10:30:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Cosmin Truta">ctruta</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>749717</commentid>
    <comment_count>0</comment_count>
    <who name="Cosmin Truta">ctruta</who>
    <bug_when>2012-10-24 08:53:27 -0700</bug_when>
    <thetext>As I fiddled with ASSERTIONS_DISABLED_DEFAULT, the build failed because of the use of LogFTP conditioned by the wrong #ifdef.
A fix will follow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>749725</commentid>
    <comment_count>1</comment_count>
      <attachid>170409</attachid>
    <who name="Cosmin Truta">ctruta</who>
    <bug_when>2012-10-24 09:07:37 -0700</bug_when>
    <thetext>Created attachment 170409
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>749794</commentid>
    <comment_count>2</comment_count>
      <attachid>170409</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-24 10:30:02 -0700</bug_when>
    <thetext>Comment on attachment 170409
Patch

Clearing flags on attachment: 170409

Committed r132368: &lt;http://trac.webkit.org/changeset/132368&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>749795</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-24 10:30:05 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>170409</attachid>
            <date>2012-10-24 09:07:37 -0700</date>
            <delta_ts>2012-10-24 10:30:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch.diff</filename>
            <type>text/plain</type>
            <size>1214</size>
            <attacher name="Cosmin Truta">ctruta</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA0MGM3MTBkMC4uNmUyMTRhYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
NiBAQAorMjAxMi0xMC0yNCAgQ29zbWluIFRydXRhICA8Y3RydXRhQHJpbS5jb20+CisKKyAgICAg
ICAgSW5jb3JyZWN0IGNvbmRpdGlvbmFsIHVzZSBvZiBMb2dGVFAKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDI2MAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBMb2dGVFAgaWYgIUxPR19ESVNBQkxF
RCwgdG8gYWxsb3cgdG9nZ2xpbmcgQVNTRVJUSU9OU19ESVNBQkxFRF9ERUZBVUxUCisgICAgICAg
IHdpdGhvdXQgYnJlYWtpbmcgdGhlIGJ1aWxkLgorCisgICAgICAgICogaHRtbC9GVFBEaXJlY3Rv
cnlEb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGVFBEaXJlY3RvcnlEb2N1bWVudDo6
RlRQRGlyZWN0b3J5RG9jdW1lbnQpOgorCiAyMDEyLTEwLTI0ICBQYXJ0aCBQYXRlbCAgPHBhcnBh
dGVsQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEV4dGVuZGluZyBleGlzdGluZyBU
aHJlYWRVbnNhZmUgc2luZ2xldG9ucyBpbiB3ZWJraXQgdG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvRlRQRGlyZWN0b3J5RG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt
bC9GVFBEaXJlY3RvcnlEb2N1bWVudC5jcHAKaW5kZXggOGZlZmMyMDEuLmMxYTAxNTBlIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZUUERpcmVjdG9yeURvY3VtZW50LmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZUUERpcmVjdG9yeURvY3VtZW50LmNwcApAQCAtNDMxLDcg
KzQzMSw3IEBAIHZvaWQgRlRQRGlyZWN0b3J5RG9jdW1lbnRQYXJzZXI6OmZpbmlzaCgpCiBGVFBE
aXJlY3RvcnlEb2N1bWVudDo6RlRQRGlyZWN0b3J5RG9jdW1lbnQoRnJhbWUqIGZyYW1lLCBjb25z
dCBLVVJMJiB1cmwpCiAgICAgOiBIVE1MRG9jdW1lbnQoZnJhbWUsIHVybCkKIHsKLSNpZm5kZWYg
TkRFQlVHCisjaWYgIUxPR19ESVNBQkxFRAogICAgIExvZ0ZUUC5zdGF0ZSA9IFdURkxvZ0NoYW5u
ZWxPbjsKICNlbmRpZgogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>